extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2024-11-25 01:13:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix nested action targets (like tree leaves) could cause multiple drag events due to event bubbling

Browse Source
This commit is contained in:
nathan 2024-02-27 15:08:00 -07:00
parent 6727df5d39
commit e228355809
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
api/js/egw_action/egwDragActionImplementation.ts
View File

@ -177,7 +177,14 @@ export class EgwDragActionImplementation implements EgwActionImplementation {
// and the multiple dragDropTypes (ai.ddTypes)
_callback.call(_context, false, ai);
if (action && egw.app_name() == 'filemanager') {
// Stop parent elements from also starting to drag if we're nested
if(ai.selected.length)
{
event.stopPropagation();
}
if(action && egw.app_name() == 'filemanager')
{
if (_context.isSelection(event)) return;
// Get all selected
@ -247,7 +254,6 @@ export class EgwDragActionImplementation implements EgwActionImplementation {
Promise.all(wait).then(() =>
{
event.dataTransfer.setDragImage(ai.helper, 12, 12);
debugger;
});
});
@ -261,7 +267,9 @@ export class EgwDragActionImplementation implements EgwActionImplementation {
if (draggable) draggable.classList.remove('drag--moving');
// cleanup drop hover class from all other DOMs if there's still anything left
Array.from(document.getElementsByClassName('et2dropzone drop-hover')).forEach(_i=>{_i.classList.remove('drop-hover')})
};
// Clean up selected
ai.selected = [];
};
// Drag Event listeners
node.addEventListener('dragstart', dragstart, false);