extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2025-02-22 21:30:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

Filemanager: Fix new file button stopped working after being readonly

Browse Source 
Moved option render inside render() since we have it, simplifys things a lot
This commit is contained in:
nathan 2023-05-16 15:00:43 -06:00
parent 37e9d8ec58
commit ffb9fa706a
1 changed files with 10 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
api/js/etemplate/Et2DropdownButton/Et2DropdownButton.ts
View File

@ -91,49 +91,32 @@ export class Et2DropdownButton extends Et2widgetWithSelectMixin(Et2Button)
// Rebind click to just the main button, not the whole thing // Rebind click to just the main button, not the whole thing
this.removeEventListener("click", this._handleClick); this.removeEventListener("click", this._handleClick);
// Need to wait until update is done and these exist
this.updateComplete.then(() =>
{
if(this.buttonNode)
{
this.buttonNode.addEventListener("click", this._handleClick);
}
if(this.dropdownNode)
{
this.dropdownNode.addEventListener('sl-select', this._handleSelect);
}
});
} }
disconnectedCallback() protected _renderOptions()
{ {
super.disconnectedCallback(); // We have our own render, so we can handle it internally
if(this.buttonNode)
{
this.buttonNode.removeEventListener("click", this._handleClick);
}
if(this.dropdownNode)
{
this.dropdownNode.removeEventListener('sl-select', this._handleSelect);
}
} }
render() render() : TemplateResult
{ {
if(this.readonly) if(this.readonly)
{ {
return ''; return html``;
} }
return html` return html`
<sl-button-group> <sl-button-group>
<sl-button size="${egwIsMobile() ? "large" : "medium"}" id="main" ?disabled=${this.disabled}> <sl-button size="${egwIsMobile() ? "large" : "medium"}" id="main"
?disabled=${this.disabled}
@click=${this._handleClick}
>
${this.label} ${this.label}
</sl-button> </sl-button>
<sl-dropdown placement="bottom-end" hoist> <sl-dropdown placement="bottom-end" hoist>
<sl-button size="${egwIsMobile() ? "large" : "medium"}" slot="trigger" caret <sl-button size="${egwIsMobile() ? "large" : "medium"}" slot="trigger" caret
?disabled=${this.disabled}></sl-button> ?disabled=${this.disabled}></sl-button>
<sl-menu> <sl-menu @sl-select=${this._handleSelect}>
${(this.select_options || []).map((option : SelectOption) => this._optionTemplate(option))}
</sl-menu> </sl-menu>
</sl-dropdown> </sl-dropdown>
</sl-button-group> </sl-button-group>