Commit Graph

3471 Commits

Author SHA1 Message Date
nathan
7a80e8be5c Fix nm column resize grabs mousedown, blocking filter selection 2023-11-20 14:56:55 -07:00
nathan
1861f63231 Et2Listbox: Fix options were not shown
Fixes merge placeholders not shown in Collabora
2023-11-17 11:20:52 -07:00
nathan
064b0088b9 Et2Select fixes
- Fix sometimes not shown emptyLabel
 - Fix LinkSearch result count
2023-11-16 15:09:48 -07:00
nathan
2207377bd4 Revert "Et2Select: Even better handling of false invalid value", it was too strict leaving blanks instead of emptyLabel
This reverts commit 7db80d066f.
2023-11-16 13:51:46 -07:00
nathan
25a823c05d Et2Select: Even better handling of false invalid value 2023-11-16 13:36:54 -07:00
nathan
b4e2524023 Fix validation messages after Shoelace update
- some messages (textbox) were out of position
- Selectboxes did not show validation message
- Selectbox considered false a valid value for required, even if that wasn't an option
2023-11-16 13:36:45 -07:00
nathan
74a8872ead Fix missing value in some static option selects
Shoelace select initially rejects the value due to missing option, and needs to be re-set once our options have arrived
2023-11-16 10:17:51 -07:00
ralf
fc603d0a85 more renames of Et2Dialog attribute modal to isModal 2023-11-16 13:43:08 +02:00
ralf
94a2a0473b fix audio files wont play (modal attribute renamed to isModal) 2023-11-16 13:37:27 +02:00
nathan
30238e52cd Et2SelectEmail: Fix incorrect total result, wrongly shown "No results" 2023-11-15 15:28:22 -07:00
nathan
47a466a39d Api: Fix client side validation failure when widget value was null
Happens for readonlys, disabled, selects with no valid options
2023-11-15 12:00:52 -07:00
nathan
2967f8d508 Et2Select: Let select option list get as big as it needs 2023-11-15 09:43:27 -07:00
nathan
6dfd854ba4 Home: Fix portlet broken by Shoelace update to 1.8
They made HasSlotController internal only
2023-11-15 09:15:17 -07:00
ralf
0be063ba89 fix error, if this.editor is not (or no longer) set 2023-11-15 17:28:17 +02:00
hadi
83909cd1fa Fix js error of Cannot read properties of null (reading '0') 2023-11-13 13:27:00 +01:00
hadi
187cd3c112 Fix set video src and duration not working 2023-11-13 12:53:18 +01:00
ralf
9c4d28ca63 merge master into 23.1 2023-11-13 10:05:15 +02:00
nathan
45f9801df8 Code documentation 2023-11-09 11:12:16 -07:00
nathan
da92471920 Add default keyboard shortcuts for save & cancel buttons 2023-11-08 14:37:30 -07:00
nathan
6a5697eab8 More Drag helper style adjustments
- height adjustments for mail so we can see address & subject
- Change how avatar is sized so we can override it via CSS
2023-11-08 09:54:00 -07:00
nathan
cfd628e87f Slightly better rendering for description contents
Uses the litElement lifecycle better, updated() is called after render()
2023-11-03 16:15:53 -06:00
nathan
1bc26101cd Fix default drag & drop helper did not work well with webcomponents
It doesn't let us do async, so was not waiting for widgets to be updated
2023-11-03 16:13:45 -06:00
hadi
d89646df27 Fix Editable Avatar's edit/delete icons are no longer displayed 2023-11-03 11:32:14 +01:00
nathan
454ab3fb98 Fix spacing & sizing
- Move option group titles to the left more
- Fix calendarowner dropdown would not size properly in sidebox
2023-11-02 17:29:50 -06:00
nathan
c2623dcb55 Fix some issues when search results have option groups
- Options sometimes disappeared when selected
- Count was off if one of the results was already selected
2023-11-02 16:58:38 -06:00
nathan
ba04abd1b4 Et2Dialog: Fix height attribute was not setting dialog height 2023-11-02 13:04:32 -06:00
ralf
d3a9f6bc46 disable user-password popup for plaintext passwords (no need) and set disabled, if password field is readonly from server-side 2023-11-02 17:22:18 +02:00
ralf
a9aefd6a32 disable user-password popup for plaintext passwords (no need) and set disabled, if password field is readonly from server-side 2023-11-02 17:16:34 +02:00
nathan
a7396cab69 Fix Uncaught (in promise) TypeError: et2_selectbox.find_select_options is not a function from et2_widget_ajaxSelect 2023-11-02 08:15:30 -06:00
nathan
5d705c3b79 Calendar: Group calendar owner / participant search results by resource type 2023-11-01 13:26:23 -06:00
nathan
d1e7040011 Fix email tag always shows "not-allowed" cursor for read-only 2023-10-31 09:02:03 -06:00
nathan
b3899e86dd Et2Select: Stop sidemenu scrolling when scrolling through options 2023-10-30 09:10:21 -06:00
hadi
9b2d208e8e Implements load method for multi-video widget 2023-10-30 13:27:38 +01:00
nathan
d15c63198c Docs: Get the ETemplate2 webComponent widets working on doc site
Sort of.  This breaks shoelace images due to them not being imported / copied, and not using the CDN
2023-10-27 11:50:51 -06:00
nathan
31b322b870 Et2SelectEmail: Fix pasting in merge placeholders didn't do anything 2023-10-26 10:19:59 -06:00
nathan
4ab788acc1 Et2SelectEmail: Fix pasting in merge placeholders didn't do anything 2023-10-26 10:09:44 -06:00
nathan
4a48fc74c7 Et2Select: Fix placeholder could not be shown 2023-10-25 10:11:44 -06:00
hadi
8fa2f565b6 Set duration time for webm files based on provided duration url param 2023-10-23 09:49:01 +02:00
nathan
f7e1dedac9 Pass options on if sent from server 2023-10-19 16:11:12 -06:00
nathan
85cef367e2 Move Et2SelectAccount initial options to its own method, fix options were sometimes missing 2023-10-19 15:03:16 -06:00
nathan
a6d3a87c75 Doc: Get class doc into docs 2023-10-16 13:34:29 -06:00
nathan
173b9bdfda Api: Fix missing country returned object directly instead of Promise
Fixes JS error loading date widgets in registration
2023-10-16 09:42:28 -06:00
nathan
136c302c15 Fix cf customised setting check if there's no ID 2023-10-13 10:01:24 -06:00
nathan
5601b99c97 Et2Select: Add tabindex to options to avoid focus stealing in sidemenu, other event handling cleanup 2023-10-12 11:25:23 -06:00
nathan
f15cbd186f Docs: Better handling for deprecated properties & methods 2023-10-11 16:48:53 -06:00
nathan
65bf573f88 All etemplate widgets in component list 2023-10-11 14:48:58 -06:00
nathan
04ad3651a4 Api: Let legacy custom JS return
Legacy JS in the form app.appname.function where we _couldn't_ find the actual function now return.  Fixes some custom click handlers couldn't submit
2023-10-10 15:24:05 -06:00
nathan
de0ae8a6a7 Api: Fix unneeded reloads in nm when applying favourite 2023-10-10 09:55:15 -06:00
nathan
8584befb83 Api: Show nm columns from favourites
Need to update preferences before submitting
2023-10-10 09:55:04 -06:00
nathan
9c244a45f6 Api: Show nm columns from favourites, automatically reloading if needed to get missing columns 2023-10-10 09:54:57 -06:00
nathan
b60f9633e6 Fix favourites did not show customfield column if needed 2023-10-10 09:54:48 -06:00
nathan
235ff7a2cf Et2SelectAccount improvements
- Fix always including all accounts
- Limit included accounts to 100 to avoid breaking
- Let repeat() cache
- Improved "more results" count
- Reduce repeats & iteration needed
2023-10-06 11:37:46 -06:00
nathan
ad21be3216 Api: Fix account selection was always loading some accounts 2023-10-06 10:49:29 -06:00
hadi
58d486e6ba Fix switch widget not setting the initial state correctly 2023-10-06 16:06:23 +02:00
nathan
a4ee20b3ee Api: Fix unneeded reloads in nm when applying favourite 2023-10-04 15:13:25 -06:00
nathan
3088d168f4 More select tests
- finds options from DOM / template
- finds static options
- combinations with other option sources
2023-10-04 10:45:41 -06:00
nathan
ddeec753ee Calendar: Fix sidebox category had no options 2023-10-04 09:13:31 -06:00
nathan
d5139d41fb Api: Show nm columns from favourites
Need to update preferences before submitting
2023-10-03 11:53:14 -06:00
nathan
e24b5578a3 Api: Show nm columns from favourites, automatically reloading if needed to get missing columns 2023-10-03 11:40:38 -06:00
nathan
efe0eff776 Calendar: Fix sidebox owner could not select options 2023-10-02 16:06:25 -06:00
nathan
72112023e8 Et2Select: Fix link search lost selected item, showing ?? instead 2023-10-02 13:11:48 -06:00
nathan
795160301b Et2Select: Unit test update
- Added check to see if it actually shows the options
- Fix "Selected multiple remote results in value" failed
2023-10-02 08:39:22 -06:00
nathan
6c06a5311f Et2Select: Fix select options were only visible as search results 2023-10-02 08:04:19 -06:00
nathan
4f575894a2 Et2Select: Fix selecting a second search result could remove first one 2023-09-29 13:43:12 -06:00
nathan
124b6b1f96 Fix link-to would close & clear immediately after selecting a result 2023-09-28 11:00:30 -06:00
nathan
d5f56b8bae Fix duration would not store days or hours, only minutes 2023-09-28 09:39:53 -06:00
nathan
2b66ca8ba6 Docs: Get avatar widget in list, remove Et2 prefix from widget names 2023-09-27 14:29:19 -06:00
nathan
54b38cab8c Fix favourites did not show customfield column if needed 2023-09-27 13:22:57 -06:00
nathan
bbf676597f Et2Select: Fix selected search results sometimes disappeared 2023-09-27 11:15:13 -06:00
Milan
aa228dad42 WIP sl-Tree 2023-09-27 13:05:48 +02:00
Milan
e3ca0bfacd Merge remote-tracking branch 'origin/master' 2023-09-27 12:59:53 +02:00
nathan
d7b6306d32 Fix column selection 2023-09-26 15:47:16 -06:00
nathan
71806e051e Put additonal options to static select before the static options 2023-09-26 13:04:17 -06:00
nathan
bf7106cf86 Hide tooltips when context menu opens 2023-09-25 10:35:55 -06:00
nathan
70be19cdfb Et2Select: Fix change event did not fire when free entry was added 2023-09-25 10:16:32 -06:00
nathan
d33377e17d Fix date-duration did not show selected properly 2023-09-25 09:51:06 -06:00
nathan
735b52b38b Remove block_change_event
It doesn't seem to be needed now, and is actually stopping the first user change from firing (change alarm time in calendar edit)
2023-09-25 09:37:48 -06:00
nathan
5601897dbb Put additonal options to static select before the static options 2023-09-25 08:50:36 -06:00
hadi
8b5819094d Fix broken fullEmail feature 2023-09-25 14:35:18 +02:00
nathan
054d124afe Initial attempt at a nice dev reference.
Many thanks to all the other developers who made this possible, especially Shoelace
2023-09-22 13:51:38 -06:00
hadi
a00fdb9eb2 Clean up etemplate2 sessions before closing the top level window 2023-09-22 16:11:14 +02:00
ralf
e3138fe886 fix calendar.edit wont open, caused by new hidden attribute:
- parent can be undefined
- typo parent.getArr(a)yMgr()
- parseBoolExpression() does NOT support boolean values
- returning null gives errors later on, commented it out for now :(
2023-09-22 10:28:00 +02:00
nathan
92cf528fe8 Introduce widget.hidden to hide widgets, and widget.set_disabled() now also hides widgets. 2023-09-21 10:43:09 -06:00
nathan
0f66624047 Get some more automatic tests working again, remove JS files 2023-09-21 08:18:09 -06:00
nathan
e2d3c5f1e8 Get some automatic tests working again 2023-09-20 14:24:01 -06:00
nathan
5349c7a966 Fix selects with no emptyLabel but an option with value="" did not return a value 2023-09-20 08:20:22 -06:00
nathan
cdd13e5109 Fix doubled options with freeEntries 2023-09-19 16:04:19 -06:00
nathan
a4b0a2a1f0 Get country flags showing again 2023-09-19 15:20:36 -06:00
nathan
36f42f77db Fix quick add did not always work the second time 2023-09-19 13:53:15 -06:00
nathan
cb484c8f6c Fix some selectbox non-values causing issues 2023-09-19 13:01:49 -06:00
nathan
dc9736260a Fix textarea did not take vertical space 2023-09-19 10:08:18 -06:00
nathan
3b54165468 Fix textarea did not take vertical space 2023-09-19 10:00:08 -06:00
nathan
368c9fae63 Fix link to did not link 2023-09-19 08:46:41 -06:00
hadi
e72671bc20 Fix styling of readonly selectbox 2023-09-19 14:03:26 +02:00
nathan
f75567a863 Select improvements
- Add _styleTemplate for easier extension
- re-organize file
- Fix weird tag style
- some cleanup
2023-09-18 16:09:43 -06:00
nathan
01797f071d Fix mail attachment dropdown actions did nothing 2023-09-18 13:57:34 -06:00
nathan
19552059b3 Fix no results sometimes showed even if there were results 2023-09-15 08:09:55 -06:00
nathan
1d1b3f5947 Avoid JS error on blur 2023-09-14 14:33:16 -06:00
nathan
472ee73dda Improve styling & behaviour of Et2SelectEmail 2023-09-14 14:30:20 -06:00
nathan
01375295fe Fix widget label positioning 2023-09-14 11:56:25 -06:00
nathan
fade177f10 Fix first select option was not set 2023-09-14 11:48:30 -06:00
Milan
0f1f45a0cc WIP sl-Tree 2023-09-14 17:36:28 +02:00
nathan
4a7f775a97 Hide tooltips when context menu opens 2023-09-13 14:05:50 -06:00
Nathan Gray
e323cd1d79
Feature/shoelace 2.4 upgrade (#135)
Update shoelace to 2.9.0
2023-09-13 11:55:33 -06:00
nathan
575545e838 Api: Fix custom date & datetime fields with data format set caused a JS error
TypeError: Cannot set property format of #<Et2DateTime> which has only a getter
2023-09-13 09:15:24 -06:00
nathan
2aafc34140 Api: Fix customfield with no data sent breaks entire customfield tab 2023-09-13 09:11:30 -06:00
nathan
0f77eca5c4 Api: Fix custom date & datetime fields with data format set caused a JS error
TypeError: Cannot set property format of #<Et2DateTime> which has only a getter
2023-09-13 09:08:00 -06:00
milan
d69fd2a4cc cleanup for backport to 23
(cherry picked from commit 9cfb44529f)
2023-09-13 10:40:32 +02:00
milan
93b4c30f54 fix use selection instead of drag/drop while pressing crt/alt
egwPreventSelect on mousedown seems to be no longer necessary in nextmatch

(cherry picked from commit b9a723a16f)
2023-09-13 10:40:32 +02:00
hadi
a8bd6e9e3c Fix click handling on grid's row no longer works
(cherry picked from commit 3dbdbc0596)
2023-09-13 10:40:32 +02:00
Milan
6d7de44b7a egw_action copy fixes regarding ticket 84314
(cherry picked from commit 0dd7616c5e)
2023-09-13 10:40:32 +02:00
Milan
45b05a6268 WIP egw_action copy fixes
paste not working

(cherry picked from commit b00371c7e1)
2023-09-13 10:40:32 +02:00
ralf
ff4c86f4f5 fix not translated context menu
window.egw with a reference to the main window in a popup, egw(_app, window) gives one with correct window context / translation in a popup (_app does not matter for translations, they are requested to be loaded from server-side)

(cherry picked from commit 40a4d38776)
2023-09-13 10:40:32 +02:00
Milan
f430b66d3b converted egw_action from javascript to typescript
classes are now uppercase and in their own files. lowercase classes are deprecated.
Interfaces are now actual interfaces that should be implemented instead of creating and returning an ai Object every time

(cherry picked from commit 5e3c67a5cf)
2023-09-13 10:40:32 +02:00
nathan
d80078893e Api: Fix customfield with no data sent breaks entire customfield tab 2023-09-08 08:41:54 -06:00
nathan
0d4cde3ad6 Fix date & time formatting on mobile
- Date & DateTimeOnly did not show value
- timesheet view was missing start time
2023-09-06 13:44:21 -06:00
nathan
896f77f2fd Fix date & time formatting on mobile
- Date & DateTimeOnly did not show value
- timesheet view was missing start time
2023-09-05 11:21:09 -06:00
nathan
3803c4ebee Fix addressbook list type filter gave error when changing 2023-09-05 08:45:59 -06:00
nathan
6793f62c0f Api: Fix legacy onchange in nextmatch got nextmatch instead of changed widget 2023-09-05 08:45:55 -06:00
nathan
b5758a2268 Fix addressbook list type filter gave error when changing 2023-09-05 08:35:58 -06:00
nathan
e4e270da2a Api: Fix legacy onchange in nextmatch got nextmatch instead of changed widget 2023-08-30 10:30:07 -06:00
nathan
834141bdd0 Et2Select: Fix some static option selects did not show their values when readonly 2023-08-30 08:16:38 -06:00
nathan
0b036f49b8 Et2Select: Fix some static option selects did not show their values when readonly 2023-08-28 13:50:09 -06:00
hadi
b34789e676 Fix properties do not get set for inherited widgets from Et2Button 2023-08-28 12:19:18 +02:00
hadi
b33f0fa8cf Fix js error happens when there's no label set on select options 2023-08-28 12:17:42 +02:00
nathan
e3f139f2af Fix canceled close still destroyed session 2023-08-23 09:55:46 -06:00
nathan
8a1869dcdc passwordToggle - Get the attribute right for Shoelace 2.0.0
It's togglePassword in the current version
2023-08-21 11:54:24 -06:00
nathan
c8d4682672 Fix class case 2023-08-18 08:47:37 -06:00
nathan
9a53dc3ffd Fix canceled close still destroyed session 2023-08-16 10:23:58 -06:00
nathan
3362940b78 * Api: Store recoverable password (encrypted) for shares so you don't have to change it when you forget 2023-08-16 09:20:27 -06:00
nathan
86740d8b90 Fix up password customfield
- passwd->et2-password custom field type
- passwordToggle attribute (changed name, icon didn't change)
2023-08-16 09:20:18 -06:00
nathan
dd0780b29c Projectmanager: Fix context menu 'Project element' did not work
egw_links.js:66 Uncaught array of value needs a prefix
2023-08-16 09:16:59 -06:00
ralf
fdad8b3e40 fix TypeError in et2_dialog.handleClose because the Lion container was not found 2023-08-16 14:15:52 +02:00
nathan
7512e105da Projectmanager: Fix context menu 'Project element' did not work
egw_links.js:66 Uncaught array of value needs a prefix
2023-08-15 14:31:22 -06:00
nathan
2c5170f15b * Api: Store recoverable password (encrypted) for shares so you don't have to change it when you forget 2023-08-14 13:42:00 -06:00
milan
9cfb44529f cleanup for backport to 23 2023-08-09 17:18:28 +02:00
milan
b9a723a16f fix use selection instead of drag/drop while pressing crt/alt
egwPreventSelect on mousedown seems to be no longer necessary in nextmatch
2023-08-09 16:56:15 +02:00
nathan
1178d16afd Et2Dialog fixes
- Fix noCloseButton attribute was not implemented
- Fix hideOnExcape=false still allowed closing on escape
- Fix using Et2Dialog.BUTTONS_OK showed no buttons
2023-08-07 17:56:15 +02:00
nathan
11fcd35d26 Api: More missing changes from SearchMixin.remoteQuery() / static options from json file 2023-08-07 16:15:32 +02:00
ralf
e6274250bc adapt Et2LinkSearch.remoteQuery() to Nathans change not run cleanSelectOptions() in Et2Select.processRemoteResults() any more
@Nathan: not sure if this needs to be applied in more places, or your change should detect it needs running ...
2023-08-07 16:15:32 +02:00
nathan
17f1e0367c Fix handling of email addresses with names
- read-only was leaving out quotes on name, failing validation
- Commas in name caused problems when adding in to existing values due to simplistic CSV splitting
2023-08-07 15:57:09 +02:00
nathan
ac061434ea Pass event along from deprecated et2_dialog to Et2Dialog 2023-08-07 15:11:49 +02:00
nathan
c403784989 Api: Include webcomponents even if they don't have variable attributes, or any event handlers get lost 2023-08-04 14:21:16 -06:00
nathan
dfc30a37d1 Pass event along from deprecated et2_dialog to Et2Dialog 2023-08-04 13:07:24 -06:00
ralf
32c0aa8555 fix TypeError if field.values is null causing some nextmatch features like search not to render 2023-08-04 14:06:54 +02:00
nathan
7a17dcc7cb Fix handling of email addresses with names
- read-only was leaving out quotes on name, failing validation
- Commas in name caused problems when adding in to existing values due to simplistic CSV splitting
2023-08-03 16:57:53 -06:00
nathan
ef910b246a Et2Dialog: Fix dialog open event was fired if a selectbox opened
Fixes flickering field in Collabora insert address dialog
2023-08-03 14:44:05 -06:00
nathan
1393fb6921 Et2Dialog: Fix dialog open event was fired if a selectbox opened
Fixes flickering field in Collabora insert address dialog
2023-08-03 14:39:47 -06:00
nathan
9a121c2508 SearchMixin: If the value is changed while the search / options are open, recalculate positioning
Fixes bug where it looks like the value hasn't changed, until the dropdown closes.
2023-08-03 14:09:42 -06:00
nathan
b2e1cef233 SearchMixin: If the value is changed while the search / options are open, recalculate positioning
Fixes bug where it looks like the value hasn't changed, until the dropdown closes.
2023-08-03 14:05:10 -06:00