Commit Graph

882 Commits

Author SHA1 Message Date
Ralf Becker
42ea57c124 * All apps/PostgreSQL: fix SQL error when deleting an entry without attachments 2017-12-07 17:21:26 +08:00
Ralf Becker
c3c385e1f4 * Filemanager/PostgreSQL: cant open file in Collabora because of SQL error
Syntax error: 7 ERROR: syntax error at or near "=“, PostgreSQL needs true/false not 1/0
2017-12-07 16:47:42 +08:00
nathangray
c1faf8329d Fix historylog pagination, found by Filippos Karailanidis 2017-12-05 15:21:06 -07:00
nathangray
e2a6052058 * Api - Fix nested custom field merging 2017-12-01 11:59:28 -07:00
Hadi Nategh
2b72f759ff * Addressbook: fix bug setting Hide User Account in preferences into Show all accounts breaks show accounts 2017-12-01 17:07:42 +01:00
Hadi Nategh
1effbd6b7f Use filemanager_select for old etemplate apps 2017-12-01 11:07:35 +01:00
nathangray
5455b97664 * Addressbook - fix SQL error with accounts hidden + Organisation by location / department
- Fix accounts missing if no preference for hide accounts set
2017-11-30 10:10:34 +01:00
Ralf Becker
a049b86324 fix avatar/files update issues 2017-11-29 10:12:32 +01:00
nathangray
4a85f3c338 Fix missing fields in merge if info_contact is not a addressbook entry 2017-11-28 09:09:39 -07:00
Hadi Nategh
a7fcb77d1b Fix error Call to a member function setDate() on boolean 2017-11-27 18:06:27 +01:00
nathangray
257edc3aa7 Addressbook - fix show/hide account preference bugs
- account filter was missing for show active
- preference changed to match current value
2017-11-22 08:42:37 -07:00
nathangray
cfb34b05bf Addressbook - fix hide accounts preference did not work for duplicate & organisation views
- Added a new preference option to hide only deactivated accounts
2017-11-22 08:42:28 -07:00
nathangray
cd661ed3ba Mail - stop additional mail in sent folder when merging multiple contacts into email 2017-11-21 08:43:40 -07:00
Hadi Nategh
8bf0763c1f Fix list of favorites in VfsSelect contains previous selected contents as well 2017-11-20 17:50:21 +01:00
Hadi Nategh
6d51130cc6 Make favorites available as an individual button in VfsSelect dialog 2017-11-20 17:02:31 +01:00
Hadi Nategh
6d378b8e73 Fix attempting to open a document link in infolog pops collabora link even the user has no permission to the collabora app 2017-11-20 10:18:12 +01:00
nathangray
357f6ae65f Mail - Also include HTML version of email in integration data (for apps that can handle it) 2017-11-15 08:50:33 -07:00
Ralf Becker
0e40bd7cb5 * CalDAV/CardDAV: fix encoding of control chars stalling iOS sync
eg. \xb is not allowed in XML and caused iOS sync to stall, as it's XML parser fails
use htmlspecialchars option ENT_XML1|ENT_DISALLOWED (PHP 5.4+) to ensure proper XML encoding
2017-11-10 15:50:28 +01:00
Ralf Becker
628e7596d3 allow to migrate accounts from ADS to SQL 2017-11-09 15:28:37 +01:00
Hadi Nategh
6b0a8a1b5d Fix vfsSelect does not show any content for the first load 2017-11-09 10:26:49 +01:00
Ralf Becker
1b5e992f43 allow sql fragments in Api\Storage\Base::delete as in other places 2017-11-08 11:45:40 +01:00
Ralf Becker
8fdffab564 allow sql fragments in Api\Storage\Base::delete as in other places 2017-11-08 11:45:24 +01:00
Ralf Becker
464f1b3894 never invalidate session in sharing, as we cant regenerate it (and we dont need to) 2017-11-07 13:03:30 +01:00
Ralf Becker
1222ef1813 also log if _check_script_tag was able to disarm XSS automatic 2017-11-07 12:24:15 +01:00
Ralf Becker
5d1217b89b deny sharing owner rights (chmod, chgrp, set eACL) and disable eACL tab 2017-11-06 15:19:19 +01:00
nathangray
dda47ca863 Disable extended ACL for readonly shares 2017-11-03 10:28:27 -06:00
Ralf Becker
4ebf79d0e1 * Sharing/Collabora: allow to use Collabora on writable shares (EPL only) 2017-11-03 12:43:09 +01:00
nathangray
ef7956f34b Make sure lang gets passed on to registration 2017-11-02 11:13:29 -06:00
nathangray
069d49afba Disable copy / paste for readonly shares 2017-11-02 09:43:08 -06:00
Ralf Becker
3689b3d645 * Filemanager/Sharing: deny rename, move, mkdir and rmdir on readonly share 2017-11-02 13:34:10 +01:00
Hadi Nategh
3465c40b50 Remove unsafe-eval CSP for CKEditor 2017-11-02 11:02:16 +01:00
Ralf Becker
0813403b5b * All apps: get sharing working with files attached to application entries 2017-10-31 10:51:59 +01:00
Ralf Becker
b9594ea357 fix typo 2017-10-31 10:49:12 +01:00
Ralf Becker
b5574da397 remove system call used for PHP < 5.3.1 2017-10-31 09:55:23 +01:00
Ralf Becker
a4526c98cb store CalDAV/CardDAV log in user spezific log directories 2017-10-30 15:00:42 +01:00
nathangray
616c11c1fb Fix wrong table name 2017-10-27 17:48:42 +02:00
nathangray
0d14155472 Fix minimum fs_id was not returning proper value 2017-10-27 17:43:40 +02:00
nathangray
90ce0cc7b6 Add a function to get the lowest fs_id for a path 2017-10-27 17:43:40 +02:00
Ralf Becker
12dbfca137 check cookies for XSS attempts 2017-10-27 16:52:34 +02:00
nathangray
5750904809 Fix setlocale to be able to find locales on Ubuntu 2017-10-27 10:54:39 +02:00
Ralf Becker
5b573abef7 do not allow path traversal and htmlencode displayed path 2017-10-26 13:16:52 +02:00
nathangray
fdb47ab168 Merge calendar events into user account if there is one over user contact 2017-10-26 09:16:02 +02:00
Ralf Becker
77b42dd9a4 always send X-Content-Type-Options: nosniff
It does not harm and stops unpredictable results from browsers changing our content-types
(FF 50+ now also supports nosniff)
2017-10-25 17:35:30 +02:00
Hadi Nategh
fdb3202b6b Add new config to the admin site configuration in order to be able to upload a custom header logo 2017-10-23 13:23:52 +02:00
nathangray
b8f8a014fa Move all tests under api/src into api/tests 2017-10-23 10:14:14 +02:00
nathangray
24de1dff3b Move PHPUnit tests from test to tests subdirectory 2017-10-23 09:51:28 +02:00
Ralf Becker
c88e6e0237 disabling E_DEPRECATED, as contrib apps wont work under PHP 7.1 with having eg. contructors with same name as the class 2017-10-21 12:03:10 +02:00
nathangray
d3c596a443 - Add a parameter to pass in the class of the notification to use so we can pass in a test one
- Explicitly tell notification what type of message (plain or html) we're giving it
2017-10-21 11:29:05 +02:00
Hadi Nategh
ff4396030a Fix CKEditor Browse Server button to open vfsSelect 2017-10-20 18:55:22 +02:00
nathangray
accd6187e2 Get date widget duration test working again 2017-10-20 09:56:47 +02:00
nathangray
9e6ecce1d0 Move tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-18 18:30:54 +02:00
nathangray
237d81ce36 Move tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-18 15:43:35 +02:00
nathangray
865fd6405d Move sanity check to a pre-condition check 2017-10-18 11:47:28 +02:00
Ralf Becker
1d7fb9fe90 improve check $GLOBALS[egw] is correctly initilized 2017-10-18 09:10:39 +02:00
nathangray
cd49f6568d Replace the lost boolean cast 2017-10-17 16:48:35 +02:00
nathangray
88a3f3b1d4 Run test in UTC, so dates match our expectations 2017-10-17 15:40:05 +02:00
nathangray
6fad74c710 Fix test had no assertions 2017-10-17 13:29:17 +02:00
nathangray
8b1a8d38f5 Revert db10b21fa7 2017-10-17 12:48:46 +02:00
nathangray
db10b21fa7 Fix child actions under 'More...' did not inherit the inheritable attributes 2017-10-13 11:13:17 -06:00
nathangray
63a3940d68 Addressbook - adjust calendar event participants to match when merging contacts 2017-10-13 09:35:36 -06:00
Hadi Nategh
052bef84ce W.I.P vfsSelect Widget:
- Fix upload feature not working
2017-10-13 13:22:45 +02:00
Hadi Nategh
5b76210218 W.I.P vfsSelect Widget:
- Fix mime types not being shown
- Fix name being displayed encoded in save2vfs mail
2017-10-12 17:45:46 +02:00
Hadi Nategh
2c721c95b2 W.I.P. VFS Select Widget:
- Add name and dialog_title as new attributes
- Fix SaveToVfs, SaveAttachmentToVfs, SaveAllToVfs in mail
- Fix button tile
2017-10-12 13:19:42 +02:00
Hadi Nategh
448cc8975f W.I.P of VFS Select widget restructure 2017-10-11 18:27:42 +02:00
Hadi Nategh
de65d91dc7 Rmove fields for none private cutomfields when name refers to a single custom field 2017-10-06 16:27:37 +02:00
nathangray
0183635c02 Add permission check for collabora before setting actions to open in editor 2017-10-05 09:55:06 -06:00
Ralf Becker
6a3a944828 fix uncaught exception if Collabora is not configured or reachable 2017-10-05 11:00:38 +02:00
nathangray
1868b40359 Set up merge to open editable documents if collabora is there 2017-10-04 14:15:47 -06:00
nathangray
285eb8494b Addressbook - Merging contacts now keeps all distribution lists, and it works now 2017-09-27 09:00:46 -06:00
Ralf Becker
1ae0f29f01 return "400 Bad Request" if propfind contains invalid elements or more then one 2017-09-26 19:13:05 +02:00
nathangray
2d57801c6a * Addressbook - Merging contacts now keeps all distribution lists 2017-09-26 11:05:34 -06:00
Hadi Nategh
a4fdc052ab Filemanager "New" actions:
- Add "New" actions into nm header as drop down list
- Re-arrange actions in contextmenu
- Let Etemplate modifies sel_options if extra changes are available
2017-09-26 18:43:18 +02:00
Hadi Nategh
6407379388 Accept localhost as a valid url 2017-09-26 11:37:37 +02:00
Ralf Becker
a6ec69169d document and enhance function signaure for server-side callback of file and vfs-upload widget
also make it usable for vfs-upload widget with it's id containing entry's id
2017-09-21 11:33:40 +02:00
nathangray
2876a2838c Adjust 'Group' account search keyword so even if someone searches for 'Group', we still respect the 'type' parameter and only return user accounts if that was what was requested. 2017-09-20 09:27:39 -06:00
Ralf Becker
48554590f4 * Addressbook: store S/Mime & PGP pubkey and photo (SQL backend only) in filesystem 2017-09-19 11:38:48 +02:00
Ralf Becker
23e654ab89 fix IDE warnings 2017-09-19 11:38:48 +02:00
nathangray
5b4fd418bf Etemplate - change select multiple validation to also consider rows > 1 to enable multiple 2017-09-14 09:19:26 -06:00
nathangray
e0eb181373 Test for overriding Horde's translations with our own 2017-09-13 17:10:48 -06:00
nathangray
27fab7c259 Etemplate - keep child after instanciating 2017-09-08 12:43:28 -06:00
nathangray
1b36ecb962 Etemplate - fix a testing bug giving false positives 2017-09-08 11:49:28 -06:00
nathangray
f9e09953d1 Etemplate - clear other set limits to avoid conflicts with other tests 2017-09-08 11:42:22 -06:00
nathangray
43f6acdf72 Etemplate - enhance email regex to avoid trailing dots in address, comment out some other checks we might not care about 2017-09-08 11:39:33 -06:00
nathangray
cc1fff6c17 Etemplate - add a URL regex to catch some invalids that were making it through 2017-09-08 11:10:57 -06:00
nathangray
12ae214b76 Etemplate - fix bug where min / max could not be 0 2017-09-08 10:30:19 -06:00
nathangray
4d68048929 Etemplate - fix causing false negatives in textbox regex text 2017-09-08 09:51:55 -06:00
nathangray
2006b1f372 Etemplate - fix some bugs in min/max validation 2017-09-08 09:51:06 -06:00
nathangray
0b3cbdeae5 Etemplate - some basic selectbox tests 2017-09-08 09:00:37 -06:00
nathangray
0ead3713e2 Etemplate url widget tests 2017-09-08 09:00:37 -06:00
nathangray
c656d13a4c Silence log of validation errors 2017-09-08 09:00:37 -06:00
nathangray
d75372368a Etemplate url-email widget tests 2017-09-08 09:00:37 -06:00
Hadi Nategh
36991cb80b S/MIME:
- Encode saved mail into sent folder with ENCODE_7bit to avoid any changes.
- Fix signed mails in sent folder not being correctly verified after.
2017-09-04 12:39:58 +02:00
Hadi Nategh
4d8efd0c4a S/MIME:
- Add public key of sender into recipient keys while encrypting a message.
This make encrypted mails in sent folder readable by sender as well.
2017-09-04 11:43:33 +02:00
Hadi Nategh
ee092b0d5a S/MIME:
- Rephrase warning message for reading encrypted mails with no relevant 
pubkey and privkey
- If no mimeType provided set it to default type from mime object
2017-09-04 10:20:04 +02:00
Hadi Nategh
f4dd4bbf96 S/MIME:
- Reveal more info about signer and certificate
2017-09-01 11:38:39 +02:00
Hadi Nategh
1a8e584e0c S/MIME:
- Fix PGP signed messages get shown as red
- Fix attachments area always gets displayed
2017-08-31 17:33:33 +02:00
Hadi Nategh
914d6b2a52 S/MIME:
- Make sure content of p12 file contained \0 chars at the end stored in credentials will not get trimmed.
2017-08-31 11:40:02 +02:00
Ralf Becker
c886d567f9 share token could still contain "+", which Vfs::encodePathComponent was not encoding
fixes some files not opening in Collabora
2017-08-30 18:16:15 +02:00
Hadi Nategh
3f06a89db5 S/MIME:
- Store full binary (pkcs12) certificate into credentials
- Extract cacert from pkcs12 and feed it into signing process
- Implement p12 export
2017-08-30 17:00:28 +02:00
Ralf Becker
b785766331 * LDAP/Mail: fix new accounts did not automatic enable mail account
Thanks to Lagrange, Joseph Fernando for the fix.
2017-08-29 20:08:43 +02:00
Hadi Nategh
f788f001d0 Fix broken mail compose 2017-08-29 11:38:08 +02:00
nathangray
495d67d5d0 Testing max & min on date widget 2017-08-28 11:44:30 -06:00
Hadi Nategh
8fd6325c3d S/MIME:
- Override send function in mailer object to be able to use additional options of part->send
- Fix Signed html message gets not working
2017-08-28 19:24:51 +02:00
Hadi Nategh
74bfeade9e S/MIME:
- Fix waring about openssl CA's bundle path
2017-08-28 16:24:56 +02:00
Hadi Nategh
4b9b5aa7e4 S/MIME:
- Add password remember option for smime_passphrase dialog in compose
2017-08-28 16:14:56 +02:00
Hadi Nategh
e3799c52fc S/MIME:
- Fix smime credentials get stored with wrong account_id
2017-08-28 15:18:25 +02:00
Hadi Nategh
466e3ad364 S/MIME:
- Missing part from commit ef04e0bb77
2017-08-28 15:02:38 +02:00
Hadi Nategh
ef04e0bb77 S/MIME:
- use acc_smime_username for fetching smime certificate
2017-08-28 14:22:55 +02:00
Hadi Nategh
668cbaaacb S/MIME:
- Store email address associated with certificate into cred_email
2017-08-28 12:35:21 +02:00
nathangray
61dc75621d Etemplate simple date widget tests 2017-08-25 10:11:41 -06:00
Hadi Nategh
36211267bf S/MIME:
- Implement unknownemail status in case signer email address is not matched with sender email address
2017-08-25 16:07:09 +02:00
Hadi Nategh
63440ddbc5 S/MIME:
- Keep private key encrypted
- Show password field always
2017-08-24 18:15:40 +02:00
nathangray
b0cd55f0b6 Some more Etemplate tests 2017-08-24 08:48:07 -06:00
nathangray
97543138f8 Some test documentation 2017-08-24 08:48:07 -06:00
nathangray
997c2fd1d5 Add simple tests for textbox widget 2017-08-24 08:48:07 -06:00
Ralf Becker
567d3d0a72 fix wrong namespace 2017-08-24 16:40:23 +02:00
Hadi Nategh
bbea403298 W.I.P S/MIME:
- Generate private key and certificate
- Add export buttons for private key and certificate
- Add certificate field
2017-08-22 17:25:29 +02:00
Hadi Nategh
7416c58e0d W.I.P. of S/MIME:
- Add extracted email from certificate into metadata
2017-08-21 11:05:58 +02:00
Ralf Becker
946ff478c4 fix missing replace 2017-08-18 12:08:51 +02:00
Ralf Becker
191d6aec45 support PHPunit 6.0+ and older 5.7 for PHP 5.6 2017-08-18 11:45:10 +02:00
Ralf Becker
c244e72017 set required PHP version for master/17.1 to 5.6, recommended version to 7.0 and add 7.1 to Travis checks 2017-08-18 10:22:52 +02:00
Hadi Nategh
ec6e82f0a1 W.I.P. SMIME:
- Fix switching account fetches a wrong pubkey
2017-08-17 09:04:44 +02:00
nathangray
72f3dc394b Fix missing CSS includes 2017-08-15 12:53:39 -06:00
nathangray
d5831a4229 Fix opening the same URL twice did not go to the specified destination the second time a second time.
This time we redirect to index.php?cd=yes so reload also works, and fix the last active tab.
2017-08-15 10:27:52 -06:00
nathangray
6566df4ff8 Fix opening the same URL twice did not go to the specified destination the second time
Eg. tracker edit went to tracker index the second time
2017-08-04 10:27:16 -06:00
nathangray
fe7e240321 Fix browser's range requests giving an empty file every second download attempt 2017-07-28 10:35:24 -06:00
nathangray
2bfe829dd8 Fix calendar entries opened from mail using a link could not be edited 2017-07-27 13:28:37 -06:00
Hadi Nategh
f600436898 W.I.P. SMIME:
- add notvalid state
- add metadata for key add to contact
2017-07-25 18:00:22 +02:00
Hadi Nategh
91fb816bb2 W.I.P. SMIME:
- Override verify method in order to pass certs bundle for verification
- Catch exception if decryption fails because encrypted message perhaps is not encrypted by receiver public key
- Define different states for signature verification
2017-07-25 17:13:49 +02:00
Ralf Becker
c6bf51180f implement expiration time for Api\Cache::(g|s)etSession() 2017-07-24 17:05:31 +02:00
Hadi Nategh
4deaf6c09a W.I.P. SMIME:
- Add missing parts from commit 0499f50943
2017-07-20 18:54:09 +02:00
Ralf Becker
b30c712e19 allow to add SQL with nummeric keys to Storage\Base::read() argument, like in ::search or Db::select 2017-07-19 17:39:22 +02:00
Hadi Nategh
2ead0ae2fb W.I.P Smime:
- Implement passphrase missing exception
2017-07-19 15:41:55 +02:00
Hadi Nategh
7eccf7c0c9 W.I.P Smime:
- Migrate smime decryption to Mail_bo
2017-07-19 15:39:28 +02:00
Hadi Nategh
78fa78983c Do not try to fetch mime part content if the content is already set 2017-07-14 09:50:19 +02:00
Stefan Werfling
3565f09ab0 Merge remote-tracking branch 'EGroupware/master' 2017-07-13 22:15:40 +02:00
Hadi Nategh
cb784c25af W.I.P. SMIME:
- Fix warning of invalid arguments
- Fix sometimes signed content not returning correct mime part
2017-07-13 15:37:02 +02:00
Stefan Werfling
680c4c43d0 change comment example 2017-07-13 13:59:03 +02:00
Stefan Werfling
834f226465 add example to comment 2017-07-13 13:56:31 +02:00
Stefan Werfling
7f572fdeb5 4loader:
namespace: add else autoload app vendor
2017-07-13 13:35:02 +02:00
Hadi Nategh
c131be8c17 W.I.P. SMIME:
- Allow saveSession to save other values in cache besides mailbox
2017-07-12 18:32:46 +02:00
Ralf Becker
79750d22a5 fix fatal error if sambaadmin is not installed, but was before 2017-07-12 18:29:01 +02:00
Hadi Nategh
06673bcb03 W.I.P. SMIME:
- Remove multipart/signed from SMIME TYPES
2017-07-11 19:03:11 +02:00
Hadi Nategh
afe1459387 Smime W.I.P:
- Fix couple of IDE warnings
2017-07-10 11:12:35 +02:00
Hadi Nategh
eb6fc7a366 Smime W.I.P:
- Return extracted signed content as horde_mime_part object
2017-07-10 11:05:15 +02:00
Ralf Becker
d38cc11f7e do NOT catch exceptions in hooks
maybe we need some parameter to hooks-calls, if all hooks should run, before exception get's re-thrown, as with this commit first exeception in a hook, will stop other hooks from running.
2017-07-08 18:05:15 +02:00
Hadi Nategh
d891035fbe Smime W.I.P:
- Remove initial content-type header
- Do not set flowed if it's multipart/signed
2017-07-07 17:53:02 +02:00
Ralf Becker
0528b72744 * Mail/ActiveDirectory: fix empty identity in mail compose and account not active in AD controled mail-server 2017-07-05 17:55:49 +02:00
nathangray
ef6eb77991 Use static to get token so children can override it 2017-06-30 09:47:21 -06:00
Ralf Becker
0d80fdbcf9 * Univention: forwarding mails to external addresses added in UCS 4.2 2017-06-30 14:44:55 +02:00