Commit Graph

23 Commits

Author SHA1 Message Date
Jörg Lehrke
18ff8a6fa7 Merge SyncML Extensions with 1.6 2009-11-16 08:04:18 +00:00
Klaus Leithoff
c819f15dbc fixing a problem regarding the datehandling in Horde/iCalendar.php reported by Chr.Kaulich 2009-10-02 09:05:09 +00:00
Klaus Leithoff
cb8cd0f3e6 when having multiple lines descriptions in contacts or calendar, these are not correctly encoded in vcard.
The problem seems to be line [784] of trunk/phpgwapi/inc/horde/Horde/iCalendar.php
$value = str_replace($this->_newline, '\n', $value);
When removing this line, the description value is correct on the client.

I could not find any sideffects during my tests, if some clients have
problems with this, I assume this would then have to be fixed at a higher
level, because the current state with this line just causes broken output.

From wikipedia regarding Linebreaks in QuotedPrintable:
If the data being encoded contains meaningful line breaks, they must be encoded as an ASCII CR LF sequence, not as their original byte values

Vcard extract without the reported line code:
DESCRIPTION;ENCODING=QUOTED-PRINTABLE:Desc 1=0D=0ADesk 2=0D=0A=0D=0A

Vcard extract with the reported line of code
DESCRIPTION;ENCODING=QUOTED-PRINTABLE:Desc 1\nDesk 2\n\n

pointed out by Philip Herbert. Carl Knauber Holding GmbH & Co KG
2008-08-04 08:42:19 +00:00
Klaus Leithoff
16cb2097fc Some Devices (Nokia S60) ignore the entire vcard, if the vcard contains
formal error.

This breaks sync for single contacts from egw to client.
example: photo in addressbook without blank line after the property value.
This way the devices are not compliant with RFC2426 (Vcard Version 3)
5. Differences From vCard v2.1
[...]
. Inline binary content must be "B" encoded and folded. A blank
line after the encoded binary content is no longer required.
[...]
This was pointed out by Philip Herbert. Carl Knauber Holding GmbH & Co KG
2008-08-04 08:18:49 +00:00
Ralf Becker
4296d0c31f dont avoid empty fields, as some are required by vCard, eg. FN 2008-07-04 11:22:25 +00:00
Ralf Becker
6d274a7aca "switching of error_log in _parseDateTime()" 2008-05-10 19:00:31 +00:00
Ralf Becker
7b6a1013fc SyncML patches from patrick.bihan-faou-AT-mindstep.com (without
logout+mbstring stuff), small modification to use the already exiting
methodes to generate full name and fileas)
The code is commited to trunk only at the moment to allow testing of it.
If everything goes well, we intend to commit it to 1.4 branch too.
Here's the original description of the patch by Patrick:
- handles the default config for current versions of funambol (i.e. the
scard/stask/snote/scal locations)
- tries to be a bit smarter on how the data content should be encoded
based on what the client specified (sif+base64/vcard, / fragmented or
not, etc.)
- workaround a bug in some versions of funambol, where funambol does not
specify the proper sif type for the type of requested data
- imported patch #117 from egw's tracker
- make sure that the logs generated by the horde code go to stderr so
they can be view in the webserver's logs
- as much as possible reduce code duplication. For example, the
categories are handled in the parent classes for both the SIF avn VCAL
formats for each type of data (addressbook,infolog,calendar).
- make sure the code can handle more than one categories in each
  direction
- treat the 'sony ericsson' vendor string just like 'sonyericsson', the
newer phones apparently have a space in the vendor string... (this
touches some files in the icalsrv as well)
- handle notes: these should now work with everything (funambol or
  other)
- remove more code duplication: the syncml "api" for the various data
types (calendar, contacts, infolog) is now common for both the vcard and
sif data formats (cf the files that need to be removed)
- handle the "privat" filter in infolog like the "private" filter (some
part of the code use the name without the trailing e)
- imported patch # 267 from egw's tracker
2007-09-29 10:29:48 +00:00
Carsten Wolff
0214de953e RRULE should not be escaped by this class in egw, because it's generated with ; in it 2007-04-24 09:33:22 +00:00
Lars Kneschke
1ba36a6ca5 Horde::iCalendar vcalendar export bug
Special characters in text field are not scaped when events or todos are exported. For example, ',' in the description field are send literal. According to rfc2445 section 4.3.11 there are some characters which must be scaped or quoted. This patch tries to solved this problem.

patch contributed by Antoni Matamalas
2006-11-13 09:19:01 +00:00
Lars Kneschke
485027f3f1 patch from Christian
this patch fixes the handling of daylight saving
2006-11-13 08:19:23 +00:00
Christian Binder
0f4fee5b3f Horde iCalendar.php::parsevCalendar now accepts ';' AND ',' as field delimiter for EXDATE and FREEBUSY 2006-11-09 09:57:49 +00:00
Lars Kneschke
9fa275421b patch from christian binder
563: set delimiter to ";" instead of ","
2006-08-24 09:47:40 +00:00
Lars Kneschke
40012677d7 don't convert charset 2 times anymore 2006-08-17 03:38:27 +00:00
Lars Kneschke
502f8508ef removed (hopefully) unneeded linebreaks 2006-08-17 03:30:19 +00:00
Lars Kneschke
87dcfb1c10 bugifx from jan 2006-05-18 14:21:29 +00:00
Lars Kneschke
1d791acb2f important patch from Jan 2006-04-07 08:54:48 +00:00
Lars Kneschke
ea0f776b92 Patch from Jan
It is the simple patch to prevents the segfaulting of horde on ical with
spaces in the begin:vevent etc lines. (just \W\w replaced by \S if I
remember well at one place..)

The second patch is for getting rid of some php5 warnings when it
encounters the array_merge() in setParameter(). (only a simple cast to
an array).
2006-03-11 08:09:12 +00:00
Lars Kneschke
785391f71d patches from JVL and some debug output removed 2006-01-22 17:59:06 +00:00
Lars Kneschke
40586d80db patch from jvl xs4all nl 2006-01-16 11:14:33 +00:00
Lars Kneschke
916f9994b6 fix charset translation 2005-12-23 12:32:57 +00:00
Ralf Becker
83b0801533 commit for Lars: latest SyncML updates 2005-07-20 12:09:32 +00:00
Lars Kneschke
062f20ec42 chaning phpgw -> egw 2005-06-20 11:04:20 +00:00
Lars Kneschke
d43bf7d44f first commit of syncml code 2005-06-19 19:00:58 +00:00