Commit Graph

965 Commits

Author SHA1 Message Date
nathangray
1868b40359 Set up merge to open editable documents if collabora is there 2017-10-04 14:15:47 -06:00
nathangray
285eb8494b Addressbook - Merging contacts now keeps all distribution lists, and it works now 2017-09-27 09:00:46 -06:00
Ralf Becker
1ae0f29f01 return "400 Bad Request" if propfind contains invalid elements or more then one 2017-09-26 19:13:05 +02:00
nathangray
2d57801c6a * Addressbook - Merging contacts now keeps all distribution lists 2017-09-26 11:05:34 -06:00
Hadi Nategh
a4fdc052ab Filemanager "New" actions:
- Add "New" actions into nm header as drop down list
- Re-arrange actions in contextmenu
- Let Etemplate modifies sel_options if extra changes are available
2017-09-26 18:43:18 +02:00
Hadi Nategh
6407379388 Accept localhost as a valid url 2017-09-26 11:37:37 +02:00
Ralf Becker
a6ec69169d document and enhance function signaure for server-side callback of file and vfs-upload widget
also make it usable for vfs-upload widget with it's id containing entry's id
2017-09-21 11:33:40 +02:00
nathangray
2876a2838c Adjust 'Group' account search keyword so even if someone searches for 'Group', we still respect the 'type' parameter and only return user accounts if that was what was requested. 2017-09-20 09:27:39 -06:00
Ralf Becker
48554590f4 * Addressbook: store S/Mime & PGP pubkey and photo (SQL backend only) in filesystem 2017-09-19 11:38:48 +02:00
Ralf Becker
23e654ab89 fix IDE warnings 2017-09-19 11:38:48 +02:00
nathangray
5b4fd418bf Etemplate - change select multiple validation to also consider rows > 1 to enable multiple 2017-09-14 09:19:26 -06:00
nathangray
e0eb181373 Test for overriding Horde's translations with our own 2017-09-13 17:10:48 -06:00
nathangray
27fab7c259 Etemplate - keep child after instanciating 2017-09-08 12:43:28 -06:00
nathangray
1b36ecb962 Etemplate - fix a testing bug giving false positives 2017-09-08 11:49:28 -06:00
nathangray
f9e09953d1 Etemplate - clear other set limits to avoid conflicts with other tests 2017-09-08 11:42:22 -06:00
nathangray
43f6acdf72 Etemplate - enhance email regex to avoid trailing dots in address, comment out some other checks we might not care about 2017-09-08 11:39:33 -06:00
nathangray
cc1fff6c17 Etemplate - add a URL regex to catch some invalids that were making it through 2017-09-08 11:10:57 -06:00
nathangray
12ae214b76 Etemplate - fix bug where min / max could not be 0 2017-09-08 10:30:19 -06:00
nathangray
4d68048929 Etemplate - fix causing false negatives in textbox regex text 2017-09-08 09:51:55 -06:00
nathangray
2006b1f372 Etemplate - fix some bugs in min/max validation 2017-09-08 09:51:06 -06:00
nathangray
0b3cbdeae5 Etemplate - some basic selectbox tests 2017-09-08 09:00:37 -06:00
nathangray
0ead3713e2 Etemplate url widget tests 2017-09-08 09:00:37 -06:00
nathangray
c656d13a4c Silence log of validation errors 2017-09-08 09:00:37 -06:00
nathangray
d75372368a Etemplate url-email widget tests 2017-09-08 09:00:37 -06:00
Hadi Nategh
36991cb80b S/MIME:
- Encode saved mail into sent folder with ENCODE_7bit to avoid any changes.
- Fix signed mails in sent folder not being correctly verified after.
2017-09-04 12:39:58 +02:00
Hadi Nategh
4d8efd0c4a S/MIME:
- Add public key of sender into recipient keys while encrypting a message.
This make encrypted mails in sent folder readable by sender as well.
2017-09-04 11:43:33 +02:00
Hadi Nategh
ee092b0d5a S/MIME:
- Rephrase warning message for reading encrypted mails with no relevant 
pubkey and privkey
- If no mimeType provided set it to default type from mime object
2017-09-04 10:20:04 +02:00
Hadi Nategh
f4dd4bbf96 S/MIME:
- Reveal more info about signer and certificate
2017-09-01 11:38:39 +02:00
Hadi Nategh
1a8e584e0c S/MIME:
- Fix PGP signed messages get shown as red
- Fix attachments area always gets displayed
2017-08-31 17:33:33 +02:00
Hadi Nategh
914d6b2a52 S/MIME:
- Make sure content of p12 file contained \0 chars at the end stored in credentials will not get trimmed.
2017-08-31 11:40:02 +02:00
Ralf Becker
c886d567f9 share token could still contain "+", which Vfs::encodePathComponent was not encoding
fixes some files not opening in Collabora
2017-08-30 18:16:15 +02:00
Hadi Nategh
3f06a89db5 S/MIME:
- Store full binary (pkcs12) certificate into credentials
- Extract cacert from pkcs12 and feed it into signing process
- Implement p12 export
2017-08-30 17:00:28 +02:00
Ralf Becker
b785766331 * LDAP/Mail: fix new accounts did not automatic enable mail account
Thanks to Lagrange, Joseph Fernando for the fix.
2017-08-29 20:08:43 +02:00
Hadi Nategh
f788f001d0 Fix broken mail compose 2017-08-29 11:38:08 +02:00
nathangray
495d67d5d0 Testing max & min on date widget 2017-08-28 11:44:30 -06:00
Hadi Nategh
8fd6325c3d S/MIME:
- Override send function in mailer object to be able to use additional options of part->send
- Fix Signed html message gets not working
2017-08-28 19:24:51 +02:00
Hadi Nategh
74bfeade9e S/MIME:
- Fix waring about openssl CA's bundle path
2017-08-28 16:24:56 +02:00
Hadi Nategh
4b9b5aa7e4 S/MIME:
- Add password remember option for smime_passphrase dialog in compose
2017-08-28 16:14:56 +02:00
Hadi Nategh
e3799c52fc S/MIME:
- Fix smime credentials get stored with wrong account_id
2017-08-28 15:18:25 +02:00
Hadi Nategh
466e3ad364 S/MIME:
- Missing part from commit ef04e0bb77
2017-08-28 15:02:38 +02:00
Hadi Nategh
ef04e0bb77 S/MIME:
- use acc_smime_username for fetching smime certificate
2017-08-28 14:22:55 +02:00
Hadi Nategh
668cbaaacb S/MIME:
- Store email address associated with certificate into cred_email
2017-08-28 12:35:21 +02:00
nathangray
61dc75621d Etemplate simple date widget tests 2017-08-25 10:11:41 -06:00
Hadi Nategh
36211267bf S/MIME:
- Implement unknownemail status in case signer email address is not matched with sender email address
2017-08-25 16:07:09 +02:00
Hadi Nategh
63440ddbc5 S/MIME:
- Keep private key encrypted
- Show password field always
2017-08-24 18:15:40 +02:00
nathangray
b0cd55f0b6 Some more Etemplate tests 2017-08-24 08:48:07 -06:00
nathangray
97543138f8 Some test documentation 2017-08-24 08:48:07 -06:00
nathangray
997c2fd1d5 Add simple tests for textbox widget 2017-08-24 08:48:07 -06:00
Ralf Becker
567d3d0a72 fix wrong namespace 2017-08-24 16:40:23 +02:00
Hadi Nategh
bbea403298 W.I.P S/MIME:
- Generate private key and certificate
- Add export buttons for private key and certificate
- Add certificate field
2017-08-22 17:25:29 +02:00
Hadi Nategh
7416c58e0d W.I.P. of S/MIME:
- Add extracted email from certificate into metadata
2017-08-21 11:05:58 +02:00
Ralf Becker
946ff478c4 fix missing replace 2017-08-18 12:08:51 +02:00
Ralf Becker
191d6aec45 support PHPunit 6.0+ and older 5.7 for PHP 5.6 2017-08-18 11:45:10 +02:00
Ralf Becker
c244e72017 set required PHP version for master/17.1 to 5.6, recommended version to 7.0 and add 7.1 to Travis checks 2017-08-18 10:22:52 +02:00
Hadi Nategh
ec6e82f0a1 W.I.P. SMIME:
- Fix switching account fetches a wrong pubkey
2017-08-17 09:04:44 +02:00
nathangray
72f3dc394b Fix missing CSS includes 2017-08-15 12:53:39 -06:00
nathangray
d5831a4229 Fix opening the same URL twice did not go to the specified destination the second time a second time.
This time we redirect to index.php?cd=yes so reload also works, and fix the last active tab.
2017-08-15 10:27:52 -06:00
nathangray
6566df4ff8 Fix opening the same URL twice did not go to the specified destination the second time
Eg. tracker edit went to tracker index the second time
2017-08-04 10:27:16 -06:00
nathangray
fe7e240321 Fix browser's range requests giving an empty file every second download attempt 2017-07-28 10:35:24 -06:00
nathangray
2bfe829dd8 Fix calendar entries opened from mail using a link could not be edited 2017-07-27 13:28:37 -06:00
Hadi Nategh
f600436898 W.I.P. SMIME:
- add notvalid state
- add metadata for key add to contact
2017-07-25 18:00:22 +02:00
Hadi Nategh
91fb816bb2 W.I.P. SMIME:
- Override verify method in order to pass certs bundle for verification
- Catch exception if decryption fails because encrypted message perhaps is not encrypted by receiver public key
- Define different states for signature verification
2017-07-25 17:13:49 +02:00
Ralf Becker
c6bf51180f implement expiration time for Api\Cache::(g|s)etSession() 2017-07-24 17:05:31 +02:00
Hadi Nategh
4deaf6c09a W.I.P. SMIME:
- Add missing parts from commit 0499f50943
2017-07-20 18:54:09 +02:00
Ralf Becker
b30c712e19 allow to add SQL with nummeric keys to Storage\Base::read() argument, like in ::search or Db::select 2017-07-19 17:39:22 +02:00
Hadi Nategh
2ead0ae2fb W.I.P Smime:
- Implement passphrase missing exception
2017-07-19 15:41:55 +02:00
Hadi Nategh
7eccf7c0c9 W.I.P Smime:
- Migrate smime decryption to Mail_bo
2017-07-19 15:39:28 +02:00
Hadi Nategh
78fa78983c Do not try to fetch mime part content if the content is already set 2017-07-14 09:50:19 +02:00
Stefan Werfling
3565f09ab0 Merge remote-tracking branch 'EGroupware/master' 2017-07-13 22:15:40 +02:00
Hadi Nategh
cb784c25af W.I.P. SMIME:
- Fix warning of invalid arguments
- Fix sometimes signed content not returning correct mime part
2017-07-13 15:37:02 +02:00
Stefan Werfling
680c4c43d0 change comment example 2017-07-13 13:59:03 +02:00
Stefan Werfling
834f226465 add example to comment 2017-07-13 13:56:31 +02:00
Stefan Werfling
7f572fdeb5 4loader:
namespace: add else autoload app vendor
2017-07-13 13:35:02 +02:00
Hadi Nategh
c131be8c17 W.I.P. SMIME:
- Allow saveSession to save other values in cache besides mailbox
2017-07-12 18:32:46 +02:00
Ralf Becker
79750d22a5 fix fatal error if sambaadmin is not installed, but was before 2017-07-12 18:29:01 +02:00
Hadi Nategh
06673bcb03 W.I.P. SMIME:
- Remove multipart/signed from SMIME TYPES
2017-07-11 19:03:11 +02:00
Hadi Nategh
afe1459387 Smime W.I.P:
- Fix couple of IDE warnings
2017-07-10 11:12:35 +02:00
Hadi Nategh
eb6fc7a366 Smime W.I.P:
- Return extracted signed content as horde_mime_part object
2017-07-10 11:05:15 +02:00
Ralf Becker
d38cc11f7e do NOT catch exceptions in hooks
maybe we need some parameter to hooks-calls, if all hooks should run, before exception get's re-thrown, as with this commit first exeception in a hook, will stop other hooks from running.
2017-07-08 18:05:15 +02:00
Hadi Nategh
d891035fbe Smime W.I.P:
- Remove initial content-type header
- Do not set flowed if it's multipart/signed
2017-07-07 17:53:02 +02:00
Ralf Becker
0528b72744 * Mail/ActiveDirectory: fix empty identity in mail compose and account not active in AD controled mail-server 2017-07-05 17:55:49 +02:00
nathangray
ef6eb77991 Use static to get token so children can override it 2017-06-30 09:47:21 -06:00
Ralf Becker
0d80fdbcf9 * Univention: forwarding mails to external addresses added in UCS 4.2 2017-06-30 14:44:55 +02:00
Ralf Becker
69456307e4 fix at PHP 7.0 not working migrating vfs from db to filesystem (filemanager/cli.php migrate-db2fs)
migration loops forever, after migrating all files, as it does not detect no more files to migrate
2017-06-21 10:02:29 +02:00
Ralf Becker
4b379776b3 fix at PHP 7.0 not working migrating vfs from db to filesystem (filemanager/cli.php migrate-db2fs)
can not unset variable bind to column, as it looses its bind
2017-06-21 09:42:46 +02:00
Ralf Becker
f7a9c253a9 fix SQL error when migrating vfs from db to filesystem (filemanager/cli.php migrate-db2fs) 2017-06-21 09:04:44 +02:00
Ralf Becker
a8adf9dd54 lower number of rows read per query, to not run out of memory
(eg. pec instance)
2017-06-15 09:32:59 +02:00
Hadi Nategh
1fc4f79850 Revert commit 8340520589 and implement the fix in more sane way 2017-06-14 14:52:31 +02:00
Hadi Nategh
04850b50ba Fix Disposition Notification title does not get correct translation, specifically for words with umlauts 2017-06-14 12:30:34 +02:00
Ralf Becker
f8839a488a * Mail: fix PHP Fatal error under PHP 5.4 2017-06-13 11:02:30 +02:00
nathangray
c05fe756fd Change eGroupWare -> EGroupware for notification sender 2017-06-12 14:13:29 -06:00
Ralf Becker
9a8be2d234 * Mail: display event-invitation, if mail contains just that and not the usualy alternatives 2017-06-12 15:29:20 +02:00
Ralf Becker
e2883e2387 * Mail: display event-invitation if it contains an attachment (eg. agenda) 2017-06-12 14:39:08 +02:00
Hadi Nategh
41caaafec9 Cover more range of long field headers 2017-06-12 11:04:10 +02:00
Hadi Nategh
276671a516 WIP SMIME:
- Override extractSignedContents in order to get content from signed message
2017-06-09 12:12:31 +02:00
Hadi Nategh
11c03702dd Implement sub_app attribute for customfields widget, in order to be able to store sub-app's specific customfields 2017-06-07 17:54:09 +02:00
Hadi Nategh
fcbb31edb0 * Mail: Fix contents of emails with long header fields get disturbed while importing them into mail app 2017-06-07 11:04:19 +02:00
nathangray
19536925b5 Fix umlauts in favorite name would cause problems with group favorites until reload 2017-05-23 10:33:16 -06:00
Hadi Nategh
264d32d233 Fix mail shows empty mailboxes for some specific mail servers 2017-05-19 15:56:48 +02:00
Hadi Nategh
92b5133c5f Missing part from previous commit 2017-05-18 15:15:24 +02:00
Hadi Nategh
83436212b7 * Mail: Fix Disposition Notification confirmation message always come in english regardless of locale settings 2017-05-18 14:50:31 +02:00
nathangray
b685b08f8d Fix custom notifications CKEditor was broken, depending on how you loaded Admin
- also fixed if you login to admin app, then switch to another app and go to site configuration from the app's sidebox menu
2017-05-17 10:12:47 -06:00
Hadi Nategh
a74d3db798 Try to create home directory if it's not exist. Fix file upload to compose dialog fails if user has no run access to filemanager and has no home folder set 2017-05-16 16:51:35 +02:00
Ralf Becker
cac463749e fix PHP Warning: explode() expects parameter 2 to be string, array given on line 375 2017-05-03 18:02:18 +02:00
nathangray
d277c8b6cf Avoid warning about app list being null instead of array if there's no apps
Appears to happen when session expires
2017-04-27 08:10:15 -06:00
Hadi Nategh
a206ec325a * ActiveSync: Fix error body part not set, while trying to forward an email 2017-04-26 17:23:48 +02:00
Hadi Nategh
73e2243b33 Fix email identity with no domain part set 2017-04-24 11:39:02 +02:00
nathangray
75124d097b PHP v5.4 syntax 2017-04-21 15:04:24 -06:00
nathangray
f60461eb9f PHP v5.4 syntax 2017-04-21 12:33:27 -06:00
nathangray
9d1756e5d9 Basic Etemplate testing
Some simple exec / process round-trip tests
2017-04-21 12:17:59 -06:00
Hadi Nategh
524296b757 * Mail: Fix vacation notice can not deal with aliases, which have no domain set 2017-04-21 11:08:39 +02:00
Hadi Nategh
848535874e Set children of readonly tab to disabled to avoid server side validation error 2017-04-20 18:33:52 +02:00
Hadi Nategh
7b810b57f3 Adopt taglist server side accordingly regarding domainOptional attribute 2017-04-19 16:40:20 +02:00
Ralf Becker
a468c57284 allow hooks to send redirects via Exception\Redirect, thought only first redirect will be executed, if there are multiple hooks 2017-04-19 10:43:29 +02:00
nathangray
8d7a9b7284 Move VFS widget file handling from Etemplate/Widget/Customfields to Storage/Customfields, to avoid errors with CalDAV/CardDAV not being able to find Etemplate/Widget/Customfields 2017-04-17 09:48:45 -06:00
nathangray
944718daaa Some more tests of basic Etemplate stuff 2017-04-17 08:30:24 -06:00
nathangray
bcd86f7ae9 Fix bug where some elements would not be returned if a child of a later sibling was the same type 2017-04-17 08:30:24 -06:00
Ralf Becker
caad687406 allow to filter by multiple account_id/uidNumber 2017-04-13 12:54:19 +02:00
Hadi Nategh
df998bab26 W.I.P. smime support:
- Make sure recipients addresses are not in RFC822 format
2017-04-11 17:29:44 +02:00
Hadi Nategh
1a63b5681d W.I.P. smime support:
- Fix stdClass not exist
2017-04-11 15:29:31 +02:00
Hadi Nategh
fff5543d3d W.I.P. smime support:
- Override verify method, in order to extract content
2017-04-11 14:24:22 +02:00
nathangray
d5c24a2c8e Thumbnails (and handling) of uploaded files on new entries that have not yet been saved 2017-04-10 10:39:04 -06:00
nathangray
ee62801ace W.I.P. Some more Etemplate testing stuff 2017-04-10 08:12:17 -06:00
Ralf Becker
e817e59fb8 * LDAP: fix fatal error in minimal install 2017-04-07 18:50:38 +02:00
Ralf Becker
8d5d178869 fix exception stalling new installations 2017-04-06 16:50:37 +02:00
Ralf Becker
fcf50f1bc0 fix last commit by storing db attribute as wakeup order wakes up acl before parent 2017-04-06 13:45:47 +02:00
Ralf Becker
6c97df764c do NOT store Acl data in session, as it can be quite huge 2017-04-06 09:47:52 +02:00
nathangray
6f13a9caa9 Test some core Widget functions 2017-04-05 10:10:08 -06:00
Ralf Becker
c0e1f3ac67 always need to translate app-title, as users might use different languages 2017-04-05 10:18:09 +02:00
Ralf Becker
96413c1096 fix no translations loaded, by keeping just that pref in the session, as it is used before rest of prefs get restored 2017-04-05 10:02:41 +02:00
nathangray
d690c7d9d3 Use a constant for birthday cache time 2017-04-04 12:10:09 -06:00
Ralf Becker
2adeddce8d do NOT store user preferences and apps in session, we restore them from instance cache 2017-04-04 19:13:43 +02:00
nathangray
99595ba1cf Moce calendar birthday stuff into contacts, expire the birthday cache if birthdays change 2017-04-04 10:58:46 -06:00
nathangray
319d217a3e Some test adjustments to make things a little smoother, and prepare for some widget tests 2017-04-04 10:31:30 -06:00
Ralf Becker
dfbd0d2e6f do NOT store actions in session or eT2 request, nor send for mobile devices skiped actions 2017-04-04 16:54:36 +02:00
Hadi Nategh
786ad5b71b Implement a new option for sidebox menu, called sendToBottom, in order to be able to sort a specific item at the bottom of the sidebox menu 2017-04-04 16:51:41 +02:00
Ralf Becker
4f9e14fcc6 never storing rows in Etemplate\Request and by that keeping apps from storing it as state into the session 2017-04-04 15:04:44 +02:00
Ralf Becker
76087e2cb7 * Api: keep session small / quick to load by limiting number of cached link-titles 2017-04-04 09:58:57 +02:00
nathangray
8cfb2c997f Silence error_log, hopefully fix wrong row count 2017-03-23 11:34:35 -06:00
nathangray
d92de5501d Addressbook - limit previous / next event to the previous / next 2 years, instead of all time
Gives slightly faster performace and reduces memory useage.
2017-03-23 09:09:05 -06:00
nathangray
6551a71b41 Addressbook - Fix filtering by addressbook in duplicates view. 2017-03-22 14:23:05 -06:00
nathangray
d5386625d5 Addressbook - Duplicate view - Fix a bug with types, add some debug to help with long queries. 2017-03-17 10:01:23 -06:00
nathangray
c65c081585 Fix searching in duplicate contact list 2017-03-16 11:06:58 -06:00
nathangray
71de64fe8f Break out parsing search into its own function 2017-03-16 10:54:27 -06:00
nathangray
56d9424c1d Fix duplicate contact view to make sense if you have more than 3 matching rows 2017-03-16 10:53:53 -06:00
Hadi Nategh
0f84e305a2 Remove not necessary error_log 2017-03-15 18:00:14 +01:00
Hadi Nategh
2b0fecd8bd Return form including etemplate-data if the output_mode is set to 1 2017-03-15 16:55:24 +01:00
nathangray
23bf37b98e * Addressbook - new view to show duplicate contacts 2017-03-13 12:11:53 -06:00
Ralf Becker
bb5a845600 our error_handler did not allow to supporess just warnings
eg. by using: error_reporting(error_reporting()&~E_WARNING);
2017-03-13 16:41:12 +01:00
Ralf Becker
211e60b45d fix through proxying not matching webserver_url using X-Forwared-Host header 2017-03-10 22:04:15 +01:00
Ralf Becker
78880b5238 missing commit for readonly db stuff 2017-03-09 20:17:50 +01:00
Hadi Nategh
66315db75a WIP SMIME suport:
- Integrate smime encryption inti mailer class
2017-03-09 17:33:46 +01:00
Ralf Becker
6221e69229 fix regexp to only match beginning of string 2017-03-09 16:42:50 +01:00
Ralf Becker
23ac04df8d allow to switch whole database readonly, via setting "db_readonly" => true in header.inc.php 2017-03-09 12:08:00 +01:00
nathangray
78c5f31ff5 * Addressbook - When viewing a user account's calendar or next/previous dates, use the account calendar over the contact calendar 2017-03-08 09:53:52 -07:00
Ralf Becker
1c80a22413 added (commented out) code to enable IMAP log for a single user 2017-03-08 10:33:00 +01:00
nathangray
0f83206907 * All apps - Add special search case for #<int> to only match the ID, not search the whole entry 2017-03-07 12:24:42 -07:00
nathangray
5926c5e7be Allow docm and xlsm merge templates 2017-03-07 12:08:01 -07:00
Hadi Nategh
3209484d31 Cover more events on XSS regexp and avoid confusion between legitimate words with beginning of "on" and on[Events] 2017-03-06 19:12:56 +01:00
Ralf Becker
acfcd24983 fix not updated logout time on new farm 2017-03-01 13:36:42 +01:00
Ralf Becker
832276f969 give quota-limit from SMTP/SQL precedence over (cached) quota from Dovecot 2017-02-28 18:39:55 +01:00
Ralf Becker
c9822e3023 Merge pull request #8 from filkaris/mail_account_bug
If Mail Account has empty password, it's still regarded as imap
2017-02-28 14:04:19 +01:00
A Sigalas
11b2eff8c5 Host always needed, not imap if username & pass missing 2017-02-28 12:55:04 +00:00
A Sigalas
b4e29edaea If Mail Account has empty password, it's still regarded as imap 2017-02-28 12:40:14 +00:00
Ralf Becker
282c0bc90f method to disable a hook for the current request 2017-02-28 13:27:48 +01:00
Ralf Becker
80cb358d88 fix use of old accounts_sql class, only existing if old phpgwapi is installed 2017-02-28 10:14:38 +01:00
Ralf Becker
38b0dd0dd0 fix PHP Deprecated: Non-static method EGroupware\Api\Vfs\Sqlfs\StreamWrapper::url_stat() should not be called statically 2017-02-27 20:39:46 +01:00
Ralf Becker
d6590cbf64 fix PHP Fatal, if debug is enabled 2017-02-27 17:31:08 +01:00
nathangray
6dd3f4838f Keep any notification errors 2017-02-27 08:10:48 -07:00
Hadi Nategh
738a1acd0e Revert Htmlawed option comment back into value 1 2017-02-27 13:33:24 +01:00
Ralf Becker
f55d36cc50 improve waterfall by releasing session 2017-02-25 15:18:21 +01:00
Hadi Nategh
8f24e0dfec * Mail: fix memory exhaustion caused by e-mails with long string set on DATE field 2017-02-23 15:44:23 +01:00
nathangray
4d0419f5b4 Allow <p> tag to enable HTML parsing as well as <br> and <span>, fixes using p for line breaks and no other formatting resulted in unparsed HTML when merging. 2017-02-17 08:56:37 -07:00
Hadi Nategh
eed277fc9e WIP of modern login page:
- Do not break account's recovery link into second line
2017-02-10 16:33:29 +01:00
Hadi Nategh
1d69265b9c WIP of modern login page:
- Fix logo size
- Implement customizable background image
- Set different logo for login
2017-02-10 15:55:30 +01:00
Hadi Nategh
508d0aa920 Try to match placeholder NENVLF with its described example 2017-02-10 10:41:43 +01:00
Hadi Nategh
83a6595d26 Handle NELF placeholder for mimetype text/html 2017-02-09 15:03:09 +01:00
nathangray
bbdd1e77c9 Skip failing false positive for PHP < 7 2017-02-08 12:32:07 -07:00
nathangray
342230ef08 Fix typo in function name 2017-02-08 12:32:07 -07:00
nathangray
d83a929254 Get tests to not fail if DB is missing - we skip the ones that need a DB 2017-02-07 16:02:06 -07:00
nathangray
eeecc2eecd Add PHPUnit tests for security, based on Ralf's previous command line tests 2017-02-07 12:28:35 -07:00
nathangray
888c9028cb Define idx_data outside of the loop, since it's used later
(Thanks Scrutinizer)
2017-02-07 09:42:10 -07:00
nathangray
1338add5fb Add PHPUnit tests for Schema, based on Ralf's previous command line tests 2017-02-07 09:19:30 -07:00
nathangray
16f649322f Add some sanity checks on egw session / GLOBALS before we start testing, makes it easier to figure out where things went wrong. 2017-02-07 09:19:30 -07:00
nathangray
b2ec0e9aa6 Move IncludeMgr tests into their own test class,
originals left there since they look useful.
2017-02-07 09:19:30 -07:00
nathangray
e0c7ddd0cb Make stored usertime protected instead of private 2017-02-06 13:27:30 -07:00
nathangray
4d6ba96115 Move commented-out DateTime tests into their own class 2017-02-06 13:08:05 -07:00
nathangray
502caf4703 Split application specific test stuff and the Egw session stuff 2017-02-06 13:08:05 -07:00
Ralf Becker
2b45b52477 fix warning about static use of Accounts::is_(active|expried) by making it static and throw a WrongParameterException, if is_expired is called with no parameter 2017-02-06 10:38:01 +01:00
Ralf Becker
250cbb5704 * Addressbook: only add groups as distribution lists, if accounts addressbook is not hidden 2017-02-06 09:21:50 +01:00
Hadi Nategh
ce9a36ddf9 WIP of smime sing and encrypt message 2017-02-03 12:33:49 +01:00
nathangray
efe0d62df7 Add method to mock the tracking object to ease reuse 2017-02-02 08:45:58 -07:00
Ralf Becker
ba8b1c403e use cryptographically secure random_int available in PHP 7+ when generating default passwords 2017-02-02 15:45:32 +01:00
Ralf Becker
be32282214 maintain an maintenance_release version in api/setup/setup.inc.php, also move update-checker images to api 2017-02-02 10:38:13 +01:00
Ralf Becker
70c0a26307 * Mail/Admin: fix setting ACL or vaction notice from Admin app, if IMAP auth uses email address from account 2017-01-31 18:01:49 +01:00
nathangray
71ffd661ac Make sure to always call typeOptions() with a string
(to satisfy Scrutenizer)
2017-01-31 08:41:22 -07:00
Ralf Becker
7ce511cfc1 fix json_php_unserialize to return false for not serialized content, as unserialize does and in contray to json_decode which returns null in that case
--> fixes SiteMgr no longer shows html blocks containing unserialized content
2017-01-31 11:16:51 +01:00
Ralf Becker
5bf8630620 allow to additionally use just a name for which content array contains a path to upload pictures 2017-01-31 10:16:16 +01:00
nathangray
4edc398286 Fix a missed change of Stylite -> EGroupware 2017-01-30 09:27:33 -07:00
nathangray
76cc4d6f5c Fix a missed change of Stylite -> EGroupware 2017-01-30 09:18:33 -07:00
Ralf Becker
388bffc48b * All apps: fix random failure in drag-n-drop or pasting images into CKEditor eg. mail compose 2017-01-27 17:38:08 +01:00
Ralf Becker
7f8b81f45b * Admin: fix bulk password reset to pick only passwords having required strength 2017-01-27 14:27:58 +01:00
Hadi Nategh
2d8b8fc5dc WIP of SMIME support: First attempt to decrypt a smime encrypted message 2017-01-26 17:45:07 +01:00
Hadi Nategh
572ae1d77e WIP of SMIME support: Add method to extract certificate's info from pkcs12 2017-01-25 18:04:54 +01:00
Hadi Nategh
efbb02b1b7 WIP of SMIME support: implement smime type storage 2017-01-25 18:03:35 +01:00
Ralf Becker
75a83fa35c allow to store (user specific) s/mime private keys in mail account 2017-01-25 11:40:05 +01:00
Ralf Becker
45114cd2b8 fix PHP fatal on call to Api\Html::progressbar caused by no longer existing static property $netscape4 2017-01-24 10:59:52 +01:00
Hadi Nategh
2b99050d99 W.I.P of SMIME support for mail application:
- Add a method for extracting public-key from a certificate
2017-01-23 16:19:46 +01:00
Ralf Becker
da58ef5769 * Filemanager/PostgreSQL: shared files were not cleaned up after expiring of 100 days not accessed under PostgreSQL 2017-01-23 15:23:11 +01:00
Ralf Becker
f8a3bd8e34 fix typo causing filtering by group-distribution-list to fail 2017-01-23 11:27:44 +01:00
Ralf Becker
bb7fb1abf8 * Addressbook/Mail: allow to use groups as (readonly) distribution lists 2017-01-23 11:17:02 +01:00
nathangray
74c48e0592 Custom fields can be at the start of the content 2017-01-19 10:53:53 -07:00
nathangray
6ed24454f9 Allow expansion of custom fields when merging to include fields from other apps
eg: {{#other_app/#addressbook_cf/n_fn}}
2017-01-19 10:53:53 -07:00
Hadi Nategh
a3562129b0 W.I.P of SMIME support for mail application:
- Resolve smime p7b attachment and translate it to PEM format
- Assign a button to show the message is signed plus handler for showing the certificate
- Fix Smime class to only use php openssl extension
2017-01-19 18:52:44 +01:00
nathangray
845a1ec3e7 Added a checkbox for 'save as infolog' when merging multiple contacts into an email document. 2017-01-19 09:36:38 -07:00
Hadi Nategh
e992b9991d W.I.P of SMIME support for mail application 2017-01-18 19:03:29 +01:00
nathangray
f8be81e17f Clear instance singleton on destruct
Allows for unit testing
2017-01-11 15:46:12 -07:00
nathangray
5e13b8dfda - Some nicer messages when things go wrong
- Reset account backend after test
2017-01-11 15:41:53 -07:00
Hadi Nategh
1eff570926 Consider whitespaces when trying to translate <, >, <= and >= signs in HTML:
- Fix some mails get cut off after switching to plain-text mode
2017-01-09 16:57:30 +01:00
nathangray
775ef84867 Fix namespace 2017-01-06 11:21:38 -07:00
nathangray
b439bb2b5c - Re-initialize Config on each start, since it doesn't happen normally
- Better error message for if login fails
2017-01-06 10:39:16 -07:00
nathangray
f8b57077fb A start on some automatic testing for apps
- use 'phpunit -c doc/phpunit.xml' to run tests
 - extend api/src/test/AppTest.php to write application tests
2017-01-06 10:39:16 -07:00
Hadi Nategh
c7089cadd9 Revert unintentional changes to mrconfig and ContentSecurityPolicy from commitacdf079fb180490d8659fad0f4c20dd74ea78503 2017-01-05 15:04:53 +01:00
Hadi Nategh
acdf079fb1 * Etemplate: Fix error "Etemplate\Api\Auth not found" happening while to login 2017-01-05 14:59:20 +01:00
Ralf Becker
dc84982a55 * CalDAV/CardDAV: send unchange REALM for "bad login or password" to allow storing credentials 2017-01-04 10:18:34 +11:00
Hadi Nategh
2d1bb1ecc3 Another patch to previous commit in order to cover empty space 2016-12-12 10:20:46 +01:00
Hadi Nategh
760bd4106f * Mail: Fix accounts selectbox in compose dialog does not include email addresses. Additionally, let local accounts without '@' get explicitly displayed in accounts selectbox. 2016-12-12 09:35:52 +01:00
Ralf Becker
d4a64babbd fix PHP 5.4 Fatal error: Can't use function return value in write context 2016-12-08 16:22:54 +01:00
Hadi Nategh
23aea3864c Keep allowExternalIMGs preference intact and use an explicit preference for allowed domains 2016-12-02 10:09:56 +01:00
Hadi Nategh
6ed3b92298 Work in progress of mail external image handler:
- Fix styling
- Add handler for mobile and display
2016-11-24 14:35:54 +01:00
Hadi Nategh
5fb70c77ab Work in progress of mail external image handler 2016-11-23 18:52:43 +01:00
Ralf Becker
6d472b1592 use openssl_random_pseudo_bytes, if available, to generate etemplate_exec_id, as it is used for CSRF protection too 2016-11-17 11:09:30 +01:00
nathangray
a15aa412e2 Attempt to fix redirects to invalid /index.php 2016-11-16 09:20:03 -07:00
Ralf Becker
6a31d2462a fix identities from aliases or imap-user without @ shown with empty label, if name is empty 2016-11-14 13:43:05 +01:00
Ralf Becker
b38542439a if webserver_url does not match eg. because of proxying, fix it 2016-11-14 13:43:05 +01:00
Klaus Leithoff
e9155a000b * Mail/Z-Push: handle charset-problem on sending mails with added EGW-Signature 2016-11-10 12:50:51 +00:00
nathangray
8ecc188fd7 Customfields required bugs
- Load attributes from modifications array, were previously ignored
- Remove double required check, actual field widget should handle it
2016-11-07 09:22:33 -07:00
Ralf Becker
c20ee5575d allow to use Api\Contacts::search() without Acl check 2016-11-07 09:26:14 +01:00
Ralf Becker
2d35e890fd remove permantent error_log on restore of egw_cal_dates 2016-11-02 14:28:34 +01:00
Ralf Becker
16689ebc27 fix use of old egw class in favor of new Api\Egw 2016-11-02 09:38:37 +01:00
Ralf Becker
225bc0bbc2 fix searching for "group" reveals groups normally hidden by forced account-selection pref "groupmembers" or "none" 2016-10-31 18:46:59 +01:00
Ralf Becker
8040fa49ec remove Exception type, to not get a Type error when PHP 7+ throws an Error 2016-10-31 18:29:32 +01:00
Ralf Becker
dbae12260b fix setting alias and forwards, allow to add/remove from existing ones 2016-10-31 15:41:52 +01:00
Ralf Becker
74e2c62b48 * Admin/Mail: allow to limit users to only create identities for aliases 2016-10-28 14:27:59 +02:00
Ralf Becker
a23ab6a9fb * Addressbook/LDAP: fix error if egroupware-epl-compat (old API) not installed 2016-10-27 10:51:47 +02:00
nathangray
648b6fd759 If searching for an account and you include 'Group ' (or translation) in the search string, it will search just groups instead of all accounts. 2016-10-24 09:21:57 -06:00
Ralf Becker
e989d079d6 removing server-side validation of non-ascii in local part of email, because \x80-\xff gives and invalid utf-8 compilation error in preg_match with /u modifier 2016-10-20 15:21:40 +02:00
Ralf Becker
ab79e193ec * Mail: show validation error if local part (before @) of email-address contains non-ascii chars 2016-10-20 12:29:56 +02:00
Ralf Becker
ad059b81e7 add missing traversable-test mentioned by Scrutinizer 2016-10-20 10:17:20 +02:00
Ralf Becker
2fbafeaa27 add missing false-test mentioned by Scrutinizer 2016-10-20 09:50:57 +02:00
Ralf Becker
c2d1fe6d50 only check vfs for templates, if /etemplates is mounted 2016-10-19 16:44:04 +02:00
Ralf Becker
ae712ff8a1 * Filemanager: break infinit recursion stalling eg. login by introducing max. sub-directory depth of 100
Detects infinit recursion caused eg. by fs_dir pointing to a child-directory.
No idea how to efficently test for that, without scanning all parents of all filesystme nodes.
2016-10-19 15:52:02 +02:00
Klaus Leithoff
7588c9a493 rework of fix for problem regarding send with bcc when using esync 2016-10-19 10:01:38 +00:00
Klaus Leithoff
c47d8a26c3 * Mail: fix problem regarding send with bcc when using esync 2016-10-18 13:59:32 +00:00
Ralf Becker
a81442373c fix typo 2016-10-13 17:58:27 +02:00
Ralf Becker
30cf772c4d move ADOdb row_lock and rollback_lock methods to Db class, use Db::$tablealiases and use them for backup, also added a "backup_(starts|finished)" hook for apps 2016-10-13 17:54:58 +02:00
Ralf Becker
6e1429d833 change to just "Powered by EGroupware <version>" 2016-10-08 14:46:25 +02:00
Hadi Nategh
c3fb98f3c1 Try to correct ckeditor references point to vendor directory 2016-10-07 12:15:03 +02:00
Ralf Becker
315ceed672 error_log if calendar can not send notifications 2016-10-06 19:09:40 +02:00
Hadi Nategh
57349e6386 Remove spellchecker lang from preferences 2016-10-06 18:30:37 +02:00
nathangray
fa8f53e6d4 Fix VFS ajax uploads did not work if path needed expansion 2016-10-05 16:13:31 -06:00
Hadi Nategh
69ce664000 Fix some of content in mails with specific html formats get removed by HtmLawed's balance 2016-10-05 17:13:07 +02:00
Hadi Nategh
93f3826259 Update HTMLawed into version 1.1.22 2016-10-05 16:18:06 +02:00
Ralf Becker
fc086c56cd fix dbb0796 allow to specify a subdirectory in attach_file as part of $file[name] parameter
(subdir was created, but file was copied to main dir)
2016-10-04 16:47:24 +02:00
Ralf Becker
dbb07961f6 allow to specify a subdirectory in attach_file as part of $file[name] parameter 2016-10-04 10:49:55 +02:00
nathangray
3da08fa7a1 Make sure category data is an array before looking inside it, avoids warning if it is not 2016-10-03 09:58:59 -06:00
Ralf Becker
adaeabe592 fix wrong namespaced Exception: \DateTime throws \Exception 2016-09-28 11:17:19 +02:00
Ralf Becker
76c83eb2a9 allow to specify multiple cat_id's 2016-09-26 14:35:52 +02:00
Ralf Becker
e467b48fea allow to import without acl-check and setting modifier 2016-09-26 11:40:02 +02:00
Ralf Becker
d99a283929 fix old class names in docu 2016-09-26 09:27:52 +02:00
Hadi Nategh
83de4986c8 Fix inline images of compose do not get stored as links into integrated applications like infolog, tracker or calendar 2016-09-21 15:52:50 +02:00
nathangray
c2bd221ae0 Silence debug error log 2016-09-13 08:07:52 -06:00
Ralf Becker
9b09267e0b * Calendar/CalDAV: update or removal of (managed) attachments via CalDAV failed 2016-09-13 15:55:55 +02:00
Ralf Becker
4bf26a6c52 Vfs::rename() is supposted to be static, quitens warning that it is used static 2016-09-13 13:53:05 +02:00
Ralf Becker
e82ce99537 fix SQL error happening in sync-colletion in TB caused by Db->Type == 'mysqli' and Db->group_connect returning false 2016-09-12 23:22:56 +02:00
nathangray
7afd7e420b Better version of optgroup fix to still allow additional data (title, color) in option entries 2016-09-12 10:42:12 -06:00
nathangray
dee0caa875 Fix validation of select values in an optgroup always failed 2016-09-12 08:40:48 -06:00
nathangray
4dcb415f44 Try to fix redirects from AJAX calls to static methods 2016-09-09 10:27:33 -06:00
Hadi Nategh
aff9f0eba8 Fix Ctrl+A in context menu does not get translated 2016-09-09 12:54:52 +02:00
Hadi Nategh
ea30baf1a3 Fix syntax issue caught by Travis which happens only for php versions older than 5.6 2016-09-08 10:10:49 +02:00
Hadi Nategh
cc278e0d17 WIP of letter avatar generator:
- Use hash system to pick always the same color for given user
2016-09-05 12:50:04 +02:00
Ralf Becker
4a25a4a1d3 * App apps: async notifications were not using SMTP only account, but personal one with unavailable session password 2016-09-02 18:12:04 +02:00
Hadi Nategh
c3583dbb3c WIP of letter avatar generator 2016-09-02 17:33:55 +02:00
Ralf Becker
d4ce9fce91 enhance filesystem check to also check fs_id of required nodes /, /home, /apps 2016-08-31 19:03:48 +02:00
Hadi Nategh
d8761441b1 * Mail: Fix pdf attachments do not get downloaded in mobile template 2016-08-31 12:10:26 +02:00
Ralf Becker
4b614c91ed * Filemanager: fix missing symlink overlay on mime-icon 2016-08-29 19:42:49 +02:00
Ralf Becker
4cd0d35ff7 possible fix for deactivated / or /apps 2016-08-29 17:14:48 +02:00
Ralf Becker
ef5b160fdd fix for PHP Warning: Illegal string offset 'to_id' in api/src/Etemplate/Widget/Link.php on line 327 2016-08-29 13:50:13 +02:00
Ralf Becker
026fd08125 Sqlfs::mkdir is no longer static, fixing some left over static calls 2016-08-29 13:42:57 +02:00
Ralf Becker
a6189bf9b9 Sqlfs::mkdir is no longer static, fixing some left over static calls 2016-08-29 12:56:35 +02:00
Ralf Becker
c474df28fb fix Scrutinizer bug: Api\Etemplate\Exception does not exist (missing \Exception) and remove old non-static stuff from Api\Etemplate\Widget::setElementAttribute(), as $this is allways unset for methods declared static 2016-08-28 12:51:19 +02:00
Ralf Becker
54bfaeb988 fix Scrutinizer docu bug: Api\Etemplate\Request\Files::__construct($id) $id is not array but string|null 2016-08-28 12:51:19 +02:00
Ralf Becker
8d2d4ef3dd fix Scrutinizer docu bug: Api\Etemplate\Request\Files::__construct($id) $id is not array but string|null 2016-08-28 12:51:19 +02:00
Ralf Becker
4e15b70373 fix Scrutinizer docu bug: Egw::setup() need to support null for $domain_names parameter 2016-08-28 12:51:19 +02:00
Ralf Becker
4dbd49d285 fix Scrutinizer docu bug: Api\Db has no more support for Halt_On_Error attribute 2016-08-28 12:51:19 +02:00
Ralf Becker
bcec596fff fix Scrutinizer docu bug: get_backend returns Sql|Ldap|Ads|Univention backend 2016-08-28 12:51:19 +02:00
Ralf Becker
056e0f97d2 fix Scrutinizer bug: replace new ldap (wrong namespace) with Api\Ldap::factory() 2016-08-28 12:51:19 +02:00
Ralf Becker
6c6f9eae7a fix Scrutinizer bug: non-existing Api\Api\Db\Exception\InvalidSql and delete_list accepts array of list-ids, while check_list does not 2016-08-28 12:51:19 +02:00
Ralf Becker
52ca45a228 fix Scrutinizer bug: remove non-static usage as it gives a PHP Fatal anyway, since Config::save_value() is declared static 2016-08-28 12:51:19 +02:00
Ralf Becker
9082a799e2 fix Scrutinizer docu bug 2016-08-28 12:51:19 +02:00