Commit Graph

2142 Commits

Author SHA1 Message Date
nathan
6a5d189489 Better fix for Et2SelectState not getting country set 2022-11-14 14:41:08 -07:00
nathan
ed2eb30b32 Fix widgets don't appear disabled when they are 2022-11-14 11:22:56 -07:00
nathan
ae961f208d Fix a few js errors in expose 2022-11-11 12:53:33 -07:00
nathan
e0617394fb Make weekend toggle better responsive to content size preference 2022-11-11 11:32:06 -07:00
nathan
47a48b386f Et2Select: Fix change event got fired too early
Don't need to block the event if we didn't actually change the value.  This fixes changing to common preferences
2022-11-09 15:34:28 -07:00
nathan
32bd2a1084 SearchMixin: Make sure dropdown doesn't cover bottom border 2022-11-09 09:30:53 -07:00
nathan
4dffd24feb Et2Select: Fix change event got fired too early
Second attempt.  If fix_bad_value() made a change, that was triggering change event before Et2App.et2_ready() had been called.  Now making sure that event does not get fired.
2022-11-08 11:04:03 -07:00
ralf
8b0e5867cb fix JS error on displaying validation message, probably when tab is not yet loaded 2022-11-08 12:51:41 +01:00
nathan
104680c477 Fix hidden nm with no initial rows were requesting data too early 2022-11-07 14:51:42 -07:00
nathan
be16565cc4 Filemanager can now update sub-grids 2022-11-07 11:51:30 -07:00
nathan
78333613fa Et2Select: Fix change event got fired too early
If fix_bad_value() made a change, that was triggering change event before Et2App.et2_ready() had been called
2022-11-07 09:57:00 -07:00
nathan
d35eacb8a2 Fix gap between label & control, better solution for date-duration 2022-11-04 09:41:45 -06:00
nathan
ee52509fca Et2Checkbox: Change vertical align, it wasn't lining up nicely in calendar edit 2022-11-04 08:42:57 -06:00
nathan
74f7f4dcb5 Et2SelectReadonly: Allow additional supplied options, but fix bug where they overwrote account options 2022-11-02 14:03:12 -06:00
nathan
87aba966c2 Et2LinkString: Fix links not shown immediately after 'Apply', only after reload 2022-11-02 11:59:10 -06:00
nathan
127ccdedbb Et2Dialog: Fix incorrect button adoption search 2022-11-02 08:36:44 -06:00
ralf
0ec8636a7b do NOT submit dialog, if it has no etemplate_exec_id, it only gives and error on server-side 2022-11-02 13:51:17 +01:00
Hadi Nategh
179e12ac68 Make sure value_id is there before using it (caused a side effect on calendar entry can not be saved anymore) 2022-11-02 12:27:49 +01:00
nathan
953166b161 Fix problems with links from mail
- unsaved links were not properly displayed
- unsaved links could not be removed
- calendar preserved original links, so even if you removed one it came back
2022-11-01 15:38:58 -06:00
nathan
6764ef979b Et2Date: Use regular inputs for mobile 2022-11-01 10:34:52 -06:00
nathan
12926c89e3 Et2DateDuration: Force label not to wrap 2022-10-31 13:58:26 -06:00
nathan
e5a88c35f5 Fix date duration label always showed above the input, never to the left 2022-10-28 11:48:42 -06:00
nathan
2659a8ab63 Filemanager: Add copy to clipboard button to share link dialog 2022-10-28 10:05:03 -06:00
nathan
f6883c33fd Add gap inside link widgets between each component 2022-10-25 11:38:48 -06:00
nathan
727db2aab5 Fix context menu actions that use nm_action gave "Uncaught nm_action is not a function!" 2022-10-24 10:20:56 -06:00
Hadi Nategh
d1841f9985 Fix hideonreadonly sometimes not being applied (eg. hbox) 2022-10-21 13:29:16 +02:00
Hadi Nategh
1ecc7b729a make sure mouse up is handled when the mouse position has crossed the min/max points 2022-10-21 12:00:08 +02:00
nathan
19bbea7aca Et2Date: Add up/down buttons on hover to adjust value without opening popup
Buttons adjust by day or minuteIncrement.  Minute values are now always rounded to multiples of minuteIncrement, unless freeMinuteEntries=true (or minuteIncrement=1)
2022-10-20 15:27:24 -06:00
nathan
1aa87138a2 Addressbook: Correct fix for CRM breaking contact list actions
etemplate2.clear() was not removing getting the correct app instance removed
2022-10-19 10:54:11 -06:00
nathan
48eb9c1968 Fix duplicate option warning from customfield select filter 2022-10-18 16:06:28 -06:00
Hadi Nategh
d1ff0a8b4f Make support for some old widgets 2022-10-18 17:44:31 +02:00
nathan
5f3570768d Et2Date: Add "Ok" button to close calendar popup 2022-10-18 09:08:53 -06:00
ralf
05b316f7ff move egw_get_file_editor_prefered_mimes() to egw.file_editor_prefered_mimes() as everything in old jsapi.js is deprecated and should be removed
.
2022-10-18 08:30:15 +02:00
nathan
9d2a319821 If widget has onclick attribute, add et2_clickable class 2022-10-17 15:18:13 -06:00
nathan
bd62279f55 Et2Select: Cancel search timer on blur and menu close
If we don't, results might come back after we leave/close and re-open
2022-10-17 09:56:58 -06:00
Hadi Nategh
68acd6d370 Prompt user a message while resizing splitter regarding iframes 2022-10-17 14:06:12 +02:00
nathan
0004aa5bb4 SearchMixin: Avoid errors if searchInputNode is not created 2022-10-14 15:12:08 -06:00
nathan
9ea00bb95f Give webComponents inside nextmatch a chance to finish before we calculate sizes 2022-10-14 14:50:57 -06:00
nathan
c52ac8fbdc Et2DateTime: Limit minutes to multiples of 5 2022-10-14 11:18:17 -06:00
nathan
dcc6d1eb83 Et2Date: change "Today" button label to "Now" for widgets with time (Et2DateTime, Et2Timeonly, etc.) 2022-10-14 10:05:59 -06:00
nathan
2cb826e268 Et2Date: changes directly in the input field will now update popup & the value when blurred 2022-10-14 09:32:59 -06:00
nathan
f9ee8952ea Fix some display bugs in expose on chrome
Sometimes the picture didn't get shown right away
2022-10-13 14:23:11 -06:00
nathan
ab07b3dee3 Et2LinkEntry: Fix value of null caused error 2022-10-13 10:37:29 -06:00
nathan
69ce014aa6 Et2Select: Vertically center multiple tags 2022-10-13 09:33:04 -06:00
nathan
53e868b47b Add default "Search" placeholder to link search 2022-10-13 09:18:49 -06:00
nathan
08e899e91c Fix Et2SelectCategory had category border when multiple
Now only shows category border for single select, when there's a value
2022-10-13 08:41:42 -06:00
Hadi Nategh
32741781ba Treat favorites in mobile view 2022-10-13 15:54:40 +02:00
Hadi Nategh
0b96af85ef Fix audio attachments do not get played via expose in mail's attachment list 2022-10-11 14:46:25 +02:00
nathan
690e89157e Et2Listbox: Make rows set the height, not the max 2022-10-07 15:33:43 -06:00
nathan
8514792efc Fix changing select options did not properly clear previous options 2022-10-07 15:31:06 -06:00
nathan
01a08447cb Fix selecting an app changed icon in first entry instead of displayed icon 2022-10-07 15:29:52 -06:00
nathan
f130134dd1 Dynheight: Don't consider size of fixed or absolute positioned widgets when collecting bottom nodes 2022-10-07 11:57:43 -06:00
nathan
38d5cd627f Work around Chromium bug that gives huge print jobs with thousands of pages
https://bugs.chromium.org/p/chromium/issues/detail?id=1161709
2022-10-07 09:08:07 -06:00
Hadi Nategh
cedaf4027c Fix navigational buttons no longer work in VfsSelect dialog 2022-10-07 14:48:20 +02:00
nathan
8221d66ce2 Fix nm printing did not properly wait for column selection or rows before trying to print 2022-10-06 15:39:35 -06:00
ralf
196024a454 stopping buttons in dialog from submitting it to server-side 2022-10-06 13:55:24 +02:00
ralf
c5b8261ec2 do NOT split RFC822 addresses containing comma in quoted name part eg. 'Becker, Ralf <rb@egroupware.org>' 2022-10-06 13:14:34 +02:00
nathan
0a745299ce Get flatpickr popup working along with LionDialog 2022-10-05 16:22:32 -06:00
nathan
3ce5aebe12 Collabora: Get insert placeholder dialog working again 2022-10-05 10:50:54 -06:00
ralf
ed05a8b6ee always need to stop button click events as otherwise the result would be submitted to server-side eT2 handler 2022-10-05 09:53:45 +02:00
nathan
f8e56edc20 Limit number of accounts (& other select/taglist search results) sent to client 2022-10-04 15:49:07 -06:00
nathan
7bb4332961 Et2SelectCategory: Fix loading with initial value did not get category color or icon in the displayed label 2022-10-04 09:17:31 -06:00
ralf
96e2b495e1 pass placeholder attribute to et2-textbox 2022-10-04 13:46:15 +02:00
nathan
b5a2778168 Fix category did not display value on first load 2022-10-03 09:12:00 -06:00
ralf
918c0324d1 remove redundant if clause 2022-09-29 15:07:10 +02:00
nathan
ba8c5101ac Et2Image: Fix data URLs did not work 2022-09-28 13:36:56 -06:00
nathan
12f8b2cb3e Et2SelectEmail: Add some documentation 2022-09-28 11:14:02 -06:00
nathan
ffd6c21ed4 Et2Select: Avoid errors if freeEntry has single quote 2022-09-27 13:55:32 -06:00
Hadi Nategh
ecd3edfd7f Set right size for dropdown button in mobile view 2022-09-27 11:44:22 +02:00
nathan
181546cdb5 Fix customfield selects so if rows > 1, we set multiple=true 2022-09-26 11:38:36 -06:00
nathan
9644e4b1df Avoid double-parsing nm row if for some reason grid has too many rows.
Should fix missing initial data, but I'm still not sure exactly why row grid can have too many rows.
2022-09-26 10:55:32 -06:00
nathan
086d92e957 Et2Select: All selectboxes now stop scroll event from bubbling to prevent parent (sidemenu) from scrolling too 2022-09-23 10:54:02 -06:00
nathan
171c9c02cb Pressing escape while in search now closes dropdown 2022-09-23 10:40:16 -06:00
nathan
074a03f2ec Include bad email address in validator message 2022-09-23 10:08:31 -06:00
nathan
d133683272 Don't apply et2_required class to parent table cell 2022-09-23 08:51:57 -06:00
nathan
91bd7d5a43 Et2Button: Fix disabled was still hiding the event even if hideonreadonly was false 2022-09-22 15:20:21 -06:00
nathan
bea34ad403 Fix adding a freeEntry did not trigger change event 2022-09-22 15:18:34 -06:00
nathan
4454f350b2 Fix some more validation bugs
- Fix error if widget did not have a feedback slot or a '#help-text' element
- Fix copy/paste error scrolling to wrong widget
2022-09-22 11:43:29 -06:00
nathan
5a8f7c3c70 More fixing of missing search options / tags
Fixes new free entries don't show up after removing a free entry
2022-09-22 11:15:25 -06:00
nathan
0424836ba8 If widget fails validation during submit check, scroll it into view 2022-09-22 09:20:50 -06:00
nathan
8da8c14a00 Et2SelectEmail: Change multiple default to false to match other selects 2022-09-22 08:59:31 -06:00
nathan
2952df2799 Et2Select + SearchMixin: Fix some bugs with display and selecting entries
- Fix clicking on text while editing triggered re-display
- Avoid unneeded node re-creation when editing free entry, handle empty value as removal
multiple=true:
- Fix clearing search removed previously selected remote results
- Fix adding a free entry did not move search down, covering the new value
multiple=false:
- Fix search & edit inputs were shown at the same time
- Fix edit free entry always took over making it impossible to search
2022-09-21 17:13:29 -06:00
nathan
e6ce33b153 Fix invalid fields were not blocking submit 2022-09-21 09:56:15 -06:00
nathan
d9cc794836 Don't bother to validate empty fields if they're not required
Fixes Et2SelectEmail complaining that empty strings are not valid email addresses
2022-09-21 09:05:51 -06:00
Hadi Nategh
ca0b17de7f Fix edit/delete buttons are not clickable on editable avatar 2022-09-21 11:15:14 +02:00
nathan
e03fea2e9b Et2Date: Fix required validation message was always shown after changing a required date
Some missed changes after moving from Lion
2022-09-20 10:44:28 -06:00
nathan
7dd0165cd2 Et2Select + search: Fix position adjustment did not work in all cases
Subsequent searches did not give space for searchbox
2022-09-20 10:07:36 -06:00
nathan
66368c6d3a Et2Select + search: Adjust dropdown position based on if it opens up or down 2022-09-20 09:43:25 -06:00
nathan
79b6cef5fd Switch egw.user(..., async=true) to always return a Promise for consistency
Switch Et2ButtonTimestamper to use egw.user(...,async=true)
2022-09-20 08:05:59 -06:00
Hadi Nategh
34d9297fc1 Do not set toolbar buttons to readonly 2022-09-20 14:44:16 +02:00
nathan
f43b641127 Implement readonly textarea as description 2022-09-19 13:28:20 -06:00
nathan
606e2688d4 Et2SelectEmail: Do not create image in tag, Et2EmailTag uses CSS for image
Fixes doubled image
2022-09-19 09:23:23 -06:00
nathan
1deeee207f Better way to show "no suggestions" indicator, works with local options now too 2022-09-16 11:17:06 -06:00
nathan
30c3000e87 Et2Select fixes
- Search with no results blocked any futher searches from displaying results
- Only show "no suggestions" after searching
2022-09-16 10:20:47 -06:00
nathan
9a036b1dfe Et2Select: Fix "required" styling did not show in a better way
Previous method (38e8df2) made widget entirely transparent
2022-09-15 15:26:06 -06:00
nathan
38e8df223d Et2Select: Fix "required" styling did not show 2022-09-15 12:36:31 -06:00
nathan
3616fe9df0 Add "hasValue" class for input widgets that have a value, and use that class to hide required styling when the widget has a value 2022-09-15 12:28:49 -06:00
nathan
c8b6a5760b Et2Select: Re-add accidentally removed chunk that sets initial value when initial value is an array
Fixes mail preview didn't show to/from addresses
2022-09-15 08:49:36 -06:00
nathan
1b72eb4a00 Revert "Revert "Et2Search: Fix some UI bugs" as it no longer renders values and therefore easily destroys existing content"
This reverts commit 0287e06df2.
2022-09-15 08:30:50 -06:00
ralf
0287e06df2 Revert "Et2Search: Fix some UI bugs" as it no longer renders values and therefore easily destroys existing content
This reverts commit 56eb4d64ac.
2022-09-15 12:56:12 +02:00
nathan
56eb4d64ac Et2Search: Fix some UI bugs
- Fix missing loading spinner while searching
Clear button was in the way, now hiding clear button when displaying the spinner

- Fix searching for the same thing twice displays no results the second time
repeat() and map() directives were not putting the DOM nodes back in, worked around by using a temp div to render into.  There were some lifecycle mistakes as well leading to collisions & re-doing.
2022-09-14 15:47:36 -06:00
Hadi Nategh
3d7df8e566 WIP Universal Access preference:
- Implements textsize preference
2022-09-14 12:41:09 +02:00
nathan
cfbb74b83e Fix some Et2DateDuration bugs
- Duration did not validate correctly
- Validation errors were not actually shown
- Empty duration ('') did not work consistently
2022-09-13 13:00:25 -06:00
nathan
9096c17348 Et2Select: Tabbing out of search field now closes the dropdown 2022-09-13 09:06:59 -06:00
Hadi Nategh
44e2938d05 Fix avatar cropper gets closed right after uploading an image 2022-09-13 12:09:55 +02:00
ralf
d8d8429622 an other fix for 4c00b812ee fixing error when trying to reply 2022-09-13 10:17:59 +02:00
ralf
c00c6f9e07 readonly et2-select-mail caused error with 4c00b812ee eg. in mail.display 2022-09-13 09:15:55 +02:00
nathan
662ea62790 Calendar: remove most sidebox date customisations
Now using regular calendar header.  "Go" button and custom header styles removed. Changing the date in sidebox calendar immediately updates state.
2022-09-12 15:35:24 -06:00
nathan
4c00b812ee Fix edit inputbox covered new freeEntries 2022-09-12 12:48:21 -06:00
nathan
0ea32818c8 Fix Et2NumberReadonly didn't display its value in nextmatch row 2022-09-12 11:25:47 -06:00
nathan
43cce1940d Fix selecting search result does not display label
Infolog contact filter still filtered, but did not show label for selected search result.
2022-09-12 10:19:38 -06:00
Hadi Nategh
1489944d49 Fix category border styling 2022-09-12 15:16:04 +02:00
ralf
26824323e5 got mailing lists working again in mail compose using includeLists=true attribute
using "$list_name <$list_id@lists.egroupware.org>" instead of just integer ids for the list, thought et2-select-mail is NOT displaying the mailing-list icon, after a mailing-list is selected
2022-09-12 14:51:13 +02:00
ralf
bf5389b02e * Mail/RichTextEditor: common preference "small paragraph" now changes return key to a line break instead of a paragraph (with margin) 2022-09-12 10:05:01 +02:00
nathan
217ae647e7 Fix historylog created editable versions of some widgets, triggering the dirty save warning 2022-09-09 12:04:23 -06:00
nathan
04feaff1d0 Avoid parse error that breaks load if string is passed as an object property 2022-09-09 08:35:20 -06:00
nathan
9db38979ef Infolog: Move timestamper & encrypt buttons into tabs using slot and parentID
Also, fix parentId was inconsistently applied
2022-09-08 13:14:55 -06:00
nathan
f85de279c6 Fix some property bugs
- Parse values that should have been objects but came as strings
- Decode SearchMixin.searchUrl
2022-09-08 11:17:34 -06:00
Hadi Nategh
79cec31989 Fix label of button overlaps outside its container if it gets squeezed enough 2022-09-08 12:47:11 +02:00
ralf
7b54b0f563 set correct return type 2022-09-08 11:30:20 +02:00
nathan
a10938ab2b Fix select account readonly did not properly show names with CSV 2022-09-07 15:12:06 -06:00
nathan
3380b867b8 Fix some overlap styling issues with sub-headers
In particular, call list buttons and most date filters were overlapping the row count
2022-09-07 09:54:09 -06:00
nathan
0fb1f32152 Et2LinkEntry: If the app is changed, clear previous search results and focus the search field 2022-09-07 08:42:04 -06:00
nathan
151df0f76b Et2Select + search fixes
- Fix multiple=false had gap between widget and dropdown
- Add clearSearch() to clear the (remote) search results
2022-09-07 08:40:46 -06:00
nathan
7f94b3ae6c Et2Date: Add "Today" button 2022-09-06 11:32:25 -06:00
nathan
6b4a16357f Et2LinkAppSelect: Fix displayed icon did not change when value changed 2022-09-06 11:11:13 -06:00
nathan
365f29f498 Explicitly translate labels & statustext in nm rows 2022-09-06 09:17:12 -06:00
nathan
cc132a8d72 Revert "getting label / tooltip of images to be translated", fixed another way.
This reverts commit 06ae750b32.
2022-09-06 09:16:25 -06:00
ralf
06ae750b32 getting label / tooltip of images to be translated
not sure why this is necessary, as Et2Widgets lists label and statustext as to translate ...
2022-09-06 10:41:08 +02:00
ralf
1ec9ef63fe fix Uncaught TypeError: Failed to execute 'getComputedStyle'
thought the image no longer changes, when selecting another one :(
2022-09-05 13:59:07 +02:00
Hadi Nategh
978d356eed Set background color for buttons used in dialogs footer 2022-09-05 10:10:11 +02:00
Hadi Nategh
ed87a8039a Implement Spinner widget 2022-09-02 13:50:38 +02:00
nathan
daf63d9c23 Et2Select: If multiple and no value, overlap the search onto the widget 2022-09-01 11:53:19 -06:00
nathan
24daafb9ef Et2Select: If somebody set '' as an option value then '' is not a bad value and doesn't need to be fixed. 2022-09-01 09:58:08 -06:00
nathan
1bbcdbfeb7 Fix Et2SelectAccount couldn't have non-account options, so freeEntries didn't show up 2022-09-01 08:30:43 -06:00
nathan
2e319319d1 Fix general free entries did not validate with 0 validators 2022-09-01 08:29:46 -06:00
nathan
a3d2674757 Et2Select + search: Fix some bugs
- Select a searched value didn't validate due to different attribute name
- et2-searchbox inside et2-select threw an additional change event, needed to catch that
- fix_bad_value() needs different handling when you can search, otherwise it just gets cleared again
2022-08-31 13:28:20 -06:00
Hadi Nategh
2507fc99bd Fix broken attached label in description 2022-08-31 13:01:06 +02:00
Hadi Nategh
8555fa2f8f Fix description & label not being aligned in middle (happens for labels not wrapped in table) 2022-08-31 12:27:52 +02:00
Hadi Nategh
38d7604115 Prevent execution error 2022-08-31 12:24:49 +02:00
nathan
6458511d75 Et2Select: Fix some missing "emptyLabel" bugs
- If there were no select_options, and an invalid value, empty label was not shown (Infolog pricelist)
- Select Number had numeric values for options which did not match string values (Infolog completed)
2022-08-30 14:27:19 -06:00
nathan
446b51d74a Customfields: Explicitly use description widget for readonly text fields 2022-08-30 13:28:15 -06:00
Hadi Nategh
e1a87caf6c WIP of better UI 2022-08-30 07:50:43 +02:00
nathan
aee54e5f45 Fix text customfield with rows set did not result in multi-line textarea 2022-08-29 09:21:49 -06:00
Hadi Nategh
31e83ddf05 Stop tags being drawn to the max width 2022-08-29 16:47:58 +02:00
nathan
1b0c2a95a2 Fix nextmatch search 2022-08-29 08:44:09 -06:00
nathan
12ef8163b4 Fix double nextmatch refresh if you search, press [Enter], then take focus out of the search 2022-08-26 13:23:36 -06:00
nathan
234b2c78b9 Et2SelectCountry: Fix limited size of search box
There was a conflict between flag style & search styles.  Now using a specific element for the current value flag instead of styling the whole slot.
2022-08-26 11:48:02 -06:00
nathan
23977d6c21 Fix "select all" long task threw an error and didn't complete
Progressbar was not found because the load event was never fired from the dialog.
2022-08-26 09:28:33 -06:00
nathan
b136958425 Et2Select: (multiple=false) When searching and user selects a value, abort search and show all non-matching entries again 2022-08-25 15:51:15 -06:00