Commit Graph

2069 Commits

Author SHA1 Message Date
nathan
074a03f2ec Include bad email address in validator message 2022-09-23 10:08:31 -06:00
nathan
d133683272 Don't apply et2_required class to parent table cell 2022-09-23 08:51:57 -06:00
nathan
91bd7d5a43 Et2Button: Fix disabled was still hiding the event even if hideonreadonly was false 2022-09-22 15:20:21 -06:00
nathan
bea34ad403 Fix adding a freeEntry did not trigger change event 2022-09-22 15:18:34 -06:00
nathan
4454f350b2 Fix some more validation bugs
- Fix error if widget did not have a feedback slot or a '#help-text' element
- Fix copy/paste error scrolling to wrong widget
2022-09-22 11:43:29 -06:00
nathan
5a8f7c3c70 More fixing of missing search options / tags
Fixes new free entries don't show up after removing a free entry
2022-09-22 11:15:25 -06:00
nathan
0424836ba8 If widget fails validation during submit check, scroll it into view 2022-09-22 09:20:50 -06:00
nathan
8da8c14a00 Et2SelectEmail: Change multiple default to false to match other selects 2022-09-22 08:59:31 -06:00
nathan
2952df2799 Et2Select + SearchMixin: Fix some bugs with display and selecting entries
- Fix clicking on text while editing triggered re-display
- Avoid unneeded node re-creation when editing free entry, handle empty value as removal
multiple=true:
- Fix clearing search removed previously selected remote results
- Fix adding a free entry did not move search down, covering the new value
multiple=false:
- Fix search & edit inputs were shown at the same time
- Fix edit free entry always took over making it impossible to search
2022-09-21 17:13:29 -06:00
nathan
e6ce33b153 Fix invalid fields were not blocking submit 2022-09-21 09:56:15 -06:00
nathan
d9cc794836 Don't bother to validate empty fields if they're not required
Fixes Et2SelectEmail complaining that empty strings are not valid email addresses
2022-09-21 09:05:51 -06:00
Hadi Nategh
ca0b17de7f Fix edit/delete buttons are not clickable on editable avatar 2022-09-21 11:15:14 +02:00
nathan
e03fea2e9b Et2Date: Fix required validation message was always shown after changing a required date
Some missed changes after moving from Lion
2022-09-20 10:44:28 -06:00
nathan
7dd0165cd2 Et2Select + search: Fix position adjustment did not work in all cases
Subsequent searches did not give space for searchbox
2022-09-20 10:07:36 -06:00
nathan
66368c6d3a Et2Select + search: Adjust dropdown position based on if it opens up or down 2022-09-20 09:43:25 -06:00
nathan
79b6cef5fd Switch egw.user(..., async=true) to always return a Promise for consistency
Switch Et2ButtonTimestamper to use egw.user(...,async=true)
2022-09-20 08:05:59 -06:00
Hadi Nategh
34d9297fc1 Do not set toolbar buttons to readonly 2022-09-20 14:44:16 +02:00
nathan
f43b641127 Implement readonly textarea as description 2022-09-19 13:28:20 -06:00
nathan
606e2688d4 Et2SelectEmail: Do not create image in tag, Et2EmailTag uses CSS for image
Fixes doubled image
2022-09-19 09:23:23 -06:00
nathan
1deeee207f Better way to show "no suggestions" indicator, works with local options now too 2022-09-16 11:17:06 -06:00
nathan
30c3000e87 Et2Select fixes
- Search with no results blocked any futher searches from displaying results
- Only show "no suggestions" after searching
2022-09-16 10:20:47 -06:00
nathan
9a036b1dfe Et2Select: Fix "required" styling did not show in a better way
Previous method (38e8df2) made widget entirely transparent
2022-09-15 15:26:06 -06:00
nathan
38e8df223d Et2Select: Fix "required" styling did not show 2022-09-15 12:36:31 -06:00
nathan
3616fe9df0 Add "hasValue" class for input widgets that have a value, and use that class to hide required styling when the widget has a value 2022-09-15 12:28:49 -06:00
nathan
c8b6a5760b Et2Select: Re-add accidentally removed chunk that sets initial value when initial value is an array
Fixes mail preview didn't show to/from addresses
2022-09-15 08:49:36 -06:00
nathan
1b72eb4a00 Revert "Revert "Et2Search: Fix some UI bugs" as it no longer renders values and therefore easily destroys existing content"
This reverts commit 0287e06df2.
2022-09-15 08:30:50 -06:00
ralf
0287e06df2 Revert "Et2Search: Fix some UI bugs" as it no longer renders values and therefore easily destroys existing content
This reverts commit 56eb4d64ac.
2022-09-15 12:56:12 +02:00
nathan
56eb4d64ac Et2Search: Fix some UI bugs
- Fix missing loading spinner while searching
Clear button was in the way, now hiding clear button when displaying the spinner

- Fix searching for the same thing twice displays no results the second time
repeat() and map() directives were not putting the DOM nodes back in, worked around by using a temp div to render into.  There were some lifecycle mistakes as well leading to collisions & re-doing.
2022-09-14 15:47:36 -06:00
Hadi Nategh
3d7df8e566 WIP Universal Access preference:
- Implements textsize preference
2022-09-14 12:41:09 +02:00
nathan
cfbb74b83e Fix some Et2DateDuration bugs
- Duration did not validate correctly
- Validation errors were not actually shown
- Empty duration ('') did not work consistently
2022-09-13 13:00:25 -06:00
nathan
9096c17348 Et2Select: Tabbing out of search field now closes the dropdown 2022-09-13 09:06:59 -06:00
Hadi Nategh
44e2938d05 Fix avatar cropper gets closed right after uploading an image 2022-09-13 12:09:55 +02:00
ralf
d8d8429622 an other fix for 4c00b812ee fixing error when trying to reply 2022-09-13 10:17:59 +02:00
ralf
c00c6f9e07 readonly et2-select-mail caused error with 4c00b812ee eg. in mail.display 2022-09-13 09:15:55 +02:00
nathan
662ea62790 Calendar: remove most sidebox date customisations
Now using regular calendar header.  "Go" button and custom header styles removed. Changing the date in sidebox calendar immediately updates state.
2022-09-12 15:35:24 -06:00
nathan
4c00b812ee Fix edit inputbox covered new freeEntries 2022-09-12 12:48:21 -06:00
nathan
0ea32818c8 Fix Et2NumberReadonly didn't display its value in nextmatch row 2022-09-12 11:25:47 -06:00
nathan
43cce1940d Fix selecting search result does not display label
Infolog contact filter still filtered, but did not show label for selected search result.
2022-09-12 10:19:38 -06:00
Hadi Nategh
1489944d49 Fix category border styling 2022-09-12 15:16:04 +02:00
ralf
26824323e5 got mailing lists working again in mail compose using includeLists=true attribute
using "$list_name <$list_id@lists.egroupware.org>" instead of just integer ids for the list, thought et2-select-mail is NOT displaying the mailing-list icon, after a mailing-list is selected
2022-09-12 14:51:13 +02:00
ralf
bf5389b02e * Mail/RichTextEditor: common preference "small paragraph" now changes return key to a line break instead of a paragraph (with margin) 2022-09-12 10:05:01 +02:00
nathan
217ae647e7 Fix historylog created editable versions of some widgets, triggering the dirty save warning 2022-09-09 12:04:23 -06:00
nathan
04feaff1d0 Avoid parse error that breaks load if string is passed as an object property 2022-09-09 08:35:20 -06:00
nathan
9db38979ef Infolog: Move timestamper & encrypt buttons into tabs using slot and parentID
Also, fix parentId was inconsistently applied
2022-09-08 13:14:55 -06:00
nathan
f85de279c6 Fix some property bugs
- Parse values that should have been objects but came as strings
- Decode SearchMixin.searchUrl
2022-09-08 11:17:34 -06:00
Hadi Nategh
79cec31989 Fix label of button overlaps outside its container if it gets squeezed enough 2022-09-08 12:47:11 +02:00
ralf
7b54b0f563 set correct return type 2022-09-08 11:30:20 +02:00
nathan
a10938ab2b Fix select account readonly did not properly show names with CSV 2022-09-07 15:12:06 -06:00
nathan
3380b867b8 Fix some overlap styling issues with sub-headers
In particular, call list buttons and most date filters were overlapping the row count
2022-09-07 09:54:09 -06:00
nathan
0fb1f32152 Et2LinkEntry: If the app is changed, clear previous search results and focus the search field 2022-09-07 08:42:04 -06:00
nathan
151df0f76b Et2Select + search fixes
- Fix multiple=false had gap between widget and dropdown
- Add clearSearch() to clear the (remote) search results
2022-09-07 08:40:46 -06:00
nathan
7f94b3ae6c Et2Date: Add "Today" button 2022-09-06 11:32:25 -06:00
nathan
6b4a16357f Et2LinkAppSelect: Fix displayed icon did not change when value changed 2022-09-06 11:11:13 -06:00
nathan
365f29f498 Explicitly translate labels & statustext in nm rows 2022-09-06 09:17:12 -06:00
nathan
cc132a8d72 Revert "getting label / tooltip of images to be translated", fixed another way.
This reverts commit 06ae750b32.
2022-09-06 09:16:25 -06:00
ralf
06ae750b32 getting label / tooltip of images to be translated
not sure why this is necessary, as Et2Widgets lists label and statustext as to translate ...
2022-09-06 10:41:08 +02:00
ralf
1ec9ef63fe fix Uncaught TypeError: Failed to execute 'getComputedStyle'
thought the image no longer changes, when selecting another one :(
2022-09-05 13:59:07 +02:00
Hadi Nategh
978d356eed Set background color for buttons used in dialogs footer 2022-09-05 10:10:11 +02:00
Hadi Nategh
ed87a8039a Implement Spinner widget 2022-09-02 13:50:38 +02:00
nathan
daf63d9c23 Et2Select: If multiple and no value, overlap the search onto the widget 2022-09-01 11:53:19 -06:00
nathan
24daafb9ef Et2Select: If somebody set '' as an option value then '' is not a bad value and doesn't need to be fixed. 2022-09-01 09:58:08 -06:00
nathan
1bbcdbfeb7 Fix Et2SelectAccount couldn't have non-account options, so freeEntries didn't show up 2022-09-01 08:30:43 -06:00
nathan
2e319319d1 Fix general free entries did not validate with 0 validators 2022-09-01 08:29:46 -06:00
nathan
a3d2674757 Et2Select + search: Fix some bugs
- Select a searched value didn't validate due to different attribute name
- et2-searchbox inside et2-select threw an additional change event, needed to catch that
- fix_bad_value() needs different handling when you can search, otherwise it just gets cleared again
2022-08-31 13:28:20 -06:00
Hadi Nategh
2507fc99bd Fix broken attached label in description 2022-08-31 13:01:06 +02:00
Hadi Nategh
8555fa2f8f Fix description & label not being aligned in middle (happens for labels not wrapped in table) 2022-08-31 12:27:52 +02:00
Hadi Nategh
38d7604115 Prevent execution error 2022-08-31 12:24:49 +02:00
nathan
6458511d75 Et2Select: Fix some missing "emptyLabel" bugs
- If there were no select_options, and an invalid value, empty label was not shown (Infolog pricelist)
- Select Number had numeric values for options which did not match string values (Infolog completed)
2022-08-30 14:27:19 -06:00
nathan
446b51d74a Customfields: Explicitly use description widget for readonly text fields 2022-08-30 13:28:15 -06:00
Hadi Nategh
e1a87caf6c WIP of better UI 2022-08-30 07:50:43 +02:00
nathan
aee54e5f45 Fix text customfield with rows set did not result in multi-line textarea 2022-08-29 09:21:49 -06:00
Hadi Nategh
31e83ddf05 Stop tags being drawn to the max width 2022-08-29 16:47:58 +02:00
nathan
1b0c2a95a2 Fix nextmatch search 2022-08-29 08:44:09 -06:00
nathan
12ef8163b4 Fix double nextmatch refresh if you search, press [Enter], then take focus out of the search 2022-08-26 13:23:36 -06:00
nathan
234b2c78b9 Et2SelectCountry: Fix limited size of search box
There was a conflict between flag style & search styles.  Now using a specific element for the current value flag instead of styling the whole slot.
2022-08-26 11:48:02 -06:00
nathan
23977d6c21 Fix "select all" long task threw an error and didn't complete
Progressbar was not found because the load event was never fired from the dialog.
2022-08-26 09:28:33 -06:00
nathan
b136958425 Et2Select: (multiple=false) When searching and user selects a value, abort search and show all non-matching entries again 2022-08-25 15:51:15 -06:00
nathan
4d8bd89952 Et2Widget: Fix widgets could not pull objects from content to use as attributes
et2-vfs-mime for files in kanban is an example
2022-08-25 13:25:45 -06:00
nathan
d25a0b215e Some work on a visual test, not yet working 2022-08-25 10:19:45 -06:00
nathan
33dcbc218f Revert "Calendar: Fix some kanban listen problems"
This reverts commit 59e64cd908.
2022-08-25 10:16:05 -06:00
nathan
59e64cd908 Calendar: Fix some kanban listen problems
- Status filter isn't really applicable
- Priority was missing its options
2022-08-25 10:13:32 -06:00
nathan
fe42b206c5 Make avatars in AvatarGroup always round 2022-08-25 09:17:05 -06:00
Hadi Nategh
cdcf80afb5 Set default shape for avatar to rounded 2022-08-24 11:21:15 +02:00
ralf
dfba1bba9c fix strange (wrong height and styled) textboxes in CF's 2022-08-24 08:47:53 +02:00
nathan
19d4b9a8b6 Make nm filters always the same size (33% each) and show ellipsis when the current value is too long 2022-08-23 11:07:02 -06:00
nathan
81378fe3a5 Calendar: Fix recurring event prompt did not have labels or icons on buttons 2022-08-23 08:54:31 -06:00
Hadi Nategh
e75621fb39 Set default placement for tabs in mobile template 2022-08-23 13:49:20 +02:00
Hadi Nategh
151fc00641 Adopt toolbar widget to use buttonIcon 2022-08-23 12:44:50 +02:00
Hadi Nategh
83dc0a95f8 Don't let button-icons grow/shrink 2022-08-23 12:42:10 +02:00
nathan
018dd11bd2 Icon improvements:
- Put the default resolver back, otherwise default icons can't be found
2022-08-22 14:58:55 -06:00
nathan
0775fd1a4e Icon improvements:
- If Et2ButtonIcon image does not resolve to a egw image, treat it as a Shoelace icon name
- Add egw images as an icon library for Shoelace
eg: <sl-icon library="egw" name="5_day_view"/>
2022-08-22 14:06:23 -06:00
ralf
ffb8354728 move label stuff to Et2Button as Et2ButtonIcon does not need it 2022-08-22 22:00:18 +02:00
nathan
1d5467faab Et2ButtonIcon: Fix icons didn't show
Must use SVGs here
2022-08-22 13:45:06 -06:00
ralf
263f2c867f re-add lost label getter and setter to fix not shown labels in buttons 2022-08-22 20:24:40 +02:00
ralf
b2d9e30b8d fixing widget set readonly="true" in template and $readolys[$id] = false is still readonly
we need to unset readonly attribute, after setting it and before calling transformAttributes, which would set it again
2022-08-22 18:37:11 +02:00
nathan
f0dcc1685d Move our button code into a mixin and extend sl-button to our current et2-button and sl-icon-button to a new et2-button-icon. 2022-08-22 08:44:54 -06:00
ralf
406da0dcec propagate label to et2-button to show it (use label="" to show just the icon) 2022-08-22 14:59:06 +02:00
Hadi Nategh
d3d0216a39 WIP Mobile template: Make all widgets large on mobile template 2022-08-22 13:59:17 +02:00
Hadi Nategh
54cd616b2c WIP Mobile view: get the nm search boxes the right size 2022-08-22 13:33:55 +02:00
nathan
3c6a8c559f Give nm columnselection more width & height 2022-08-19 14:51:32 -06:00
nathan
49e9dc660d Kanban: Adjust styles to better match 21.1
- Changed AvatarGroup to use circle avatars
- Et2Avatar default for shape was overriding what was in attribute
- Fix doubled card contents
- Remove some unneeded classes
2022-08-19 14:33:59 -06:00
nathan
6e30a68121 Get automatic search when more than 20 select_options working for all cases
StaticOptions, change after init previously didn't work
2022-08-19 11:07:16 -06:00
ralf
da2db8ccc0 fix not working contacts in calls list
caused by first set empty value overwriting/removing the this.app, which is no longer available when the real value/id is set
2022-08-19 09:55:08 +02:00
nathan
bfa2477f5b Fix description label did not handle %s
This is the "preferred" way of handling such things with LitElement (in render), over the way Et2Widget has to change the DOM due to extended widgets.
2022-08-18 16:22:39 -06:00
nathan
4318d1c0a5 Put nextmatch column selection into a dialog 2022-08-18 14:47:58 -06:00
Hadi Nategh
c052b2e9af Fix toolbar actions have no tooltip set 2022-08-18 11:10:39 +02:00
nathan
24d9d3ef53 Fix search letter cannot be disabled 2022-08-17 16:26:22 -06:00
nathan
dce4ac78fc - Fix some missing column labels in column selection
- Fix column sorting didn't work
2022-08-17 15:48:29 -06:00
nathan
40bbc53af8 Fix Uncaught TypeError: Cannot read properties of null (reading 'app_obj') when clicking a project title.
onclick for nextmatch rows was not getting re-parsed for each row, so it was trying with the original widget from the template instead of the one from the row.
Also accepting widget as argument into compiled legacy code and using it over original context so we don't need to re-compile for each row.
2022-08-17 13:23:55 -06:00
nathan
6caaba1bca Et2AvatarGroup: Show names on hover 2022-08-17 08:53:24 -06:00
nathan
8747bc2e0c Allow et2-select-email to be focused as first input 2022-08-16 16:49:42 -06:00
nathan
d5d9dd6164 Select + search improvements
- Use et2-search widget with clearable for search
- Add focus(), which opens & focuses search
2022-08-16 16:46:20 -06:00
nathan
0110cdf5f9 Fix error syncing due to missing context 2022-08-16 16:43:18 -06:00
nathan
0ae69429b5 Fix CustomFilterHeader did not work properly
Some transformations were not correctly handled, and events were therefor not bound
2022-08-16 09:29:08 -06:00
nathan
8c7cfc3e69 nm - give the reason when it can't generate column name (no IDs) 2022-08-16 09:22:57 -06:00
nathan
660ba3368d Fix missing description label 2022-08-16 09:20:40 -06:00
Hadi Nategh
4fab7c1aaf Fix select apps drop down not being aligned with other fields in infolog and generally in all apps 2022-08-16 11:38:08 +02:00
ralf
2a7d05a545 fix not camelCase attribute name, sanitize app-names to 16 chars and use "infolog" for CRM-view
still not fully working, as NM controller somehow overwrites it again :(
2022-08-16 10:10:36 +02:00
nathan
ffc4fe36a0 Kanban: Fix display of resources on card by adding Et2AvatarGroup 2022-08-15 15:16:23 -06:00
nathan
95f10b57f3 Et2Image: Check that src from content is valid to avoid overwriting existing src attribute
Happens in Kanban contact, src="email" but email has a value (an email address)
2022-08-15 13:25:08 -06:00
nathan
6095b0e2ae Fix Et2LinkSearch did not always get correct option when it was loaded with a value
SearchMixin was incorrectly allowing it as a free entry, so it wasn't being properly loaded by Et2LinkSearch
2022-08-15 10:38:19 -06:00
nathan
652e84644b Et2Widget: 'attributes' is read-only in webcomponent, so assign it in to avoid errors
This is used by some kanban column stuff
2022-08-15 10:35:12 -06:00
nathan
ddee9a2b59 Et2Select: Move option rendering into its own function, call it for Et2SelectAccount. This fixes missing option/label in some cases
eg: Kanban edit column Add/Remove assigned
2022-08-15 10:31:49 -06:00
ralf
2a8aa8e7ae some fixes for vfsSearchUI 2022-08-15 17:38:56 +02:00
ralf
c0490007ff fix TypeError: _widget.get_value is not a function 2022-08-15 16:48:40 +02:00
Hadi Nategh
a456f509f5 Let the tags styling matches the rest of the framework 2022-08-12 12:46:48 +02:00
ralf
8b45483c68 fix not working "use enddate" in edit or quickadd
also fix not displayed month in header and add translation of month or week-day names
2022-08-12 11:38:15 +02:00
ralf
429886139b change default remoteQuery to send query and options as parameters and additional as GET parameters
to support old taglist style callbacks and the select callbacks
2022-08-11 11:24:07 +02:00
ralf
458519800d removing tiny left padding and big right margin from [+] button in calendar NM header 2022-08-11 11:15:22 +02:00
ralf
75a263a047 automatic enable search for more than 20 options on Birgits request 2022-08-10 13:29:15 +02:00
ralf
a54c100470 fix email selection after changing selects client- and server-side to no longer send id attribute, but value
thought we still accept id, if there is no value
2022-08-10 13:28:48 +02:00
Hadi Nategh
b59b4ff2aa Change default input focused color 2022-08-10 13:15:24 +02:00
ralf
9ddfba4a24 fix no category was selected (because of numeric value) and color was not shown 2022-08-09 17:24:28 +02:00
ralf
259bc4cd71 fix not working click on URL
static method Et2Url.action() can NOT use this.egw(), but global egw
2022-08-09 16:46:57 +02:00
Hadi Nategh
5f67bd720a Fix shoelace inputs outline focused color 2022-08-09 16:46:19 +02:00
Hadi Nategh
1a32718e62 Override some of the shoelace tab's styling 2022-08-09 15:53:29 +02:00
Hadi Nategh
281047e2cc Keep the original outerNode top offset as we need it later for NM height calculations 2022-08-09 15:17:58 +02:00
ralf
ea0cbd0441 account selection currently only need to use server-side search, for pref "Primary group and search"
for all other types the local search is sufficient, as everything is already local!
fix Taglist::ajax_search for accounts to pass the icon to client-side and always set value instead of id
2022-08-09 10:47:57 +02:00
ralf
7c976d7fdd fix et2-checkbox onChange not called 2022-08-08 18:32:43 +02:00
ralf
e7eb9f42e3 fix many errors around et2-select emulating old taglist:
- preprocessor: translate attributes autocomplete_url -> searchUrl, autocomplete_params -> searchOptions, and allow options
- sending search query as URL/GET parameter with default of app: <appname>
- handle searchUrl like allowFreeEntries by adding selected result to select_options via createFreeEntries, as they otherwise get removed by fix_bad_value not finding the value in select_options
- change taglist validation (again) to not validate search values
- still requires changes in application code, as taglist always behaved like multiple=true (returning and expecting an array of values) and did automatically search from client-side for it's initial value(s)
--> maybe more changes are in order to NOT require changing application code
--> fixes editing Sieve rules
2022-08-08 17:28:51 +02:00
ralf
79a395e3e6 fix missing scrollbar in longer then visible dropdown 2022-08-08 14:44:37 +02:00
ralf
7f36de45a4 take symlink indicator from api not old etemplate app
Using LGPL licenses GNOME icon: https://de.wikipedia.org/wiki/Datei:High-contrast-emblem-symbolic-link.svg
2022-08-08 14:12:20 +02:00
Hadi Nategh
301d38796f Still set width for buttons with only icon and remove the extra left padding in this case as we want the button and icon be square 2022-08-08 11:57:02 +02:00
ralf
2017bd8261 remove legacy widgets dropdown_button and favorites 2022-08-07 12:09:02 +02:00
ralf
d9d14f1e2a implement appicon as web-component and remove/replace legacy et2_widget_image with stubs 2022-08-07 11:55:02 +02:00
ralf
29ac5d82a9 remove legacy widgets url-*, colorpicker and tabs 2022-08-07 11:02:54 +02:00
ralf
ba35be1d86 Change Et2Checkbox to behave closer to legacy et2_widget_checkbox and thereby fixing all sorts of errors with it.
Fix vfsSelectUI to be able to select files again with click on the row and only submit selected files.
Also change Et2Widget.iterateOver and legacy et2_widget.interateOver to be called with new web-component classes like Et2Checkbox. Also make Et2Widget matching all widgets by default like et2_widget.
Remove legacy et2_widget_checkbox code.
2022-08-07 10:10:33 +02:00
ralf
239a81e6d9 replace et2_link_add with a stub and no longer include it in etemplate2.ts 2022-08-06 08:38:16 +02:00
ralf
49aba7193d adapt tab-activation on validation error to new tabs and additionally scroll widget into view 2022-08-05 20:33:29 +02:00
nathan
e8a93ab782 Handle initial value sometimes not set after Shoelace version bump 2022-08-05 11:32:59 -06:00