Commit Graph

1835 Commits

Author SHA1 Message Date
Ralf Becker
a599f9390c fix TypeError: Argument 1 passed to EGroupware\Api\Accounts::username() must be of the type int, null given 2021-10-07 16:53:54 +02:00
Ralf Becker
542192ce6e fix PHP 8.0 error Illegal string offset
folder object need to be cast to string (folder name) as objects are not allowed as array keys
2021-10-07 12:37:32 +02:00
Ralf Becker
16d02a856c fix missing icons after previous commit 2021-10-07 11:57:43 +02:00
Ralf Becker
7a93814c25 fix PHP 8.0 error when deleting a Kanban card
- link deletion failed when link_id was "" as in PHP 8.0 "" < 0 --> gave the error
- link to card was never deleted as board_id is not stored in card
2021-10-07 10:44:59 +02:00
Ralf Becker
7c40fc0981 an other chunk of fixed PHP 8.0 Warnings 2021-10-07 10:16:09 +02:00
Ralf Becker
9a15aad67d fix mail account creation under PHP 8.0
PHP 8.0: "new" > 0 === true
PHP<8.0: "new" > 0 === false
2021-10-06 12:32:54 +02:00
Hadi Nategh
ed86f5bfae PHP8: fix error Illegal offset typePHP, happens while moving mail from one account to another 2021-10-06 11:43:43 +02:00
Hadi Nategh
b6319bc18b Fix wrong condition on checking url strlen 2021-10-06 11:35:53 +02:00
Ralf Becker
56f60c691f next big chunk of fixed PHP 8.0 Warnings 2021-10-05 14:21:36 +02:00
Ralf Becker
29d2d7a580 fixing some conditions in the previous commit stalling InfoLog list 2021-10-05 11:35:56 +02:00
Ralf Becker
6ac401ef19 fixing a ton of PHP Warnings slowing us down in PHP 8.0 2021-10-05 11:35:56 +02:00
Ralf Becker
8084758d76 fix PHP 8.0 error: count(): Argument #1 ($value) must be of type Countable|array, string given 2021-10-04 13:05:13 +02:00
Ralf Becker
eebc939ff2 fix PHP 8.0 Warning: Argument #2 of array_merge must be of type array, boolean given 2021-10-04 11:01:53 +02:00
Ralf Becker
712786c927 improve parsing if only a fullName is given to support the following:
- Becker, Ralf --> surname: Becker, personal: Ralf
- Ralf Becker  --> surname: Becker, personal: Ralf
- Becker --> surname: Becker
2021-10-04 10:41:45 +02:00
Ralf Becker
10c35381d5 improving parsing of country data:
- if we got a country-name but no -code, look up the code
- if we got a country-name like "Name (Name2)" try both separate first
- if we have a valid country-code set the -name to be the untranslated one as our UI does
2021-10-04 09:59:16 +02:00
Ralf Becker
b90dcede90 fix parsing with no street data and of custom fields 2021-10-03 18:48:33 +02:00
Ralf Becker
73b8f6d9f6 if no separate name-components given, simply split first word off as n_given and rest as n_family 2021-10-01 18:28:57 +02:00
Ralf Becker
7e26f64e49 add an additional static method Api\Mail\Smtp::mailbox_address()
as PHP 8.0 does not allow to call a non-static method static, even if $this is (conditionally) not used
2021-09-29 10:11:47 +02:00
Ralf Becker
3e035a70a4 implement and document PATCH 2021-09-27 13:30:41 +02:00
Ralf Becker
392b8036f4 REST API allow sending a JSON patch to update or create a new contact (currently only via POST or PUT, not as PATCH!)
allows eg. to create a contact from a simple Wordpress contact-form only supporting POST requests and a flat object, see new example in the documentation
2021-09-27 13:30:41 +02:00
Ralf Becker
547a5aa605 missing @type="NameComponent" and updated examples in docu with @type 2021-09-27 13:30:41 +02:00
Ralf Becker
a463264926 Implemented @type attributes for all top-level objects from JsContact Draft 08 2021-09-27 13:30:41 +02:00
Ralf Becker
322652de95 Contacts REST API:
- implement missing PUT/POST of distribution list / CardGroups
- implement changes from next JsContact draft:
  + string plus extra localizations attribute instead of localizedString object
  + use "<domain>:<name>" for vendor attributes
- add/parse urn:uuid: prefix if UID is a UUID
2021-09-27 13:30:41 +02:00
Ralf Becker
ce5389d0d5 finished REST API for contacts modulo docu and bugs ;)
- JsCardGroup now used for distribution lists
- responses are not in "responses" attribute (no longer in root of object)
- fix sometimes empty / different members between PROPFIND/REPORT/JSON-GET and GET of group (caused by wrongly implemented limit to given AB)
- JSON pretty-print only if requested by Accept: application/pretty+json
- fix invalid JSON for errors (caused by opening {"responses": already sent
2021-09-27 13:30:41 +02:00
Ralf Becker
3bc015a90d got POST, PUT and DELETE request to add, update and delete contacts working
added JSON exception handler with nicer JsCalendar parse errors
2021-09-27 13:30:40 +02:00
Ralf Becker
655f52a876 fix excess separator, if not 2nd street-line 2021-09-27 13:30:40 +02:00
Ralf Becker
18324dfa8e WIP REST Api for contacts 2021-09-27 13:30:40 +02:00
Ralf Becker
38c07d7f69 WIP REST API for contacts using JsContacts draft 2021-09-27 13:30:40 +02:00
Ralf Becker
9babcdf010 fix PHP 8.0 error: implode(): Argument #2 ($array) must be of type ?array, string given 2021-09-24 12:30:20 +02:00
Ralf Becker
e4c82ac1fa * Filemanager/Sharing: create different share-token for different recipients (before recipients where added to the token)
- allows to individually remove the token, otherwise new token for the other recipients need to be redistributed
- sending one email to multiple recipients still creates a single share-token for all the recipients (send multiple mails if that's not desired)
2021-09-20 13:28:52 +02:00
Ralf Becker
bad32959c2 missing files from filemanager mount GUI 2021-09-13 19:44:01 +02:00
Ralf Becker
d596f76d43 * Filemanager: added user-interface to mount WebDAV or SMB shares 2021-09-13 19:43:57 +02:00
Ralf Becker
7d08ac4936 preferring get_rrows over get_rows to fix SQL error in timesheet merge 2021-09-13 18:03:34 +02:00
Ralf Becker
f2f1af58ce allow pushing to multiple users in one request 2021-09-10 14:13:50 +02:00
nathan
93aa346090 * Api: Fix some merge files were opened in browser instead of downloaded 2021-09-03 09:44:21 -06:00
Ralf Becker
95c5fed125 * PostgreSQL/Addressbook/All Apps: fix SQL error in history tab if there are attachments 2021-09-03 09:58:34 +02:00
Ralf Becker
73301e9276 * Addressbook/PostgreSQL: fix SQL error deleting a contact finally 2021-09-01 09:34:43 +02:00
nathan
43eed77879 Vfs: Fix Stylite/Links/StreamWrapper was not respecting backup parameter 2021-08-23 09:04:37 -06:00
Ralf Becker
0463b796ce implement some missing features from old eTemplate:
- evaluate class set on a grid cell as done for the widget contained (probably more a bug-fix then a feature)
- allow to preset query for link-entry widget by passing an object with a query attribute
- allow to overwrite not only $readonlys[__ALL__] but also widget readonly attribute with a $readonlys value of false
2021-08-23 14:28:34 +02:00
Ralf Becker
5bc4dc90e3 need to catch the statement in line 1347 2021-08-18 11:21:12 +02:00
Ralf Becker
226ee1485d * PostgreSQL: fix SQL error when accessing eg. InfoLog
Links class trys to delete empty attachment directories and virtual / empty attachment directories have non-integer (hash) id causing an SQL error in PostgreSQL.
2021-08-18 11:21:12 +02:00
Ralf Becker
c609485fe4 update script to remove hashes/non-email-addresses from egw_history_log.share_email 2021-08-17 18:24:52 +02:00
nathan
b8acaae1c5 * Api: Fix changes in history log had a hash instead of user if the change was made after a share was opened. 2021-08-17 18:24:52 +02:00
Hadi Nategh
16f71b3a0b * Knowledge Base: fix pasting/dragging image into htmlarea editor does not work 2021-08-16 11:53:42 +02:00
Ralf Becker
4152c957fa * Calendar/Addressbook/InfoLog: no longer allow to immediate delete entries as it breaks CalDAV/CardDAV sync
always show deleted filter and set deleted status in calendar
see #29778
2021-08-13 15:57:13 +02:00
Ralf Becker
2d24362f8f remove config allowing to immediately delete contacts (as it's required for sync) 2021-08-13 15:57:13 +02:00
nathan
79c9eb9e9b Api: Add some extra parameters to Merge::merge_entries() so overridding classes can still use the parent method, passing in IDs & merge object 2021-08-11 09:05:40 -06:00
Ralf Becker
d882ff4738 * Setup: support uninstalling automatic installed apps (no more reinstalling next update) 2021-08-03 19:09:37 +02:00
Ralf Becker
e95403eac6 missing file from backport 2021-07-23 07:57:15 +02:00
nathangray
0541089170 Api: Fix missed change in nested document actions
see 186e03671a
2021-07-22 11:58:42 +02:00
nathangray
16278dd064 Fix PHP warnings for PHP 8 compatability 2021-07-22 11:36:24 +02:00
Ralf Becker
45d77b594d keep original REQUEST_URI in ORIG_REQUEST_URI when modifying it 2021-07-22 11:29:11 +02:00
Ralf Becker
10c24c1830 * Filemanager/VFS: when creating a new file as root eg. via (docker exec) filemanager/cli.php do NOT create files unreadable by webserver 2021-07-22 11:26:42 +02:00
Ralf Becker
fdaac697e2 got symlinks working for filesystem streamwrapper and fix one bug in Vfs with symlinks 2021-07-22 11:25:15 +02:00
nathan
f7aef98666 Implement symlink for filesystem StreamWrapper with test
Whether it works or not depends on filesystem though.
2021-07-22 11:25:15 +02:00
nathan
ac41289ecd Fix wrong permission constant used, resulting in permissions when there shouldn't be 2021-07-22 11:19:00 +02:00
Ralf Becker
8a411e7f46 need to call Vfs\StreamWrapper::init_static() after setting Vfs::$user
Vfs::$user should be protected and moved to Vfs\Base plus a getter and setter method added for public access,
as after setting it in 21.1+, Api\Vfs\StreamWrapper::init_static() need to be called to set the default user context!
2021-07-22 09:13:46 +02:00
nathan
7a5804c2e7 Fix symlink directory problem from 2a64e79 and add a unit test to avoid that in the future 2021-07-21 11:29:38 -06:00
nathangray
4606a29408 Api: Fix bug where StreamWrappers that mapped onto other StreamWrappers would be parsed earlier than we want, leading to the first StreamWrapper not getting used. 2021-07-21 11:29:26 -06:00
nathan
e75bef4415 Missed part of b021767ac1, not sure why it didn't come 2021-07-12 16:38:18 -06:00
nathangray
7f63e612dd Make sure nested document actions open in new tab, same as others. 2021-07-12 16:37:20 -06:00
nathangray
a728276a15 Change merge download/Collabora to a common generation method, avoiding need to POST.
This allows Kanban to download merge files
2021-07-12 16:30:01 -06:00
Hadi Nategh
32edce1626 Try to take only quoted_printable to decode and avoid decoding url params as quoted 2021-07-01 17:14:13 +02:00
nathangray
12591f3911 Api: Fix Asyncservice did not have proper filesystem access as the job user 2021-06-24 08:20:26 -06:00
Hadi Nategh
001d5168ee Fix 404 errors caused by none existing html editor icons 2021-06-15 12:12:11 +02:00
Ralf Becker
4ef9b08457 fix class Api\Mail\Config not found 2021-06-15 10:53:31 +02:00
Ralf Becker
5c7925773b * Mail/Dovecot: allow to disable caching of flags in site config to support Dovecot private seen flags on shared folders 2021-06-15 10:24:55 +02:00
nathangray
00e5c1e521 * Api: Prevent invalid customfield names 2021-06-11 10:05:44 -06:00
nathangray
96fd9153d3 Etemplate: Better error message for parse errors in xml strings (not files)
This happens in things like Transformer, where we generate some XML for parsing
2021-06-10 11:36:05 -06:00
nathangray
1334d963d9 * Api: Clear initial load URL after using it, so F5 takes you to the app's normal entry point 2021-06-10 09:08:39 -06:00
Hadi Nategh
134aa92712 Clear xml errors in buffer after using xml in Mail otherwise it may get caught wrongly further in etemplate widget 2021-06-04 14:05:29 +02:00
Ralf Becker
8bb4f56149 implement (increment|decrement)Cache to avoid race-conditions if multiple processes update a value
implemented in memcached and APCu backends, default implementation using get&set in base-class
2021-05-31 20:32:10 +02:00
Ralf Becker
cda95d8188 store some lock-data, so only a single callback calculate data on cache-miss
done to avoid race-conditions where many processes try to fetch and therefore calculate some expensive to calculate data
eg. mass-mailings in our hosting
2021-05-27 08:52:58 +02:00
Ralf Becker
691fb06de5 * Setup: skip files backup on update even if configured
It might takes the server down for hours and updates usually dont affect the files
2021-05-27 08:50:02 +02:00
Ralf Becker
d733cb48e9 report and log enabling push (and other IMAP errors)
don't switch regular reload handling off in that case
2021-05-25 18:26:13 +02:00
Ralf Becker
a117e4cf6a port csv-export from old eTemplate nextmatch to separate Api\Etemplate\Export class to not have to rely on old eTemplate 2021-05-23 09:20:36 +02:00
nathangray
35bc2ffe70 Api: Fix accounts list (Sql) would be empty after refresh if there were less than 50 accounts
- Fix some accounts backend were not returning results indexed by account ID
2021-05-21 09:18:09 -06:00
Hadi Nategh
e919523a51 Merge login Ui changes 2021-05-21 16:46:54 +02:00
Hadi Nategh
3037191ea8 WIP login Ui:
- Re-arrange registration links
- Fix bg colors
- Fix social icons padding
2021-05-21 16:17:49 +02:00
Hadi Nategh
33951a6377 WIP login Ui:
- Get login messages the same style as egw messages
- Arrange logo and social icons
2021-05-21 16:17:00 +02:00
Hadi Nategh
a2d182c11a Add extra icons for login apps content 2021-05-21 16:10:56 +02:00
Ralf Becker
f2d349cf2c fix PHP Warning on login page 2021-05-21 09:52:41 +02:00
nathangray
4b9ec7ec13 Api: Respect do_symlink flag to keep links as links
Fixes troubles with syncing
2021-05-20 13:00:55 -06:00
Ralf Becker
50fcb69225 fix some real typos 2021-05-19 19:30:21 +02:00
Ralf Becker
65405790e3 * AD: fix account-selection type "groupmembers" caused high load on AD
also caching groups now on instance level instead of session
2021-05-19 19:30:21 +02:00
nathangray
ded8cdecf9 Fix symlinks were opened read-only in Collabora 2021-05-19 08:37:51 -06:00
Ralf Becker
e14d2ef332 * ADS/LDAP: improve caching of searching/listing 2021-05-16 20:44:04 +02:00
Ralf Becker
1e2c7de6f7 allow to pass JSON serialized date-array with date&timezone to constructor 2021-05-15 15:57:37 +02:00
Ralf Becker
46e97f8975 fix typo causing number of failed attempts on IP whitelist not to be used 2021-05-11 11:21:21 +02:00
Ralf Becker
a218faf73e * AD/Login: fix login always reports "account is expired", if account-selection "group-members" is set for AD 2021-05-05 15:46:11 +02:00
Hadi Nategh
82ab8d9092 WIP login Ui: add motion into apps list 2021-05-03 17:13:04 +02:00
Hadi Nategh
635ca0a89d WIP login ui:
- Move login.json file into pixelegg
- Include icons into json file
2021-05-03 13:21:01 +02:00
Hadi Nategh
1d843eabcd WIP login Ui:
- Arrange apps in the json file and add more details
- Open app's url in a new window
2021-05-03 12:03:28 +02:00
nathangray
84e03fe334 Addressbook: Fix contact categories were cleared when DAVx5 synced some Android clients 2021-04-30 09:26:00 -06:00
Hadi Nategh
41ab849ecc WIP login Ui
- Implements apps tooltip
2021-04-30 14:58:41 +02:00
Hadi Nategh
faadfbdc23 Fix loading login json file 2021-04-29 18:22:38 +02:00
Hadi Nategh
39eef44217 WIP login page Ui 2021-04-29 15:24:25 +02:00
Hadi Nategh
59dbd27719 Fix mail integration fails for mails with having not encoded ampersands on their html content 2021-04-27 17:41:34 +02:00
Hadi Nategh
a49ac9648e Implement throbber for mobile framework 2021-04-22 16:00:52 +02:00
Ralf Becker
df5cce7a74 * SAML/Shibboleth: fix metadata-URL to container eduPersonUniqueId or a custom OID, if specified 2021-04-20 17:34:20 +02:00
Ralf Becker
8df0ba3d70 fixes required for EPL firewall 2021-04-20 15:51:36 +02:00
nathangray
f89c8cfb03 Add hrules to sidebox menus 2021-04-19 16:02:41 -06:00
nathangray
df8251603f Add missing parameter type 2021-04-19 16:01:17 -06:00
nathangray
35fd51da86 Add table name in when parsing search
Also, some code quality fixes
2021-04-19 14:34:53 -06:00
nathangray
51f9177634 Try harder for nextmatch template name so it can be passed to hooks. If it can't be found in value, look in original attributes. 2021-04-19 10:42:48 -06:00
Hadi Nategh
fb83d97150 Implement loading aware framework animation 2021-04-19 10:17:47 +02:00
Ralf Becker
fb30713cbb fix not working load_via parameter 2021-04-18 21:07:38 +02:00
Ralf Becker
d144d65fe9 fix double encoding of backlash in class-names 2021-04-17 09:45:44 +02:00
nathangray
4f0c7250da Fix error when linking to new entry
"Invalid datetime format: 1366 Incorrect integer value: '#97056a438e3c1ab04fd0f0ae46ad6b13' for column ... fs_dir"
2021-04-15 10:25:18 -06:00
nathangray
d9b29fa82a Fix shares could not find files after fe79fe390f 2021-04-14 10:58:42 -06:00
Hadi Nategh
4af0bec278 * Mail: fix losing inline images after being re-saved as draft or created as new 2021-04-13 13:23:09 +02:00
nathangray
fe79fe390f Avoid caching when the url contains links, avoids problems with eg: /apps/InfoLog/Open/2021 2021-04-12 10:31:35 -06:00
Hadi Nategh
e88c4edea2 Fix php 8 errors 2021-04-08 18:36:46 +02:00
Hadi Nategh
b5540c7288 Fix mail content styles 2021-04-08 11:31:36 +02:00
Ralf Becker
8daf1f43f7 fix PHP error: Call to a member function contentTypeMap() on null 2021-04-08 10:19:15 +02:00
Ralf Becker
dfdb300f5f fix PHP 8 error: array_merge() does not accept unknown named parameters 2021-04-07 21:41:11 +02:00
Ralf Becker
e03b1aeb16 fix PHP 8 error: key() Argument #1 must be of type array, null given 2021-04-07 13:12:32 +02:00
Ralf Becker
673760f59d * Setup/SAML: fix not stored custome OID and added eduPersonUniqueId 2021-04-07 10:07:56 +02:00
Ralf Becker
4045c06896 fix PHP 8 errors 2021-04-06 15:32:21 +02:00
Ralf Becker
c92bfa822f fix PHP 8 Fatal error caused by not parsable URL like "<scheme>://<user>@/path" (missing domain) 2021-04-06 09:19:54 +02:00
nathangray
060710a74a Make sure we can log all throwables, not just exceptions 2021-04-05 10:46:50 -06:00
Ralf Becker
7ae4d44308 fix PHP 8 errors 2021-04-02 19:34:11 +02:00
Ralf Becker
7135243d06 nicer implementation of CreateObject and some small fixes 2021-04-02 10:47:52 +02:00
nathangray
4ab170541e Api: Fix incorrect extended ACL check was done when symlinking 2021-04-01 10:28:06 -06:00
Ralf Becker
fed41622c2 fixing all sorts of PHP 8 errors and PHPStorm errors 2021-03-31 17:50:01 +02:00
Ralf Becker
0efa9ae141 docu update 2021-03-31 17:50:01 +02:00
Ralf Becker
37e5e12c3c PHP 8 fix: adding explicit cast for comparing DB-version to a float major number 2021-03-31 13:31:42 +02:00
Ralf Becker
79040d1524 disable warnings under PHP 8 for now, as the hide fatal errors and log errors in xet files 2021-03-31 11:30:34 +02:00
nathangray
72b00c0422 Fix missing translation 2021-03-30 11:04:19 -06:00
nathangray
d5aacd190d Add 'no_quick_add' link registry setting so apps can opt out of the quick add 2021-03-30 10:12:29 -06:00
Ralf Becker
8f1383b973 replace create_function no longer available in PHP 8 2021-03-29 20:33:07 +02:00
Ralf Becker
868135775c PHP 8 fixes 2021-03-29 16:47:19 +02:00
Ralf Becker
05cd66fa09 set minimum PHP version for 21.1 to 7.3 and recommend to 7.4 (PHP 8.0 is still NOT supported) 2021-03-24 08:04:54 +01:00
nathangray
e3a1d1b338 Fix static var accessed as a constant 2021-03-23 16:23:23 -06:00
Ralf Becker
0faafe8eee fix "Virtual List View error" caused by not set search attribute
also retry without VLV control in that case
2021-03-23 13:55:17 +01:00
Ralf Becker
84845d05b5 Fix PHP 8.0 Fatal error: Unparenthesized a ? b : c ?: d is not supported 2021-03-21 21:46:10 +01:00
Ralf Becker
ab9c089f70 fix PHP 8 Fatal error Array and string offset access syntax with curly braces is no longer supported 2021-03-21 21:13:07 +01:00
Ralf Becker
52e8aff9ae fix PHP 8 Fatal error undefined constant EGW_API_INC 2021-03-21 21:10:37 +01:00
Ralf Becker
3e278b3bd3 fix PHP 8.0 Fatal error: Array and string offset access syntax with curly braces is no longer supported 2021-03-21 18:47:15 +01:00
Ralf Becker
ffc048d472 fix PHP 8.0 Fatal error unknown function get_magic_quotes_gpc 2021-03-21 18:27:09 +01:00
Ralf Becker
dac55616af fix PHP 8.0 Fatal error 2021-03-21 18:25:14 +01:00
Ralf Becker
eb2b3943d7 fix Db errors with PHP 7.4+
caused by private $this->app not stored in session when Db\Depricated was instaciated
also move $GLOBALS[egw]->ADOdb to a static class var to fix session restore order caused $GLOBALS[egw] not yet restored giving a warning
2021-03-21 17:39:34 +01:00
Ralf Becker
b79971a1e9 set columns to search for phoneSearch for non-SQL backends too 2021-03-21 12:56:59 +01:00
Ralf Becker
fc50aa6312 phonesearch: LDAP or AD backend only search for local part hopefully stored without any formatting 2021-03-21 10:39:26 +01:00
nathangray
ce17d087c1 Fix hidden upload share link would not work for logged in user that was not share owner 2021-03-17 11:34:09 -06:00
nathangray
c21af32c1b Fix hidden upload share link would not work for logged in user 2021-03-17 11:17:06 -06:00
nathangray
47d2f433d6 Fix missed fstab mount kept unmounted shares around 2021-03-16 11:38:44 -06:00
Ralf Becker
06907d040b fix hidden upload sharing incl. use of multiple share-links in tabs 2021-03-16 15:03:15 +02:00
Ralf Becker
2aff05757e fix home-directories where created with wrong permissions, as Vfs::$is_root was wrongly evaluated 2021-03-15 11:41:53 +02:00
nathangray
1ffde3b692 Change global sharing variable to be a list of shares in use, indexed by token. This should resolve the issues with multiple shares being accessed in the same session. 2021-03-11 17:00:16 -07:00