Commit Graph

4909 Commits

Author SHA1 Message Date
nathan
6458511d75 Et2Select: Fix some missing "emptyLabel" bugs
- If there were no select_options, and an invalid value, empty label was not shown (Infolog pricelist)
- Select Number had numeric values for options which did not match string values (Infolog completed)
2022-08-30 14:27:19 -06:00
nathan
5cfa26bd7b Fix line break after widget name broke legacy option parser 2022-08-30 13:56:13 -06:00
nathan
446b51d74a Customfields: Explicitly use description widget for readonly text fields 2022-08-30 13:28:15 -06:00
Hadi Nategh
f65020ab93 WIP Ui: Try to give same spacing for dialogHeader and dialogFooter 2022-08-30 11:57:52 +02:00
Hadi Nategh
deabd5ae53 WIP Ui: fix some rows in dialogs getting wrongly aligned in the middle 2022-08-30 09:12:31 +02:00
Hadi Nategh
6b18fa7db9 WIP Ui: adopt to the shoelace font-family and size 2022-08-30 08:54:29 +02:00
Hadi Nategh
e1a87caf6c WIP of better UI 2022-08-30 07:50:43 +02:00
nathan
d521d2aa24 Admin: Fix some errors deleting a group
- use the minified app.js
- export the JS class
- include the PHP command class explicitly so it's always found
- Make sure to send all expected parameters to ajax_delete_group
2022-08-29 14:25:39 -06:00
nathan
aee54e5f45 Fix text customfield with rows set did not result in multi-line textarea 2022-08-29 09:21:49 -06:00
Hadi Nategh
31e83ddf05 Stop tags being drawn to the max width 2022-08-29 16:47:58 +02:00
nathan
1b0c2a95a2 Fix nextmatch search 2022-08-29 08:44:09 -06:00
Hadi Nategh
feb476b8cd Add a placeholder icon when no country is selected in Et2-SelectCountry widget 2022-08-29 15:41:04 +02:00
nathan
12ef8163b4 Fix double nextmatch refresh if you search, press [Enter], then take focus out of the search 2022-08-26 13:23:36 -06:00
nathan
234b2c78b9 Et2SelectCountry: Fix limited size of search box
There was a conflict between flag style & search styles.  Now using a specific element for the current value flag instead of styling the whole slot.
2022-08-26 11:48:02 -06:00
nathan
23977d6c21 Fix "select all" long task threw an error and didn't complete
Progressbar was not found because the load event was never fired from the dialog.
2022-08-26 09:28:33 -06:00
nathan
6d38f22949 Add "Just me" as empty_label in add favorite dialog 2022-08-26 08:34:16 -06:00
Hadi Nategh
e2fbbef09b Fix tree nodes getting wrong bg color on hover 2022-08-26 11:47:18 +02:00
nathan
b136958425 Et2Select: (multiple=false) When searching and user selects a value, abort search and show all non-matching entries again 2022-08-25 15:51:15 -06:00
nathan
4d8bd89952 Et2Widget: Fix widgets could not pull objects from content to use as attributes
et2-vfs-mime for files in kanban is an example
2022-08-25 13:25:45 -06:00
nathan
080dea2378 Fix add favorites
Changed to use a proper template & dialog, now that we have et2-details widget.
2022-08-25 11:47:21 -06:00
nathan
d25a0b215e Some work on a visual test, not yet working 2022-08-25 10:19:45 -06:00
nathan
33dcbc218f Revert "Calendar: Fix some kanban listen problems"
This reverts commit 59e64cd908.
2022-08-25 10:16:05 -06:00
nathan
59e64cd908 Calendar: Fix some kanban listen problems
- Status filter isn't really applicable
- Priority was missing its options
2022-08-25 10:13:32 -06:00
nathan
fe42b206c5 Make avatars in AvatarGroup always round 2022-08-25 09:17:05 -06:00
Hadi Nategh
6be968f852 Add translation for avatar label 2022-08-24 15:03:49 +02:00
Hadi Nategh
cdcf80afb5 Set default shape for avatar to rounded 2022-08-24 11:21:15 +02:00
ralf
dfba1bba9c fix strange (wrong height and styled) textboxes in CF's 2022-08-24 08:47:53 +02:00
nathan
19d4b9a8b6 Make nm filters always the same size (33% each) and show ellipsis when the current value is too long 2022-08-23 11:07:02 -06:00
nathan
81378fe3a5 Calendar: Fix recurring event prompt did not have labels or icons on buttons 2022-08-23 08:54:31 -06:00
ralf
9000b802f6 change width of search in NM to 3/4 = 12em 2022-08-23 15:37:16 +02:00
Hadi Nategh
e75621fb39 Set default placement for tabs in mobile template 2022-08-23 13:49:20 +02:00
ralf
3552fa13e7 only convert buttons without label to et2-button-icon 2022-08-23 12:48:48 +02:00
Hadi Nategh
151fc00641 Adopt toolbar widget to use buttonIcon 2022-08-23 12:44:50 +02:00
Hadi Nategh
83dc0a95f8 Don't let button-icons grow/shrink 2022-08-23 12:42:10 +02:00
ralf
94cec559d6 need to leave the NM header check for et2-button-icon conversation, to not convert [+ Add] in NM header 2022-08-23 11:18:21 +02:00
ralf
ef599cb219 drop all size attributes (except SL size: small, large, medium), as it messes up too much
you can always set a width manually, if you don't want flex to share the width equally between input fields
Also removed automatic conversation of image to name attribute for new et2-button-icon, so our image setter can switch between our own icons and the SL icon library
2022-08-23 11:12:10 +02:00
nathan
c82d727b33 Setting a fixed width stops nm search from resizing with clear button 2022-08-22 15:36:03 -06:00
nathan
018dd11bd2 Icon improvements:
- Put the default resolver back, otherwise default icons can't be found
2022-08-22 14:58:55 -06:00
ralf
7876fbf710 convert buttons without background_image attribute to et2-button-icon with name="<image-spec>" library="egw" 2022-08-22 22:41:34 +02:00
ralf
95f68a4b3d convert buttons without background_image attribute to et2-button-icon with name attribute instead of image 2022-08-22 22:31:24 +02:00
nathan
0775fd1a4e Icon improvements:
- If Et2ButtonIcon image does not resolve to a egw image, treat it as a Shoelace icon name
- Add egw images as an icon library for Shoelace
eg: <sl-icon library="egw" name="5_day_view"/>
2022-08-22 14:06:23 -06:00
ralf
ffb8354728 move label stuff to Et2Button as Et2ButtonIcon does not need it 2022-08-22 22:00:18 +02:00
nathan
1d5467faab Et2ButtonIcon: Fix icons didn't show
Must use SVGs here
2022-08-22 13:45:06 -06:00
ralf
263f2c867f re-add lost label getter and setter to fix not shown labels in buttons 2022-08-22 20:24:40 +02:00
ralf
b2d9e30b8d fixing widget set readonly="true" in template and $readolys[$id] = false is still readonly
we need to unset readonly attribute, after setting it and before calling transformAttributes, which would set it again
2022-08-22 18:37:11 +02:00
nathan
f0dcc1685d Move our button code into a mixin and extend sl-button to our current et2-button and sl-icon-button to a new et2-button-icon. 2022-08-22 08:44:54 -06:00
ralf
406da0dcec propagate label to et2-button to show it (use label="" to show just the icon) 2022-08-22 14:59:06 +02:00
ralf
6c3df5ad8b fix not translated quick add
caused by _callback not waiting for promise
2022-08-22 14:24:35 +02:00
Hadi Nategh
d3d0216a39 WIP Mobile template: Make all widgets large on mobile template 2022-08-22 13:59:17 +02:00
Hadi Nategh
54cd616b2c WIP Mobile view: get the nm search boxes the right size 2022-08-22 13:33:55 +02:00
Hadi Nategh
bcf9d6b937 Do not drop the size attribute if we are setting new shoelace size format 2022-08-22 13:29:17 +02:00
nathan
3c6a8c559f Give nm columnselection more width & height 2022-08-19 14:51:32 -06:00
nathan
49e9dc660d Kanban: Adjust styles to better match 21.1
- Changed AvatarGroup to use circle avatars
- Et2Avatar default for shape was overriding what was in attribute
- Fix doubled card contents
- Remove some unneeded classes
2022-08-19 14:33:59 -06:00
nathan
6e30a68121 Get automatic search when more than 20 select_options working for all cases
StaticOptions, change after init previously didn't work
2022-08-19 11:07:16 -06:00
ralf
da2db8ccc0 fix not working contacts in calls list
caused by first set empty value overwriting/removing the this.app, which is no longer available when the real value/id is set
2022-08-19 09:55:08 +02:00
nathan
bfa2477f5b Fix description label did not handle %s
This is the "preferred" way of handling such things with LitElement (in render), over the way Et2Widget has to change the DOM due to extended widgets.
2022-08-18 16:22:39 -06:00
nathan
4318d1c0a5 Put nextmatch column selection into a dialog 2022-08-18 14:47:58 -06:00
Hadi Nategh
c052b2e9af Fix toolbar actions have no tooltip set 2022-08-18 11:10:39 +02:00
nathan
24d9d3ef53 Fix search letter cannot be disabled 2022-08-17 16:26:22 -06:00
nathan
dce4ac78fc - Fix some missing column labels in column selection
- Fix column sorting didn't work
2022-08-17 15:48:29 -06:00
nathan
40bbc53af8 Fix Uncaught TypeError: Cannot read properties of null (reading 'app_obj') when clicking a project title.
onclick for nextmatch rows was not getting re-parsed for each row, so it was trying with the original widget from the template instead of the one from the row.
Also accepting widget as argument into compiled legacy code and using it over original context so we don't need to re-compile for each row.
2022-08-17 13:23:55 -06:00
nathan
6caaba1bca Et2AvatarGroup: Show names on hover 2022-08-17 08:53:24 -06:00
Hadi Nategh
3dd525d6d9 Fix misaligned toggled button in toolbar 2022-08-17 16:37:50 +02:00
Hadi Nategh
3844363bde Get contextmenu and toolbar icons react on hover like shoelace does 2022-08-17 15:51:57 +02:00
Hadi Nategh
3f461d0074 Get contextmenu and toolbar menulist closer to shoelace menu styling 2022-08-17 15:32:53 +02:00
Hadi Nategh
98aac39047 WIP getting all legacy menus close to new webcomponent styling 2022-08-17 12:35:36 +02:00
nathan
8747bc2e0c Allow et2-select-email to be focused as first input 2022-08-16 16:49:42 -06:00
nathan
d5d9dd6164 Select + search improvements
- Use et2-search widget with clearable for search
- Add focus(), which opens & focuses search
2022-08-16 16:46:20 -06:00
nathan
0110cdf5f9 Fix error syncing due to missing context 2022-08-16 16:43:18 -06:00
nathan
a7fc04631e Add legacy option for link 2022-08-16 09:44:03 -06:00
nathan
0ae69429b5 Fix CustomFilterHeader did not work properly
Some transformations were not correctly handled, and events were therefor not bound
2022-08-16 09:29:08 -06:00
nathan
8c7cfc3e69 nm - give the reason when it can't generate column name (no IDs) 2022-08-16 09:22:57 -06:00
nathan
660ba3368d Fix missing description label 2022-08-16 09:20:40 -06:00
Hadi Nategh
4fab7c1aaf Fix select apps drop down not being aligned with other fields in infolog and generally in all apps 2022-08-16 11:38:08 +02:00
ralf
2a7d05a545 fix not camelCase attribute name, sanitize app-names to 16 chars and use "infolog" for CRM-view
still not fully working, as NM controller somehow overwrites it again :(
2022-08-16 10:10:36 +02:00
nathan
ffc4fe36a0 Kanban: Fix display of resources on card by adding Et2AvatarGroup 2022-08-15 15:16:23 -06:00
nathan
95f10b57f3 Et2Image: Check that src from content is valid to avoid overwriting existing src attribute
Happens in Kanban contact, src="email" but email has a value (an email address)
2022-08-15 13:25:08 -06:00
nathan
d5d6d54902 Avoid error if title widget is not an input widget 2022-08-15 10:40:13 -06:00
nathan
6095b0e2ae Fix Et2LinkSearch did not always get correct option when it was loaded with a value
SearchMixin was incorrectly allowing it as a free entry, so it wasn't being properly loaded by Et2LinkSearch
2022-08-15 10:38:19 -06:00
nathan
652e84644b Et2Widget: 'attributes' is read-only in webcomponent, so assign it in to avoid errors
This is used by some kanban column stuff
2022-08-15 10:35:12 -06:00
nathan
ddee9a2b59 Et2Select: Move option rendering into its own function, call it for Et2SelectAccount. This fixes missing option/label in some cases
eg: Kanban edit column Add/Remove assigned
2022-08-15 10:31:49 -06:00
ralf
2a8aa8e7ae some fixes for vfsSearchUI 2022-08-15 17:38:56 +02:00
ralf
c0490007ff fix TypeError: _widget.get_value is not a function 2022-08-15 16:48:40 +02:00
Hadi Nategh
a456f509f5 Let the tags styling matches the rest of the framework 2022-08-12 12:46:48 +02:00
ralf
8b45483c68 fix not working "use enddate" in edit or quickadd
also fix not displayed month in header and add translation of month or week-day names
2022-08-12 11:38:15 +02:00
Hadi Nategh
c082831ad9 Fix password dialog 2022-08-11 15:43:56 +02:00
ralf
3d97fccb61 only rows > 1 switches on multiple
in some places we have rows="1", which des nothing at all previously, removing it now
fixes errors e.g. in AB where the category filter returned [] (empty array) for "All addressbooks" causing a server-side PHP 8 error (Invalid index)
2022-08-11 14:14:33 +02:00
Hadi Nategh
9b7fe9403b Drop pixelegg template from admin 2022-08-11 13:15:30 +02:00
ralf
429886139b change default remoteQuery to send query and options as parameters and additional as GET parameters
to support old taglist style callbacks and the select callbacks
2022-08-11 11:24:07 +02:00
ralf
458519800d removing tiny left padding and big right margin from [+] button in calendar NM header 2022-08-11 11:15:22 +02:00
ralf
e38d0709b7 fix <description /> causes all sorts of problems (by replacing it separate)
for <select rows="N" also switch on multiple, as old eTemplate2 did
fixes tracker site configuration did not allow to select more than one staff member
2022-08-10 15:44:48 +02:00
ralf
cad42eb6aa fix validation of taglist now send to select, specially using "id" attribute, if there is no "value"
also check modifications of select_options, as done in preferences
fixes not validating mail preferences: toggleOnActions and contactLabel
2022-08-10 14:39:19 +02:00
Hadi Nategh
1dedad6a3e Remove hover background color from vfsPath 2022-08-10 13:47:26 +02:00
ralf
75a263a047 automatic enable search for more than 20 options on Birgits request 2022-08-10 13:29:15 +02:00
ralf
a54c100470 fix email selection after changing selects client- and server-side to no longer send id attribute, but value
thought we still accept id, if there is no value
2022-08-10 13:28:48 +02:00
Hadi Nategh
b59b4ff2aa Change default input focused color 2022-08-10 13:15:24 +02:00
Hadi Nategh
e41af3d7ce Fix filemanager symlink icons and removes background from vfsPath 2022-08-10 13:13:29 +02:00
ralf
9ddfba4a24 fix no category was selected (because of numeric value) and color was not shown 2022-08-09 17:24:28 +02:00
ralf
cb63269598 style former buttons without background-image, which are now just an et2-image with a more fitting height
preprocessor rewriting them adds class imageButton giving the image a height of 20px, like the image in buttons has
2022-08-09 16:54:21 +02:00
ralf
259bc4cd71 fix not working click on URL
static method Et2Url.action() can NOT use this.egw(), but global egw
2022-08-09 16:46:57 +02:00
Hadi Nategh
5f67bd720a Fix shoelace inputs outline focused color 2022-08-09 16:46:19 +02:00
ralf
e438f89371 allow whitespace after last attribute eg. <description value="Something" /> 2022-08-09 16:05:22 +02:00
Hadi Nategh
1a32718e62 Override some of the shoelace tab's styling 2022-08-09 15:53:29 +02:00
ralf
0e2d1cb15d fix broken index templates 2022-08-09 15:37:15 +02:00
Hadi Nategh
281047e2cc Keep the original outerNode top offset as we need it later for NM height calculations 2022-08-09 15:17:58 +02:00
ralf
56f103b21c another change to make preprocessor more tolerant with > in attributes
eg. label="> %s"
fixes Admin >> Applications >> EPL Functions >> CTI
2022-08-09 15:15:17 +02:00
ralf
b9da68dd7f making preprocessor more tolerant with > in attributes
eg. <description value="Use Admin >> Site config"/>
2022-08-09 13:03:14 +02:00
Hadi Nategh
5f2d0d5bdd Fix toolbar menulist not having enough width 2022-08-09 11:00:10 +02:00
ralf
ea0cbd0441 account selection currently only need to use server-side search, for pref "Primary group and search"
for all other types the local search is sufficient, as everything is already local!
fix Taglist::ajax_search for accounts to pass the icon to client-side and always set value instead of id
2022-08-09 10:47:57 +02:00
ralf
7c976d7fdd fix et2-checkbox onChange not called 2022-08-08 18:32:43 +02:00
ralf
e1c8acddc1 fix egw.request() to return simple / non-json-responses, like egw.json() does 2022-08-08 17:28:51 +02:00
ralf
e7eb9f42e3 fix many errors around et2-select emulating old taglist:
- preprocessor: translate attributes autocomplete_url -> searchUrl, autocomplete_params -> searchOptions, and allow options
- sending search query as URL/GET parameter with default of app: <appname>
- handle searchUrl like allowFreeEntries by adding selected result to select_options via createFreeEntries, as they otherwise get removed by fix_bad_value not finding the value in select_options
- change taglist validation (again) to not validate search values
- still requires changes in application code, as taglist always behaved like multiple=true (returning and expecting an array of values) and did automatically search from client-side for it's initial value(s)
--> maybe more changes are in order to NOT require changing application code
--> fixes editing Sieve rules
2022-08-08 17:28:51 +02:00
Hadi Nategh
b0d1d82736 Remove hover color from toolbar's admin settings button 2022-08-08 16:34:29 +02:00
ralf
79a395e3e6 fix missing scrollbar in longer then visible dropdown 2022-08-08 14:44:37 +02:00
ralf
7f36de45a4 take symlink indicator from api not old etemplate app
Using LGPL licenses GNOME icon: https://de.wikipedia.org/wiki/Datei:High-contrast-emblem-symbolic-link.svg
2022-08-08 14:12:20 +02:00
Hadi Nategh
301d38796f Still set width for buttons with only icon and remove the extra left padding in this case as we want the button and icon be square 2022-08-08 11:57:02 +02:00
ralf
2017bd8261 remove legacy widgets dropdown_button and favorites 2022-08-07 12:09:02 +02:00
ralf
d9d14f1e2a implement appicon as web-component and remove/replace legacy et2_widget_image with stubs 2022-08-07 11:55:02 +02:00
ralf
29ac5d82a9 remove legacy widgets url-*, colorpicker and tabs 2022-08-07 11:02:54 +02:00
ralf
ba35be1d86 Change Et2Checkbox to behave closer to legacy et2_widget_checkbox and thereby fixing all sorts of errors with it.
Fix vfsSelectUI to be able to select files again with click on the row and only submit selected files.
Also change Et2Widget.iterateOver and legacy et2_widget.interateOver to be called with new web-component classes like Et2Checkbox. Also make Et2Widget matching all widgets by default like et2_widget.
Remove legacy et2_widget_checkbox code.
2022-08-07 10:10:33 +02:00
ralf
35cff9c978 set width of mime icon to 16px as it was before 2022-08-06 12:16:05 +02:00
ralf
7e81b69b74 support empty attribute values 2022-08-06 12:11:41 +02:00
ralf
4ff66f0fd7 replace removed check.png with its .svg counterpart 2022-08-06 09:18:39 +02:00
ralf
239a81e6d9 replace et2_link_add with a stub and no longer include it in etemplate2.ts 2022-08-06 08:38:16 +02:00
ralf
49aba7193d adapt tab-activation on validation error to new tabs and additionally scroll widget into view 2022-08-05 20:33:29 +02:00
ralf
bb28500ef7 fix mail preferences could not be saved 2022-08-05 20:20:46 +02:00
nathan
e8a93ab782 Handle initial value sometimes not set after Shoelace version bump 2022-08-05 11:32:59 -06:00
nathan
36d74dd91f Select search term after selecting a search result 2022-08-05 11:10:50 -06:00
nathan
e67c3d6e61 Et2Tabs: Implement et2_IResizable 2022-08-05 11:01:26 -06:00
ralf
b22674dbd7 change tabbox to be an input widget allowing to get and set the active tab 2022-08-05 17:37:23 +02:00
Hadi Nategh
2593acf303 Let the button with no label set and only icon be square 2022-08-05 16:25:47 +02:00
Hadi Nategh
3fe7398b18 Fix some of calendar's toolbar actions not having icon or caption 2022-08-05 13:03:59 +02:00
Hadi Nategh
10b61cc612 Finish up loading animation if the active tab is an old etemplate 2022-08-05 12:53:56 +02:00
nathan
fb94a47df1 Et2LinkSearch: Avoid error if title couldn't be found 2022-08-04 16:25:44 -06:00
nathan
b88ce18639 Fix invalid template names caused by appending cache_buster incorrectly
38721229b0
2022-08-04 16:15:04 -06:00
nathan
045f322bf6 Et2Select changes:
- Position search & edit inputs to avoid reflow
- When editing a freeEntry, blurring accepts the current value, before it canceled the edit
2022-08-04 15:50:52 -06:00
nathan
f08eaa9fdc Et2Colorpicker: Turn on clear value button 2022-08-04 14:03:28 -06:00
nathan
098c2ab3f0 Fix some issues from the shoelace version bump
- SlSelect.getItemLabel() not there anymore
- SlSelect.menuItems is now a real list, and fails when parent tries to write to it
- Tabs didn't hide properly when not active, giving a scrollbar
2022-08-04 13:47:16 -06:00
nathan
97daa9a731 WIP Fixing colorpicker - moving it to be based on Shoelace 2022-08-04 13:08:34 -06:00
ralf
3c4b03ca3c * SAML/Univention: support for Univention SAML IdP for SSO incl. docu 2022-08-04 20:10:23 +02:00
ralf
d540576656 do NOT allow to call Api\Etemplate\Widget\Link::ajax_delete() without a positive link_id 2022-08-04 19:37:23 +02:00
nathan
78acaba766 Et2LinkList: Fix deleting links on unsaved entries deleted more than expected 2022-08-04 10:47:06 -06:00
nathan
111e337db1 Avoid error when getting tab height from parent 2022-08-04 09:19:04 -06:00
nathan
ae4b8de4e5 Remove setting textContent twice. If needed, loadFromXML() will handle it. 2022-08-04 08:59:40 -06:00
Hadi Nategh
47825f1be3 Override default color-indicator from shoelace 2022-08-04 16:31:14 +02:00
Hadi Nategh
de699325a6 Set a smaller font-size for tab's label 2022-08-04 16:19:30 +02:00
Hadi Nategh
fd8f6c2f07 Remove border from toolbar 3dots menu-button 2022-08-04 12:37:45 +02:00
Hadi Nategh
2369daa2e8 Add toggle alignment option into Et2Details widget 2022-08-04 11:40:27 +02:00
ralf
509fbd73e9 fix JS error, if user has no preferences or favorites 2022-08-04 09:08:46 +02:00
nathan
e1af1f3765 Make sure nextmatch header row filters have enough space
ACL dialog needed this - 14% is too small
2022-08-03 16:30:14 -06:00