Commit Graph

3175 Commits

Author SHA1 Message Date
nathan
ffb9fa706a Filemanager: Fix new file button stopped working after being readonly
Moved option render inside render() since we have it, simplifys things a lot
2023-05-16 15:01:24 -06:00
nathan
6ecb2d8cf9 Et2Select: Fix missing options filter to handle option groups too 2023-05-16 11:02:20 -06:00
nathan
eddcc97163 Et2ButtonIcon: Fix missing icons
There was a conflict between Et2InputWidget setting the widget name & image
2023-05-16 10:02:34 -06:00
hadi
60643d86b2 Fix toolbar icons are no longer shown in mobile theme 2023-05-15 17:29:13 +02:00
nathan
3bd2ee5aad Fix confirm dialog sometimes mis-placed initiating button in value 2023-05-12 10:06:55 -06:00
nathan
d5d217c589 Some "invalid option" fixes:
- Don't notify user, just log it to the console
- Fix calendar owner filtered out not loaded options
2023-05-11 10:56:42 -06:00
nathan
91b94a5126 Et2Select: Use same z-index for search box as dropdown 2023-05-10 13:43:46 -06:00
nathan
01ab3ab85a Et2Select: Fix selection of first option when no value provided, broken by 134cd9d249 2023-05-10 09:19:43 -06:00
hadi
104ecb2732 Make sure that we are literally marking the row's content before deactivating drag action 2023-05-10 14:56:53 +02:00
nathan
820bd35689 Fix filtered out invalid values were still left in value 2023-05-09 14:28:02 -06:00
nathan
3e1b1e56dc Fix focussed select does not close when it loses focus
Mail reply moves focus from To: to body, and To dropdown stayed open
2023-05-09 14:04:02 -06:00
nathan
134cd9d249 Fix invalid option check did not work for multiple 2023-05-09 08:57:55 -06:00
ralf
e2580aedea * Mail: work around Firefox not offering an option to not ask again installing EGroupware as mail-handler 2023-05-09 10:47:35 +02:00
nathan
4ce6bb3f3d Et2Select: Remove values that use options that aren't there to avoid the validation error 2023-05-05 11:08:47 -06:00
hadi
a8e83ad59f Fix readonly links styling 2023-05-04 12:41:30 +02:00
nathan
9aa4c6f403 Et2DateDuration: Fix value of "" caused NaN 2023-05-03 08:42:15 -06:00
hadi
6588759497 Fix typo related to the commit 8e8c664e95 2023-05-03 15:33:23 +02:00
ralf
d11c74f0bc fix error trying to submit 2023-05-03 11:16:47 +02:00
nathan
46b7c5258b Skip disabled widgets in iterateOver
This fixes disabled widgets returning their value unexpectedly, and ID collisions when we have 2 widgets with the same ID, but disable one.
2023-05-02 14:21:03 -06:00
nathan
ab195097f5 Et2DateDuration: Use integers for duration when we have a separate box for each duration, float when there's one box 2023-05-02 14:17:40 -06:00
hadi
8e8c664e95 Fix broken 3dots menu for nm in mobile theme 2023-05-02 18:53:42 +02:00
nathan
05e262d5ee Some tests for Et2EmailTag 2023-05-01 15:27:17 -06:00
nathan
5cb6415fef Et2Link: Fix projectmanager did not open in pm tab
Broken by 12e42d6
2023-05-01 10:28:36 -06:00
nathan
2fc44da034 Api: Fix clicking Select dropdown button while open did not close dropdown 2023-05-01 08:55:25 -06:00
nathan
8e9071acc8 Calendar: More sidebox owner fixes
- another instance of remote class causing problems
- remove duplicates to avoid warning message
2023-04-28 11:27:26 -06:00
nathan
96c66eeaf8 Fix LinkEntry change caused double change event 2023-04-28 09:27:17 -06:00
nathan
86dac02826 Calendar: Fix second selected owner in sidemenu went missing 2023-04-27 14:02:41 -06:00
ralf
a50fa29419 null and undefined are objects too
fixes TypeError: Cannot read properties of null (reading 'length')
2023-04-26 09:22:30 +02:00
nathan
7d86d69b49 Add statustext to list of detached attributes 2023-04-25 13:53:16 -06:00
nathan
12e42d6396 Fix Et2Link always opening in the same popup 2023-04-25 09:54:05 -06:00
nathan
7a75f50362 Api: Always resolve jsonq, even if empty array
Fixes callback was not called if response was []
2023-04-25 09:10:33 -06:00
nathan
5b9cf0ae0b Et2InputWidget: Give clones of object values so receiver cannot use the reference
Fixes failing change detection in EgwApp.update_state, since the value was the same object
2023-04-25 09:09:18 -06:00
hadi
92724b727d Fix js error causes stop execution for apps with no favorites 2023-04-25 16:46:06 +02:00
hadi
998039b464 Do not translate category names 2023-04-25 12:02:35 +02:00
nathan
8fdfcc5c61 Fix missing entry values 2023-04-24 13:27:57 -06:00
nathan
027fc4dfab Always strip comma regardless of number preference so parse float always works. 2023-04-24 09:42:09 -06:00
hadi
69e06ca501 Make content marking possible on nm rows 2023-04-24 14:52:07 +02:00
nathan
61deaad2a2 Fix et2container.getValueById() failed with error on (some) webcomponents 2023-04-19 11:30:37 -06:00
nathan
5c1c31e2a5 Fix typo in 5a824ef 2023-04-19 10:25:49 -06:00
nathan
9e8bc6e1ee Let change event bubble so it can be caught by parents 2023-04-19 10:03:54 -06:00
hadi
2e570a0343 Fix toolbar actions not getting their icons displayed when the toolbar is being opened from its none origin apps 2023-04-19 17:50:57 +02:00
nathan
aac751f864 Api: Fix Et2Link did not open PDFs in Collabora, but always downloaded them 2023-04-18 11:48:25 -06:00
nathan
5a824ef25b Et2Select: Fix doubled tags, long tags missing ellipsis 2023-04-18 10:36:34 -06:00
nathan
6db4bdbac0 Preferences: Add a preference option for if select multiple dropdowns stay open, excluding email selection
Also, German translations from Birgit
2023-04-18 08:52:06 -06:00
nathan
5358bb5f6f Don't validate inputs that are disabled, in addition to readonly 2023-04-17 14:47:06 -06:00
nathan
358cc70d66 Preferences: Add a preference for if select multiple dropdowns stay open or closes immediately after selection 2023-04-17 09:28:27 -06:00
nathan
5781542cab Fix multi-select in headers did not trigger update when a tag was removed
Value got passed around by reference, so as soon as the value was changed, activeFilters had the updated value.  Now just leaving applyFilters() to do the check.
2023-04-14 15:22:58 -06:00
nathan
43873af7bc Add implicit preference to remember user's last sort order.
Sort stored in favorites override this when the favorite is used.
2023-04-14 10:28:16 -06:00
nathan
8d1055c5c7 Api: Include webcomponents even if they don't have variable attributes, or any event handlers get lost 2023-04-14 09:35:06 -06:00
nathan
f28771e22b Api: Let box onclick also be detached attribute 2023-04-14 09:07:05 -06:00
nathan
3423e680b8 Validation changes:
- Fix multiplying messages on focus/blur
- Server-side (Manual) messages do not block submit.  Server set it, we'll let server check it.
2023-04-13 15:06:31 -06:00
nathan
e4592e822e Api: If widget has autocomplete="on", set the name attribute for autocomplete 2023-04-12 15:14:35 -06:00
nathan
9f20a89306 Et2DateDurationReadonly: Fix value change did not update, so displayed value was unchanged 2023-04-11 17:09:36 -06:00
nathan
32ce18b832 Et2NumberReadonly: If value is null, just show nothing 2023-04-11 17:08:18 -06:00
nathan
f8904ef126 Fix et2-vbox center alignment 2023-04-11 11:58:56 -06:00
ralf
b3ea3c89cf implement onlyEmail attribute for et2-select-mail to only display email address, even if we have a full rfc822 address and use it for aliases and forwards in admin mail 2023-04-11 18:19:17 +02:00
ralf
f957656f92 also allow / and # in every position of placeholder name 2023-04-11 17:11:56 +02:00
ralf
649645ab0f * Mail: allow placeholders in compose instead of email-addresses to be able to create mail templates 2023-04-11 15:01:40 +02:00
nathan
4708c19665 Fix vfsSelectUI path closed dialog if you pressed enter 2023-04-06 16:14:09 -06:00
nathan
713c0ce21b Et2Dialog: Move enter handler to keyUp so input event handlers can fire first 2023-04-06 16:13:42 -06:00
hadi
9a1593b154 * Filemanager: fix broken expose view for filename click&open action 2023-04-06 17:46:59 +02:00
hadi
a09c0bad38 * Filemanager: fix after opening and closing the gallery in filemanager the list is no longer accessible 2023-04-06 14:56:39 +02:00
nathan
0026591f03 Api: Remove call to jQuery.dialog from app_base.js
Replaced with alert warning to port app to typescript (egw_app.ts)
2023-04-05 13:16:47 -06:00
nathan
8ec449403f Api: Remove call to jQuery.dialog 2023-04-05 11:52:55 -06:00
nathan
aa89bf82af Et2Select: Re-color dropdown icon in darkmode 2023-04-05 11:30:36 -06:00
nathan
24bb8ffebf Et2Description: Fix urls from activateLinks did not open properly 2023-04-04 14:08:24 -06:00
nathan
55116c7b49 Et2Select: Fix select closes immediately after opening
If you click to open then click again to close, select wouldn't stay open after that.
2023-04-04 10:12:48 -06:00
nathan
98ae5aac1c Et2Select: It was impossible to have "," in an option value, as it would get split by set_value()
see a9d2a3972c
2023-04-03 14:55:04 -06:00
nathan
886de143d4 Fix "Uncaught (in promise) TypeError: Failed to execute 'observe' on 'ResizeObserver': parameter 1 is not of type 'Element'." 2023-04-03 11:57:57 -06:00
nathan
1702269b65 Api: Fix readonly category select did not load application categories
Categories were loaded before attributes & application was not used
2023-04-03 10:21:46 -06:00
nathan
a9d2a3972c Et2Select: It was impossible to have "," as an option value, as it would get split by fix_bad_value() 2023-04-03 08:52:31 -06:00
hadi
44d4b70aaf Add autocomplete attribute to input widgets 2023-04-03 12:29:50 +02:00
hadi
c4809386e1 Set a max height for select tags 2023-03-31 14:07:30 +02:00
nathan
73723eff5a Don't try to load disabled templates
Allows us to disable / not load templates even if they have template / ID
2023-03-30 10:49:56 -06:00
nathan
deefd1e0ea Et2SelectDayOfWeek: Fix missing all days, weekday, weekend options 2023-03-30 08:33:07 -06:00
hadi
1aa0528642 Fix broken vfsPath widget 2023-03-30 16:04:52 +02:00
nathan
2446c3823f Et2TabsMobile: Fix double values when submitting.
Render was making multiple copies of the sub-template
2023-03-29 11:02:28 -06:00
nathan
7d71246ff0 Et2Date: Fix incorrect validation error for empty dates on mobile 2023-03-29 10:22:35 -06:00
hadi
09560a325a Fix some dialog's buttons are not getting fit into the dialog initiated size 2023-03-29 17:21:41 +02:00
nathan
46af0265fa Et2CheckboxReadonly: Fix checkbox was not visible if selectedValue attribute was not set 2023-03-28 14:20:47 -06:00
nathan
b67abdafd1 Fix up recur days 2023-03-28 13:48:26 -06:00
nathan
70db89b2f6 Et2DateReadonly: Fix readonly date did not re-render when value changed 2023-03-28 08:30:45 -06:00
nathan
e0e074a4b1 Et2SelectEmail: Fix keyboard navigation in search results 2023-03-27 08:51:20 -06:00
nathan
af66c63714 Keep select tag icons their original color 2023-03-24 11:45:55 -06:00
nathan
8de9ffc240 Et2Select: Fix keyboard navigation in search results & sidebox category closes 2023-03-23 17:21:32 -06:00
nathan
5614870a29 Et2Select: Always close the dropdown after an option is selected, even if multiple=true. Now for keypresses too.
see 62402f39ae
2023-03-23 16:02:09 -06:00
nathan
62402f39ae Et2Select: Always close the dropdown after an option is selected, even if multiple=true 2023-03-23 15:23:32 -06:00
ralf
23fea7cfb1 nicer than window.setTimeout() 2023-03-23 21:50:35 +01:00
ralf
5818d4bfc0 * NewsAdmin: fix creating of new categories
deferring setting the label, if parentNode is not yet there
2023-03-23 21:42:34 +01:00
nathan
5e6b11e73c Et2UrlEmail: Use default mail app when preference says to 2023-03-22 13:03:23 -06:00
nathan
d2e23876f1 Et2Checkbox: Use normal color even when required
Preveiously check was white, which was hard to see on yellow required background
2023-03-22 11:18:56 -06:00
nathan
e034557f60 Api: Fix number could not handle comma as decimal separator if different from browser's region. 2023-03-22 10:59:05 -06:00
nathan
59ea901cf9 Et2DateDuration: Fix widget did not fire change event when value changed 2023-03-20 14:50:45 -06:00
nathan
60e4e17fad Fix DateRange UI did not fill in start date properly 2023-03-20 13:43:03 -06:00
ralf
d3eed5b738 merge transpiling branch into master 2023-03-20 20:32:09 +01:00
ralf
dd43a3dc7a same for _linkCallback (give method and attribute a different name to fix transpiling) 2023-03-20 20:26:51 +01:00
nathan
53984a270f Get nm rows showing 2023-03-20 13:11:00 -06:00
nathan
be4506fa3b Fix DateRange UI did not fill in start date properly 2023-03-20 10:33:26 -06:00
ralf
2eaa4bb038 fix Resumable import for transpiling 2023-03-20 13:48:35 +01:00
ralf
05a8882681 using ESM module from SortableJS (link in two other places already)
could probably go to master and work with old RollupJS config
2023-03-20 13:47:36 +01:00
ralf
1015f057f4 fix Flatpicker plugin imports for et2-date* widgets 2023-03-20 13:41:25 +01:00
nathan
4f40ef01da Home: Fix single entry did not save correctly 2023-03-17 10:27:27 -06:00
nathan
fd253b10f5 Only wait for nm header widgets, not all the rows that just get removed.
see 0b8c108279
2023-03-17 08:26:58 -06:00
ralf
b95cdcb3c0 also declare and export app and framework 2023-03-17 08:52:52 +01:00
nathan
0b8c108279 Fix weird nm column sizing in infolog.
Depending on favorite settings, changing favorite (or 'No filters') caused incorrect column sizing in nm list
2023-03-16 16:15:35 -06:00
nathan
7c229e1df3 Home: Immediately apply property changes to portlet
Server can override if needed, but this is a little more responsive and fixes some non webComponent portlets (eg: single entry) still needing a reload before they can stay up to date
2023-03-16 11:48:50 -06:00
nathan
ae265c9b52 Fix select all did not respect some filters
Certain sequence of applying filters could trigger long task & get all IDs, which failed.
2023-03-16 11:21:27 -06:00
nathan
17018a7a24 Home: Better initial load of new favorites
Less server requests, shows data without reload, favorite select populated immediately
2023-03-15 10:16:08 -06:00
nathan
0f1866eb19 Home: Fix birthdays lost range option 2023-03-14 15:02:02 -06:00
nathan
c0680a006d Home: Make resize less jumpy 2023-03-14 11:22:38 -06:00
nathan
b09c6e804f Home: Restore ability to manually add to list portlet
Now just using the properties dialog to add
2023-03-14 09:15:02 -06:00
ralf
096981ea3f WIP transpiling: only import as type as only used as such 2023-03-14 09:07:02 +01:00
nathan
9a8375fa33 Revert "fixes for transpiling:"
This reverts commit f5a1fce8bc.
2023-03-13 14:32:31 -06:00
ralf
f5a1fce8bc fixes for transpiling:
- importing Instance and HTMLElementWithValue types only as type
- import flatpicker plugins with: import {default as <PluginName>} from <file>
2023-03-13 19:41:00 +01:00
ralf
43dfaa6bc2 fixes for transpiling: import instantiated StaticOptions object, not the type
has also the benefit of using a single instance
2023-03-13 19:38:36 +01:00
nathan
ca17161f4a Remove action WIP 2023-03-10 14:50:05 -07:00
nathan
5cfe1cef58 Home: Weather portlet improvements 2023-03-10 14:44:41 -07:00
Hadi Nategh
665dcc18da Fix links in infolog description getting into a new line 2023-03-10 20:17:48 +01:00
Hadi Nategh
87a055e7bd Fix tree's actions no longer available after refreshing the root node 2023-03-09 13:05:57 +01:00
ralf
2543a011cb fix wrong import path stalling Babel transpiling 2023-03-09 08:48:01 +01:00
nathan
e7f10c711c Fix numeric validator on a Et2Number would not pass 2023-03-08 13:28:04 -07:00
nathan
5ebad31675 Fix description label did not get row value in nextmatch
Fixes projectmanager price list showed "5 / $row_cont[pl_unit]" instead of "5 / h"
2023-03-08 11:53:48 -07:00
nathan
0492c92352 Et2Colorpicker: Let popup panel auto-position
Fixes color picker goes offscreen in kanban board edit
2023-03-08 11:26:47 -07:00
nathan
b703e2bfe5 Fix required validator went missing if a regex validator was added 2023-03-08 11:00:27 -07:00
nathan
9f95db7ad8 Home WIP: Fix changing portlet width would not stick for some types 2023-03-07 16:16:01 -07:00
nathan
d9e12ecf4a Home WIP: Better re-layout calcs, use correct portlet type (if possible) when adding 2023-03-07 16:02:29 -07:00
nathan
5760c5049f Et2InputWidget: Split label around widget if it has %s in it 2023-03-07 10:51:33 -07:00
Hadi Nategh
9f9c988c14 Fix error Cannot read properties of undefined (reading 'implements') 2023-03-07 16:16:57 +01:00
nathan
bb67507223 Et2DateDuration: Don't error & break everything for a bad display format, just log it and continue 2023-03-06 15:02:45 -07:00
nathan
1538496df1 Home WIP: Get calendar working 2023-03-06 14:47:48 -07:00
nathan
fc3feb974a Home WIP: Fix initial positioning and layout 2023-03-06 13:48:15 -07:00
nathan
514d4cf207 Home WIP: Header spacing & style improvements 2023-03-06 13:19:49 -07:00
nathan
d37143c842 Home WIP Favorites working a little better 2023-03-06 13:19:49 -07:00
nathan
59c4070733 Et2LinkList: Fire change event when link is removed
Avoid error if instance manager is missing
2023-03-06 13:19:49 -07:00
nathan
db5be59ed0 Home: WIP home now shows stuff again 2023-03-06 13:19:48 -07:00
Hadi Nategh
c485a287bb Let et2Select be clickable on top user menu 2023-03-02 16:46:30 +01:00
nathan
49d719e5f6 Et2DropdownButton: If readonly, display / render nothing
does not affect disabled, which still displays as disabled
2023-02-28 11:12:50 -07:00
nathan
e62cf4c2f7 Fix double-bound file drop handler
Fixes double-submit after dropping a second file.  Noticed in mail compose, but probably affects everywhere file widget was used to upload
2023-02-28 10:39:10 -07:00
nathan
da1b1f6999 Fix gantt chart couldn't load data
broken by 2066523.
Loading caused 'Exception "t is undefined" while handling JSON response from ....' deep inside dhtmlx-gantt
2023-02-28 09:05:49 -07:00
Hadi Nategh
057afb8623 Some styling fixes for mobile view:
- fix broken Addressbook's avatar in view and edit mode
- fix buttons with icon not getting white filter
2023-02-28 13:06:52 +01:00
nathan
86b883951a Add isReady flag to etemplate. onchange functions set as attributes in .xet files will not be called until the etemplate is finished loading. 2023-02-27 15:31:07 -07:00
nathan
0117c4bde3 Move client-side holidays cache to MODULE_GLOBAL egw.holidays(year) 2023-02-27 15:15:36 -07:00
nathan
635780d7d4 Et2LinkTo: Fix linking to existing file in VFS did not do anything
Onchange was not being set
2023-02-27 13:25:47 -07:00
nathan
ce141fa152 Disable file drag and drop so normal drag and drop in filemanager works properly 2023-02-27 11:17:23 -07:00
ralf
a8dd625a61 register old-hbox client-side and all old-*box on server-side 2023-02-27 09:57:21 +01:00
Hadi Nategh
2dc78de2c1 Support deprecated get values method for ET2Select_ro 2023-02-27 09:56:39 +01:00
nathan
206652307b Et2Date fixes
- Fix mobile get / set value was not actually setting value properly
- Set a minimum input width
2023-02-24 11:58:16 -07:00
nathan
ab812c8dec Just the timer dialog gets timesheet color, leave others alone 2023-02-23 10:12:21 -07:00
ralf
a48a3eb3c1 add ES2020 check to login page and move it outside egw_ready (no longer allowing to translate the message) 2023-02-23 14:00:37 +01:00
nathan
41cbb68de0 Et2Select: Fix extra scrollbar with rows=1, multiple, hover lots (> 8 or so) of rows 2023-02-22 16:23:56 -07:00
nathan
4311eebdc9 Et2Dialog: Fix missing button alignment 2023-02-22 14:51:21 -07:00
nathan
cd22b9aad6 Slow down tab switch on drag
Avoid another tab being moved underneath the cursor if the target tab has different sidebox menu width, triggering another tab switch
2023-02-22 14:31:41 -07:00
Hadi Nategh
24570cd438 Let sl-button-group deals with blur and focus handling for our Et2DropDownButton widget 2023-02-22 17:56:02 +01:00
nathan
f7d44c63cb Enable disabled select options 2023-02-22 09:51:57 -07:00
nathan
e532ca176b Add Et2TabsMobile that has special rendering for tabs on mobile 2023-02-21 10:31:38 -07:00
Hadi Nategh
68fdb1b985 Revert "changes to get old eTemplate apps like KnowledgeBase working in 23.1"
This reverts commit d816d837cd.
2023-02-21 13:02:23 +01:00
Hadi Nategh
188334d647 Fix scrolling in mobile view sidebar not working 2023-02-20 15:16:43 +01:00
ralf
5cf63cc45e * Timesheet: allow to set preference to never ask again to start working time on login 2023-02-20 12:42:21 +01:00
nathan
9cc1f08d63 Et2UrlEmail: Fix click to add to email button was broken 2023-02-17 08:51:27 -07:00
nathan
33ca8a47a9 Et2Select: Tweak size calculations for rows setting to work better for all font size preferences 2023-02-16 11:59:34 -07:00
Hadi Nategh
b25346c1e4 ET2Button doesn't get resized properly after set/remove label therefore try to force an update 2023-02-16 15:17:13 +01:00
nathan
524a9b3c7b Change how readonly multiple selects with rows=1 show more tags are hidden
Showing total number of values is way easier than showing the number that aren't displayed
2023-02-15 13:23:05 -07:00
nathan
ced2bc6061 Et2Password: Fix still forced autocomplete="new-password" 2023-02-15 09:21:40 -07:00
nathan
84bdea4193 Fix nm print dialog missing print orientation 2023-02-14 16:27:44 -07:00
nathan
80c5a64316 Et2Password: Autocorrect always off 2023-02-14 13:48:21 -07:00
nathan
d1c6145af0 Et2Password: Some cleanup
- Now passing autocomplete & autocorrect parameters on instead of forcing
 - Only doing the readonly input trick if autocomplete=="new-password"
2023-02-14 13:43:26 -07:00
nathan
68caabe1ae Fix hidden tabs did not make children readonly
Fixes required fields on hidden tabs still got validated
2023-02-14 10:09:58 -07:00
nathan
16c8fb420b Et2Password: Overwrite render to force input to readonly as a work-around for browsers ignoring autocomplete="new-password"
Doesn't make a difference for me, but easy for others to test if I commit
2023-02-13 15:59:38 -07:00
nathan
03a237fd7e Et2Select: Turn off browser autocomplete in search 2023-02-13 14:57:55 -07:00
nathan
d02a40ee82 Et2Select: Remove any doubled values when setting value 2023-02-13 14:00:52 -07:00
nathan
e2cbbe9358 Re-add feature where readonly URL widget with label uses the label as link text 2023-02-13 13:29:25 -07:00
nathan
c4f3ec9840 Et2Select: Fix free entries can get doubled if more free entries added 2023-02-10 14:13:13 -07:00
nathan
570edaa1e0 Et2Favorites: Update sidebox favorite icons when user changes default favorite 2023-02-09 16:47:59 -07:00
nathan
4322937ea7 Et2Date: Add widget classes to flatpicker popup 2023-02-09 14:47:43 -07:00
nathan
96558b9da8 Fix missing translation in Select group & dropdown options 2023-02-09 14:47:43 -07:00
nathan
bf764df720 Mail: Multiple attachments changes
- Offer to open in Collabora any file, not just editable (PDF)
- Put collabora option first in the option list if user prefers to open in collabora
- Change label to "Open with Collabora Office" with translation from Birgit
2023-02-09 14:47:43 -07:00
Hadi Nategh
0d68f87ae3 Make sure the path is available when checking for scrolling touch 2023-02-09 17:15:01 +01:00
ralf
d816d837cd changes to get old eTemplate apps like KnowledgeBase working in 23.1
makes some more symbols global again in one block at the end of the files
2023-02-09 14:17:24 +01:00
Hadi Nategh
5a2bbd6463 Adjust details container calculation for overlaySummary based on left/right alignment 2023-02-09 11:26:25 +01:00
nathan
32dd160e35 Et2Date: Add placement property to control where calendar popup opens. "top", "bottom", or "auto" 2023-02-08 14:36:09 -07:00
nathan
00a857b2d7 Projectmanager: Fix gantt column selection opens with wrong position
Now using a proper dialog, similar to nextmatch column selection
2023-02-08 11:48:56 -07:00
nathan
efa550f251 Et2Select: Add onTagClick property for actions on tag clicks
Fixes unable to detect clicking on individual tags inside readonly et2-select-email
2023-02-08 09:11:33 -07:00
ralf
ed09a0b079 add missing readonly et2-select-lang to fix language column in news-admin index 2023-02-08 08:24:59 +01:00
nathan
193dbfc339 Et2Select: Fix some search weirdness
- Search didn't start until 1 character more than expected
- Search didn't happen on enter because the et2-searchbox inside stopped the key event from bubbling
2023-02-07 16:24:06 -07:00
nathan
9cde6a7171 Fix some styling on select-email
- Make +N tag right aligned & look like text, not tag
- Fix popup to open below but covering field
- give popup border & dropshadow
2023-02-07 12:04:05 -07:00
nathan
2a3a8a7371 Et2Select: Fix tags can't be removed 2023-02-07 10:04:56 -07:00
Hadi Nategh
84a58ec6ae Add new attribute for details widget to overlay the summary container 2023-02-07 16:49:18 +01:00
Hadi Nategh
cb6f2ee808 Add missing column on email tag tooltip 2023-02-07 10:01:46 +01:00
nathan
2c15e2f8ef Et2Description: Fix broken activate links test, it needed camelCase attribute 2023-02-06 15:59:32 -07:00
nathan
1b7f9d3ebc Et2SelectEmail: Give dragged tags some z-index, so they go over the other controls 2023-02-06 15:07:30 -07:00
nathan
cd980c78df Limit mail to & cc addresses to 1 row, show all on hover.
Use:
multiple="true" rows="1" maxTagsVisible="1"
to trigger show all on hover
2023-02-06 14:48:55 -07:00
ralf
bd8198d230 missing et2-select-lang widget 2023-02-06 15:52:58 +01:00
Hadi Nategh
dda3b1f5d1 Remove excessive BR tag from email tag 2023-02-06 11:33:50 +01:00
nathan
1d8d4f9c72 Fix some readonly issues where widgets were not looking readonly
- Editable tags were still editable if the select was readonly
- LinkTo could still select an app (readonly not passed on)
- Hide the dropdown for multi-select when readonly
2023-02-03 14:09:07 -07:00
nathan
21599f6097 Make all toolbar toggle button icons gray when off 2023-02-02 10:46:51 -07:00
nathan
929bf866cd Et2Lavatar: Fix missed property camelCase
contact_id -> contactId
2023-02-02 09:19:04 -07:00
Hadi Nategh
138999f233 Add again full value as tooltip for email tags 2023-02-02 12:12:08 +01:00
nathan
1fa9d91d59 Et2Description: Fix links were not clickable
activateLinks property got typoed to activeLinks in the template conversion
2023-02-01 14:31:17 -07:00
nathan
346a720d27 Et2LAvatar: Update statustext (tooltip) with name based on lname & fname 2023-02-01 14:06:54 -07:00
nathan
86376bdc0c Et2DateRange: Add relative -> absolute conversion as needed when setting value 2023-02-01 13:04:25 -07:00
nathan
15f986cf1a Get Et2Date & Et2DateTime tests passing again 2023-02-01 09:46:00 -07:00
Hadi Nategh
e397e43c1b Fix PGP back/restore dialog 2023-02-01 14:15:56 +01:00
nathan
ab56ad1171 Et2Select: Handle paste of CSV into selects with allowFreeEntries
Special handling for Et2SelectEmail to handle email addresses that may have a name or comma
2023-01-31 09:48:27 -07:00
nathan
0b15ede568 Et2Date: Fire change event when a new date is selected
Fixes nm date filters not filtering
2023-01-30 16:10:49 -07:00
nathan
e575c40ff3 Some missed cases where client-side lavatar was not used 2023-01-30 15:26:09 -07:00
nathan
f503743956 Use client-side Et2LAvatar instead of image for Et2SelectEmail options & tags
Should now be only avatar.php image when provided
2023-01-27 13:27:31 -07:00
nathan
5bab72b8be Use client-side Et2LAvatar for user accounts whenever possible, only using avatar.php when there's a real image.
TODO:
- Need to find a cheap way to determine if there's a real image in Api/src/Accounts.php & class.mail_compose.inc.php

- Still some work for me to do in Et2SelectEmail
2023-01-27 10:34:40 -07:00
nathan
9cebab3c2f Fix readonly selects could display 'undefined' with no value and no emptyLabel 2023-01-26 12:58:37 -07:00
nathan
bf6cca24fd Et2Favorites: Make star icon bigger 2023-01-26 09:22:45 -07:00
nathan
e4e0610a41 Et2LinkAppSelect: Use configured app link icon instead of always using navbar 2023-01-25 15:14:14 -07:00
nathan
62bc77a4d2 Make sure egw.lang() doesn't error trying to translate option label
This un-reverts 4e5f68f97c
2023-01-25 14:24:08 -07:00
nathan
4b8b454566 Make sure values are strings, otherwise they might not match comparison
Should fix tracker list "Created by" filter losing display when you select a search result
2023-01-25 13:43:35 -07:00
ralf
6ef78c9591 Revert "Fix missing translation on read-only select"
Causes:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'toLowerCase')
    at Object.lang (egw_lang.js:73:16)
    at Et2SelectAccountReadonly._readonlyRender (Et2SelectReadonly.ts:189:59)
    at Et2SelectAccountReadonly.render (Et2SelectReadonly.ts:168:16)
    at Et2SelectAccountReadonly.update (lit-element.js:6:304)
    at Et2SelectAccountReadonly.performUpdate (reactive-element.js:6:4849)
    at Et2SelectAccountReadonly.scheduleUpdate (reactive-element.js:6:4496)
    at Et2SelectAccountReadonly._$Ej (reactive-element.js:6:4404)

This reverts commit 4e5f68f97c.
2023-01-25 09:46:22 +01:00
nathan
4e5f68f97c Fix missing translation on read-only select 2023-01-24 14:44:28 -07:00
nathan
9bf0149645 Fix selectbox positioning issue
Tracker owner would open down instead of up with fontsize = 14.  Updating to shoelace 2.0.0-beta.81 fixes it.  Going farther introduces some other issues that I don't want to get into right now
2023-01-24 13:58:38 -07:00
nathan
49d3d84f3a Completely hide disabled nm filters, as before 2023-01-24 10:25:01 -07:00
nathan
56fcfbf992 No 'All categories' empty label for mail 2023-01-24 09:26:46 -07:00
nathan
2332c2a806 Et2Tag: Make edit textbox larger 2023-01-24 08:27:52 -07:00
ralf
9fb153bbcc fix historylog in calendar not shown
caused by multi-attributes use a vbox, who's constructor unset the readonly attribute
--> setting it again hard, as all widgets in historylog are r/o and without readonly select-boxes have no detached DOM interface
2023-01-24 14:31:16 +01:00
nathan
7518278948 Add edit button to freeEntry selectbox tags 2023-01-23 17:34:37 -07:00
nathan
802a312839 Stop nextmatch from making a popup dirty if a filter changes 2023-01-19 14:40:56 -07:00
ralf
5fe8f2642a fix problem with Safari 16.2 of NOT displaying dialog contents eg. of timer dialog 2023-01-19 15:23:16 -06:00
nathan
86917eff65 Fix file settings error "'0' is NOT allowed ('not found')!" for gid.
It did not have a '0' => 'root' option, which is what we were using for the value.
2023-01-19 09:21:03 -07:00
nathan
80fbd3cc26 Fix placeholder widget
IDs on et2-boxes caused unwanted namespace, Et2Listbox couldn't find its ID before fully initializing
2023-01-19 08:44:52 -07:00
nathan
3f5cb42c96 Fix vfsUpload didn't open mail files 2023-01-18 13:07:04 -07:00
Hadi Nategh
03123ee729 Fix wrong label set for dark mode switch 2023-01-18 12:15:26 +01:00
nathan
3164cb6dd0 Make sure we get the right popup if multiple nextmatches use the same popup ID 2023-01-17 15:35:28 -07:00
nathan
6774f2e9d4 Remove another class that could be hiding popup contents 2023-01-17 14:30:28 -07:00
nathan
2ab7079f13 Et2LinkString: Can now fetch its own link data, given application & entryId
Includes some fixes for only_app filter
2023-01-17 14:03:28 -07:00
nathan
38b507dcd1 Et2Date: Stop required validation showing on initial load even with a value 2023-01-17 10:52:02 -07:00
nathan
a5929388fc Et2VfsMime: Add value getter
Fixes tracker comments with more than one image would only show the last
2023-01-17 08:37:24 -07:00
nathan
d87e0c7f38 Fix missing default button images 2023-01-16 16:15:57 -07:00
nathan
19c02fc91c Et2InputWidget: Do not try to validate readonly widgets, user can't change the value to fix it 2023-01-16 08:55:31 -07:00
Hadi Nategh
10c646a367 Make sure the sort and shadowRoot are there before using them, avoiding execution error, since getValue it could be called in earlier stage eg: a699117b1b 2023-01-16 12:55:45 +01:00
nathan
374ba994a4 Customfield validation fixes
- customfield did not pass required setting on to widgets
- link entry did not support required
2023-01-13 11:28:02 -07:00
nathan
1a969c4cfc Et2Date: Fix validation message display
Required validation was incorrectly displayed / not hidden
2023-01-13 08:40:21 -07:00
nathan
461e83df28 Remove all validation messages on focus, not just manual / server-side messages.
Server side ones are still re-added on blur, client-side messages are re-run.
2023-01-12 09:17:29 -07:00
ralf
4e1b31bb37 also legacy-load old phpgwapi JS code like tabs using in KB 2023-01-12 08:43:17 -06:00
nathan
4f7b54c6bb Fix some more select attribute / legacy options issues 2023-01-11 15:49:56 -07:00
nathan
a699117b1b Fix hiding server-side messages for selectboxes
Messages were not properly hidden & displayed, and setting handleFocus & handleBlur accidentally overwrote them in Shoelace widgets
2023-01-11 11:11:02 -07:00
nathan
1163f9e31d Hide server-side validation messages while widget has focus. If the value did not change, put messages back 2023-01-09 16:02:59 -07:00
nathan
ffb26cb2f1 Change tree icon size from 20px to 16px
Can be overridden in CSS now
2023-01-09 14:36:44 -07:00
nathan
56f84f2fdd Fix swapped open / closed icons in tree 2023-01-09 13:19:40 -07:00
nathan
ba608fddc7 Et2Split: Fix incorrect / frozen sizing of split in Firefox
If user dragged very quickly & released the mouse button before the resize was complete, we would wind up with incorrect size
2023-01-06 11:07:50 -07:00
nathan
323115b041 Replace font size accidentally removed in 40278c8827 2023-01-06 09:11:54 -07:00
nathan
39ab880188 Don't die if CustomFilterHeader is for a component that isn't a webcomponent, just error & use a select 2023-01-05 16:36:03 -07:00
nathan
c403edc49a Fix incorrect suggested password length 2023-01-05 15:35:04 -07:00
nathan
f8a8a290ce Tests for switch widget 2023-01-05 14:06:54 -07:00
nathan
3ecd9c222b Fix switch widget did not validate value server-side 2023-01-05 14:06:39 -07:00
nathan
9a190321c1 Et2Button: Fix class mixup that broke buttons 2023-01-05 09:00:02 -07:00
nathan
ca5d80264c Less errors in date tests, still not passing 2023-01-05 08:38:56 -07:00
nathan
37dd18894f Get tests for Colorpicker passing again 2023-01-04 15:33:48 -07:00
nathan
acd44a1e0e Get tests for Button passing again 2023-01-04 15:03:43 -07:00
nathan
40278c8827 Get our WebComponent tests running again
Made a lot of "failed to construct htmlelement" errors go away, avoid a bunch of egwIsMobile is undefined errors
2023-01-04 12:01:09 -07:00
nathan
ac1d8b6be8 Fix TypeError: Cannot read properties of null (reading 'replace')
Fixes unable to edit tracker in mobile view.
2023-01-02 16:20:50 -07:00
nathan
b8c3a97138 Et2Tabs: fix keyboard navigation 2022-12-22 14:51:48 -07:00
nathan
b0bedc8467 Accessability improvements
- Toolbar buttons get label, but it is visually hidden
- Add label to calendar Add button
2022-12-22 14:14:45 -07:00
nathan
c617dfe080 Fix placeholder sub-groups were not showing 2022-12-21 12:28:59 -07:00
nathan
098fe647dc Start on converting date range to webcomponent 2022-12-20 14:05:20 -07:00
nathan
28678c48f4 remove debug 2022-12-19 13:08:21 -07:00
nathan
7d94692dfd Fix some missing account names
- egw().accounts() were not cleaned
- accounts not in normal cache did not call requestUpdate() properly
2022-12-19 12:01:29 -07:00
nathan
ac97af35cb Lets try creating options directly when we get them, rather than going through update first
Timing was not getting menu items created soon enough, resulting in IDs instead of names in the options
2022-12-16 11:48:12 -07:00
nathan
9ce0520e5c Allow actually disabled inputs 2022-12-16 10:40:58 -07:00
nathan
272b63d32e Explicitly define autofocus as reflected so it works in Firefox too 2022-12-15 13:18:16 -07:00
nathan
a9fe524123 Et2Select: Fix value got wrecked by fix_bad_value() when there are option groups 2022-12-15 11:31:56 -07:00
nathan
e756962f86 Change egw.accounts() to always return a Promise 2022-12-15 10:22:19 -07:00
nathan
2ed0479380 Add nm action dialogs into application tab, not document body 2022-12-14 16:10:50 -07:00
nathan
3b5f64a4c3 Implement option groups 2022-12-14 14:32:20 -07:00
nathan
a832c12dbc Fix DnD to link file to entry 2022-12-14 11:56:27 -07:00
nathan
54498a005c Et2Dialog: Second try waiting on template load
Now creating the template promise immediately on setting template name and using a resolver function to resolve after template is loaded
2022-12-14 10:39:15 -07:00
nathan
6c4c42bcde Translation of "on vacation" from Birgit 2022-12-12 15:09:57 -07:00
nathan
27573f6d83 Et2Dialog: Try waiting until after update is complete to avoid an error loading the template in Safari 2022-12-12 14:43:47 -07:00
nathan
65a7abeca2 A little more space for details dropdown 2022-12-12 14:26:54 -07:00
nathan
5acc8c55c8 Et2SelectEmail: Fix fullEmail did not show full email 2022-12-12 14:07:08 -07:00
nathan
34172704dc Fix SelectAccount didn't always get values into options correctly 2022-12-12 13:10:53 -07:00
nathan
9acda4b390 Link fixes
- Fix file that was linked then removed before first save was still linked on save
- Use events for better decoupling between Et2LinkTo & Et2LinkList
2022-12-12 10:32:08 -07:00
nathan
0f37d2f437 Fix sometimes missing accounts for SelectAccount widgets 2022-12-09 13:16:44 -07:00
nathan
6177ca0536 SearchMixin: Filter selected remote correctly for single selects too 2022-12-09 13:14:57 -07:00
nathan
5f44c51d89 Et2Checkbox: Fix internal positioning was causing entire page to overflow 2022-12-09 10:55:19 -07:00
nathan
8ed40c8c0e Et2SelectThumbnail: Fix current value(s) did not display 2022-12-09 09:03:43 -07:00
nathan
dd39305443 Fix VFS upload couldn't show newly uploaded files 2022-12-08 15:01:25 -07:00
nathan
4b4d6fe184 Stop scrolling new tag into view, it causes calendar sidemenu to get stuck 2022-12-08 14:47:02 -07:00
nathan
ce64ddf9e0 Fix doubled tags if widget gets select_options after a remote option is selected 2022-12-08 14:28:05 -07:00
ralf
26d4082cda fix not working buttons in timer dialog 2022-12-08 20:13:32 +01:00
nathan
691928a54c Fix attachments not displayed in tracker comments 2022-12-08 11:39:00 -07:00
nathan
be5125509e SearchMixin: Fix selecting multiple remote values only showed the last 2022-12-08 10:24:49 -07:00
nathan
d7f8f7d997 Fix editing link remark did not load current value 2022-12-07 15:51:50 -07:00
nathan
c26732a913 Some more fixes for historylog widget
- Fix options in proper format could be interpreted as sub-widgets
- Fix numeric values
2022-12-07 15:04:22 -07:00
nathan
12151139ff Et2Dialog: Better non-modal handling, now with less internal conflicts with SlDialog 2022-12-07 13:45:38 -07:00
nathan
32248e67ee Et2Dialog: Better non-modal styling 2022-12-07 11:30:14 -07:00
nathan
4b6357dd90 Et2Dialog nonmodal WIP
Non-modal dialogs don't cover header with app tabs.
TODO: The dialog needs to be added to the app content div instead of the body
2022-12-07 09:13:46 -07:00
nathan
fb40aedf89 SearchMixin: Use parent set select_otions, no need to duplicate 2022-12-06 11:59:51 -07:00
nathan
daa999d586 Et2LinkList: Fix context menu actions 2022-12-06 10:55:20 -07:00
nathan
25f64d0064 Fix error on some bad options
Would sometimes stop historylog from loading
2022-12-06 10:05:47 -07:00
nathan
57993741cb Et2Dialog: Don't close dialog for buttons that are not in the footer 2022-12-06 09:44:56 -07:00
nathan
3971abc54b Fix some select options were not being cleaned
Integer values provided from server were not being converted to strings, breaking value handling & matching
2022-12-06 09:13:04 -07:00
nathan
2188791540 Et2LinkList: Fix context menu "Save As" gave error
Cannot read properties of undefined (reading 'dispatchEvent')
2022-12-05 17:05:10 -07:00
nathan
fa2375b1a6 SearchMixin: Fix selected remote options got lost if adding a freeEntry 2022-12-05 13:56:31 -07:00
nathan
e875b9ddf4 Use same background color for primary buttons 2022-12-05 10:54:05 -07:00
nathan
b2b3caaa64 Fix searchbox triggered change an extra time after pressing Enter key 2022-12-05 10:31:15 -07:00