Commit Graph

287 Commits

Author SHA1 Message Date
Ralf Becker
ba366467b0 * Admin/Mail: fix saving mail-accounts for multiple accounts 2018-05-04 15:07:06 +02:00
Ralf Becker
98376b5908 * PHP 7.2: fix several PHP Fatal errors and warnings stalling installation and usage 2018-04-09 16:02:00 +02:00
Hadi Nategh
d9d051a97e Fix move/copy actions in link_to widget vfsSelect try to create not unwanted new symlink 2018-04-04 17:54:30 +02:00
Hadi Nategh
eb1eed5b8d Implement new feature for vfs-select widget to accept extra buttons action. Additionally, add extra "copy" and "move" actions to link-to vfs dialog. 2018-03-13 17:43:21 +01:00
Ralf Becker
32d10dd243 Fix not working textbox validators containing backslashes
PHP xml parser reads backslashes literal from attributes, 
while JavaScript ones need them escaped (eg. like PHP strings)
-> replace \\ with \ to get following XML working: validator="/^\\d+$"
2018-03-10 17:55:12 +01:00
Ralf Becker
a799abb0a0 * All apps: multiselect custom-field switches to single select after submit 2018-02-28 13:41:13 +01:00
nathangray
816db05496 Use abstraction to determine mime type, see 9a398594ac 2018-02-15 10:16:04 -07:00
nathangray
c67560049c * Api - Check if email address is known before offering 'Add as contact' button 2018-02-08 13:19:26 -07:00
Ralf Becker
d934f33ea6 also fixing preg for email with optional domain part 2018-02-05 19:13:01 +01:00
Ralf Becker
75a39143f8 fixing the fix, now "email.@domain.com" is invalied, but "x@domain.com" is valid 2018-02-05 16:06:46 +01:00
Ralf Becker
6efe719ea1 one letter name-part in email address failed validation, eg. "x@egroupware.org" 2018-02-05 15:32:00 +01:00
nathangray
9a398594ac * Etemplate - Don't trust browsers mime if we don't have to - fixes incorrect mime types and Resources rejecting pictures 2018-01-30 09:14:52 -07:00
Ralf Becker
20cde78af3 allow user & password again as in http://user:pass@example.com/ to fix tests 2018-01-30 16:54:43 +01:00
Ralf Becker
a9ee58cfad allow private IP addresses (starting with 10.|169.254.|192.168.) too 2018-01-30 16:19:35 +01:00
Hadi Nategh
95d1911528 Fix error Call to a member function setDate() on boolean 2017-11-27 18:05:47 +01:00
Hadi Nategh
1ecfab062a Fix list of favorites in VfsSelect contains previous selected contents as well 2017-11-20 17:49:46 +01:00
Hadi Nategh
7e6bcc035f Make favorites available as an individual button in VfsSelect dialog 2017-11-20 17:01:50 +01:00
Ralf Becker
b408c8b464 allow to specify a date-format in custom-fields using eg. format=Ymd, as it was possible in 11.1 in len field 2017-11-10 17:31:05 +01:00
Neo Morina
85866c6ef6
Made some changes at egw_actions
This is a usefull for opening "second level results" as a popup.
"Second level results" couldn't get opened as a popup at Project Manager app when i try to add a new Project as Template at the selected Project.
2017-11-09 14:43:49 +01:00
Hadi Nategh
861d714724 Fix vfsSelect does not show any content for the first load 2017-11-09 10:25:35 +01:00
nathangray
b8f8a014fa Move all tests under api/src into api/tests 2017-10-23 10:14:14 +02:00
Hadi Nategh
ff4396030a Fix CKEditor Browse Server button to open vfsSelect 2017-10-20 18:55:22 +02:00
nathangray
accd6187e2 Get date widget duration test working again 2017-10-20 09:56:47 +02:00
nathangray
9e6ecce1d0 Move tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-18 18:30:54 +02:00
nathangray
237d81ce36 Move tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-18 15:43:35 +02:00
nathangray
8b1a8d38f5 Revert db10b21fa7 2017-10-17 12:48:46 +02:00
nathangray
db10b21fa7 Fix child actions under 'More...' did not inherit the inheritable attributes 2017-10-13 11:13:17 -06:00
Hadi Nategh
052bef84ce W.I.P vfsSelect Widget:
- Fix upload feature not working
2017-10-13 13:22:45 +02:00
Hadi Nategh
5b76210218 W.I.P vfsSelect Widget:
- Fix mime types not being shown
- Fix name being displayed encoded in save2vfs mail
2017-10-12 17:45:46 +02:00
Hadi Nategh
2c721c95b2 W.I.P. VFS Select Widget:
- Add name and dialog_title as new attributes
- Fix SaveToVfs, SaveAttachmentToVfs, SaveAllToVfs in mail
- Fix button tile
2017-10-12 13:19:42 +02:00
Hadi Nategh
448cc8975f W.I.P of VFS Select widget restructure 2017-10-11 18:27:42 +02:00
Hadi Nategh
de65d91dc7 Rmove fields for none private cutomfields when name refers to a single custom field 2017-10-06 16:27:37 +02:00
Hadi Nategh
6407379388 Accept localhost as a valid url 2017-09-26 11:37:37 +02:00
Ralf Becker
a6ec69169d document and enhance function signaure for server-side callback of file and vfs-upload widget
also make it usable for vfs-upload widget with it's id containing entry's id
2017-09-21 11:33:40 +02:00
Ralf Becker
48554590f4 * Addressbook: store S/Mime & PGP pubkey and photo (SQL backend only) in filesystem 2017-09-19 11:38:48 +02:00
nathangray
5b4fd418bf Etemplate - change select multiple validation to also consider rows > 1 to enable multiple 2017-09-14 09:19:26 -06:00
nathangray
1b36ecb962 Etemplate - fix a testing bug giving false positives 2017-09-08 11:49:28 -06:00
nathangray
f9e09953d1 Etemplate - clear other set limits to avoid conflicts with other tests 2017-09-08 11:42:22 -06:00
nathangray
43f6acdf72 Etemplate - enhance email regex to avoid trailing dots in address, comment out some other checks we might not care about 2017-09-08 11:39:33 -06:00
nathangray
cc1fff6c17 Etemplate - add a URL regex to catch some invalids that were making it through 2017-09-08 11:10:57 -06:00
nathangray
12ae214b76 Etemplate - fix bug where min / max could not be 0 2017-09-08 10:30:19 -06:00
nathangray
4d68048929 Etemplate - fix causing false negatives in textbox regex text 2017-09-08 09:51:55 -06:00
nathangray
2006b1f372 Etemplate - fix some bugs in min/max validation 2017-09-08 09:51:06 -06:00
nathangray
0b3cbdeae5 Etemplate - some basic selectbox tests 2017-09-08 09:00:37 -06:00
nathangray
0ead3713e2 Etemplate url widget tests 2017-09-08 09:00:37 -06:00
nathangray
d75372368a Etemplate url-email widget tests 2017-09-08 09:00:37 -06:00
nathangray
495d67d5d0 Testing max & min on date widget 2017-08-28 11:44:30 -06:00
nathangray
61dc75621d Etemplate simple date widget tests 2017-08-25 10:11:41 -06:00
nathangray
b0cd55f0b6 Some more Etemplate tests 2017-08-24 08:48:07 -06:00
nathangray
97543138f8 Some test documentation 2017-08-24 08:48:07 -06:00
nathangray
997c2fd1d5 Add simple tests for textbox widget 2017-08-24 08:48:07 -06:00
Hadi Nategh
1fc4f79850 Revert commit 8340520589 and implement the fix in more sane way 2017-06-14 14:52:31 +02:00
Hadi Nategh
11c03702dd Implement sub_app attribute for customfields widget, in order to be able to store sub-app's specific customfields 2017-06-07 17:54:09 +02:00
nathangray
75124d097b PHP v5.4 syntax 2017-04-21 15:04:24 -06:00
nathangray
f60461eb9f PHP v5.4 syntax 2017-04-21 12:33:27 -06:00
nathangray
9d1756e5d9 Basic Etemplate testing
Some simple exec / process round-trip tests
2017-04-21 12:17:59 -06:00
Hadi Nategh
848535874e Set children of readonly tab to disabled to avoid server side validation error 2017-04-20 18:33:52 +02:00
Hadi Nategh
7b810b57f3 Adopt taglist server side accordingly regarding domainOptional attribute 2017-04-19 16:40:20 +02:00
nathangray
8d7a9b7284 Move VFS widget file handling from Etemplate/Widget/Customfields to Storage/Customfields, to avoid errors with CalDAV/CardDAV not being able to find Etemplate/Widget/Customfields 2017-04-17 09:48:45 -06:00
nathangray
944718daaa Some more tests of basic Etemplate stuff 2017-04-17 08:30:24 -06:00
nathangray
bcd86f7ae9 Fix bug where some elements would not be returned if a child of a later sibling was the same type 2017-04-17 08:30:24 -06:00
nathangray
d5c24a2c8e Thumbnails (and handling) of uploaded files on new entries that have not yet been saved 2017-04-10 10:39:04 -06:00
nathangray
ee62801ace W.I.P. Some more Etemplate testing stuff 2017-04-10 08:12:17 -06:00
nathangray
6f13a9caa9 Test some core Widget functions 2017-04-05 10:10:08 -06:00
nathangray
319d217a3e Some test adjustments to make things a little smoother, and prepare for some widget tests 2017-04-04 10:31:30 -06:00
Ralf Becker
dfbd0d2e6f do NOT store actions in session or eT2 request, nor send for mobile devices skiped actions 2017-04-04 16:54:36 +02:00
Ralf Becker
4f9e14fcc6 never storing rows in Etemplate\Request and by that keeping apps from storing it as state into the session 2017-04-04 15:04:44 +02:00
nathangray
71ffd661ac Make sure to always call typeOptions() with a string
(to satisfy Scrutenizer)
2017-01-31 08:41:22 -07:00
Ralf Becker
5bf8630620 allow to additionally use just a name for which content array contains a path to upload pictures 2017-01-31 10:16:16 +01:00
Ralf Becker
388bffc48b * All apps: fix random failure in drag-n-drop or pasting images into CKEditor eg. mail compose 2017-01-27 17:38:08 +01:00
Hadi Nategh
acdf079fb1 * Etemplate: Fix error "Etemplate\Api\Auth not found" happening while to login 2017-01-05 14:59:20 +01:00
Ralf Becker
6d472b1592 use openssl_random_pseudo_bytes, if available, to generate etemplate_exec_id, as it is used for CSRF protection too 2016-11-17 11:09:30 +01:00
nathangray
a15aa412e2 Attempt to fix redirects to invalid /index.php 2016-11-16 09:20:03 -07:00
nathangray
8ecc188fd7 Customfields required bugs
- Load attributes from modifications array, were previously ignored
- Remove double required check, actual field widget should handle it
2016-11-07 09:22:33 -07:00
Ralf Becker
e989d079d6 removing server-side validation of non-ascii in local part of email, because \x80-\xff gives and invalid utf-8 compilation error in preg_match with /u modifier 2016-10-20 15:21:40 +02:00
Ralf Becker
ab79e193ec * Mail: show validation error if local part (before @) of email-address contains non-ascii chars 2016-10-20 12:29:56 +02:00
Ralf Becker
c2d1fe6d50 only check vfs for templates, if /etemplates is mounted 2016-10-19 16:44:04 +02:00
nathangray
fa8f53e6d4 Fix VFS ajax uploads did not work if path needed expansion 2016-10-05 16:13:31 -06:00
nathangray
3da08fa7a1 Make sure category data is an array before looking inside it, avoids warning if it is not 2016-10-03 09:58:59 -06:00
Ralf Becker
d99a283929 fix old class names in docu 2016-09-26 09:27:52 +02:00
nathangray
c2bd221ae0 Silence debug error log 2016-09-13 08:07:52 -06:00
nathangray
7afd7e420b Better version of optgroup fix to still allow additional data (title, color) in option entries 2016-09-12 10:42:12 -06:00
nathangray
dee0caa875 Fix validation of select values in an optgroup always failed 2016-09-12 08:40:48 -06:00
nathangray
4dcb415f44 Try to fix redirects from AJAX calls to static methods 2016-09-09 10:27:33 -06:00
Hadi Nategh
aff9f0eba8 Fix Ctrl+A in context menu does not get translated 2016-09-09 12:54:52 +02:00
Ralf Becker
ef5b160fdd fix for PHP Warning: Illegal string offset 'to_id' in api/src/Etemplate/Widget/Link.php on line 327 2016-08-29 13:50:13 +02:00
Ralf Becker
c474df28fb fix Scrutinizer bug: Api\Etemplate\Exception does not exist (missing \Exception) and remove old non-static stuff from Api\Etemplate\Widget::setElementAttribute(), as $this is allways unset for methods declared static 2016-08-28 12:51:19 +02:00
Ralf Becker
54bfaeb988 fix Scrutinizer docu bug: Api\Etemplate\Request\Files::__construct($id) $id is not array but string|null 2016-08-28 12:51:19 +02:00
Ralf Becker
8d2d4ef3dd fix Scrutinizer docu bug: Api\Etemplate\Request\Files::__construct($id) $id is not array but string|null 2016-08-28 12:51:19 +02:00
nathangray
73dbaa0dfb Preserve link order set by application 2016-08-17 10:52:45 -06:00
Ralf Becker
94bc949cfa * All apps: symlink files to not yet saved entries were not working 2016-08-17 16:05:26 +02:00
Ralf Becker
a8e1980a15 * Addresssbook: fixed category tree looses unavailable categories (eg. private categories of other users) 2016-08-15 18:22:38 +02:00
Ralf Becker
780d35c096 add not yet detected unicode in name-part of email, like "zero width space" 2016-08-12 11:22:56 +02:00
Ralf Becker
4315999573 use Etemplate\Widget::registerWidget, not some third class extended from Etemplate\Widget, as that might screw up autoloading if it happes to create a circle 2016-08-09 10:11:29 +02:00
nathangray
3b1ce04608 Avoid a Illegal string offset warning from link-entry widgets when they have only-app attribute set
Happened on infologs added from projectmanager element list
2016-07-21 12:51:32 -06:00
Ralf Becker
22b62aa168 fix Scrutinizer "bugs" 2016-07-02 11:57:26 +02:00
Ralf Becker
903b14f45d fix some scrutinizer "bugs" 2016-06-26 19:44:53 +02:00
Hadi Nategh
93217a149d jQuery libraries updates via composer 2016-06-06 17:38:20 +02:00
nathangray
366c6aabf5 Update participating contacts in addressbook list when an event changes 2016-05-25 17:28:59 -06:00
Ralf Becker
5be1075f26 move empty.html used for autocomplete to api/templates/default/, as $app/src/ will not be available for direct requests 2016-05-14 12:38:31 +02:00
Nathan Gray
e38fa525ef Unset empty filter arrays, not set them to null 2016-05-11 19:40:49 +00:00
Ralf Becker
e34fe9a4e7 using Acl::(ADD|READ|EDIT|DELETE|PRIVAT) constants instead old EGW_ACL_* defines and fix some namespace errors found by doc/check_namespace.php 2016-05-11 19:23:14 +00:00
Ralf Becker
e87cbc4832 use static Hooks methods 2016-05-11 18:58:10 +00:00
Nathan Gray
457e05d920 Change filterheaders to extend taglist instead of select 2016-05-09 19:17:04 +00:00
Ralf Becker
251de1dc54 move category images to api, fixes PHP Fatal in admin_categories, if phpgwapi is not installed 2016-05-09 10:05:57 +00:00
Ralf Becker
72404a1e29 using new api for mail app 2016-05-03 19:17:44 +00:00
Ralf Becker
e5d6f6a909 fix calendar preferences to show start- and end-time of day 2016-05-03 13:24:21 +00:00
Ralf Becker
834cc466f5 to allow installing api or EGroupware without phpgwapi, old exceptions which we have to extend in order allow old apps to catch exceptions thrown from new api, have to reside in api/inc and get autoloaded 2016-05-02 16:57:50 +00:00
Ralf Becker
22fa4e70bc moving to stray css includes into etemplate2.css, so they also get minified and loaded in one go 2016-04-29 13:43:50 +00:00
Ralf Becker
b6403e336e move common::get_tpl_dir to Api\Framework\Template::get_dir, and replaced some other overlooked methods 2016-04-27 19:11:41 +00:00
Ralf Becker
88ecdf19db check type in all cases to specified eg. select-app was as widget-type was not understood 2016-04-25 19:21:46 +00:00
Ralf Becker
9a57fbaedd fix server-side validation to allow values of option children 2016-04-21 14:51:40 +00:00
Ralf Becker
8c87cf9dfc move egw_framework to api and refactor it 2016-04-07 20:42:06 +00:00
Ralf Becker
2e3bd32721 moving all - non ancient ;-) - js files to api/js 2016-04-07 10:38:05 +00:00
Ralf Becker
4835611da4 remember newly set options from get_rows method for server-side validation of nextmatch filters 2016-04-05 12:56:10 +00:00
Ralf Becker
f838eb0f01 move country class to api, made all methods static and update country list with current (lowercase) ISO 3166 list 2016-03-31 19:41:39 +00:00
Ralf Becker
2bd9c7c7e5 fix some wrong case usages of new Api\Html class 2016-03-29 09:13:46 +00:00
Ralf Becker
47eca40f25 remove no longer required use common 2016-03-29 06:43:18 +00:00
Nathan Gray
63a69c03cd Move gantt widget into projectmanager 2016-03-22 21:33:58 +00:00
Ralf Becker
3f3973af51 only scanning widget directory, not parent 2016-03-22 10:21:13 +00:00
Ralf Becker
9c0cd79425 missing propset svn:keywords Id 2016-03-22 09:10:08 +00:00
Ralf Becker
066257ff30 fix PHP Fatal error: Call to a member function read() on null in etemplate/inc/class.contact_widget.inc.php, private var must be only protected 2016-03-22 08:56:55 +00:00
Ralf Becker
77c5102792 fixed more namespace issues found by doc/check_namespace.php I wrote and forgot about it ;-) 2016-03-21 21:21:40 +00:00
Nathan Gray
847abfb198 - Fix some namespace issues breaking custom filter header
- Fix some copy+paste errors
2016-03-21 20:36:12 +00:00
Nathan Gray
e214a7153c Break out Nextmatch sub-widgets into their own files, and make sure sub widgets can get autoloaded. 2016-03-21 18:40:43 +00:00
Nathan Gray
9905a3f6bd Cache widget registry for an hour.
Fixes historylog not loading entries.
2016-03-21 17:08:17 +00:00
Nathan Gray
2935c25eed Add missing use egw_framework 2016-03-21 16:06:26 +00:00
Ralf Becker
1b5429f0ff replacing common::egw_exit() with exit, there is no more extra cleanup 2016-03-20 16:30:01 +00:00
Ralf Becker
485416d5f1 replace create_function with performanter, because opcachable closure 2016-03-20 14:01:29 +00:00
Ralf Becker
4da844a70f move categories class to api 2016-03-20 13:41:33 +00:00
Ralf Becker
52a7f2198a move egw_json_(request|response|push) to api 2016-03-20 13:02:55 +00:00
Ralf Becker
31b4e66690 fix not working changing of preferences, caused by missing reference operator in expand_widget 2016-03-20 11:14:06 +00:00
Ralf Becker
7968afc67d add missing docu of parameter 2016-03-20 10:59:59 +00:00
Ralf Becker
59ffb2497b add missing use common 2016-03-19 17:05:59 +00:00
Ralf Becker
df7d8c414a modified client-side to call new server-side classes in api, instead compatibility classes in etemplate 2016-03-19 16:16:59 +00:00
Ralf Becker
6af1e23b66 move et2 widget browser to api, thought link to it is currently only in old eTemplate sidebox menu 2016-03-19 15:25:32 +00:00
Ralf Becker
2f4c727f9d moving eT2 server-side to api 2016-03-19 13:06:07 +00:00