nathangray
c319478816
Fix readonly shares were mounted as writable when shared to another user
2021-02-16 16:14:32 -07:00
nathangray
4b6551c5a3
- Fix missing quote when updating shares with VFS changes
...
- Fix user delete entry search for single user
2021-02-16 11:53:32 -07:00
nathangray
316adfab5e
Fix some bugs in hidden uploads
...
- Creating the share couldn't handle sqlfs://user@path style paths
- UI namespace issues
2020-10-21 09:13:37 -06:00
nathangray
5bf4d4866f
WIP on sharing prompt to ask about mounting new share
2020-10-20 16:47:26 -06:00
Ralf Becker
7c9e1c98ec
fix umount to deal with user-specific mounts too
2020-10-20 20:16:57 +02:00
Ralf Becker
9eae0333ad
allow for user specific mounts
2020-10-20 20:13:36 +02:00
Ralf Becker
4886583cc1
change sharing to allow mounting shared into existing user sessions
...
without the need to destroy the session, if the sharee is a different user
This is accomplished by keeping the sharee in the stream context / attribute of the vfs class(es) instead of static Vfs::$user.
Later is still used for the current user - identical to egw_info[user][account_id].
This commit / merge of the vfs-context feature branch also added the abilty to mount WebDAV sources, eg. a sharing link from an other EGroupware instance
or any WebDAV server
2020-10-08 11:24:34 +02:00
nathangray
94a57d6902
Api: Some tests for filesystem
2020-09-16 11:48:40 -06:00
nathangray
372eadcff3
Api: Fix fstab overlap when accessing a share while logged in
2020-09-10 11:11:39 -06:00
Hadi Nategh
50a34d9c42
Make sure path is not empty before using it, fixes error "an error happened! File '' is not an absolute path!"
2020-08-14 11:06:06 +02:00
nathangray
0fdd8f87cb
Api: Fix out of memory error when deleting users and filesystem is large
...
Fixed by not deleting the files, just changing owner
2020-04-28 14:16:09 -06:00
nathangray
a3c6eba952
Fix sharing of of a file inside a symlinked directory failed.
2020-04-14 11:19:12 -06:00
nathangray
fb4e6c0dfe
Some improvements to sharing when multiple shares are involved
2020-04-03 16:20:47 -06:00
Ralf Becker
d830e048e4
loading filemanager translations for sharing
2020-04-01 10:46:32 +02:00
nathangray
c937f50193
Make sure share cleanup job doesn't remove shares just because of access rights
2020-03-30 09:35:59 -06:00
nathangray
d3eb2d9b22
Change the hidden upload message
2020-03-27 13:40:48 -06:00
nathangray
93a7166710
Add hidden upload directory as mail action
2020-03-26 13:20:20 -06:00
Ralf Becker
aa566e12fa
translation for "Hidden uploads" and move it between readonly and writable shares
2020-03-26 10:38:34 +01:00
nathangray
895b1ebee9
Cleanup, bugfix & refactoring of hidden upload folder.
2020-03-25 11:39:40 -06:00
nathangray
7163acfe1d
* Add action to share filemanager folder (readonly) with hidden upload folder
2020-03-24 20:34:04 -06:00
nathangray
a7593b2f83
Add some comment so we know what's going on
2020-03-19 10:41:45 -06:00
nathangray
173b695cf2
Api: Sharing listens to Vfs hooks to stay up-to-date with deleted or renamed files
2020-03-06 14:48:26 -07:00
Ralf Becker
4fe466f4f9
deals with some rows share_path have "vfs://default" prefix, some are just path
2020-03-06 15:08:34 +01:00
nathangray
9b2e6b5012
Api: Fix Sharing missing temp file cleanup
2020-03-05 15:03:34 -07:00
Ralf Becker
7283d33a93
fold Apache error.log and ignored PHP syntax errors, plus remove some warnings
2020-03-05 11:53:26 +01:00
nathangray
8b503dbae3
Admin: change delete user filemanager hook to move home dir, but only search /home for other files
...
- Translation from Birgit
2019-11-19 10:19:04 -07:00
Ralf Becker
93b1c7f1ab
fix namespace issues
2019-11-19 14:02:37 +02:00
Ralf Becker
7cd4169768
* all apps: fixing serveral cases of wrong Url when proxying and terminating TLS on the proxy
2019-11-15 13:54:34 +01:00
nathangray
d8faef3503
Admin: Extend Vfs::deleteAccount hook to all the files it can find, not just home dir.
2019-11-07 13:46:14 -07:00
nathangray
56989f338b
Remove duplicate method
2019-10-08 14:44:35 -06:00
nathangray
4e339a62a4
Filemanager: Fix shared directory could not open odp (or other non-odt files) in Collabora
...
Also fix "Permission denied" error trying to open office files without Collabora
2019-09-18 11:54:08 -06:00
nathangray
58c53efd49
Api - When doing monthly share cleanup, check to see if share target is still valid
...
- removed some duplicated code
2019-07-18 15:25:28 -06:00
nathangray
87c4f0ff9c
Filemanager - Add some actions for merge-print shares into email templates
2019-07-16 13:44:20 -06:00
Ralf Becker
1c9dc97afa
fix undefined variable
2019-04-28 11:16:44 +02:00
nathangray
49008fd529
Support sharing from filemanager as an app, treating it as VFS
2019-04-05 09:34:47 -06:00
Ralf Becker
4b5379d61b
* Filemanager/WebDAV: handle url-special chars like %, # and ? correctly
2019-03-21 12:36:25 +01:00
nathangray
3dd671ad8d
Changes to support accessing Samba shares with Collabora
2019-01-31 14:42:37 -07:00
nathangray
91fffd045e
* Api - Fix linking into new entries fails with SQL error
2019-01-21 11:22:21 -07:00
Ralf Becker
4b73aee7c8
* All apps: fix linking of filemanager files to entries, if there is no file yet
2019-01-16 18:41:58 +01:00
Ralf Becker
1d826e798a
fix SQLSTATE[42000]: Syntax error or access violation in filemanager
...
caused by not correctly quoted empty string instead of id in extended ACL
2018-10-19 13:46:06 +02:00
Ralf Becker
adee0b4c52
fix warning about unknown option 'ro' by filesystem streamwrapper
...
it is handled by vfs, so ignoring it here
2018-10-18 11:13:04 +02:00
Ralf Becker
58703cbaba
* Filemanager/SMB: fix directory creation failed on Samba (smbclient PHP extension)
...
smbclient treats every non-zero value of $options parameter as recursive, not just &1 and we have by default &8 = STREAM_REPORT_ERRORS set.
2018-09-06 12:04:18 +02:00
Hadi Nategh
17cfcf1168
Replace basename with Vfs::basename to avoid setlocale issue.
2018-08-01 10:02:16 +02:00
nathangray
17ba77d369
Make sure we get correct path when sharing from a share
2018-07-30 12:55:23 -06:00
nathangray
0098f41a12
Fix missing collabora app
2018-07-26 15:08:32 -06:00
Hadi Nategh
7413b60ecf
Do not add edit setting action when we are in sharing view
2018-07-26 14:10:53 +02:00
nathangray
8092e1fb86
Set current app to filemanager so js loads correctly
2018-07-18 12:27:27 -06:00
nathangray
ca32d0bc50
Remove unreachable code
2018-06-05 14:59:05 -06:00
nathangray
d0a50d8d45
Changes needed to just get the screenshots, much more work needed for proper functionallity since I faked the permissions
2018-06-05 14:31:04 -06:00
nathangray
8030c477c9
Avoid warning about scheme already registered
2018-05-11 11:25:02 -06:00
nathangray
0dea93ac15
Api - Editing files in shared directories & sharing editable links
2018-05-07 10:40:12 -06:00
nathangray
0d52cc293b
Throw an exception (that phpunit can catch) rather than exiting on failure so all tests can get
2018-05-03 10:59:22 -06:00
Ralf Becker
81143a0624
* All apps: fixed moving attachments to new entries (without attachments) lost moved file
2018-04-12 15:10:05 +02:00
Ralf Becker
5b93dd160c
fixing not working links stream-wrapper
2018-04-10 08:54:32 +02:00
nathangray
f26b271067
Exclude symlinks from Vfs
2018-04-09 14:02:24 -06:00
nathangray
abc1ccc8f1
Trying to share a symlink actually uses the link target instead
2018-04-09 14:02:24 -06:00
Ralf Becker
98c7a7af64
fix Scrutinizer issue (seems to be some left over old code)
2018-04-09 16:32:00 +02:00
Ralf Becker
98376b5908
* PHP 7.2: fix several PHP Fatal errors and warnings stalling installation and usage
2018-04-09 16:02:00 +02:00
nathangray
0a7f81a2e2
Api - Sharing from filesystem:// mounts - with tests even
2018-03-23 13:01:43 -06:00
Ralf Becker
74746a14ef
* Sharing/Collabora: fix not working cleanup of temp. files and shares
...
- 14.x installs had the job created with old class-name egw_sharing
- Wopi shares where never cleaned up, they are now after 3 month
2018-03-22 13:09:59 +01:00
Ralf Becker
1d835928d2
new method Api\Framework::getUrl() to get a full / externally usable Url
2018-03-21 12:51:52 +01:00
Ralf Becker
21e123ef84
do NOT use hostname configured in setup, if it is the default localhost
...
stick with HTTP Host header in that case
2018-03-21 12:49:31 +01:00
Hadi Nategh
045436609d
Get Sharing + Collabora into latest 17.1 version
2018-03-21 12:43:25 +01:00
Hadi Nategh
be4dbc37ae
* Fix opening collabora fails from a shared directory:
...
-we need to have collabora app to avoid CSP error since redirect share-link in collabora should get frame-src. e.g:(Collabora/Src/Ui.php:redirect(Sharing::share2link))
2018-03-16 13:15:45 +01:00
nathangray
3185acb7b1
Add merge into the list to get /apps working again
2018-03-15 16:55:43 -06:00
nathangray
6be5b8f678
Fix editing a file through gave not found error if the symlink was in a versioned directory
2018-03-15 16:55:43 -06:00
Hadi Nategh
65b2588d65
Add missing negation from commit 600872a4bf
2018-03-15 12:24:19 +01:00
Hadi Nategh
600872a4bf
An attempt to fix broken collabora sharing which originally got broken by commit f166fbdd46
in order to get mounted template sharing fixed.
2018-03-14 18:58:30 +01:00
nathangray
357e5a3326
Re-init static streamwrapper, as some of them look at permissions or preferences
2018-03-12 13:51:04 -06:00
nathangray
223b55d631
Api - Allow sharing to use Collabora to open files instead of downloading
2018-03-07 11:29:00 -07:00
Hadi Nategh
dca72ebd9c
Fix broken sharing caused by commit 89a8e6f448
2018-03-05 11:13:54 +01:00
nathangray
89a8e6f448
Place check on session first to avoid errors if it's missing
2018-02-15 09:19:26 -07:00
nathangray
f166fbdd46
* Api - Fix sharing from mounted shares failed with 404
2018-02-13 15:10:34 -07:00
Hadi Nategh
5e94600677
*Mail: Fix sharing of attached files as download links in compose dialog exposes all folders as readonly shares
2018-01-17 16:32:21 +01:00
Hadi Nategh
9b639b1fe0
Fix collabora can not open vfs symlinks from apps
2017-12-13 10:10:04 +01:00
Ralf Becker
2cec97a6c5
replace from PostgreSQL not understood && with standard AND
2017-12-07 17:28:00 +08:00
Ralf Becker
4a13fb4c21
* All apps/PostgreSQL: fix SQL error when deleting an entry without attachments
2017-12-07 17:16:46 +08:00
Ralf Becker
93353a55c0
* Filemanager/PostgreSQL: cant open file in Collabora because of SQL error
...
Syntax error: 7 ERROR: syntax error at or near "=“, PostgreSQL needs true/false not 1/0
2017-12-07 16:45:01 +08:00
Hadi Nategh
1f998f1612
Fix attempting to open a document link in infolog pops collabora link even the user has no permission to the collabora app
2017-11-16 16:31:22 +01:00
Ralf Becker
ff3ae9815d
never invalidate session in sharing, as we cant regenerate it (and we dont need to)
2017-11-07 13:02:39 +01:00
nathangray
dda47ca863
Disable extended ACL for readonly shares
2017-11-03 10:28:27 -06:00
Ralf Becker
4ebf79d0e1
* Sharing/Collabora: allow to use Collabora on writable shares (EPL only)
2017-11-03 12:43:09 +01:00
nathangray
069d49afba
Disable copy / paste for readonly shares
2017-11-02 09:43:08 -06:00
Ralf Becker
3689b3d645
* Filemanager/Sharing: deny rename, move, mkdir and rmdir on readonly share
2017-11-02 13:34:10 +01:00
Ralf Becker
0813403b5b
* All apps: get sharing working with files attached to application entries
2017-10-31 10:51:59 +01:00
nathangray
616c11c1fb
Fix wrong table name
2017-10-27 17:48:42 +02:00
nathangray
0d14155472
Fix minimum fs_id was not returning proper value
2017-10-27 17:43:40 +02:00
nathangray
90ce0cc7b6
Add a function to get the lowest fs_id for a path
2017-10-27 17:43:40 +02:00
Ralf Becker
c886d567f9
share token could still contain "+", which Vfs::encodePathComponent was not encoding
...
fixes some files not opening in Collabora
2017-08-30 18:16:15 +02:00
nathangray
ef6eb77991
Use static to get token so children can override it
2017-06-30 09:47:21 -06:00
Ralf Becker
69456307e4
fix at PHP 7.0 not working migrating vfs from db to filesystem (filemanager/cli.php migrate-db2fs)
...
migration loops forever, after migrating all files, as it does not detect no more files to migrate
2017-06-21 10:02:29 +02:00
Ralf Becker
4b379776b3
fix at PHP 7.0 not working migrating vfs from db to filesystem (filemanager/cli.php migrate-db2fs)
...
can not unset variable bind to column, as it looses its bind
2017-06-21 09:42:46 +02:00
Ralf Becker
f7a9c253a9
fix SQL error when migrating vfs from db to filesystem (filemanager/cli.php migrate-db2fs)
2017-06-21 09:04:44 +02:00
Hadi Nategh
a74d3db798
Try to create home directory if it's not exist. Fix file upload to compose dialog fails if user has no run access to filemanager and has no home folder set
2017-05-16 16:51:35 +02:00
Ralf Becker
da58ef5769
* Filemanager/PostgreSQL: shared files were not cleaned up after expiring of 100 days not accessed under PostgreSQL
2017-01-23 15:23:11 +01:00
Ralf Becker
ad059b81e7
add missing traversable-test mentioned by Scrutinizer
2016-10-20 10:17:20 +02:00
Ralf Becker
2fbafeaa27
add missing false-test mentioned by Scrutinizer
2016-10-20 09:50:57 +02:00
Ralf Becker
ae712ff8a1
* Filemanager: break infinit recursion stalling eg. login by introducing max. sub-directory depth of 100
...
Detects infinit recursion caused eg. by fs_dir pointing to a child-directory.
No idea how to efficently test for that, without scanning all parents of all filesystme nodes.
2016-10-19 15:52:02 +02:00
Ralf Becker
d4ce9fce91
enhance filesystem check to also check fs_id of required nodes /, /home, /apps
2016-08-31 19:03:48 +02:00
Ralf Becker
4cd0d35ff7
possible fix for deactivated / or /apps
2016-08-29 17:14:48 +02:00