Commit Graph

3012 Commits

Author SHA1 Message Date
Ralf Becker
2321b218c9 Changelog for 20.1.20200901 2020-09-01 20:49:32 +02:00
nathangray
dbe55e4218 Etemplate: Row count does not depend on data.class 2020-09-01 20:43:14 +02:00
nathangray
a14076a6f1 Etemplate: Fix another bug in refresh / add / update
This one was found in Infolog, adding a sub to an entry with the show-subs preference set to only while filtering.  The row count would be off by one if the new entry did not match the filter.
2020-09-01 20:43:14 +02:00
nathangray
2341ecd7d3 Api: Handle refreshing multiple UIDs but not getting them all back.
Previously we were assuming only 1 was requested, now properly handling multiple UIDs in a single request and not all of them being returned (eg ACL or doesn't match filters)
2020-09-01 20:43:14 +02:00
Ralf Becker
b71554ab4c * PostgreSQL: fix SQL error opening ProjectManager
caused by exploding SQL expression by comma --> keep colums as array, to not have the need to explode it
2020-09-01 10:26:35 +02:00
nathangray
939816c60e Etemplate: Avoid trying to repaint datagrid while it's hidden
Avoids an infinite(?) loop and endless "[Violation] 'setTimeout' handler took <N>ms" messages
2020-08-31 15:17:36 -06:00
nathangray
ccaf269751 Remove workaround, fix 3 second refresh 2020-08-31 11:25:54 -06:00
nathangray
350f375f93 Partially revert 26a6749 as it's been handled elsewhere
(030dafc0a7c9bdc6677afe87fa69615068acb4c0,d525347275a2268ed9624d35ddbd4e43a345179d)
2020-08-31 11:25:47 -06:00
nathangray
087b198ba9 Etemplate: Don't try to delete row if it's not in the nextmatch 2020-08-31 11:25:28 -06:00
nathangray
2ea088fb26 Fix nm displayed row count was not updated when adding a row.
This seems to have resolved the issue of the last row going missing.
2020-08-31 11:25:14 -06:00
nathangray
a485301dd9 Etemplate: Fix some nm / push bugs
- Handling for sub-grids
- Fix some index issues in selectionMgr causing rows to jump around
2020-08-31 11:25:05 -06:00
nathangray
eb5468e837 Add debug function to log selected nextmatch internals
Example usage:
etemplate2.getByApplication('addressbook')[0].widgetContainer.getDOMWidgetById('nm').spillYourGuts()
2020-08-31 11:24:57 -06:00
Hadi Nategh
5f81624e7f Avoid getting exceptions when user has no access to status app but getting notified by broadcast message 2020-08-25 13:23:06 +02:00
Hadi Nategh
706a7cd31d Fix set column not working because of using wrong constant variable 2020-08-20 16:48:20 +02:00
Hadi Nategh
5545247141 * All Apps: fix print list column selection does not contain customfields 2020-08-20 16:19:43 +02:00
Hadi Nategh
eb53daab31 Make commit 26a6749b3d condition available only for refresh add 2020-08-20 16:19:34 +02:00
Hadi Nategh
71b385a806 * All apps: fix drag and drop a file from FireFox download list not working 2020-08-19 08:54:34 +02:00
Ralf Becker
d3f01ccb61 Changelog for 20.1.20200818 2020-08-18 14:58:09 +02:00
Hadi Nategh
c919f4b27d Fix radiobox widget calling onchange event infinitely 2020-08-18 13:22:09 +02:00
Ralf Becker
cf83de93fc * All apps: fix last rows was removed when adding new entry to list with only a couple of rows
see ticket #48204, we do a full refresh now to work around this issue until we have a real fix
2020-08-17 12:16:20 +02:00
Ralf Becker
f3326a3cc8 fix sometimes not deleted infologs ("0 selected"), because global var got deleted, using now a closure as for the action 2020-08-16 11:22:45 +02:00
Ralf Becker
01335f787d * Calendar/CalDAV: config to replace email-domain eg. for a migration 2020-08-14 18:04:24 +02:00
Hadi Nategh
c279290b01 Fix clear button in search widget disappears after being reloaded 2020-08-14 13:38:29 +02:00
Hadi Nategh
3755c1079a Make sure path is not empty before using it, fixes error "an error happened! File '' is not an absolute path!" 2020-08-14 11:56:28 +02:00
Ralf Becker
cc5fbcfdc1 * Mail: fix not shown folder tree for some Cyrus servers
since 20.1 uses Horde_Imap_Client::MBOX_ALL_SUBSCRIBED to query subscribed and unsubscribed folders in one command
2020-08-13 18:53:10 +02:00
Hadi Nategh
41e22de9d4 * File Sharing: fix broken file sharing dialog 2020-08-13 14:37:14 +02:00
Ralf Becker
1cf0266aca Changelog for 20.1.20200812 2020-08-12 12:38:07 +02:00
Hadi Nategh
3b0a1bef0b A temporary fix for commit 471741ce12 which breaks nm row update with auto refresh enabled 2020-08-12 12:24:37 +02:00
Hadi Nategh
7756357756 Fix nm filter onchange no longer sending expected nm widget 2020-08-11 16:14:32 +02:00
Ralf Becker
904e1c8169 Changelog for 20.1.20200810 2020-08-10 13:45:13 +02:00
nathangray
382de156cf Home using non-global EgwApp instances for portlets 2020-08-09 19:31:42 +02:00
nathangray
8f769a9550 Fix removing a nm row did not re-index
This caused duplications or holes depending on what you did before or after
2020-08-09 18:59:57 +02:00
nathangray
7752fe03de Fix some nextmatch bugs
- Removed rows could still have jQuery actions bound, resulting in errors
- Focused row was not cleared if it was removed, resulting in errors
- Fixed double get_rows call on refresh(..., update)
2020-08-09 18:50:19 +02:00
nathangray
ee472bb5a9 Change addressbook group / template on client side, not server side
Fixes the issue where the nextmatch_controller is part of the context for the request, but the first thing set_template() does when the server tells the nextmatch to change the template is destroy the controller.  This means that when the data is parsed, the context is missing or damaged.
2020-08-09 18:50:19 +02:00
nathangray
20cd1cf802 Etemplate: Change how nextmatch handles update & refresh push messages 2020-08-09 18:50:19 +02:00
nathangray
ece51a1d12 Fix CRM view did not add new infolog entries on push 2020-08-09 18:50:19 +02:00
nathangray
a562867671 Etemplate: Add et2_nextmatch.set_disable_autorefresh() to change it dynamically 2020-08-09 18:50:19 +02:00
nathangray
0b804bc507 Etemplate: add disable_autorefresh attribute to nextmatch to be able to disable autorefresh 2020-08-09 18:50:19 +02:00
nathangray
a8f3938713 Etemplate: Fix et2_selectAccount legacy options were not set 2020-08-07 08:58:06 -06:00
Hadi Nategh
18289ecd9d Do not show close button on success message and dismiss it on container click handler 2020-08-07 13:31:22 +02:00
Hadi Nategh
16844dced7 Do not show edit button on taglist single mode 2020-08-07 12:09:35 +02:00
nathangray
b351825427 Fix update was doing full refresh, changed back to previous behaviour
Left 'update-in-place', as discussed, as it's way more clear what it does.
2020-08-06 13:34:58 -06:00
Hadi Nategh
2a948825d3 Add missing compiled js file from commit 13ed300c9c 2020-08-06 10:39:48 +02:00
nathangray
1230a4eb6e * Etemplate: Fix entry widget had wrong ID, so was missing value
Typescript conversion error
2020-08-05 11:56:23 -06:00
Ralf Becker
5a5575ace2 improve fix not updated number of nextmatch rows on push type "delete" 2020-08-05 18:49:03 +02:00
Ralf Becker
0c1b92f029 fix not updated number of nextmatch rows on push type "delete" 2020-08-05 18:27:09 +02:00
Hadi Nategh
7b6b72ea6b Fix errors happening in mobile framework 2020-08-03 15:48:34 +02:00
Hadi Nategh
9a7dc47f7f Add translations 2020-08-03 11:05:13 +02:00
Ralf Becker
67af309c33 * Tracker/Notifications: send mail after response to user and push errors 2020-08-01 15:10:35 +02:00
Ralf Becker
20250bbc04 * Notifications: taking push server into account for checking user is online for popup or email notifications 2020-07-31 17:50:48 +02:00
Ralf Becker
26be32f33e fix SQL error in ranking caused by automatic added ambigous column which app code had already aliased "$table.$col AS $col" 2020-07-31 13:39:53 +02:00
Ralf Becker
d46a65306d Changelog for 20.1.20200731 2020-07-31 10:50:07 +02:00
Ralf Becker
c4bb5c3caf * Preferences: use push to ask every affected client to reload preferences, if affected 2020-07-31 09:49:29 +02:00
nathangray
09ac3d918b Etemplate: Password suggest now works if started disabled then enabled via JS 2020-07-30 21:57:45 +02:00
nathangray
d0f02afc28 Try to fix up password with respect to autofill 2020-07-30 09:23:36 -10:00
nathangray
c1bb4e8da2 Etemplate: Fix password widget did not disable suggest dynamically 2020-07-30 09:22:37 -10:00
Hadi Nategh
e120bdb189 Return an object for egw message in order to have access to it after display 2020-07-30 15:29:45 +02:00
nathangray
370fd63088 Etemplate: Update controller indexMap when adding a new row
Fixes deleting former top mail that got moved down by a pushed new mail removed both newly added and the selected mail
2020-07-30 10:03:53 +02:00
Ralf Becker
732582305b * Calendar: fix not working refresh via push, if Home app is used
Current fix only makes sure global app.calendar created by home get completly destroyed (and newly created by calendar itself), and not just unregistered from the push
We probably want to modify home to create private app objects for its portlets
2020-07-29 18:26:29 +02:00
Hadi Nategh
8f13e3516d Do not include egw message in print 2020-07-29 15:47:34 +02:00
Ralf Becker
35edb2b49e * Mail: replying to a mail should only update icon, not move it to top of list 2020-07-29 13:59:42 +02:00
Hadi Nategh
31e5ecade3 Fix notifications stalling login 2020-07-29 12:59:21 +02:00
Ralf Becker
5c2920f1c0 Changelog for 20.1.20200728 2020-07-28 11:50:08 +02:00
nathangray
20ae4b426d Etemplate: nm.refresh() with type 'edit' no longer always fully reloads all rows, it now behaves the same as 'update' 2020-07-28 08:02:48 +02:00
nathangray
afae9caeea Etemplate: Fix isDirty() was always false for multi-select (tracker selection) 2020-07-28 08:02:39 +02:00
Ralf Becker
7887e3098e * Login: updated update background image with 20.1 highlights 2020-07-28 08:00:41 +02:00
nathangray
a01a635d5b Calendar exception no longer needed 2020-07-27 21:03:38 +02:00
Ralf Becker
3a8554c266 explicit call Egw::__destruct() to fix calendar notifications not send, if dialog is Saved not Applied 2020-07-27 16:09:21 +02:00
Hadi Nategh
88134e94f6 Implement popup notifications filter based on tab notification's indicator 2020-07-27 15:29:16 +02:00
Ralf Becker
a01cd94966 * Security: allow to configure SameSite cookie attribute 2020-07-27 14:04:20 +02:00
Ralf Becker
3957a94e47 calendar non-list views need refresh calls, even using push 2020-07-27 09:46:07 +02:00
Ralf Becker
ee02ff18ed fix broken token/syntax, if no metadata yet 2020-07-24 18:15:11 +02:00
Ralf Becker
e8c2c1bbc7 fix broken token/syntax, if no metadata yet 2020-07-24 18:15:11 +02:00
Hadi Nategh
7900bfd9cd Avoid outputting same message multiple times if it's still alive 2020-07-24 12:46:29 +02:00
Hadi Nategh
ae0349487d Change tab notification indicator 2020-07-24 11:32:52 +02:00
Ralf Becker
8bb9111cd5 fix double message in popup and none in main window 2020-07-24 09:23:44 +02:00
Ralf Becker
b60a9ffff4 add check if only fallback push and skip full refresh (Framework::refresh_opener) for push and supporting apps 2020-07-24 09:07:13 +02:00
nathangray
b6e47f9b11 Etemplate: Password widget now auto-updates the second 'confirm' password if you have two and suggest a password. 2020-07-23 13:56:14 -06:00
nathangray
6d2af76576 * Infolog: Push updates 2020-07-23 13:34:08 -06:00
Ralf Becker
efaf9771d0 do NOT push participants of type email for privacy reasons 2020-07-23 19:06:08 +02:00
Hadi Nategh
0cea328928 Only set notification tab for none active tabs 2020-07-23 17:39:39 +02:00
Ralf Becker
0f799acd75 fix multiple accounts could not subscribe for push on the same mailbox 2020-07-23 16:56:45 +02:00
Hadi Nategh
1815b1e985 Implement framework tab's notification 2020-07-23 15:50:15 +02:00
Ralf Becker
cf06054fd7 move configuration of imap servers supporting push to mail site config and stadard imap server 2020-07-23 14:17:32 +02:00
Hadi Nategh
0ce38aa260 Fix social media icons for jdots login page 2020-07-23 10:27:36 +02:00
Ralf Becker
9d7ae4b4b0 * jDots: fix login page 2020-07-23 10:05:17 +02:00
nathangray
3e9794e526 Etemplate: Do not bother to resize hidden etemplates
Fixes Admin > App > Site config gets resized incorrectly when switching to another app's tab & back
2020-07-22 15:51:42 -06:00
Ralf Becker
0d426ae911 fix new_entry class not "allowing" to select or focus a row 2020-07-22 21:40:07 +02:00
Ralf Becker
4b9be2876e fix new mail rows appear no unseen 2020-07-22 21:32:48 +02:00
nathangray
a6688ab3f8 Etemplate: Allow app to specify a new row index for updated rows as well. 2020-07-22 12:00:01 -06:00
Ralf Becker
25f942c431 fix accidently commited host-name 2020-07-22 18:21:07 +02:00
Ralf Becker
0f8a2668fb fix token was only updated on account-change, not new login or daily token rotation, also support now multiple tokens/instances registring tokens for same account 2020-07-22 17:01:19 +02:00
Ralf Becker
32043f7a41 trigger full refresh / applyFilters, if app refresh_add returns false 2020-07-22 16:58:40 +02:00
nathangray
32b061919f Etemplate: Change default for password widget suggest to off
Customfields still default to on
2020-07-21 15:36:45 -06:00
nathangray
f0b924008b Etemplate: Add a callback so apps can decide where to put new push rows 2020-07-21 15:32:22 -06:00
Ralf Becker
8e213a7de5 set id of DOM container, in case server-side returned a different eTemplate 2020-07-21 22:05:08 +02:00
nathangray
bd6b20bae8 Fix home cannot find its portlet templates
This reverts commit ff0cdf8143.
2020-07-20 14:34:10 -06:00
nathangray
69420c19ad Api: Handle add push messages in the nextmatch list 2020-07-20 13:43:26 -06:00
Ralf Becker
bf44ee753a WIP push for mail (currently only Dovecot with further configuration!) 2020-07-20 12:09:08 +02:00
Hadi Nategh
6d9dfc6364 Fix vfs-select icons 2020-07-20 11:07:19 +02:00
Hadi Nategh
1f066dee26 Implement new egw messaging (keeps not deliberately dismissed messages) 2020-07-17 14:09:37 +02:00
nathangray
bd7b916811 Api: log on_shutdown() messages to its own log file 2020-07-16 14:54:02 -06:00
Ralf Becker
853fd72d91 Changelog for 20.1.20200716 2020-07-16 15:48:24 +02:00
Ralf Becker
ab1e59c0df register and deregister old JavaScript based app objects with new TypeScript registry to receive observer and push calls 2020-07-15 19:15:54 +02:00
Hadi Nategh
fcd7a77c44 Fixing none app static functions stopped being called relevant to commit 52eb5ca8e0 2020-07-15 11:01:34 +02:00
nathangray
3dd30b1ee1 Api: Fix multiple action confirmation 2020-07-14 14:19:53 -06:00
Hadi Nategh
90d33cd4fb Add more translations 2020-07-14 15:08:45 +02:00
Hadi Nategh
b29cce05be Fix searchbox no longer works in mobile template 2020-07-14 12:17:15 +02:00
Ralf Becker
808313c121 set grants if given for push 2020-07-13 19:26:05 +02:00
Hadi Nategh
31293807f9 Use text-indent for input and select box text indentation since padding would break 100% width 2020-07-13 16:20:15 +02:00
nathangray
31b7c49fd3 Etemplate: Avoid error if sender is not passed 2020-07-10 13:30:47 -06:00
nathangray
af4fcd7a2d Etemplate: Avoid trying to process regexes by checking for end anchor 2020-07-10 13:27:48 -06:00
nathangray
13842ffb79 * Infolog: Add filter by contact to export filters 2020-07-10 13:13:04 -06:00
nathangray
510a6419c5 Etemplate: Avoid error if file_data.mime is false for some reason
(file missing)
2020-07-10 11:11:05 -06:00
Hadi Nategh
146cba903b Add missing part from commit 4c7709d49f 2020-07-10 13:16:50 +02:00
Ralf Becker
502d423885 fix PHP Warning: substr() expects parameter 1 to be string, array given 2020-07-10 11:08:38 +02:00
nathangray
4fc02fbe20 Etemplate: Fix searchbox did not properly manage child DOM nodes 2020-07-08 14:34:50 -06:00
nathangray
9cb143d0d3 Etemplate: Prevent dialogs from destroying parent's request 2020-07-08 11:01:05 -06:00
Ralf Becker
7428e2d7cd do not add path of url to CSP 2020-07-07 13:18:28 +02:00
nathangray
ca8742e10b Etemplate: Password widget css improvements
Fixes buttons blocked by long passwords
2020-07-06 11:42:16 -06:00
Ralf Becker
34cbc6880a step attribute for number widget 2020-07-06 18:24:07 +02:00
nathangray
4c7709d49f Etemplate: Get vfsUpload values to use expose so they work like links 2020-07-03 14:23:41 -06:00
nathangray
ee498f703d Etemplate: Fix password widget could not be cleared entirely 2020-07-03 09:25:51 -06:00
nathangray
e80c118aa8 Etemplate: Replace resetDirty(), it's needed for IInput interface 2020-07-02 11:19:11 -06:00
nathangray
7278b30ff0 Actually set the default cf prefix so everything works. 2020-07-02 09:40:09 -06:00
nathangray
5958feb1c3 Etemplate: add customfield prefix as an explicit attribute, importexport filter was using it 2020-06-30 10:43:41 -06:00
Hadi Nategh
6ba8210d83 Avoid requesting external images with mixed content 2020-06-30 15:54:21 +02:00
nathangray
57d03110e4 Etemplate: If long task response is an object, stringify the object so we can see what it says 2020-06-29 14:08:02 -06:00
nathangray
b057f95a5a Close confirm improvements & fixes
- Toolbars are now always not dirty
2020-06-29 13:23:17 -06:00
nathangray
10846271f1 Close confirm improvements & fixes
- nextmatch is now always not dirty
- Logging the dirty widgets to console
- Fix searchbox did not fully doLoadingFinished()
2020-06-29 11:55:35 -06:00
nathangray
a50ede7967 Avoid errors from close confirm changes if button is not fully created. 2020-06-29 10:54:14 -06:00
Ralf Becker
8cb3b228ca Changelog for 20.1.20200628 2020-06-28 16:37:10 +02:00
Ralf Becker
27ad7772de add AGPL license for smallpart 2020-06-28 11:35:44 +02:00
Ralf Becker
361d5cb351 bump version to 20.1 2020-06-28 10:04:21 +02:00
nathangray
175c1fe369 Fix selectbox resetDirty() 2020-06-25 10:31:48 -06:00
Hadi Nategh
8863f28e37 Revert it because it has caused a weird issue regarding our nextmatch filters 2020-06-25 14:17:00 +02:00
nathangray
143be4dc98 Etemplate: Cancel buttons do not trigger the change/close prompt 2020-06-24 10:37:57 -06:00
nathangray
74284afc07 Fix htmlarea.isDirty() was using the pre-editor initialization value causing it to always be true 2020-06-24 09:58:18 -06:00
nathangray
10b2eda4ac Fix bug in isDirty() causing error for some widgets, which broke onbeforeclose 2020-06-24 09:40:35 -06:00
Ralf Becker
4959281164 fix optional SAML/Shibboleth login fails when proxying as form field with name "auth=saml" get lost 2020-06-24 08:56:13 +02:00
nathangray
03e08be0e6 Etemplate: Changing the tab doesn't count as making any data dirty 2020-06-23 13:37:31 -06:00
nathangray
f0e074093c Ralf's fix for Saml for PHP 7.2 2020-06-23 10:21:07 -06:00
Ralf Becker
08b039c4fb fix some SAML/Shibboleth problems caused by EGroupware running in container behind proxy on host 2020-06-21 08:17:00 +02:00
nathangray
52714f0a63 Etemplate: Check dirty before closing, ask if there are changes 2020-06-19 13:27:41 -06:00
Hadi Nategh
b95e9be02a Cleanup widget browser 2020-06-18 14:58:24 +02:00
Ralf Becker
7e81b733e1 fix typo in directory permissions 2020-06-18 10:48:56 +02:00
Hadi Nategh
acc7d3f01b Sidebox's triangle icon styling improvement 2020-06-17 11:06:30 +02:00
nathangray
31f20d9783 Etemplate: Fix history widget lost some widgets when converted to TypeScript 2020-06-16 10:58:03 -06:00
nathangray
b56a8f9901 Default password customfield plaintext attribute to false 2020-06-16 09:23:54 -06:00
Ralf Becker
2c489ef5b8 change default for password attribute plaintext back to true, to not break every existing usage of that widget 2020-06-16 08:37:51 +02:00