Commit Graph

3558 Commits

Author SHA1 Message Date
Ralf Becker
26a8d40c5f fix PHP 8.0 TypeError: ZipArchive::setCommentName(): Argument #2 ($comment) must be of type string, array given 2021-11-13 17:02:26 +01:00
Hadi Nategh
90597e1dea Get the link entry app selection menu working again 2021-11-11 10:28:00 +01:00
Ralf Becker
bbd048a143 try fixing an other case where an unrelated XML error was reported
Error passing XML file '<text type="text" id="#Kunde_Firma"/>' line 12: EndTag: '</' not found
There is obviously no line 12 ;)
2021-11-11 09:50:17 +01:00
Ralf Becker
cb70a57b78 quieten permanent log of search links for non-ascii project-names etc. 2021-11-11 09:11:04 +01:00
Ralf Becker
46e384198b fix PHP 8.0 TypeError: Unsupported operand types: string & int 2021-11-11 08:00:20 +01:00
nathan
6aa0366330 Maybe fix SQL error from searching contacts with private + duplicates 2021-11-10 09:53:24 -07:00
nathan
050bf162d9 Api: Fix check of disabled attribute was misbehaving if the value was null or 0
This showed up when validating tracker config, some rows were disabled with disabled="@tracker".  When tracker=0, they did not return their value.
2021-11-10 13:58:40 +01:00
Ralf Becker
4d08b1412d fix PHP 8.0 TypeError: array_merge(): Argument #2 must be of type array, null given 2021-11-10 12:47:34 +01:00
Ralf Becker
8d25c83380 fix/catch PHP 8.0 ValueError: mb_convert_encoding(): Argument #3 ($from_encoding) contains invalid encoding "cp1250" 2021-11-10 12:43:30 +01:00
Ralf Becker
aca63345ca fix PHP 8.0 TypeError: strpos(): Argument #1 ($haystack) must be of type string, array given 2021-11-10 12:16:20 +01:00
Hadi Nategh
dfdd3b918b Update jquery-ui to 1.13.1 2021-11-10 11:55:45 +01:00
Ralf Becker
5477f3d095 * LDAP/Addressbook: fix region contains for given country invalid value gives an LDAP error on update
cause by trying to write NULL, which is not allowed, unsetting the attribute the proper way now
2021-11-09 11:08:07 +01:00
Ralf Becker
3655619b43 fix PHP 8.0 problem "new" > 0 causing mail accounts created via admin for an other user to fail 2021-11-09 08:03:16 +01:00
Ralf Becker
fa67fc24d7 fix PHP 8.0 TypeError: Api\Accounts::username(): Argument #1 ($account_id) must be of type ?int, string given
new method for account link-title not throwing an error, for non-numeric arguments and therefore stalling all titles
2021-11-08 12:23:08 +01:00
Ralf Becker
9638bddaac fix PHP 8.0 TypeError: Exception::__construct(): Argument #2 ($code) must be of type int, string given 2021-11-08 11:36:49 +01:00
Ralf Becker
ff68c12773 fix PHP 8.0 TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given 2021-11-05 15:19:20 +01:00
Ralf Becker
1ad1c6e951 fix PHP 8.0 TypeError: Unsupported operand types: null + array 2021-11-05 14:50:19 +01:00
Ralf Becker
c8bab89460 fix PHP 8.0 TypeError: uasort(): Argument #1 ($array) must be of type array, null given 2021-11-05 14:37:50 +01:00
Ralf Becker
e8c352acbd fix PHP 8.0 ValueError: stripos(): Argument #3 ($offset) must be contained in argument #1 ($haystack) 2021-11-05 11:39:13 +01:00
Ralf Becker
0d8f4f624f fix PHP 8.0 error: trim expects string, array given
removed trim
2021-11-05 09:08:57 +01:00
Hadi Nategh
17e25fa1e0 Fix PHP8.0 error (TypeError): strlen(): Argument #1 ($string) must be of type string, array given 2021-11-04 17:24:56 +01:00
Hadi Nategh
fd3b61b6af Fix PHP8.0 (TypeError): explode(): Argument #2 ($string) must be of type string, array given 2021-11-04 14:32:17 +01:00
Hadi Nategh
5227425671 Fix stripos(): Argument #3 ($offset) must be contained in argument #1 ($haystack) by preventing empty html value being processed 2021-11-04 14:14:10 +01:00
Ralf Becker
ae6128d7d0 * Filemanager: fix not working variables eg. $user in GUI mount (Admin > Filemanager)
also support no user/password for sharing links
2021-11-03 14:55:21 +01:00
Hadi Nategh
8a9aad7f2c * Filemanager: Fix video controller not working in filemanager gallery 2021-11-02 17:45:17 +01:00
Ralf Becker
45437a5c9d add $depth parameter to Vfs::checkLock($url, int $depth=0) and use it to query all locks in one go for filemanager_ui::get_rows() 2021-10-29 08:48:26 -06:00
nathan
facdf2d119 API: Make sure memberships is an array to avoid other errors (PHP 8.0) 2021-10-27 13:41:48 -06:00
Ralf Becker
12c6b57ed0 fix regression reported by @asig2016 after big warning fix 2021-10-23 09:56:11 +02:00
nathan
1ecfe6fea5 Api: Fix "Unsupported operand types: array + bool" when infolog linked contact could not be read 2021-10-22 09:43:09 -06:00
Hadi Nategh
dddd0a2ee0 Fix onchange event not working for date-range widget 2021-10-22 13:27:37 +02:00
nathan
17d4c2a869 Api: Fix merge action files in subdirectories had their path as part of action caption instead of just the file name 2021-10-21 09:59:57 -06:00
nathan
3c7d18b8db Api: Change app placeholders list to use some more horizontal space, stop hiding common & user placeholders 2021-10-21 08:40:37 -06:00
Ralf Becker
efff64299c fix big chunk of PHP 8.0 warnings 2021-10-21 10:42:18 +02:00
nathan
e70060f34b Api: Fix cf sub-entry placeholder expansion was not passing content for placeholders like {{#customer/n_fn}} 2021-10-20 14:10:41 -06:00
Ralf Becker
a8cc4d3c33 closing/commiting the session to speed up calendar loading 2021-10-20 13:58:40 +02:00
nathan
eb1ed53c1a JS changes from 068e3feff0 2021-10-19 14:23:31 -06:00
nathan
dacb898218 Api: Fix setting the date min attribute to a number did not work
jQueryUI timepicker checks the type of variable
2021-10-19 14:22:55 -06:00
nathan
888fd1d61c Add missing placeholder widget JS 2021-10-19 09:47:38 -06:00
nathan
f4daa11c5b Api: Fix replacements from sub-apps (eg: infolog contact) were missing 2021-10-19 09:19:26 -06:00
Hadi Nategh
2af7775aa2 * Mail: Add set flags action into mail filters 2021-10-19 13:15:35 +02:00
Hadi Nategh
551d797cb6 * Mail: Implements date extension for vacation rule. None imap admin user can also set vacation rule by date. 2021-10-19 13:15:13 +02:00
nathan
d7de30a423 Infolog: Avoid errors adding app replacements if incorrect parameters given 2021-10-19 10:13:04 +02:00
nathan
b320f7517f Fix kanban merge into document stopped working with introduction of PDF checkbox 2021-10-19 09:48:12 +02:00
nathan
82103dd514 * Collabora: Merge placeholder dialogs
Added merge placeholder & address dialogs to Collabora.  Also some new merge preferences for target filename and location, and placeholder list UI
2021-10-14 13:18:21 -06:00
nathan
09f93f2b9d * Add filemanager actions to convert editable files to PDF or PNG and a checkbox to merge file as PDF 2021-10-14 09:18:55 -06:00
nathan
9de404da9c Fix ReflectionParameter::isArray() was deprecated as of PHP 8.0.0 2021-10-14 08:59:12 -06:00
nathan
65b0a31aeb Fix expansion broken in ddddc5ba05
Caused export field checkboxes in new definition to not keep their value
2021-10-14 08:58:49 -06:00
Hadi Nategh
894ebe2f51 PHP8: fix lots of warnings 2021-10-14 15:38:48 +02:00
Hadi Nategh
ab8a7d4c23 Remove none existing mail connectionTimeout preference. Fixes warning of Undefined array key 'connectionTimeout'. 2021-10-14 11:36:35 +02:00
Ralf Becker
60536222ce fix PHP 8.0 error forwarding mail as attachment (calling count on null) 2021-10-14 09:41:53 +02:00
Ralf Becker
ccadef611d fix PHP 8.0 error when converting an InfoLog into a ticket
Cannot access offset of type string on string
Also add line and file to our non-json exception handler, for easier identifying the problems
2021-10-14 08:08:34 +02:00
Alexandros Sigalas
fdd275c605
Tabs of tabwidget, added onClick and ondDblclick events (#109)
* Tabs of tabwidget, added onClick and ondDblclick events

* OnClick and ondDblclick events on Tabs of tabwidget, parse functions only once.
2021-10-13 08:33:37 -06:00
Hadi Nategh
2d7aed2f4b Fix error "Non-static method Merge::get_all_ids() cannot be called statically" 2021-10-12 12:57:01 +02:00
Ralf Becker
d51d0eee83 fix a bunch of PHP Warnings 2021-10-12 11:51:56 +02:00
Ralf Becker
c844a47889 fix PHP 8.0 error: Undefined constant "EGroupware\Api\Contacts\cat_id" 2021-10-11 18:41:03 +02:00
Ralf Becker
389b66bedf fix PHP Warning: Illegal string offset 'tmp_name' 2021-10-11 14:03:09 +02:00
Hadi Nategh
8feac04979
Merge pull request #108 from asig2016/21.1_toolbar
Added preference_id and preference_app attributes to toolbar widget, …
2021-10-11 10:22:46 +02:00
Ralf Becker
2e1f6a983f output line and file of exception as trace not always contain it 2021-10-09 08:43:48 +02:00
Alexandros Sigalas
a1f4922506 Added preference_id and preference_app attributes to toolbar widget, to make usage in edit forms opened in framework tabs easier. 2021-10-08 17:38:42 +03:00
Ralf Becker
f21492632b an other chunk of PHP 8.0 Warnings fixed 2021-10-08 15:44:32 +02:00
Hadi Nategh
fbfe937524 Accept mail externalImages with long url 2021-10-08 14:31:44 +02:00
Ralf Becker
867c000d99 fix Api\Accounts::username(): Argument #1 ($account_id) must be of type ?int, string given 2021-10-08 14:11:15 +02:00
Ralf Becker
7de75f16c1 fix PHP 8.0 errors around ACL dialog and policy:
- bitwise AND operator gives TypeError if both values are neither a number nor a numeric string, eg: null, "run"
- Etemplate::setElementAttribute() must NOT be called before instantiating an Etemplate object, you will get fatal error otherwise, because no request object
2021-10-08 09:06:45 +02:00
Ralf Becker
ca00987fb2 fix PHP 8.0 Fatal error: Declaration of Api\Etemplate\Request\Session::read($id = null) must be compatible with Api\Etemplate\Request::read($id = null, $handle_not_found = true) 2021-10-07 18:40:15 +02:00
Ralf Becker
7525a9b186 fix not working preferences GUI after ddddc5ba05 2021-10-07 17:28:42 +02:00
Ralf Becker
a599f9390c fix TypeError: Argument 1 passed to EGroupware\Api\Accounts::username() must be of the type int, null given 2021-10-07 16:53:54 +02:00
Ralf Becker
542192ce6e fix PHP 8.0 error Illegal string offset
folder object need to be cast to string (folder name) as objects are not allowed as array keys
2021-10-07 12:37:32 +02:00
Ralf Becker
16d02a856c fix missing icons after previous commit 2021-10-07 11:57:43 +02:00
Ralf Becker
7a93814c25 fix PHP 8.0 error when deleting a Kanban card
- link deletion failed when link_id was "" as in PHP 8.0 "" < 0 --> gave the error
- link to card was never deleted as board_id is not stored in card
2021-10-07 10:44:59 +02:00
Ralf Becker
7c40fc0981 an other chunk of fixed PHP 8.0 Warnings 2021-10-07 10:16:09 +02:00
Hadi Nategh
8c47c14b8d Fix styling in toolbar 2021-10-06 15:46:19 +02:00
Ralf Becker
9a15aad67d fix mail account creation under PHP 8.0
PHP 8.0: "new" > 0 === true
PHP<8.0: "new" > 0 === false
2021-10-06 12:32:54 +02:00
Hadi Nategh
ed86f5bfae PHP8: fix error Illegal offset typePHP, happens while moving mail from one account to another 2021-10-06 11:43:43 +02:00
Hadi Nategh
b6319bc18b Fix wrong condition on checking url strlen 2021-10-06 11:35:53 +02:00
Ralf Becker
56f60c691f next big chunk of fixed PHP 8.0 Warnings 2021-10-05 14:21:36 +02:00
Ralf Becker
29d2d7a580 fixing some conditions in the previous commit stalling InfoLog list 2021-10-05 11:35:56 +02:00
Ralf Becker
6ac401ef19 fixing a ton of PHP Warnings slowing us down in PHP 8.0 2021-10-05 11:35:56 +02:00
Ralf Becker
8084758d76 fix PHP 8.0 error: count(): Argument #1 ($value) must be of type Countable|array, string given 2021-10-04 13:05:13 +02:00
Ralf Becker
eebc939ff2 fix PHP 8.0 Warning: Argument #2 of array_merge must be of type array, boolean given 2021-10-04 11:01:53 +02:00
Ralf Becker
712786c927 improve parsing if only a fullName is given to support the following:
- Becker, Ralf --> surname: Becker, personal: Ralf
- Ralf Becker  --> surname: Becker, personal: Ralf
- Becker --> surname: Becker
2021-10-04 10:41:45 +02:00
Ralf Becker
10c35381d5 improving parsing of country data:
- if we got a country-name but no -code, look up the code
- if we got a country-name like "Name (Name2)" try both separate first
- if we have a valid country-code set the -name to be the untranslated one as our UI does
2021-10-04 09:59:16 +02:00
Ralf Becker
b90dcede90 fix parsing with no street data and of custom fields 2021-10-03 18:48:33 +02:00
Ralf Becker
73b8f6d9f6 if no separate name-components given, simply split first word off as n_given and rest as n_family 2021-10-01 18:28:57 +02:00
Ralf Becker
7e26f64e49 add an additional static method Api\Mail\Smtp::mailbox_address()
as PHP 8.0 does not allow to call a non-static method static, even if $this is (conditionally) not used
2021-09-29 10:11:47 +02:00
Hadi Nategh
643f1cf7c4 Add compiled js file from commit ae5e11f7a2 2021-09-28 17:12:45 +02:00
Hadi Nategh
39d15ccece Translate details title before setting it into the DOM 2021-09-28 17:11:46 +02:00
Ralf Becker
3e035a70a4 implement and document PATCH 2021-09-27 13:30:41 +02:00
Ralf Becker
392b8036f4 REST API allow sending a JSON patch to update or create a new contact (currently only via POST or PUT, not as PATCH!)
allows eg. to create a contact from a simple Wordpress contact-form only supporting POST requests and a flat object, see new example in the documentation
2021-09-27 13:30:41 +02:00
Ralf Becker
547a5aa605 missing @type="NameComponent" and updated examples in docu with @type 2021-09-27 13:30:41 +02:00
Ralf Becker
a463264926 Implemented @type attributes for all top-level objects from JsContact Draft 08 2021-09-27 13:30:41 +02:00
Ralf Becker
6fe8604b8b Use EGW_(USER|PASSWORD) from doc/phpunix.xml instead of hardcoded demo/guest 2021-09-27 13:30:41 +02:00
Ralf Becker
322652de95 Contacts REST API:
- implement missing PUT/POST of distribution list / CardGroups
- implement changes from next JsContact draft:
  + string plus extra localizations attribute instead of localizedString object
  + use "<domain>:<name>" for vendor attributes
- add/parse urn:uuid: prefix if UID is a UUID
2021-09-27 13:30:41 +02:00
Ralf Becker
ce5389d0d5 finished REST API for contacts modulo docu and bugs ;)
- JsCardGroup now used for distribution lists
- responses are not in "responses" attribute (no longer in root of object)
- fix sometimes empty / different members between PROPFIND/REPORT/JSON-GET and GET of group (caused by wrongly implemented limit to given AB)
- JSON pretty-print only if requested by Accept: application/pretty+json
- fix invalid JSON for errors (caused by opening {"responses": already sent
2021-09-27 13:30:41 +02:00
Ralf Becker
3bc015a90d got POST, PUT and DELETE request to add, update and delete contacts working
added JSON exception handler with nicer JsCalendar parse errors
2021-09-27 13:30:40 +02:00
Ralf Becker
655f52a876 fix excess separator, if not 2nd street-line 2021-09-27 13:30:40 +02:00
Ralf Becker
18324dfa8e WIP REST Api for contacts 2021-09-27 13:30:40 +02:00
Ralf Becker
38c07d7f69 WIP REST API for contacts using JsContacts draft 2021-09-27 13:30:40 +02:00
Ralf Becker
9babcdf010 fix PHP 8.0 error: implode(): Argument #2 ($array) must be of type ?array, string given 2021-09-24 12:30:20 +02:00
Ralf Becker
37a938f38d Changelog for 21.1.20210923 2021-09-23 15:02:29 +02:00
Hadi Nategh
5a51732752 Move framework push boradcast method into base class 2021-09-22 11:56:50 +02:00