Commit Graph

2319 Commits

Author SHA1 Message Date
nathan
e62cf4c2f7 Fix double-bound file drop handler
Fixes double-submit after dropping a second file.  Noticed in mail compose, but probably affects everywhere file widget was used to upload
2023-02-28 10:39:10 -07:00
nathan
da1b1f6999 Fix gantt chart couldn't load data
broken by 2066523.
Loading caused 'Exception "t is undefined" while handling JSON response from ....' deep inside dhtmlx-gantt
2023-02-28 09:05:49 -07:00
Hadi Nategh
057afb8623 Some styling fixes for mobile view:
- fix broken Addressbook's avatar in view and edit mode
- fix buttons with icon not getting white filter
2023-02-28 13:06:52 +01:00
nathan
86b883951a Add isReady flag to etemplate. onchange functions set as attributes in .xet files will not be called until the etemplate is finished loading. 2023-02-27 15:31:07 -07:00
nathan
0117c4bde3 Move client-side holidays cache to MODULE_GLOBAL egw.holidays(year) 2023-02-27 15:15:36 -07:00
nathan
635780d7d4 Et2LinkTo: Fix linking to existing file in VFS did not do anything
Onchange was not being set
2023-02-27 13:25:47 -07:00
ralf
a8dd625a61 register old-hbox client-side and all old-*box on server-side 2023-02-27 09:57:21 +01:00
Hadi Nategh
2dc78de2c1 Support deprecated get values method for ET2Select_ro 2023-02-27 09:56:39 +01:00
nathan
206652307b Et2Date fixes
- Fix mobile get / set value was not actually setting value properly
- Set a minimum input width
2023-02-24 11:58:16 -07:00
nathan
41cbb68de0 Et2Select: Fix extra scrollbar with rows=1, multiple, hover lots (> 8 or so) of rows 2023-02-22 16:23:56 -07:00
nathan
4311eebdc9 Et2Dialog: Fix missing button alignment 2023-02-22 14:51:21 -07:00
Hadi Nategh
24570cd438 Let sl-button-group deals with blur and focus handling for our Et2DropDownButton widget 2023-02-22 17:56:02 +01:00
nathan
f7d44c63cb Enable disabled select options 2023-02-22 09:51:57 -07:00
nathan
e532ca176b Add Et2TabsMobile that has special rendering for tabs on mobile 2023-02-21 10:31:38 -07:00
nathan
9cc1f08d63 Et2UrlEmail: Fix click to add to email button was broken 2023-02-17 08:51:27 -07:00
nathan
33ca8a47a9 Et2Select: Tweak size calculations for rows setting to work better for all font size preferences 2023-02-16 11:59:34 -07:00
Hadi Nategh
b25346c1e4 ET2Button doesn't get resized properly after set/remove label therefore try to force an update 2023-02-16 15:17:13 +01:00
nathan
524a9b3c7b Change how readonly multiple selects with rows=1 show more tags are hidden
Showing total number of values is way easier than showing the number that aren't displayed
2023-02-15 13:23:05 -07:00
nathan
ced2bc6061 Et2Password: Fix still forced autocomplete="new-password" 2023-02-15 09:21:40 -07:00
nathan
84bdea4193 Fix nm print dialog missing print orientation 2023-02-14 16:27:44 -07:00
nathan
80c5a64316 Et2Password: Autocorrect always off 2023-02-14 13:48:21 -07:00
nathan
d1c6145af0 Et2Password: Some cleanup
- Now passing autocomplete & autocorrect parameters on instead of forcing
 - Only doing the readonly input trick if autocomplete=="new-password"
2023-02-14 13:43:26 -07:00
nathan
68caabe1ae Fix hidden tabs did not make children readonly
Fixes required fields on hidden tabs still got validated
2023-02-14 10:09:58 -07:00
nathan
16c8fb420b Et2Password: Overwrite render to force input to readonly as a work-around for browsers ignoring autocomplete="new-password"
Doesn't make a difference for me, but easy for others to test if I commit
2023-02-13 15:59:38 -07:00
nathan
03a237fd7e Et2Select: Turn off browser autocomplete in search 2023-02-13 14:57:55 -07:00
nathan
d02a40ee82 Et2Select: Remove any doubled values when setting value 2023-02-13 14:00:52 -07:00
nathan
e2cbbe9358 Re-add feature where readonly URL widget with label uses the label as link text 2023-02-13 13:29:25 -07:00
nathan
c4f3ec9840 Et2Select: Fix free entries can get doubled if more free entries added 2023-02-10 14:13:13 -07:00
nathan
570edaa1e0 Et2Favorites: Update sidebox favorite icons when user changes default favorite 2023-02-09 16:47:59 -07:00
nathan
4322937ea7 Et2Date: Add widget classes to flatpicker popup 2023-02-09 14:47:43 -07:00
nathan
96558b9da8 Fix missing translation in Select group & dropdown options 2023-02-09 14:47:43 -07:00
Hadi Nategh
5a2bbd6463 Adjust details container calculation for overlaySummary based on left/right alignment 2023-02-09 11:26:25 +01:00
nathan
32dd160e35 Et2Date: Add placement property to control where calendar popup opens. "top", "bottom", or "auto" 2023-02-08 14:36:09 -07:00
nathan
00a857b2d7 Projectmanager: Fix gantt column selection opens with wrong position
Now using a proper dialog, similar to nextmatch column selection
2023-02-08 11:48:56 -07:00
nathan
efa550f251 Et2Select: Add onTagClick property for actions on tag clicks
Fixes unable to detect clicking on individual tags inside readonly et2-select-email
2023-02-08 09:11:33 -07:00
ralf
ed09a0b079 add missing readonly et2-select-lang to fix language column in news-admin index 2023-02-08 08:24:59 +01:00
nathan
193dbfc339 Et2Select: Fix some search weirdness
- Search didn't start until 1 character more than expected
- Search didn't happen on enter because the et2-searchbox inside stopped the key event from bubbling
2023-02-07 16:24:06 -07:00
nathan
9cde6a7171 Fix some styling on select-email
- Make +N tag right aligned & look like text, not tag
- Fix popup to open below but covering field
- give popup border & dropshadow
2023-02-07 12:04:05 -07:00
nathan
2a3a8a7371 Et2Select: Fix tags can't be removed 2023-02-07 10:04:56 -07:00
Hadi Nategh
84a58ec6ae Add new attribute for details widget to overlay the summary container 2023-02-07 16:49:18 +01:00
Hadi Nategh
cb6f2ee808 Add missing column on email tag tooltip 2023-02-07 10:01:46 +01:00
nathan
2c15e2f8ef Et2Description: Fix broken activate links test, it needed camelCase attribute 2023-02-06 15:59:32 -07:00
nathan
1b7f9d3ebc Et2SelectEmail: Give dragged tags some z-index, so they go over the other controls 2023-02-06 15:07:30 -07:00
nathan
cd980c78df Limit mail to & cc addresses to 1 row, show all on hover.
Use:
multiple="true" rows="1" maxTagsVisible="1"
to trigger show all on hover
2023-02-06 14:48:55 -07:00
ralf
bd8198d230 missing et2-select-lang widget 2023-02-06 15:52:58 +01:00
Hadi Nategh
dda3b1f5d1 Remove excessive BR tag from email tag 2023-02-06 11:33:50 +01:00
nathan
1d8d4f9c72 Fix some readonly issues where widgets were not looking readonly
- Editable tags were still editable if the select was readonly
- LinkTo could still select an app (readonly not passed on)
- Hide the dropdown for multi-select when readonly
2023-02-03 14:09:07 -07:00
nathan
21599f6097 Make all toolbar toggle button icons gray when off 2023-02-02 10:46:51 -07:00
nathan
929bf866cd Et2Lavatar: Fix missed property camelCase
contact_id -> contactId
2023-02-02 09:19:04 -07:00
Hadi Nategh
138999f233 Add again full value as tooltip for email tags 2023-02-02 12:12:08 +01:00
nathan
1fa9d91d59 Et2Description: Fix links were not clickable
activateLinks property got typoed to activeLinks in the template conversion
2023-02-01 14:31:17 -07:00
nathan
346a720d27 Et2LAvatar: Update statustext (tooltip) with name based on lname & fname 2023-02-01 14:06:54 -07:00
nathan
86376bdc0c Et2DateRange: Add relative -> absolute conversion as needed when setting value 2023-02-01 13:04:25 -07:00
nathan
15f986cf1a Get Et2Date & Et2DateTime tests passing again 2023-02-01 09:46:00 -07:00
nathan
ab56ad1171 Et2Select: Handle paste of CSV into selects with allowFreeEntries
Special handling for Et2SelectEmail to handle email addresses that may have a name or comma
2023-01-31 09:48:27 -07:00
nathan
0b15ede568 Et2Date: Fire change event when a new date is selected
Fixes nm date filters not filtering
2023-01-30 16:10:49 -07:00
nathan
e575c40ff3 Some missed cases where client-side lavatar was not used 2023-01-30 15:26:09 -07:00
nathan
f503743956 Use client-side Et2LAvatar instead of image for Et2SelectEmail options & tags
Should now be only avatar.php image when provided
2023-01-27 13:27:31 -07:00
nathan
5bab72b8be Use client-side Et2LAvatar for user accounts whenever possible, only using avatar.php when there's a real image.
TODO:
- Need to find a cheap way to determine if there's a real image in Api/src/Accounts.php & class.mail_compose.inc.php

- Still some work for me to do in Et2SelectEmail
2023-01-27 10:34:40 -07:00
nathan
9cebab3c2f Fix readonly selects could display 'undefined' with no value and no emptyLabel 2023-01-26 12:58:37 -07:00
nathan
bf6cca24fd Et2Favorites: Make star icon bigger 2023-01-26 09:22:45 -07:00
nathan
e4e0610a41 Et2LinkAppSelect: Use configured app link icon instead of always using navbar 2023-01-25 15:14:14 -07:00
nathan
62bc77a4d2 Make sure egw.lang() doesn't error trying to translate option label
This un-reverts 4e5f68f97c
2023-01-25 14:24:08 -07:00
nathan
4b8b454566 Make sure values are strings, otherwise they might not match comparison
Should fix tracker list "Created by" filter losing display when you select a search result
2023-01-25 13:43:35 -07:00
ralf
6ef78c9591 Revert "Fix missing translation on read-only select"
Causes:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'toLowerCase')
    at Object.lang (egw_lang.js:73:16)
    at Et2SelectAccountReadonly._readonlyRender (Et2SelectReadonly.ts:189:59)
    at Et2SelectAccountReadonly.render (Et2SelectReadonly.ts:168:16)
    at Et2SelectAccountReadonly.update (lit-element.js:6:304)
    at Et2SelectAccountReadonly.performUpdate (reactive-element.js:6:4849)
    at Et2SelectAccountReadonly.scheduleUpdate (reactive-element.js:6:4496)
    at Et2SelectAccountReadonly._$Ej (reactive-element.js:6:4404)

This reverts commit 4e5f68f97c.
2023-01-25 09:46:22 +01:00
nathan
4e5f68f97c Fix missing translation on read-only select 2023-01-24 14:44:28 -07:00
nathan
9bf0149645 Fix selectbox positioning issue
Tracker owner would open down instead of up with fontsize = 14.  Updating to shoelace 2.0.0-beta.81 fixes it.  Going farther introduces some other issues that I don't want to get into right now
2023-01-24 13:58:38 -07:00
nathan
49d3d84f3a Completely hide disabled nm filters, as before 2023-01-24 10:25:01 -07:00
nathan
56fcfbf992 No 'All categories' empty label for mail 2023-01-24 09:26:46 -07:00
nathan
2332c2a806 Et2Tag: Make edit textbox larger 2023-01-24 08:27:52 -07:00
ralf
9fb153bbcc fix historylog in calendar not shown
caused by multi-attributes use a vbox, who's constructor unset the readonly attribute
--> setting it again hard, as all widgets in historylog are r/o and without readonly select-boxes have no detached DOM interface
2023-01-24 14:31:16 +01:00
nathan
7518278948 Add edit button to freeEntry selectbox tags 2023-01-23 17:34:37 -07:00
nathan
802a312839 Stop nextmatch from making a popup dirty if a filter changes 2023-01-19 14:40:56 -07:00
ralf
5fe8f2642a fix problem with Safari 16.2 of NOT displaying dialog contents eg. of timer dialog 2023-01-19 15:23:16 -06:00
nathan
86917eff65 Fix file settings error "'0' is NOT allowed ('not found')!" for gid.
It did not have a '0' => 'root' option, which is what we were using for the value.
2023-01-19 09:21:03 -07:00
nathan
80fbd3cc26 Fix placeholder widget
IDs on et2-boxes caused unwanted namespace, Et2Listbox couldn't find its ID before fully initializing
2023-01-19 08:44:52 -07:00
nathan
3f5cb42c96 Fix vfsUpload didn't open mail files 2023-01-18 13:07:04 -07:00
nathan
3164cb6dd0 Make sure we get the right popup if multiple nextmatches use the same popup ID 2023-01-17 15:35:28 -07:00
nathan
6774f2e9d4 Remove another class that could be hiding popup contents 2023-01-17 14:30:28 -07:00
nathan
2ab7079f13 Et2LinkString: Can now fetch its own link data, given application & entryId
Includes some fixes for only_app filter
2023-01-17 14:03:28 -07:00
nathan
38b507dcd1 Et2Date: Stop required validation showing on initial load even with a value 2023-01-17 10:52:02 -07:00
nathan
a5929388fc Et2VfsMime: Add value getter
Fixes tracker comments with more than one image would only show the last
2023-01-17 08:37:24 -07:00
nathan
d87e0c7f38 Fix missing default button images 2023-01-16 16:15:57 -07:00
nathan
19c02fc91c Et2InputWidget: Do not try to validate readonly widgets, user can't change the value to fix it 2023-01-16 08:55:31 -07:00
Hadi Nategh
10c646a367 Make sure the sort and shadowRoot are there before using them, avoiding execution error, since getValue it could be called in earlier stage eg: a699117b1b 2023-01-16 12:55:45 +01:00
nathan
374ba994a4 Customfield validation fixes
- customfield did not pass required setting on to widgets
- link entry did not support required
2023-01-13 11:28:02 -07:00
nathan
1a969c4cfc Et2Date: Fix validation message display
Required validation was incorrectly displayed / not hidden
2023-01-13 08:40:21 -07:00
nathan
461e83df28 Remove all validation messages on focus, not just manual / server-side messages.
Server side ones are still re-added on blur, client-side messages are re-run.
2023-01-12 09:17:29 -07:00
nathan
4f7b54c6bb Fix some more select attribute / legacy options issues 2023-01-11 15:49:56 -07:00
nathan
a699117b1b Fix hiding server-side messages for selectboxes
Messages were not properly hidden & displayed, and setting handleFocus & handleBlur accidentally overwrote them in Shoelace widgets
2023-01-11 11:11:02 -07:00
nathan
1163f9e31d Hide server-side validation messages while widget has focus. If the value did not change, put messages back 2023-01-09 16:02:59 -07:00
nathan
ffb26cb2f1 Change tree icon size from 20px to 16px
Can be overridden in CSS now
2023-01-09 14:36:44 -07:00
nathan
56f84f2fdd Fix swapped open / closed icons in tree 2023-01-09 13:19:40 -07:00
nathan
ba608fddc7 Et2Split: Fix incorrect / frozen sizing of split in Firefox
If user dragged very quickly & released the mouse button before the resize was complete, we would wind up with incorrect size
2023-01-06 11:07:50 -07:00
nathan
323115b041 Replace font size accidentally removed in 40278c8827 2023-01-06 09:11:54 -07:00
nathan
39ab880188 Don't die if CustomFilterHeader is for a component that isn't a webcomponent, just error & use a select 2023-01-05 16:36:03 -07:00
nathan
c403edc49a Fix incorrect suggested password length 2023-01-05 15:35:04 -07:00
nathan
f8a8a290ce Tests for switch widget 2023-01-05 14:06:54 -07:00
nathan
3ecd9c222b Fix switch widget did not validate value server-side 2023-01-05 14:06:39 -07:00
nathan
9a190321c1 Et2Button: Fix class mixup that broke buttons 2023-01-05 09:00:02 -07:00
nathan
ca5d80264c Less errors in date tests, still not passing 2023-01-05 08:38:56 -07:00
nathan
37dd18894f Get tests for Colorpicker passing again 2023-01-04 15:33:48 -07:00
nathan
acd44a1e0e Get tests for Button passing again 2023-01-04 15:03:43 -07:00
nathan
40278c8827 Get our WebComponent tests running again
Made a lot of "failed to construct htmlelement" errors go away, avoid a bunch of egwIsMobile is undefined errors
2023-01-04 12:01:09 -07:00
nathan
ac1d8b6be8 Fix TypeError: Cannot read properties of null (reading 'replace')
Fixes unable to edit tracker in mobile view.
2023-01-02 16:20:50 -07:00
nathan
b8c3a97138 Et2Tabs: fix keyboard navigation 2022-12-22 14:51:48 -07:00
nathan
b0bedc8467 Accessability improvements
- Toolbar buttons get label, but it is visually hidden
- Add label to calendar Add button
2022-12-22 14:14:45 -07:00
nathan
c617dfe080 Fix placeholder sub-groups were not showing 2022-12-21 12:28:59 -07:00
nathan
098fe647dc Start on converting date range to webcomponent 2022-12-20 14:05:20 -07:00
nathan
7d94692dfd Fix some missing account names
- egw().accounts() were not cleaned
- accounts not in normal cache did not call requestUpdate() properly
2022-12-19 12:01:29 -07:00
nathan
ac97af35cb Lets try creating options directly when we get them, rather than going through update first
Timing was not getting menu items created soon enough, resulting in IDs instead of names in the options
2022-12-16 11:48:12 -07:00
nathan
9ce0520e5c Allow actually disabled inputs 2022-12-16 10:40:58 -07:00
nathan
272b63d32e Explicitly define autofocus as reflected so it works in Firefox too 2022-12-15 13:18:16 -07:00
nathan
a9fe524123 Et2Select: Fix value got wrecked by fix_bad_value() when there are option groups 2022-12-15 11:31:56 -07:00
nathan
e756962f86 Change egw.accounts() to always return a Promise 2022-12-15 10:22:19 -07:00
nathan
2ed0479380 Add nm action dialogs into application tab, not document body 2022-12-14 16:10:50 -07:00
nathan
3b5f64a4c3 Implement option groups 2022-12-14 14:32:20 -07:00
nathan
a832c12dbc Fix DnD to link file to entry 2022-12-14 11:56:27 -07:00
nathan
54498a005c Et2Dialog: Second try waiting on template load
Now creating the template promise immediately on setting template name and using a resolver function to resolve after template is loaded
2022-12-14 10:39:15 -07:00
nathan
6c4c42bcde Translation of "on vacation" from Birgit 2022-12-12 15:09:57 -07:00
nathan
27573f6d83 Et2Dialog: Try waiting until after update is complete to avoid an error loading the template in Safari 2022-12-12 14:43:47 -07:00
nathan
65a7abeca2 A little more space for details dropdown 2022-12-12 14:26:54 -07:00
nathan
5acc8c55c8 Et2SelectEmail: Fix fullEmail did not show full email 2022-12-12 14:07:08 -07:00
nathan
34172704dc Fix SelectAccount didn't always get values into options correctly 2022-12-12 13:10:53 -07:00
nathan
9acda4b390 Link fixes
- Fix file that was linked then removed before first save was still linked on save
- Use events for better decoupling between Et2LinkTo & Et2LinkList
2022-12-12 10:32:08 -07:00
nathan
0f37d2f437 Fix sometimes missing accounts for SelectAccount widgets 2022-12-09 13:16:44 -07:00
nathan
6177ca0536 SearchMixin: Filter selected remote correctly for single selects too 2022-12-09 13:14:57 -07:00
nathan
5f44c51d89 Et2Checkbox: Fix internal positioning was causing entire page to overflow 2022-12-09 10:55:19 -07:00
nathan
8ed40c8c0e Et2SelectThumbnail: Fix current value(s) did not display 2022-12-09 09:03:43 -07:00
nathan
dd39305443 Fix VFS upload couldn't show newly uploaded files 2022-12-08 15:01:25 -07:00
nathan
4b4d6fe184 Stop scrolling new tag into view, it causes calendar sidemenu to get stuck 2022-12-08 14:47:02 -07:00
nathan
ce64ddf9e0 Fix doubled tags if widget gets select_options after a remote option is selected 2022-12-08 14:28:05 -07:00
nathan
691928a54c Fix attachments not displayed in tracker comments 2022-12-08 11:39:00 -07:00
nathan
be5125509e SearchMixin: Fix selecting multiple remote values only showed the last 2022-12-08 10:24:49 -07:00
nathan
d7f8f7d997 Fix editing link remark did not load current value 2022-12-07 15:51:50 -07:00
nathan
c26732a913 Some more fixes for historylog widget
- Fix options in proper format could be interpreted as sub-widgets
- Fix numeric values
2022-12-07 15:04:22 -07:00
nathan
12151139ff Et2Dialog: Better non-modal handling, now with less internal conflicts with SlDialog 2022-12-07 13:45:38 -07:00
nathan
32248e67ee Et2Dialog: Better non-modal styling 2022-12-07 11:30:14 -07:00
nathan
4b6357dd90 Et2Dialog nonmodal WIP
Non-modal dialogs don't cover header with app tabs.
TODO: The dialog needs to be added to the app content div instead of the body
2022-12-07 09:13:46 -07:00
nathan
fb40aedf89 SearchMixin: Use parent set select_otions, no need to duplicate 2022-12-06 11:59:51 -07:00
nathan
daa999d586 Et2LinkList: Fix context menu actions 2022-12-06 10:55:20 -07:00
nathan
25f64d0064 Fix error on some bad options
Would sometimes stop historylog from loading
2022-12-06 10:05:47 -07:00
nathan
57993741cb Et2Dialog: Don't close dialog for buttons that are not in the footer 2022-12-06 09:44:56 -07:00
nathan
3971abc54b Fix some select options were not being cleaned
Integer values provided from server were not being converted to strings, breaking value handling & matching
2022-12-06 09:13:04 -07:00
nathan
2188791540 Et2LinkList: Fix context menu "Save As" gave error
Cannot read properties of undefined (reading 'dispatchEvent')
2022-12-05 17:05:10 -07:00
nathan
fa2375b1a6 SearchMixin: Fix selected remote options got lost if adding a freeEntry 2022-12-05 13:56:31 -07:00
nathan
e875b9ddf4 Use same background color for primary buttons 2022-12-05 10:54:05 -07:00
nathan
b2b3caaa64 Fix searchbox triggered change an extra time after pressing Enter key 2022-12-05 10:31:15 -07:00
nathan
2b02d4e9ab Fix listbox sometimes lost value 2022-12-05 10:11:17 -07:00
nathan
7ba5730251 Change properties to camelCase 2022-12-05 09:42:55 -07:00