Commit Graph

3722 Commits

Author SHA1 Message Date
ralf
89ca0de684 replace original message header with fieldset in html and convert it to plain as before 2022-05-11 15:57:14 +02:00
ralf
08271725f3 trying "harder" to set users default font and -size in TinyMCE 2022-05-11 15:56:35 +02:00
ralf
51ff6d7fec fix smallPART file-access depending on full path (not just /apps/smallpart/$id!)
allow apps like smallpart to additional return 0|1 instead of bool, to not cache result, if it depends on $rel_path, as cache does not consider $rel_path
2022-05-11 13:52:41 +02:00
ralf
af434abb96 never set a full path as filename of an attachment as it triggers rejection for some mail-servers 2022-05-11 10:44:48 +02:00
Hadi Nategh
58077a60f1 Fix seek to a new time in youtube video does not work when pause action happens instantly after it 2022-05-11 09:33:22 +02:00
ralf
126bab8146 fix PHP 8.1 throws \mysqli_sql_exception or \PDOException for SQL errors
- change them to our regular Api\Db\Exception
- for prop(find|patch) explicitly catch PDOException to deal more graceful with non-ascii prop-names
2022-05-10 12:39:08 +02:00
ralf
8d645e5a7d final fix for "Network error" when stream files to client
It is important to FIRST disable zlib.output_compression (before headers are sent!) and THEN end all output-buffering!
Without the two steps in this order, we are either limited by the memory limit or get the "Network error", because the streaming/fpassthrough does not apply the compression.
2022-05-05 12:49:07 +02:00
Hadi Nategh
02096632e6 Set back focus to the first field in form 2022-05-04 14:19:05 +02:00
Hadi Nategh
e4efa38d45 Fix stolen focus on egw input fields 2022-05-04 12:54:40 +02:00
ralf
0bf4dc6d88 lower number of rows queried per chunk to 2000 to avoid memory_limit on huge tables 2022-05-04 12:23:00 +02:00
Hadi Nategh
2e7451f283 Mail: Fix htmlEditor does not include styling on each tag causing mail content sent with no styling 2022-05-03 15:49:38 +02:00
ralf
b62b523d93 fix not loaded grants / other users categories after last commit 2022-05-03 13:34:16 +02:00
ralf
766088155b fixed messed up signature changing from / mail-accounts
also fixed some undefined warnings
2022-05-02 17:22:31 +02:00
ralf
949a130306 fix displayed [] instead of [Login] 2022-05-02 09:16:08 +02:00
ralf
cf4f16dfb2 fix diverse undefined array-key or variable warnings 2022-04-29 12:47:46 +02:00
ralf
859329fe6d * CalDAV/Calendar: expand-property report used by iCal app (Mac) did not return rights on other users calendar
but other users/groups which have rights on the queried users calendar
Also on longer enumerate group-members in group-memberships as calendar-proxy-(read|write) groups, as iCal app understands group-memberships.
2022-04-28 16:10:47 +02:00
ralf
0efb94f2bf do NOT log not found template because of missing $row_cont expansion on server-side 2022-04-28 10:40:05 +02:00
ralf
78a4d163aa another chunk of fixed PHP Warning: Undefined array key or variable in api 2022-04-27 20:30:58 +02:00
ralf
ca9ab2d340 fix "a ton" of PHP Warning: Undefined array key or variable in mail code 2022-04-27 20:29:45 +02:00
ralf
68f7437cd0 fix PHP 8.1 Error: Serialization of 'LDAP\Connection' is not allowed 2022-04-27 13:00:36 +02:00
ralf
0ec9ce58cd replace mixed return-type with #[\ReturnTypeWillChange] annotation to keep PHP 7.3 requirement 2022-04-26 08:16:26 +02:00
ralf
c7d7f3a304 fix CallbackIterator to return mixed, as it can be overwritten with a callback 2022-04-26 08:13:19 +02:00
ralf
c19eb3cb02 fix PHP 8.1 Deprecated by adding return type declarations 2022-04-26 08:10:15 +02:00
ralf
92922acfd4 fix PHP 8.x TypeError: string & int 2022-04-24 20:53:16 +02:00
ralf
022258cc85 fix an other case of "Network error" when downloading as ZIP 2022-04-22 11:00:38 +02:00
nathan
5dda1c368c * Api: Merge placeholder that checks for EMPTY {{IF fieldname~EMPTY~True text~False text}}
EMPTY check was already there, just adding it explicitly into the placeholder list
2022-04-12 09:12:36 -06:00
Hadi Nategh
8364b37f46 Fix some mail actions e.g. "view as source" or "Html" no longer working 2022-04-11 13:23:44 +02:00
Hadi Nategh
b34f54b1c1 Fix missing context for public class properties 2022-04-08 13:46:07 +02:00
ralf
000d4ee651 Changelog for 21.1.20220408 2022-04-08 13:22:45 +03:00
nathan
15fa789cfd Check & set context for filesystem:// too 2022-04-08 12:46:10 +03:00
nathan
0c07e8deaf Api: Make sure mountpoint URL query and target URL query don't double ? in path query 2022-04-08 12:45:45 +03:00
ralf
8447a315b5 * Filemanager/SMB: fix not working sharing of SMB shares (with fixed credentials!)
sanitize URL before sending them to PHP / other stream-wrappers like the smb one, which chokes on our ro=1 parameter
2022-04-08 12:45:07 +03:00
Hadi Nategh
ef1c1543ab Fix error Unexpected token '='. Expected an opening '(' before a method's parameter list 2022-04-07 15:32:47 +02:00
nathan
2103c2869d Api: Fix sharing folders by making sure compression is off 2022-04-07 09:02:17 +03:00
Hadi Nategh
b303f16d61 Fix broken file widget's accept option caused by Resumable overriding it on initiation 2022-04-06 14:45:09 +02:00
ralf
47b457b73b Changelog for 21.1.20220406 2022-04-06 08:52:45 +03:00
Hadi Nategh
d649fb8647 Fix removeSessionItem not working 2022-04-05 10:25:07 +02:00
Hadi Nategh
88646cf5a5 Use dymanic import for pdfjs and bundled-es-modules the same as in master 2022-04-04 17:13:29 +02:00
Hadi Nategh
dcd3e9dcbd Use compiled js file for pdf-player and multi-video webcomponents because the ES2015 TS compiler breaks their constructors 2022-04-04 13:36:49 +02:00
Ralf Becker
c3d5a96826 pending changes from our translation server 2022-04-04 13:28:05 +02:00
ralf
a2bc71d7fc fix PHP 8.1 error/mysqli_sql_exception: Invalid character set was provided (utf-8 instead of utf8) 2022-04-04 10:22:13 +03:00
ralf
6c31c40ddf LDAP resources are objects (no longer resources) from PHP 8.1+ 2022-04-04 10:22:13 +03:00
ralf
98a08ec152 fix vfs-path widget to correctly deal with smallPART paths (hierarchical structure inside entry directory) 2022-04-01 21:08:51 +03:00
Hadi Nategh
cc81b2d173 Add missing pdf-player.ts file 2022-03-31 14:42:34 +02:00
Hadi Nategh
c8fd2fac37 Add multi-video and pdf-player components 2022-03-31 14:41:19 +02:00
Hadi Nategh
3c7a5a201a Implement custom html multi video element (makes it possible to merge and control multiple videos as one tag) 2022-03-31 14:41:19 +02:00
Ralf Becker
3d53fa9d97 add missing $relpath 2022-03-31 14:41:19 +02:00
Ralf Becker
6490e4360f extract data-preparation from Etemplate\Widget\Vfs::beforeSendToClient() to use it to send the data to client-side in an AJAX call 2022-03-31 14:41:19 +02:00
ralf
ac1a7f6bdb fix broken tracker mailhandling caused by protected constructor
also disable reading from DB, in case no (numeric) acc_id given, like from tracker mailhandling
2022-03-30 10:58:31 +03:00
ralf
28adde1b99 Allow overwriting values in all mail accounts through an optional file /var/www/mail-overwrites.inc.php 2022-03-29 20:43:32 +03:00
nathan
d35577f1a8 * Api: Fix splitter widget did not restore size from preference 2022-03-29 09:42:01 -06:00
ralf
4c503d61ea * Addressbook: allow keeping custom fileAs value (LDAP: displayname) by adding it as first option 2022-03-29 10:26:51 +03:00
ralf
b990c00207 do NOT attempt to use credentials encrypted with user password in an async context
(where user password is not available)
otherwise an s/mime certificate or user specific password will stall sending notification, even if no smtp authentication required
2022-03-28 17:59:20 +03:00
ralf
d8827da73f do NOT overwrite everything, if vfs-upload is used without id:
- using fallback id of "file_widget" the client-side uses
- ignore validation, if there is no id
2022-03-28 13:55:52 +03:00
Hadi Nategh
65eda2c1d8 Fix error "explode(): Argument #2 ($string) must be of type string, array given", happens sometimes while merging contacts 2022-03-22 10:56:56 +01:00
Hadi Nategh
6c75d9eb9f Fix alarm not being fired sometimes 2022-03-15 18:38:25 +01:00
Hadi Nategh
ac25c9b2b8 Allow multiple alarms being set for countdown widget 2022-03-15 17:13:36 +01:00
ralf
4ca434f500 fix delete-account did not show 0 entries for InfoLog, also give a total per InfoLog type 2022-03-15 10:51:27 +02:00
Ralf Becker
7d7557fe3d fix broken filemanager after PM integration commit
array_merge_recursive accumulates values in sub-arrays:
array_merge_recursive(['nm'=>['get_rows'=>'a.c.m']], ['nm'=>['get_rows'=>'a.c.m']]) === ['nm'=>['get_rows'=>['a.c.m','a.c.m']]
2022-03-07 10:19:09 -07:00
nathan
60bc11a66e * Projectmanager: Add calendar integration so projects can be shown as events in calendar 2022-03-07 10:19:09 -07:00
nathan
9de70e9260 Add a hook for before get_rows is called 2022-03-07 10:19:09 -07:00
ralf
c68b8cc42d only send password (or hash) to client-side, if explicitly requested 2022-02-25 13:53:39 +02:00
ralf
24390a135a prefer [Login] button below over maybe existing SAML login button above 2022-02-21 21:20:28 +02:00
nathan
de14e34abb - Fix 'Forgot password' could not complete due to redirect
- Avoid error if no groups selected in registration configuration
2022-02-09 08:14:08 -07:00
Ralf Becker
9b630bedcc Changelog for 21.1.20220207 2022-02-07 12:13:40 +02:00
Ralf Becker
35668ca6ef pending translations from our translation server 2022-02-07 07:58:48 +01:00
Ralf Becker
998f7dc074 fix get_file_id() (sometimes) not finding the right id for shared directories or writable Collabora shares 2022-02-02 21:53:48 +02:00
nathan
4c0ef2020f Make sure we use the lowest file_id, even if that comes from a disabled file, so we're consistent with versioned files 2022-02-02 21:53:48 +02:00
nathan
e420a6db10 Collabora: Use the same file ID when accessing via share 2022-02-02 21:53:48 +02:00
Ralf Becker
8fba1d9a2f do NOT handle / redirect for not found eT2 session in ajax_destroy_session()
as it's called, when the session is no longer needed
2022-01-19 20:17:07 +02:00
Ralf Becker
26e09680c2 implement new "units" parameter to limit used units in date-since widget
eg. <date-since units="d" shows age in days
2022-01-14 17:24:07 +02:00
Ralf Becker
9e655d4de2 fixing the fix ;)
call_user_func_array(): Argument #1 ($callback) must be a valid callback, class admin_account does not have a method "ajax_process_content"
2022-01-12 13:33:30 +02:00
Ralf Becker
8b0cf6dbf2 fix Error Method admin_account::delete::et2_process() does not exist 2022-01-12 13:00:40 +02:00
Ralf Becker
8e2b649801 fix not closing popups when using et2_process json.php handler 2022-01-10 19:57:42 +02:00
Ralf Becker
4853f9a622 use $method parameter of Api\Etemplate::exec() plus new et2_process handler as menuaction GET parameter
allows determining the called function on the URL to eg. send it to different FPM pool
(before the menuaction of et2 was always "EGroupware\Api\Etemplate::ajax_process_content")
2022-01-10 19:57:42 +02:00
Hadi Nategh
b1de5e3881 Revert "use $method parameter of Api\Etemplate::exec() plus new et2_process handler as menuaction GET parameter"
This reverts commit 5576048f95.
2022-01-10 10:11:23 +01:00
Ralf Becker
5576048f95 use $method parameter of Api\Etemplate::exec() plus new et2_process handler as menuaction GET parameter
allows determining the called function on the URL to eg. send it to different FPM pool
(before the menuaction of et2 was always "EGroupware\Api\Etemplate::ajax_process_content")
2022-01-09 17:57:39 +02:00
Ralf Becker
6bafc579f0 allow to pass url including http(s) scheme to Html::link($url, ...) and therefore other methods of Html class 2021-12-23 10:03:10 +02:00
Ralf Becker
6800484429 fix PHP Warning: explode(): Empty delimiter 2021-12-16 20:23:31 +02:00
Ralf Becker
c6f447f49c fix still not working sync-report for accounts addressbook
turns out Microsoft AD also returns a "Virtual List View error" if sorting by standard LDAP (modify|created)timestamp, have to use when(Changed|Created) instead, as for filter
2021-12-16 20:08:35 +02:00
Ralf Becker
9439c2d799 fix SQLfs fsck to query errors in chunks of 500, in case there are a huge numbers of them 2021-12-14 21:28:56 +02:00
Hadi Nategh
1448581403 Decode html entities used in inline image sources because tinymce encodes them 2021-12-14 10:36:00 +01:00
Hadi Nategh
1c65b55f63 Fix issue contact plus button sometimes gets stuck 2021-12-10 10:51:38 +01:00
nathan
5b7706c77d * Etemplate: Add link icon overlay to link list 2021-12-06 10:13:33 -07:00
Hadi Nategh
de2c406c76 add compiled js file for commit 89507d1f2b 2021-12-06 10:28:40 +01:00
Hadi Nategh
89507d1f2b Add underline button into html editor's toolbar 2021-12-06 10:25:49 +01:00
Ralf Becker
e74262ff43 pending translations from our translation server 2021-12-04 15:45:41 +01:00
nathan
2f537252a8 Replace hyphen in utf-8 2021-12-03 11:40:26 -07:00
nathan
0543af4d82 Api: Force merge placeholder charset to UTF-8, avoids mangled accent characters 2021-12-03 11:40:19 -07:00
Ralf Becker
5f0b2ab513 * CardDAV/ActiveDirectory: fix empty account-addressbook if sync-collection-report is used
Microsoft AD can NOT filter by (modify|create)TimeStamp, we have to use when(Created|Changed) attribute
2021-12-02 20:09:49 +02:00
Ralf Becker
67412124a4 fix syntax error under PHP 7.3
7.3 is still the minimum requirement for 21.1
2021-12-01 20:00:15 +02:00
Ralf Becker
0435f3a4a5 * Guacamole/Backup/Restore: fix not working restore for Guacamole
disabling constraints and only truncate Guacamole tables, not dropping and creating them again
2021-11-30 21:57:26 +02:00
Ralf Becker
e50703aaae Changelog for 21.1.20211130 2021-11-30 10:11:56 +02:00
Ralf Becker
77900b09b3 fix Undefined array key warning 2021-11-29 16:46:18 +02:00
Ralf Becker
74dbdc30fb fix a couple of Undefined array key warnings 2021-11-29 16:36:16 +02:00
Ralf Becker
2b965a8399 fix / work around PHP 8.0 Error Call to undefined method EGroupware\Api\Etemplate\Widget\Vfs::set_attrs() 2021-11-24 20:59:43 +01:00
Ralf Becker
d83440e9f4 fix PHP 8.0 TypeError: Unsupported operand types 2021-11-23 18:08:14 +01:00
Ralf Becker
d3be189245 fix PHP 8.0 TypeError: Illegal offset type 2021-11-23 17:45:06 +01:00
Ralf Becker
68265cd7ab fix PHP 8.0 TypeError: Unsupported operand types: string & int 2021-11-23 17:24:22 +01:00
Ralf Becker
916565f797 fix PHP 8.0 TypeError: array_keys(): Argument #1 ($array) must be of type array, null given 2021-11-19 13:01:10 +01:00
Ralf Becker
9afc3a45b7 fix PHP 8.0 ArgumentCountError: readlink() expects exactly 1 argument, 2 given 2021-11-18 08:29:16 +01:00
nathan
4caec9dbd3 Improve logging message to include values instead of 'Array' 2021-11-17 20:24:50 +01:00
nathan
711a03aebf Fix placeholder dialog in collabora did not show up
It wasn't in the packaged JS
2021-11-17 10:24:55 -07:00
nathan
b0ef704c4b Clear tree before setting options to avoid duplicates 2021-11-16 15:16:10 -07:00
Ralf Becker
838f42e87f fix PHP 8.0 TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given 2021-11-16 18:21:19 +01:00
Hadi Nategh
6f6613a450 Fix tinymce upload image not working in ole etemplate apps like knowledge base app 2021-11-16 16:51:29 +01:00
Ralf Becker
abf411415f fix PHP 8.0 TypeError: Cannot access offset of type string on string 2021-11-15 16:01:30 +01:00
Ralf Becker
bd29f1ef6a fix PHP 8.0 TypeError: Cannot access offset of type string on string 2021-11-15 15:04:15 +01:00
Ralf Becker
dfec4360b3 fix PHP 8.0 TypeError: array_keys(): Argument #1 ($array) must be of type array, null given 2021-11-13 17:39:56 +01:00
Ralf Becker
c212cf36ae fix PHP 8.0 TypeError: fwrite(): Argument #2 ($data) must be of type string, array given 2021-11-13 17:31:19 +01:00
Ralf Becker
c6052a5fbb fix PHP 8.0 TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given 2021-11-13 17:25:01 +01:00
Ralf Becker
72a7039dce fix PHP 8.0 TypeError: array_merge(): Argument #1 must be of type array, null given 2021-11-13 17:18:41 +01:00
Hadi Nategh
537c4652a3 Fix error "Non-static method Merge::get_all_ids() cannot be called statically" 2021-11-13 17:08:20 +01:00
Ralf Becker
26af55cba6 fix PHP 8.0 TypeError: Unsupported operand types: string + int 2021-11-13 17:05:42 +01:00
Ralf Becker
26a8d40c5f fix PHP 8.0 TypeError: ZipArchive::setCommentName(): Argument #2 ($comment) must be of type string, array given 2021-11-13 17:02:26 +01:00
Hadi Nategh
90597e1dea Get the link entry app selection menu working again 2021-11-11 10:28:00 +01:00
Ralf Becker
bbd048a143 try fixing an other case where an unrelated XML error was reported
Error passing XML file '<text type="text" id="#Kunde_Firma"/>' line 12: EndTag: '</' not found
There is obviously no line 12 ;)
2021-11-11 09:50:17 +01:00
Ralf Becker
cb70a57b78 quieten permanent log of search links for non-ascii project-names etc. 2021-11-11 09:11:04 +01:00
Ralf Becker
46e384198b fix PHP 8.0 TypeError: Unsupported operand types: string & int 2021-11-11 08:00:20 +01:00
nathan
6aa0366330 Maybe fix SQL error from searching contacts with private + duplicates 2021-11-10 09:53:24 -07:00
nathan
050bf162d9 Api: Fix check of disabled attribute was misbehaving if the value was null or 0
This showed up when validating tracker config, some rows were disabled with disabled="@tracker".  When tracker=0, they did not return their value.
2021-11-10 13:58:40 +01:00
Ralf Becker
4d08b1412d fix PHP 8.0 TypeError: array_merge(): Argument #2 must be of type array, null given 2021-11-10 12:47:34 +01:00
Ralf Becker
8d25c83380 fix/catch PHP 8.0 ValueError: mb_convert_encoding(): Argument #3 ($from_encoding) contains invalid encoding "cp1250" 2021-11-10 12:43:30 +01:00
Ralf Becker
aca63345ca fix PHP 8.0 TypeError: strpos(): Argument #1 ($haystack) must be of type string, array given 2021-11-10 12:16:20 +01:00
Hadi Nategh
dfdd3b918b Update jquery-ui to 1.13.1 2021-11-10 11:55:45 +01:00
Ralf Becker
5477f3d095 * LDAP/Addressbook: fix region contains for given country invalid value gives an LDAP error on update
cause by trying to write NULL, which is not allowed, unsetting the attribute the proper way now
2021-11-09 11:08:07 +01:00
Ralf Becker
3655619b43 fix PHP 8.0 problem "new" > 0 causing mail accounts created via admin for an other user to fail 2021-11-09 08:03:16 +01:00
Ralf Becker
fa67fc24d7 fix PHP 8.0 TypeError: Api\Accounts::username(): Argument #1 ($account_id) must be of type ?int, string given
new method for account link-title not throwing an error, for non-numeric arguments and therefore stalling all titles
2021-11-08 12:23:08 +01:00
Ralf Becker
9638bddaac fix PHP 8.0 TypeError: Exception::__construct(): Argument #2 ($code) must be of type int, string given 2021-11-08 11:36:49 +01:00
Ralf Becker
ff68c12773 fix PHP 8.0 TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given 2021-11-05 15:19:20 +01:00
Ralf Becker
1ad1c6e951 fix PHP 8.0 TypeError: Unsupported operand types: null + array 2021-11-05 14:50:19 +01:00
Ralf Becker
c8bab89460 fix PHP 8.0 TypeError: uasort(): Argument #1 ($array) must be of type array, null given 2021-11-05 14:37:50 +01:00
Ralf Becker
e8c352acbd fix PHP 8.0 ValueError: stripos(): Argument #3 ($offset) must be contained in argument #1 ($haystack) 2021-11-05 11:39:13 +01:00
Ralf Becker
0d8f4f624f fix PHP 8.0 error: trim expects string, array given
removed trim
2021-11-05 09:08:57 +01:00
Hadi Nategh
17e25fa1e0 Fix PHP8.0 error (TypeError): strlen(): Argument #1 ($string) must be of type string, array given 2021-11-04 17:24:56 +01:00
Hadi Nategh
fd3b61b6af Fix PHP8.0 (TypeError): explode(): Argument #2 ($string) must be of type string, array given 2021-11-04 14:32:17 +01:00
Hadi Nategh
5227425671 Fix stripos(): Argument #3 ($offset) must be contained in argument #1 ($haystack) by preventing empty html value being processed 2021-11-04 14:14:10 +01:00
Ralf Becker
ae6128d7d0 * Filemanager: fix not working variables eg. $user in GUI mount (Admin > Filemanager)
also support no user/password for sharing links
2021-11-03 14:55:21 +01:00
Hadi Nategh
8a9aad7f2c * Filemanager: Fix video controller not working in filemanager gallery 2021-11-02 17:45:17 +01:00
Ralf Becker
45437a5c9d add $depth parameter to Vfs::checkLock($url, int $depth=0) and use it to query all locks in one go for filemanager_ui::get_rows() 2021-10-29 08:48:26 -06:00
nathan
facdf2d119 API: Make sure memberships is an array to avoid other errors (PHP 8.0) 2021-10-27 13:41:48 -06:00
Ralf Becker
12c6b57ed0 fix regression reported by @asig2016 after big warning fix 2021-10-23 09:56:11 +02:00
nathan
1ecfe6fea5 Api: Fix "Unsupported operand types: array + bool" when infolog linked contact could not be read 2021-10-22 09:43:09 -06:00
Hadi Nategh
dddd0a2ee0 Fix onchange event not working for date-range widget 2021-10-22 13:27:37 +02:00
nathan
17d4c2a869 Api: Fix merge action files in subdirectories had their path as part of action caption instead of just the file name 2021-10-21 09:59:57 -06:00
nathan
3c7d18b8db Api: Change app placeholders list to use some more horizontal space, stop hiding common & user placeholders 2021-10-21 08:40:37 -06:00
Ralf Becker
efff64299c fix big chunk of PHP 8.0 warnings 2021-10-21 10:42:18 +02:00
nathan
e70060f34b Api: Fix cf sub-entry placeholder expansion was not passing content for placeholders like {{#customer/n_fn}} 2021-10-20 14:10:41 -06:00
Ralf Becker
a8cc4d3c33 closing/commiting the session to speed up calendar loading 2021-10-20 13:58:40 +02:00
nathan
eb1ed53c1a JS changes from 068e3feff0 2021-10-19 14:23:31 -06:00