extern/egroupware_official
1
0
Fork 0
mirror of https://github.com/EGroupware/egroupware.git synced 2024-12-23 15:18:58 +01:00
Code Issues Packages Projects Releases Wiki Activity
33,173 Commits 33 Branches 357 Tags 204 MiB
b4b2b9d5d2
Commit Graph

964 Commits

Author SHA1 Message Date
Hadi Nategh
d9d051a97e Fix move/copy actions in link_to widget vfsSelect try to create not unwanted new symlink 2018-04-04 17:54:30 +02:00
nathangray
1cb13a1f13 * Api - Fix references to sub-fields of custom field entries only merged for the first entry of each type 2018-04-03 15:27:09 -06:00
Hadi Nategh
980b4e1ab2 Make sure mail_bo object is there before using it, fixes error "can not call undefined function reopen()" 2018-04-03 10:33:40 +02:00
nathangray
0a7f81a2e2 Api - Sharing from filesystem:// mounts - with tests even 2018-03-23 13:01:43 -06:00
Hadi Nategh
2943b678bd Fix merge replace placeholders causes huge performance issue. Additionally, fixes the extra $ sign shown up in replaced placeholders. 2018-03-23 16:46:51 +01:00
Ralf Becker
74746a14ef * Sharing/Collabora: fix not working cleanup of temp. files and shares 
- 14.x installs had the job created with old class-name egw_sharing
- Wopi shares where never cleaned up, they are now after 3 month
 2018-03-22 13:09:59 +01:00
Ralf Becker
1d835928d2 new method Api\Framework::getUrl() to get a full / externally usable Url 2018-03-21 12:51:52 +01:00
Ralf Becker
21e123ef84 do NOT use hostname configured in setup, if it is the default localhost 
stick with HTTP Host header in that case
 2018-03-21 12:49:31 +01:00
Hadi Nategh
045436609d Get Sharing + Collabora into latest 17.1 version 2018-03-21 12:43:25 +01:00
Hadi Nategh
be4dbc37ae * Fix opening collabora fails from a shared directory: 
-we need to have collabora app to avoid CSP error since redirect share-link in collabora should get frame-src. e.g:(Collabora/Src/Ui.php:redirect(Sharing::share2link))
 2018-03-16 13:15:45 +01:00
Hadi Nategh
e9b80ecee5 Remove not used csp method 2018-03-16 13:14:16 +01:00
nathangray
3185acb7b1 Add merge into the list to get /apps working again 2018-03-15 16:55:43 -06:00
nathangray
6be5b8f678 Fix editing a file through gave not found error if the symlink was in a versioned directory 2018-03-15 16:55:43 -06:00
Hadi Nategh
65b2588d65 Add missing negation from commit 600872a4bf 2018-03-15 12:24:19 +01:00
Hadi Nategh
600872a4bf An attempt to fix broken collabora sharing which originally got broken by commit f166fbdd46 in order to get mounted template sharing fixed. 2018-03-14 18:58:30 +01:00
Ralf Becker
dcb78d9776 remove due to own table in 17.1 no longer needed migration of (private) custome-fields 2018-03-14 14:50:46 +01:00
Hadi Nategh
eb1eed5b8d Implement new feature for vfs-select widget to accept extra buttons action. Additionally, add extra "copy" and "move" actions to link-to vfs dialog. 2018-03-13 17:43:21 +01:00
Ralf Becker
ddd4127ee7 * AD/LDAP migration: change favorites and index states too 2018-03-12 21:22:12 +01:00
nathangray
357e5a3326 Re-init static streamwrapper, as some of them look at permissions or preferences 2018-03-12 13:51:04 -06:00
Ralf Becker
c2c1bdb6ad * EMail/Tracker/InfoLog: fix error converting mails by replacing 4-byte utf8 chars 
MySQL and MariaDB before 10.1 need 4-byte utf8 chars replaced with our default utf8 charset
(MariaDB 10.1 does the replacement automatic, 10.0 cuts everything off behind and MySQL gives an error)
Changing charset to utf8mb4 requires schema update, shortening of some indexes and probably have negative impact on performace!
		if (substr($this->Type, 0, 5) == 'mysql' && $this->ServerInfo['version'] < 10.1)
		{
			$value = preg_replace('/[\x{10000}-\x{10FFFF}]/u', "\xEF\xBF\xBD", $value);
		}
 2018-03-12 14:02:13 +01:00
Ralf Becker
163c87db82 * Api: use proxy configuration when downloading available tutorial videos 2018-03-12 11:16:57 +01:00
Hadi Nategh
fbf63bf65c Fix tutorials.json url to use https 2018-03-12 11:08:09 +01:00
Ralf Becker
32d10dd243 Fix not working textbox validators containing backslashes 
PHP xml parser reads backslashes literal from attributes, 
while JavaScript ones need them escaped (eg. like PHP strings)
-> replace \\ with \ to get following XML working: validator="/^\\d+$"
 2018-03-10 17:55:12 +01:00
Ralf Becker
e578e64926 ActiveDirectory: additional allow accountExpires=0 for never expires 
(beside attribute is not set or has value 9223372036854775807)
 2018-03-09 19:51:49 +01:00
nathangray
223b55d631 Api - Allow sharing to use Collabora to open files instead of downloading 2018-03-07 11:29:00 -07:00
Hadi Nategh
d2859d5cee * Mail: Fix "tel:" href links wrongly get denied by mail compose 2018-03-05 18:16:12 +01:00
Hadi Nategh
53b97078ad Fix mail with a bold digits gets removed from text part 2018-03-05 17:31:47 +01:00
Hadi Nategh
dca72ebd9c Fix broken sharing caused by commit 89a8e6f448 2018-03-05 11:13:54 +01:00
nathangray
9a51ad9211 API - Avoid issue with incompatable types by forcing to array, even if no account found 2018-03-02 10:21:43 -07:00
Hadi Nategh
63dd5ce96b Make sure replace only and only VT char (Vertical Tab) 2018-03-02 12:13:13 +01:00
Ralf Becker
205cf9c588 replace non-utf8 chars in content send to browser with utf8 replacement char 
before we were removing the whole string
 2018-03-01 17:38:45 +01:00
Ralf Becker
f800ab008b if we can not store failed login attempts in database, store it in cache 2018-02-28 18:01:32 +01:00
Ralf Becker
a799abb0a0 * All apps: multiselect custom-field switches to single select after submit 2018-02-28 13:41:13 +01:00
Ralf Becker
c1e8ac6324 Switching consistent hashing (Libketama) off by default 
as for just 2 Memcached servers it creates an extrem unbalanced 
distribution favoring the 2. server and has no benefits,
as requests to the failed node can only go to the other one anyway.
 2018-02-28 10:45:48 +01:00
Ralf Becker
8b88e748f7 * Admin: new config to generate no or lowercase email addresses for new users 2018-02-20 09:15:42 +01:00
nathangray
816db05496 Use abstraction to determine mime type, see 9a398594ac 2018-02-15 10:16:04 -07:00
nathangray
89a8e6f448 Place check on session first to avoid errors if it's missing 2018-02-15 09:19:26 -07:00
Ralf Becker
e3c67a1c63 fix PHP Warning if keys contain a backslash as in namespaced classes 2018-02-15 09:52:24 +01:00
nathangray
9c29079ddf Silence warning about time in array format by passing it to constructor 2018-02-14 08:38:48 -07:00
Ralf Becker
f4927d7e0b * Filemanager/Sharing: fix PHP 7.1 error causing auth request to popup 
Session only stores app-names and $GLOBALS[egw_info][user][apps] gets restored from $GLOBALS[egw_info][apps] for the allowed app-names. Check if we need to restore from installed apps array was using is_array($GLOBALS[egw_info][user][apps][api]) instead or isset($GLOBALS[egw_info][user][apps][0]), as check if it is a real, non associative array
 2018-02-14 09:03:14 +01:00
nathangray
f166fbdd46 * Api - Fix sharing from mounted shares failed with 404 2018-02-13 15:10:34 -07:00
nathangray
c67560049c * Api - Check if email address is known before offering 'Add as contact' button 2018-02-08 13:19:26 -07:00
Hadi Nategh
4e0be8a887 Allow custom theme for mobile template 2018-02-08 10:10:15 +01:00
nathangray
a8ffe5ab05 * Api - Fix some spelling errors, reported by Stefan Unverricht 2018-02-07 13:30:55 -07:00
Hadi Nategh
034b17a49a Implement new user preference in order to be able to select a handler for opening a merge print document 2018-02-07 13:15:29 +01:00
Ralf Becker
d934f33ea6 also fixing preg for email with optional domain part 2018-02-05 19:13:01 +01:00
Ralf Becker
75a39143f8 fixing the fix, now "email.@domain.com" is invalied, but "x@domain.com" is valid 2018-02-05 16:06:46 +01:00
Ralf Becker
6efe719ea1 one letter name-part in email address failed validation, eg. "x@egroupware.org" 2018-02-05 15:32:00 +01:00
nathangray
f07dbf7439 Attempt to prefer user's date format when parsing date from a string. 
Should fix merging into spreadsheet problems with certain date formats (dd/mm/yyyy)
 2018-02-02 11:37:30 -07:00
Hadi Nategh
1494d1a6e9 * Addressbook: Fix avatar photo gets removed when adding category to contact via contextmenu 2018-01-31 16:10:48 +01:00
nathangray
cf2b759054 * Admin - fix group list filter & sort 
- Remove created & modified columns since they're not stored for groups
- Fix email sort
- Fix search returned all results
 2018-01-30 11:28:27 -07:00
nathangray
9a398594ac * Etemplate - Don't trust browsers mime if we don't have to - fixes incorrect mime types and Resources rejecting pictures 2018-01-30 09:14:52 -07:00
Ralf Becker
20cde78af3 allow user & password again as in http://user:pass@example.com/ to fix tests 2018-01-30 16:54:43 +01:00
Ralf Becker
a9ee58cfad allow private IP addresses (starting with 10.|169.254.|192.168.) too 2018-01-30 16:19:35 +01:00
Ralf Becker
bff3b0215e * LDAP/ActiveDirectory: fix sorting accounts by anything other then account-name fails 2018-01-29 12:47:57 +01:00
Ralf Becker
37957a49f4 update/add support options in setup and about EGroupware page 2018-01-29 10:20:18 +01:00
nathangray
be93c24def Make sure popup notifications are fully in recipient's language 
"Message from" and "Linked entries" were in sender's language
 2018-01-25 15:40:25 -07:00
nathangray
670b74cf23 Fix wiki links did not load properly after login if your session was expired 2018-01-24 10:28:34 -07:00
Ralf Becker
034eddb37e * Mail: fix invalid domain name in headers stall whole mailbox 
Horde_Idna::decode() and Horde_Mime_Headers::toArray() throws Horde_Idna_Exception for invalid domain names in email addresses like "test@-domain.com", which stall display of whole folder
 2018-01-23 12:58:35 +01:00
Ralf Becker
3dadd5b14b fix call to protected method EGroupware\Api\Mail::clean_subject_for_filename() from context mail_integration 2018-01-23 09:31:54 +01:00
nathangray
e13bd2ed63 Mail - Reorganize and use same cleaning function when saving mail as infolog as for saving to VFS 2018-01-22 09:13:19 -07:00
Ralf Becker
79ee97a22c allow to sepecify last security release for multiple major versions 2018-01-21 10:27:40 +01:00
Hadi Nategh
5e94600677 *Mail: Fix sharing of attached files as download links in compose dialog exposes all folders as readonly shares 2018-01-17 16:32:21 +01:00
nathangray
f402561d7d Better tests for Customfields, fix a couple of permission bugs revealed 
Found a problems when requesting 'all' custom fields, it would still use current user permissions
 2018-01-12 10:03:34 -07:00
nathangray
3709d773d9 * Allow private custom fields in notifications, with filtering according to set permissions. Private custom fields are removed from notifications to non-users. 2018-01-10 10:43:43 -07:00
Ralf Becker
57b92c29de
Merge pull request #32 from stefanwerfling/patch-1 
Update autoload.php
 2017-12-23 12:27:53 +07:00
nathangray
a9b616fa20 * API - Make sure private custom fields are not accidentally included in notification due to being cached 2017-12-21 11:26:51 -07:00
stefanwerfling
bfabaa52eb
Update autoload.php 
- add interface exist check for interface loading by vendor classes
 2017-12-21 19:19:03 +01:00
Hadi Nategh
a3b903b75c * Mail: Fix empty trash/empty junk actions causes error in some mail servers, e.g. Cyrus. 2017-12-15 13:33:04 +01:00
Hadi Nategh
9b639b1fe0 Fix collabora can not open vfs symlinks from apps 2017-12-13 10:10:04 +01:00
Hadi Nategh
d52ede97c5 * Mail: fix vacation notice still sending out notification mail even if the original mail is a spam. 2017-12-08 13:54:11 +01:00
Ralf Becker
2cec97a6c5 replace from PostgreSQL not understood && with standard AND 2017-12-07 17:28:00 +08:00
Ralf Becker
4a13fb4c21 * All apps/PostgreSQL: fix SQL error when deleting an entry without attachments 2017-12-07 17:16:46 +08:00
Ralf Becker
93353a55c0 * Filemanager/PostgreSQL: cant open file in Collabora because of SQL error 
Syntax error: 7 ERROR: syntax error at or near "=“, PostgreSQL needs true/false not 1/0
 2017-12-07 16:45:01 +08:00
Hadi Nategh
594bd63181 * Mail/Admin: Fix upload picture into mail signature from editor image browser does not work. 2017-12-06 16:25:43 +01:00
nathangray
ced6c63ddd Fix historylog pagination, found by Filippos Karailanidis 2017-12-05 15:13:30 -07:00
Nathan Gray
fade7185ae
Merge pull request #31 from filkaris/history_rows 
Historylog widget: Ability to set nextmatch num_rows
 2017-12-05 08:40:30 -07:00
nathangray
6506418e61 * Api - Fix nested custom field merging 2017-12-01 11:58:44 -07:00
nathangray
2df24a3aaf Add flag for select all to collabora action 2017-12-01 10:36:58 -07:00
Hadi Nategh
90a5e91fc7 * Addressbook: fix bug setting Hide User Account in preferences into Show all accounts breaks show accounts 2017-12-01 14:58:44 +01:00
A Sigalas
e9de76af7a Set option for num_rows 2017-12-01 11:04:31 +00:00
Hadi Nategh
a93722959b Use filemanager_select for old etemplate apps 2017-12-01 11:05:32 +01:00
nathangray
e88afc07d0 * Addressbook - fix SQL error with accounts hidden + Organisation by location / department 
- Fix accounts missing if no preference for hide accounts set
 2017-11-29 09:12:05 -07:00
Ralf Becker
dd4ae60fa2 fix avatar/files update issues 2017-11-29 09:58:36 +08:00
Hadi Nategh
95d1911528 Fix error Call to a member function setDate() on boolean 2017-11-27 18:05:47 +01:00
nathangray
b04eb80b39 Addressbook - fix show/hide account preference bugs 
- account filter was missing for show active
- preference changed to match current value
 2017-11-21 11:07:50 -07:00
Hadi Nategh
1ecfab062a Fix list of favorites in VfsSelect contains previous selected contents as well 2017-11-20 17:49:46 +01:00
Hadi Nategh
7e6bcc035f Make favorites available as an individual button in VfsSelect dialog 2017-11-20 17:01:50 +01:00
nathangray
b47777422b Make prefix argument optional 2017-11-16 09:56:20 -07:00
Hadi Nategh
1f998f1612 Fix attempting to open a document link in infolog pops collabora link even the user has no permission to the collabora app 2017-11-16 16:31:22 +01:00
nathangray
867c661796 Fix missing fields in merge if info_contact is not a addressbook entry 2017-11-15 15:41:12 -07:00
nathangray
c8369f9b39 Addressbook - fix hide accounts preference did not work for duplicate & organisation views 
- Added a new preference option to hide only deactivated accounts
 2017-11-15 11:29:10 -07:00
nathangray
ddd45ccc2e Mail - stop additional mail in sent folder when merging multiple contacts into email 2017-11-14 17:00:17 -07:00
Ralf Becker
b408c8b464 allow to specify a date-format in custom-fields using eg. format=Ymd, as it was possible in 11.1 in len field 2017-11-10 17:31:05 +01:00
Nathan Gray
43927f0bd5
Merge pull request #29 from neomorina/patch-2 
Made some changes at egw_actions
 2017-11-10 08:56:55 -07:00
Nathan Gray
a4608d64d7
Merge pull request #28 from neomorina/patch-1 
Add MIME Type "text/csv" when "pagerepeat" found
 2017-11-10 08:50:47 -07:00
Ralf Becker
3055190ea7 * CalDAV/CardDAV: fix encoding of control chars stalling iOS sync 
eg. \xb is not allowed in XML and caused iOS sync to stall, as it's XML parser fails
use htmlspecialchars option ENT_XML1|ENT_DISALLOWED (PHP 5.4+) to ensure proper XML encoding
 2017-11-10 15:49:30 +01:00
Ralf Becker
e5ddf8d6b6 allow to migrate accounts from ADS to SQL 2017-11-09 15:27:50 +01:00
Neo Morina
85866c6ef6
Made some changes at egw_actions 
This is a usefull for opening "second level results" as a popup.
"Second level results" couldn't get opened as a popup at Project Manager app when i try to add a new Project as Template at the selected Project.
 2017-11-09 14:43:49 +01:00
Neo Morina
653a0d50c7
Added MIME Type "text/csv" when "pagerepeat" found 
This gives the possibility to use "pagerepeat" in CSV files.
 2017-11-09 13:16:06 +01:00
Hadi Nategh
861d714724 Fix vfsSelect does not show any content for the first load 2017-11-09 10:25:35 +01:00
nathangray
7c65127e64 Mail - Also include HTML version of email in integration data (for apps that can handle it) 2017-11-08 13:11:46 -07:00
Ralf Becker
ff3ae9815d never invalidate session in sharing, as we cant regenerate it (and we dont need to) 2017-11-07 13:02:39 +01:00
Ralf Becker
719b2ff834 also log if _check_script_tag was able to disarm XSS automatic 2017-11-07 12:23:11 +01:00
Ralf Becker
cfe9204f77 allow sql fragments in Api\Storage\Base::delete as in other places 2017-11-06 16:43:23 +01:00
Ralf Becker
790fa8c71d allow sql fragments in Api\Storage\Base::delete as in other places 2017-11-06 16:24:30 +01:00
Ralf Becker
0d99d129dc deny sharing owner rights (chmod, chgrp, set eACL) and disable eACL tab 2017-11-06 14:52:12 +01:00
nathangray
dda47ca863 Disable extended ACL for readonly shares 2017-11-03 10:28:27 -06:00
Ralf Becker
4ebf79d0e1 * Sharing/Collabora: allow to use Collabora on writable shares (EPL only) 2017-11-03 12:43:09 +01:00
nathangray
ef7956f34b Make sure lang gets passed on to registration 2017-11-02 11:13:29 -06:00
nathangray
069d49afba Disable copy / paste for readonly shares 2017-11-02 09:43:08 -06:00
Ralf Becker
3689b3d645 * Filemanager/Sharing: deny rename, move, mkdir and rmdir on readonly share 2017-11-02 13:34:10 +01:00
Hadi Nategh
3465c40b50 Remove unsafe-eval CSP for CKEditor 2017-11-02 11:02:16 +01:00
Ralf Becker
0813403b5b * All apps: get sharing working with files attached to application entries 2017-10-31 10:51:59 +01:00
Ralf Becker
b9594ea357 fix typo 2017-10-31 10:49:12 +01:00
Ralf Becker
b5574da397 remove system call used for PHP < 5.3.1 2017-10-31 09:55:23 +01:00
Ralf Becker
a4526c98cb store CalDAV/CardDAV log in user spezific log directories 2017-10-30 15:00:42 +01:00
nathangray
616c11c1fb Fix wrong table name 2017-10-27 17:48:42 +02:00
nathangray
0d14155472 Fix minimum fs_id was not returning proper value 2017-10-27 17:43:40 +02:00
nathangray
90ce0cc7b6 Add a function to get the lowest fs_id for a path 2017-10-27 17:43:40 +02:00
Ralf Becker
12dbfca137 check cookies for XSS attempts 2017-10-27 16:52:34 +02:00
nathangray
5750904809 Fix setlocale to be able to find locales on Ubuntu 2017-10-27 10:54:39 +02:00
Ralf Becker
5b573abef7 do not allow path traversal and htmlencode displayed path 2017-10-26 13:16:52 +02:00
nathangray
fdb47ab168 Merge calendar events into user account if there is one over user contact 2017-10-26 09:16:02 +02:00
Ralf Becker
77b42dd9a4 always send X-Content-Type-Options: nosniff 
It does not harm and stops unpredictable results from browsers changing our content-types
(FF 50+ now also supports nosniff)
 2017-10-25 17:35:30 +02:00
Hadi Nategh
fdb3202b6b Add new config to the admin site configuration in order to be able to upload a custom header logo 2017-10-23 13:23:52 +02:00
nathangray
b8f8a014fa Move all tests under api/src into api/tests 2017-10-23 10:14:14 +02:00
nathangray
24de1dff3b Move PHPUnit tests from test to tests subdirectory 2017-10-23 09:51:28 +02:00
Ralf Becker
c88e6e0237 disabling E_DEPRECATED, as contrib apps wont work under PHP 7.1 with having eg. contructors with same name as the class 2017-10-21 12:03:10 +02:00
nathangray
d3c596a443 - Add a parameter to pass in the class of the notification to use so we can pass in a test one 
- Explicitly tell notification what type of message (plain or html) we're giving it
 2017-10-21 11:29:05 +02:00
Hadi Nategh
ff4396030a Fix CKEditor Browse Server button to open vfsSelect 2017-10-20 18:55:22 +02:00
nathangray
accd6187e2 Get date widget duration test working again 2017-10-20 09:56:47 +02:00
nathangray
9e6ecce1d0 Move tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-18 18:30:54 +02:00
nathangray
237d81ce36 Move tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-18 15:43:35 +02:00
nathangray
865fd6405d Move sanity check to a pre-condition check 2017-10-18 11:47:28 +02:00
Ralf Becker
1d7fb9fe90 improve check $GLOBALS[egw] is correctly initilized 2017-10-18 09:10:39 +02:00
nathangray
cd49f6568d Replace the lost boolean cast 2017-10-17 16:48:35 +02:00
nathangray
88a3f3b1d4 Run test in UTC, so dates match our expectations 2017-10-17 15:40:05 +02:00
nathangray
6fad74c710 Fix test had no assertions 2017-10-17 13:29:17 +02:00
nathangray
8b1a8d38f5 Revert db10b21fa7 2017-10-17 12:48:46 +02:00
nathangray
db10b21fa7 Fix child actions under 'More...' did not inherit the inheritable attributes 2017-10-13 11:13:17 -06:00
nathangray
63a3940d68 Addressbook - adjust calendar event participants to match when merging contacts 2017-10-13 09:35:36 -06:00
Hadi Nategh
052bef84ce W.I.P vfsSelect Widget: 
- Fix upload feature not working
 2017-10-13 13:22:45 +02:00
Hadi Nategh
5b76210218 W.I.P vfsSelect Widget: 
- Fix mime types not being shown
- Fix name being displayed encoded in save2vfs mail
 2017-10-12 17:45:46 +02:00
Hadi Nategh
2c721c95b2 W.I.P. VFS Select Widget: 
- Add name and dialog_title as new attributes
- Fix SaveToVfs, SaveAttachmentToVfs, SaveAllToVfs in mail
- Fix button tile
 2017-10-12 13:19:42 +02:00
Hadi Nategh
448cc8975f W.I.P of VFS Select widget restructure 2017-10-11 18:27:42 +02:00
Hadi Nategh
de65d91dc7 Rmove fields for none private cutomfields when name refers to a single custom field 2017-10-06 16:27:37 +02:00
nathangray
0183635c02 Add permission check for collabora before setting actions to open in editor 2017-10-05 09:55:06 -06:00
Ralf Becker
6a3a944828 fix uncaught exception if Collabora is not configured or reachable 2017-10-05 11:00:38 +02:00
nathangray
1868b40359 Set up merge to open editable documents if collabora is there 2017-10-04 14:15:47 -06:00