Nathan Gray
33f264346a
Fix error deleting a favorite
2014-05-13 21:39:23 +00:00
Ralf Becker
ac220a6e82
using egw.is_popup() which deals with situation of egw main-window having an opener (eg. bookmark)
2014-05-13 06:44:50 +00:00
Nathan Gray
9a8182480f
Stop popups from re-initializing sidebox. Fixes favorites causing whole application to reload after saving a popup.
2014-05-12 20:36:18 +00:00
Nathan Gray
140a0746d1
Make sure top actually has app before calling it.
...
Fixes error in calendar where non-list views are still in an iframe, but top window has no app.js
2014-04-30 16:25:05 +00:00
Nathan Gray
4d016169e7
Precautions for iframes + sidebox
...
- Unbind any existing events on existing sidebox, if _init_sidebox() is called again
- Only call _init_sidebox() on top-level window's app.js, fixes some iframe issues with admin
2014-04-29 16:51:57 +00:00
Nathan Gray
5c19f99d9d
Remove no longer needed AJAX call for groups, API now provides them directly to the widget
2014-04-29 16:15:23 +00:00
Hadi Nategh
c912849bd5
Apply favorites sortable feature to sidebox fav. menu
2014-04-25 07:37:11 +00:00
Ralf Becker
ac18b6cc8d
changed et2_core_inheritance.js to implement ClassWithAttributes extending Class from egw_inheritance and changed et2 objects to use ClassWithAttributes when required (also fixed lots of IDE warnings / added docu)
2014-03-20 09:40:37 +00:00
Ralf Becker
086195c0aa
stop event propagation after calling setState, fixes "double sidebox" in CRM view, if called via a favorite (caused 2 identical requests to server, which both added their sidebox)
2014-03-11 08:16:52 +00:00
Nathan Gray
e9b5dfde4d
Bind key handler to save favorite on Enter
2014-03-03 18:51:58 +00:00
Ralf Becker
1ae9925cd5
removed .on("mouse(enter|leave)" (wrapping trash icon), as it stalls delete of favorites in IE11
2014-02-26 15:44:00 +00:00
Ralf Becker
b692346cce
several IE11 fixes avoiding or working around javascript errors
2014-02-19 15:10:39 +00:00
Ralf Becker
d01d5119ca
calling app[appname].et2_ready(et2,name) with template name as second parameter
2014-02-17 14:58:20 +00:00
Ralf Becker
0fa215c9e8
fixed sometimes not deletable favorites
2014-02-14 12:46:49 +00:00
Ralf Becker
af1e70ab32
fixed javascript error, if favorite has no href AND make sure all new favorites are created with an href, like they are created server-side
2014-02-13 16:50:49 +00:00
Ralf Becker
3a5ece79a7
fixed creating or deleting favorites in calendar does not work: was caused by sidebox not initialised as not yet loaded, now calling _init_sidebox from framework, also need to add a click handler for favorites as initialising sidebox removes one installed from template
2014-02-13 15:37:49 +00:00
Ralf Becker
f0d7751496
removed caret from group favorites, fixed prefered favorite was not show correct initialy nor updated
2014-02-12 21:51:25 +00:00
Ralf Becker
4a7c0204a0
fixed just added favorite can NOT be used as default for dropdown button (gave alert "No default set")
2014-02-12 20:55:10 +00:00
Nathan Gray
1ca01da9b0
Fix missing group ID when deleting group favorites, fixes unable to delete group favorites
2014-02-12 17:33:22 +00:00
Ralf Becker
22b66c9e3d
fix javascript error when clicking on a group favorite (state.state is undefined)
2014-02-12 11:23:04 +00:00
Nathan Gray
444d82d1c7
-Unencode favorite search, firefox leaves encoded spaces
...
-If adding a favorite with same name as existing favorite, old one is removed from the sidebox.
2014-02-06 17:53:29 +00:00
Nathan Gray
1cb3ac1111
Fix groups in add favorite popup:
...
- missing options for selectbox
- saving for group wouldn't work
2014-02-06 00:30:03 +00:00
Nathan Gray
c771f2fc80
Make sure group is there before trying to set its value
2014-02-05 20:53:08 +00:00
Nathan Gray
a79f7b87a6
Continue moving most favorite functionality from favorite widget into framework. Favorite widget now uses framework.
2013-12-12 23:45:09 +00:00
Ralf Becker
2bb7b7565c
fix add-favorite method to NOT bubble and giving a CSP warning instead of running
2013-12-12 02:42:08 +00:00
Nathan Gray
e15144c7f9
- Fix name in delete confirm
...
- Some documentation & cleanup
2013-12-12 00:38:06 +00:00
Nathan Gray
0ecc494cb4
Remove loading class if there is no favorite delete being processed
2013-12-12 00:00:54 +00:00
Nathan Gray
d2e2622b77
Remove reference to sidebox in destructor
2013-12-11 23:54:42 +00:00
Nathan Gray
443b8ed854
Give some UI feedback if the delete does not work
2013-12-06 23:26:48 +00:00
Nathan Gray
72c37e0849
non-et2 Favorites work in progress
...
Handle states that are id_data objects for egw.open()
2013-12-06 23:12:05 +00:00
Nathan Gray
d097a0bfa1
non-et2 Favorites work in progress
...
New states now added to list immediately, can delete states
2013-12-06 21:26:55 +00:00
Nathan Gray
79498c5ae5
non-et2 Favorites work in progress
...
Can now save & restore state. Still some UI needed, not fully integrated with et2 favorites.
2013-12-06 18:24:29 +00:00
Nathan Gray
cfefedc8f7
non-et2 Favorites work in progress
...
Add current link shows popup with state details.
2013-12-05 23:22:54 +00:00
Nathan Gray
87936488bf
Implement getState() & setState() towards a more universal favorites, but still more to do:
...
- Need to get favorite widget to use setState()
- Move much code out of etemplate2 widgets into a higher level
2013-12-05 00:00:43 +00:00
Ralf Becker
6d226a7921
split constructor function and place of instanciation for app.js objects: app[appname] = new app.classes[appname]();
2013-11-04 20:54:23 +00:00
Ralf Becker
a6311fa1a3
creating and using an app-specific egw object
2013-10-07 16:53:13 +00:00
Nathan Gray
1d9589db99
If et2 object changes, we need the new one, not reject.
2013-08-20 23:20:56 +00:00
Nathan Gray
dca0c40418
Promote some useful common functionality to the app.js parent class
2013-08-20 19:20:10 +00:00
Ralf Becker
0d7c5455df
fixed wrong dependency
2013-07-19 15:22:54 +00:00
Nathan Gray
978a90852c
Add a base object for application javascript code to contain it, and solve initialization timing issues
2013-04-09 08:45:59 +00:00
