Commit Graph

510 Commits

Author SHA1 Message Date
ralf
8d645e5a7d final fix for "Network error" when stream files to client
It is important to FIRST disable zlib.output_compression (before headers are sent!) and THEN end all output-buffering!
Without the two steps in this order, we are either limited by the memory limit or get the "Network error", because the streaming/fpassthrough does not apply the compression.
2022-05-05 12:49:07 +02:00
ralf
2d4980f080 next chunk of fixed PHP Warning: Undefined array key or variable in main repo 2022-04-27 20:31:12 +02:00
ralf
12c0f4efd6 fix TypeError: fpassthru(): Argument #1 ($stream) must be of type resource, string given 2022-04-21 11:27:52 +02:00
nathan
554d125d96 Leave output buffering alone, since trying to turn it off makes the download fail
The browser was giving "Failed - Network error" and there was nothing in the server log. ob_get_level() was giving 3, but trying to turn it using ob_end_clean() was just... failing.
2022-04-21 11:27:52 +02:00
ralf
9a7a24e155 fix PHP 8.0 Error: explode(): Argument #2 ($string) must be of type string, array given 2022-04-06 16:29:17 +03:00
Ralf Becker
0ae7f21fa1 fix explode(): Argument #2 ($string) must be of type string, array given 2022-01-06 19:12:10 +02:00
Ralf Becker
a75d42eb8f fix PHP 8.0 Error: Illegal string offset 'string' 2021-11-23 17:18:17 +01:00
Ralf Becker
3b08a5979a fix PHP 8.0 TypeError: count(): Argument #1 ($value) must be of type Countable|array, bool given 2021-11-23 08:42:30 +01:00
Ralf Becker
8f73669d6a fix PHP 8.0 TypeError: Unsupported operand types: string + string 2021-11-22 08:41:28 +01:00
Ralf Becker
2a57071d88 fix PHP 8.0 TypeError: implode(): Argument #1 ($pieces) must be of type array, string given 2021-11-22 08:37:15 +01:00
nathan
e1ac07a766 Fix PHP 8.0 TypeError: get_class(): Argument #1 ($object) must be of type object, null given
Also fix some deprecated implode() calls
2021-11-16 09:37:47 -07:00
Ralf Becker
3803cbd133 fix PHP 8.0 TypeError: implode(): Argument #2 ($array) must be of type ?array, string given 2021-11-16 08:41:02 +01:00
Ralf Becker
a3ecf4fe0e fix PHP 8.0 ValueError: fgetcsv(): Argument #3 ($separator) must be a single character 2021-11-16 08:38:15 +01:00
Ralf Becker
21c62f083d fix PHP 8.0 ValueError: Path cannot be empty
and other IDE errors
2021-11-16 08:18:33 +01:00
Ralf Becker
edd42f1212 fix PHP 8.0 Error: Undefined constant "self" 2021-11-15 15:56:01 +01:00
Ralf Becker
eca5200268 fix diverse PHP 8.0 TypeErrors and ArgumentCountError in import/export 2021-11-15 14:42:40 +01:00
Ralf Becker
738ee7a8ec fix PHP 8.0 TypeError: array_keys(): Argument #1 ($array) must be of type array, null given 2021-11-15 08:03:17 +01:00
Ralf Becker
6eca840838 fix PHP 8.0 TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given 2021-11-14 15:48:44 +01:00
Ralf Becker
e7e16da33d fix PHP 8.0 TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given 2021-11-14 15:38:19 +01:00
Ralf Becker
a125be6074 fix PHP 8.0 TypeError: Api\Accounts::username(): Argument #1 ($account_id) must be of type ?int, string given
using Api\Accounts::title() but cast to int, if giving an non-zero result
2021-11-08 12:35:14 +01:00
nathan
ddaef879a8 Try to avoid "PHP Warning: DOMDocument::loadXML(): Empty string supplied as input" 2021-11-03 09:39:30 -06:00
Ralf Becker
efff64299c fix big chunk of PHP 8.0 warnings 2021-10-21 10:42:18 +02:00
Ralf Becker
937a96198c fix PHP 8.0 error: count(): Argument #1 ($value) must be of type Countable|array, string given 2021-10-19 09:03:57 +02:00
nathan
506a9bb2f9 Fix PHP 8 error: "array_search(): Argument #2 ($haystack) must be of type array, null given" 2021-10-14 08:59:18 -06:00
nathan
7502749ef1 Avoid some more PHP8 errors
An error happened! (TypeError): Cannot access offset of type string on string
2021-10-14 08:59:05 -06:00
nathan
f8fd87cd1d PHP 8.0: Avoid fatal error "array_key_exists(): Argument #2 ($array) must be of type array, null given" 2021-10-14 08:58:57 -06:00
Ralf Becker
8485a1ea04 fix PHP 8.0 TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given 2021-10-11 12:43:41 +02:00
nathangray
883eb9132d Importexport: Fix import category from file was always blank 2021-04-22 14:28:57 -06:00
nathangray
145b7efca2 Importexport: Fix clicking import button from list did not start with that definition loaded 2021-04-22 14:28:19 -06:00
nathangray
aff06ec4cc Import/export fixes
- Fix for missing floats by Jürgen Dlugi
- Fix broken timesheet export was always 0 results
2021-04-08 16:53:06 -06:00
nathangray
98219a2517 Put type in front of variable name 2021-03-31 13:14:18 -06:00
nathangray
a21c49d99c PHP 8 code quality improvements suggested by PHPStorm 2021-03-31 11:25:12 -06:00
Ralf Becker
868135775c PHP 8 fixes 2021-03-29 16:47:19 +02:00
Ralf Becker
ab9c089f70 fix PHP 8 Fatal error Array and string offset access syntax with curly braces is no longer supported 2021-03-21 21:13:07 +01:00
nathangray
947755676e ImportExport: Another fix for exporting custom date fields with custom format.
- PHP base DateTime class was being used instead of our own Api\DateTime
- User's preferred date format was not being respected
- Custom formatting was only parsed if the first entry had a value in that field
2020-09-18 10:06:04 -06:00
nathangray
edaf3abd4f ImportExport: Fix custom dates formatting to work for more than just the first row 2020-09-10 11:39:25 -06:00
nathangray
3c4d46b030 ImportExport: Fix date-time customfields with custom format were not exported correctly
see 74bd66d857
2020-09-04 11:06:25 -06:00
nathangray
74bd66d857 * ImportExport: Date custom fields with custom formatting now correctly handled 2020-09-03 11:29:55 -06:00
nathangray
bc253e0bd7 ImportExport: Fix all custom field types were showing up as filterable. Now limited to the ones we can handle. 2020-07-10 11:25:49 -06:00
nathangray
1a3582536a Import/Export: Fix export destroyed list's etemplate request 2020-07-09 13:14:24 -06:00
nathangray
aba5f61a42 Fix missing translation reported by Stefan Unverricht 2020-04-15 10:15:24 -06:00
nathangray
d31d19c1ec * Import/Export: Fix export CSV with Tab delimiter literally inserted '\t' instead of tab.
Reported by xenolevis
2019-10-02 11:48:10 -06:00
nathangray
11e145967e Remove unused preferred export definition preference 2019-08-02 10:17:16 -06:00
nathangray
196cd13771 Importexport - support deleteaccount hook 2019-07-22 15:11:09 -06:00
nathangray
94798bb691 Import/Export - fix definition list actions (Create export) disappeared from context menu after use 2019-07-08 13:49:16 -06:00
nathangray
fdddeb1e84 ImportExport - fix create export from import fails with error
"Too few arguments to function importexport_definitions_ui::save(), 0 passed..."
2019-06-24 09:35:11 -06:00
nathangray
e71bbd8abe Store requester and comment into command history when importing users 2019-05-10 13:33:04 -06:00
nathangray
8230686a1b Import/Export - add definition setting to force a certain category
- update tracker to extend importexport_basic_import_csv
2019-03-07 15:52:48 -07:00
nathangray
0c9904a21a Importexport - handle select values that are label,value pairs as well as name => value 2019-03-06 14:31:06 -07:00
nathangray
b7c0fce767 Avoid warning if conditions do not exist 2019-02-07 10:56:10 -07:00