Commit Graph

1049 Commits

Author SHA1 Message Date
nathangray
3c5b7c8ba5 * Addressbook - Allow multiselection for customfield added to link title 2018-08-08 09:18:55 -06:00
Ralf Becker
af6c2a0f25 * CalDAV/Calendar: fix not working snozzing of alarms in Thunderbird
Caused by triggered alarms were - so far - immediatly deleted, now we keep them around for an other day, so TB get them in the update iCal after PUTing its X-MOZ-SNOOZE-TIME-<timestampt>
2018-08-07 15:03:59 +02:00
Hadi Nategh
dae7c85b42 Warn user on login page if using browser is IE 11 or below. 2018-08-07 13:40:46 +02:00
Ralf Becker
c579347ad1 allow to identify real changes 2018-08-03 11:56:34 +02:00
Hadi Nategh
024c8ce7fb * Framework: fix broken favicon 2018-08-02 09:52:31 +02:00
Hadi Nategh
7e126290f7 Some more basename replacing with Vfs::basename to avoid setlocale issue. 2018-08-01 11:11:16 +02:00
Hadi Nategh
17cfcf1168 Replace basename with Vfs::basename to avoid setlocale issue. 2018-08-01 10:02:16 +02:00
Hadi Nategh
d89247fdf3 Strip RFC822 email to avoid search contacts other than email itself. Fix issue sometimes add as new contact not showing up because it takes it as existing contact. 2018-07-31 11:06:38 +02:00
nathangray
17ba77d369 Make sure we get correct path when sharing from a share 2018-07-30 12:55:23 -06:00
Ralf Becker
634efff9c4 fix SQL error or information leakage on no longer available custom fields 2018-07-30 15:28:12 +02:00
Ralf Becker
f4081c1443 Revert "* Api - Avoid SQL errors caused by removed custom fields still in favorites"
This reverts commit a03931493f.
2018-07-30 15:28:12 +02:00
nathangray
0098f41a12 Fix missing collabora app 2018-07-26 15:08:32 -06:00
Hadi Nategh
7413b60ecf Do not add edit setting action when we are in sharing view 2018-07-26 14:10:53 +02:00
nathangray
a03931493f * Api - Avoid SQL errors caused by removed custom fields still in favorites 2018-07-25 10:16:46 -06:00
Hadi Nategh
c5e902926b Fix notifications with same id but no links are not getting grouped together 2018-07-23 16:25:07 +02:00
nathangray
82ea4fe2de * Addressbook - add filtering by distribution list for organisations 2018-07-19 14:54:05 -06:00
nathangray
de15acc03d Add div to list of tags that avoid HTML encoding on replacements
Fixes HTML tracker description from external source showing HTML in notifications
2018-07-19 12:50:22 -06:00
nathangray
8092e1fb86 Set current app to filemanager so js loads correctly 2018-07-18 12:27:27 -06:00
Ralf Becker
e6dab124ee * Univention: fix not working password change (setting Kerberos credentials) 2018-07-13 09:58:38 +02:00
Hadi Nategh
677a4a03fb * Tracker: fix issue text part of some html tickets mail notifications contain html parts 2018-07-12 17:47:19 +02:00
Hadi Nategh
dd03c7fe16 * Mail: fix some smime signed messages get recognized wrongly as encrypted 2018-07-04 15:41:43 +02:00
Ralf Becker
18a048e5c8 finish migration AD to new UCS domain via EGroupware 2018-07-03 22:25:08 +02:00
Hadi Nategh
eb5652dc20 * Api: get avatar showing up for taglist accounts and calendar owner 2018-06-29 10:12:59 +02:00
Ralf Becker
a11b9a266b * Addressbook: fix SMime/PGP public key import not containing a newline after the key 2018-06-25 14:23:19 +02:00
Ralf Becker
b29f89cf16 migrate AD accounts incl. mail-attributes to SQL 2018-06-20 15:25:44 +02:00
nathangray
b049a68cb9 Api - Better way to clear recipients between merges that doesn't loose the placeholder 2018-06-18 10:26:49 -06:00
Hadi Nategh
5f3b59fe3d Remove meta tag by HtmLawed 2018-06-18 11:08:46 +02:00
Ralf Becker
7ba77356d5 new "session_created" hook 2018-06-18 09:07:14 +02:00
Hadi Nategh
8f53e3d9f1 * Mail: warn user when there's no space left for storing sieve rules because of sieve_maxscriptsize limit 2018-06-15 15:49:34 +02:00
nathangray
aea2b4d216 * Api - Clear recipients between merges to avoid sending subsequent merges to previous contacts 2018-06-14 11:09:56 -06:00
nathangray
c3b642a39a Allow apps to implement their own Sharing 2018-06-13 14:45:43 -06:00
Ralf Becker
baa2807606 some hooks needed for new policy app 2018-06-12 19:04:02 +02:00
nathangray
d201dc9fd9 Seperate birthday cache by language 2018-06-11 11:26:08 -06:00
nathangray
67d8166b27 Better way to handle an app having more than one etemplate2_before_exec hook - fixes collabora stopped working 2018-06-08 10:26:48 -06:00
nathangray
6708ccb043 Record share emails in history log & display them instead of user when set 2018-06-06 15:51:46 -06:00
nathangray
0582f2347f Fix a few issues from Scrutinizer
- Remove debug code
- Remove some unused variables
- Add get_ui() to base class that gives error message (should always be a subclass)
2018-06-06 09:54:49 -06:00
nathangray
cc21c823dd Handle an app having more than one etemplate2_before_exec hook 2018-06-05 15:34:54 -06:00
nathangray
847d1c6812 Fix some namespace errors 2018-06-05 15:01:09 -06:00
nathangray
ca32d0bc50 Remove unreachable code 2018-06-05 14:59:05 -06:00
nathangray
71ee883210 Entry sharing - handle files checkbox 2018-06-05 14:31:04 -06:00
nathangray
1bd5927869 Pass action back to popup so it knows what to do 2018-06-05 14:31:04 -06:00
nathangray
a1a7570c86 Add method to get sharing context menu actions 2018-06-05 14:31:04 -06:00
nathangray
4a9df7ef33 Got link creation via context menu working 2018-06-05 14:31:04 -06:00
nathangray
a5f5930064 Check record-level permissions 2018-06-05 14:31:04 -06:00
nathangray
d0a50d8d45 Changes needed to just get the screenshots, much more work needed for proper functionallity since I faked the permissions 2018-06-05 14:31:04 -06:00
Ralf Becker
430368eab9 new JSON response method "message" to call egw.message eg. in a popup, by using the context from the egw.json call 2018-06-05 12:29:51 +02:00
nathangray
5d65420a03 Limit subjects for filenames to 200 characters to avoid failures 2018-06-04 10:24:15 -06:00
Ralf Becker
84b715c5af * Admin: allow to show last login, IP and password change in list 2018-06-01 14:46:52 +02:00
Hadi Nategh
f479314e06 Allow apps to load JavaScript or CSS files, knowing we're loading the framework or not 2018-06-01 10:37:38 +02:00
Hadi Nategh
71ae7876d6 Fix namespace issue when calling function 2018-05-29 11:13:12 +02:00
Hadi Nategh
e9f1e8bcad Implement taglist-thumbnail for rest of upload image fields in admin site configuration 2018-05-29 11:05:08 +02:00
Hadi Nategh
6aeb7a5c1e * Admin: Implement new feature to upload multiple images for login background image in site-configuration and show them randomly. 2018-05-28 15:31:32 +02:00
Hadi Nategh
ecb8f84afa Add complementary option for app-select widget in order to be able to exclude specific apps from the list 2018-05-22 14:39:15 +02:00
Ralf Becker
54ee23e731 use error-image from api not old phpgwapi 2018-05-20 13:22:46 +02:00
Hadi Nategh
41a983e317 Make a bigger header size assumption (32k) in order to cover importing mails with big headers 2018-05-14 14:54:44 +02:00
nathangray
5ceea5b93e Slightly more robust checking for "blank" HTML area in case CKEditor adds some styles 2018-05-11 15:00:12 -06:00
nathangray
8030c477c9 Avoid warning about scheme already registered 2018-05-11 11:25:02 -06:00
nathangray
668a4fede8 Api - Turn on merge for presentations, text templates, spreadsheet templates and presentation templates 2018-05-07 13:34:35 -06:00
nathangray
0dea93ac15 Api - Editing files in shared directories & sharing editable links 2018-05-07 10:40:12 -06:00
Ralf Becker
ba366467b0 * Admin/Mail: fix saving mail-accounts for multiple accounts 2018-05-04 15:07:06 +02:00
nathangray
0d52cc293b Throw an exception (that phpunit can catch) rather than exiting on failure so all tests can get 2018-05-03 10:59:22 -06:00
Ralf Becker
b8e230190f * Mail: fixed equal signs (=) are not displayed in subject
Not sure why, but equal sign was removed unconditional together with other non-printable chars.
Equal sign is now removed from that preg and code is cleaned up to have a single preg removing unprintable chars independet on the function used to decode the header.
2018-05-03 11:01:08 +02:00
nathangray
cf4752e8dd Change account filtering to give accounts when asked even if accounts are hidden in preferences 2018-04-26 14:34:09 -06:00
nathangray
6c4ea8cb38 Api - Stop adding calcext:value-type attributes when merging to spreadsheets, they're no longer used and can cause a warning with recent templates 2018-04-23 09:24:49 -06:00
nathangray
48239f3506 Fix mail merge into mail template excluded BCC 2018-04-20 12:00:50 -06:00
Ralf Becker
fa2403f905 * EMail: fix searching in email gives an error
reverting commit 5bd63482ea as the implemented __isset and ArrayAccess interface hide the one implemented by parent Horde_Imap_Client
2018-04-20 10:39:23 +02:00
nathangray
235746e4d6 * Addressbook - Add preference to turn off user groups as distribution lists 2018-04-17 09:35:08 -06:00
Ralf Becker
5bd63482ea implement __isset and ArrayAccess for Imap, to allow eg. to use empty($imap->attribute) 2018-04-17 10:28:37 +02:00
Ralf Becker
753beb06ac fix PHP 7.2 Warning: The each() function is deprecated 2018-04-13 16:08:37 +02:00
Ralf Becker
77b79f24b7 * Setup: updates from old versions (eg. 1.4 or 1.8) no longer require to update to 14.x and 16.1 first 2018-04-13 13:46:49 +02:00
Ralf Becker
f1437d4ccb fixing a couple more PHP Warning count(): Parameter must be an array or an object that implements Countable 2018-04-13 09:12:26 +02:00
Ralf Becker
63d89a3ba0 * Setup/Restore: restore from a other charsets then utf-8 failed 2018-04-12 18:00:27 +02:00
Ralf Becker
81143a0624 * All apps: fixed moving attachments to new entries (without attachments) lost moved file 2018-04-12 15:10:05 +02:00
Ralf Becker
d70304e391 * CalDAV/resources: fix wrong ACL/rights send to clients (PHP warning in log) 2018-04-12 13:03:13 +02:00
Ralf Becker
235821b04a run fastcgi_finish_request also for non-compat install 2018-04-11 15:05:53 +02:00
Ralf Becker
7c1a481d97 fix shutdown functions did not have $GLOBALS[egw] set, caused by session created by MServer 2018-04-11 15:04:48 +02:00
Ralf Becker
ad95a01cec fixing function and test 2018-04-11 14:05:49 +02:00
Ralf Becker
047e68ecd4 limit filesystem depth for managed attachments to gard against infinit recursion 2018-04-11 11:25:53 +02:00
Ralf Becker
bded1bf17e remove 4-byte unicode when cleaning subjects 2018-04-11 11:22:11 +02:00
Ralf Becker
104cae6081 fix smime key got immediatly deleted again 2018-04-10 14:52:14 +02:00
Ralf Becker
5b93dd160c fixing not working links stream-wrapper 2018-04-10 08:54:32 +02:00
nathangray
f26b271067 Exclude symlinks from Vfs 2018-04-09 14:02:24 -06:00
nathangray
abc1ccc8f1 Trying to share a symlink actually uses the link target instead 2018-04-09 14:02:24 -06:00
Ralf Becker
98c7a7af64 fix Scrutinizer issue (seems to be some left over old code) 2018-04-09 16:32:00 +02:00
Ralf Becker
98376b5908 * PHP 7.2: fix several PHP Fatal errors and warnings stalling installation and usage 2018-04-09 16:02:00 +02:00
Hadi Nategh
d9d051a97e Fix move/copy actions in link_to widget vfsSelect try to create not unwanted new symlink 2018-04-04 17:54:30 +02:00
nathangray
1cb13a1f13 * Api - Fix references to sub-fields of custom field entries only merged for the first entry of each type 2018-04-03 15:27:09 -06:00
Hadi Nategh
980b4e1ab2 Make sure mail_bo object is there before using it, fixes error "can not call undefined function reopen()" 2018-04-03 10:33:40 +02:00
nathangray
0a7f81a2e2 Api - Sharing from filesystem:// mounts - with tests even 2018-03-23 13:01:43 -06:00
Hadi Nategh
2943b678bd Fix merge replace placeholders causes huge performance issue. Additionally, fixes the extra $ sign shown up in replaced placeholders. 2018-03-23 16:46:51 +01:00
Ralf Becker
74746a14ef * Sharing/Collabora: fix not working cleanup of temp. files and shares
- 14.x installs had the job created with old class-name egw_sharing
- Wopi shares where never cleaned up, they are now after 3 month
2018-03-22 13:09:59 +01:00
Ralf Becker
1d835928d2 new method Api\Framework::getUrl() to get a full / externally usable Url 2018-03-21 12:51:52 +01:00
Ralf Becker
21e123ef84 do NOT use hostname configured in setup, if it is the default localhost
stick with HTTP Host header in that case
2018-03-21 12:49:31 +01:00
Hadi Nategh
045436609d Get Sharing + Collabora into latest 17.1 version 2018-03-21 12:43:25 +01:00
Hadi Nategh
be4dbc37ae * Fix opening collabora fails from a shared directory:
-we need to have collabora app to avoid CSP error since redirect share-link in collabora should get frame-src. e.g:(Collabora/Src/Ui.php:redirect(Sharing::share2link))
2018-03-16 13:15:45 +01:00
Hadi Nategh
e9b80ecee5 Remove not used csp method 2018-03-16 13:14:16 +01:00
nathangray
3185acb7b1 Add merge into the list to get /apps working again 2018-03-15 16:55:43 -06:00
nathangray
6be5b8f678 Fix editing a file through gave not found error if the symlink was in a versioned directory 2018-03-15 16:55:43 -06:00
Hadi Nategh
65b2588d65 Add missing negation from commit 600872a4bf 2018-03-15 12:24:19 +01:00
Hadi Nategh
600872a4bf An attempt to fix broken collabora sharing which originally got broken by commit f166fbdd46 in order to get mounted template sharing fixed. 2018-03-14 18:58:30 +01:00
Ralf Becker
dcb78d9776 remove due to own table in 17.1 no longer needed migration of (private) custome-fields 2018-03-14 14:50:46 +01:00
Hadi Nategh
eb1eed5b8d Implement new feature for vfs-select widget to accept extra buttons action. Additionally, add extra "copy" and "move" actions to link-to vfs dialog. 2018-03-13 17:43:21 +01:00
Ralf Becker
ddd4127ee7 * AD/LDAP migration: change favorites and index states too 2018-03-12 21:22:12 +01:00
nathangray
357e5a3326 Re-init static streamwrapper, as some of them look at permissions or preferences 2018-03-12 13:51:04 -06:00
Ralf Becker
c2c1bdb6ad * EMail/Tracker/InfoLog: fix error converting mails by replacing 4-byte utf8 chars
MySQL and MariaDB before 10.1 need 4-byte utf8 chars replaced with our default utf8 charset
(MariaDB 10.1 does the replacement automatic, 10.0 cuts everything off behind and MySQL gives an error)
Changing charset to utf8mb4 requires schema update, shortening of some indexes and probably have negative impact on performace!
		if (substr($this->Type, 0, 5) == 'mysql' && $this->ServerInfo['version'] < 10.1)
		{
			$value = preg_replace('/[\x{10000}-\x{10FFFF}]/u', "\xEF\xBF\xBD", $value);
		}
2018-03-12 14:02:13 +01:00
Ralf Becker
163c87db82 * Api: use proxy configuration when downloading available tutorial videos 2018-03-12 11:16:57 +01:00
Hadi Nategh
fbf63bf65c Fix tutorials.json url to use https 2018-03-12 11:08:09 +01:00
Ralf Becker
32d10dd243 Fix not working textbox validators containing backslashes
PHP xml parser reads backslashes literal from attributes, 
while JavaScript ones need them escaped (eg. like PHP strings)
-> replace \\ with \ to get following XML working: validator="/^\\d+$"
2018-03-10 17:55:12 +01:00
Ralf Becker
e578e64926 ActiveDirectory: additional allow accountExpires=0 for never expires
(beside attribute is not set or has value 9223372036854775807)
2018-03-09 19:51:49 +01:00
nathangray
223b55d631 Api - Allow sharing to use Collabora to open files instead of downloading 2018-03-07 11:29:00 -07:00
Hadi Nategh
d2859d5cee * Mail: Fix "tel:" href links wrongly get denied by mail compose 2018-03-05 18:16:12 +01:00
Hadi Nategh
53b97078ad Fix mail with a bold digits gets removed from text part 2018-03-05 17:31:47 +01:00
Hadi Nategh
dca72ebd9c Fix broken sharing caused by commit 89a8e6f448 2018-03-05 11:13:54 +01:00
nathangray
9a51ad9211 API - Avoid issue with incompatable types by forcing to array, even if no account found 2018-03-02 10:21:43 -07:00
Hadi Nategh
63dd5ce96b Make sure replace only and only VT char (Vertical Tab) 2018-03-02 12:13:13 +01:00
Ralf Becker
205cf9c588 replace non-utf8 chars in content send to browser with utf8 replacement char
before we were removing the whole string
2018-03-01 17:38:45 +01:00
Ralf Becker
f800ab008b if we can not store failed login attempts in database, store it in cache 2018-02-28 18:01:32 +01:00
Ralf Becker
a799abb0a0 * All apps: multiselect custom-field switches to single select after submit 2018-02-28 13:41:13 +01:00
Ralf Becker
c1e8ac6324 Switching consistent hashing (Libketama) off by default
as for just 2 Memcached servers it creates an extrem unbalanced 
distribution favoring the 2. server and has no benefits,
as requests to the failed node can only go to the other one anyway.
2018-02-28 10:45:48 +01:00
Ralf Becker
8b88e748f7 * Admin: new config to generate no or lowercase email addresses for new users 2018-02-20 09:15:42 +01:00
nathangray
816db05496 Use abstraction to determine mime type, see 9a398594ac 2018-02-15 10:16:04 -07:00
nathangray
89a8e6f448 Place check on session first to avoid errors if it's missing 2018-02-15 09:19:26 -07:00
Ralf Becker
e3c67a1c63 fix PHP Warning if keys contain a backslash as in namespaced classes 2018-02-15 09:52:24 +01:00
nathangray
9c29079ddf Silence warning about time in array format by passing it to constructor 2018-02-14 08:38:48 -07:00
Ralf Becker
f4927d7e0b * Filemanager/Sharing: fix PHP 7.1 error causing auth request to popup
Session only stores app-names and $GLOBALS[egw_info][user][apps] gets restored from $GLOBALS[egw_info][apps] for the allowed app-names. Check if we need to restore from installed apps array was using is_array($GLOBALS[egw_info][user][apps][api]) instead or isset($GLOBALS[egw_info][user][apps][0]), as check if it is a real, non associative array
2018-02-14 09:03:14 +01:00
nathangray
f166fbdd46 * Api - Fix sharing from mounted shares failed with 404 2018-02-13 15:10:34 -07:00
nathangray
c67560049c * Api - Check if email address is known before offering 'Add as contact' button 2018-02-08 13:19:26 -07:00
Hadi Nategh
4e0be8a887 Allow custom theme for mobile template 2018-02-08 10:10:15 +01:00
nathangray
a8ffe5ab05 * Api - Fix some spelling errors, reported by Stefan Unverricht 2018-02-07 13:30:55 -07:00
Hadi Nategh
034b17a49a Implement new user preference in order to be able to select a handler for opening a merge print document 2018-02-07 13:15:29 +01:00
Ralf Becker
d934f33ea6 also fixing preg for email with optional domain part 2018-02-05 19:13:01 +01:00
Ralf Becker
75a39143f8 fixing the fix, now "email.@domain.com" is invalied, but "x@domain.com" is valid 2018-02-05 16:06:46 +01:00
Ralf Becker
6efe719ea1 one letter name-part in email address failed validation, eg. "x@egroupware.org" 2018-02-05 15:32:00 +01:00
nathangray
f07dbf7439 Attempt to prefer user's date format when parsing date from a string.
Should fix merging into spreadsheet problems with certain date formats (dd/mm/yyyy)
2018-02-02 11:37:30 -07:00
Hadi Nategh
1494d1a6e9 * Addressbook: Fix avatar photo gets removed when adding category to contact via contextmenu 2018-01-31 16:10:48 +01:00
nathangray
cf2b759054 * Admin - fix group list filter & sort
- Remove created & modified columns since they're not stored for groups
- Fix email sort
- Fix search returned all results
2018-01-30 11:28:27 -07:00
nathangray
9a398594ac * Etemplate - Don't trust browsers mime if we don't have to - fixes incorrect mime types and Resources rejecting pictures 2018-01-30 09:14:52 -07:00
Ralf Becker
20cde78af3 allow user & password again as in http://user:pass@example.com/ to fix tests 2018-01-30 16:54:43 +01:00
Ralf Becker
a9ee58cfad allow private IP addresses (starting with 10.|169.254.|192.168.) too 2018-01-30 16:19:35 +01:00
Ralf Becker
bff3b0215e * LDAP/ActiveDirectory: fix sorting accounts by anything other then account-name fails 2018-01-29 12:47:57 +01:00
Ralf Becker
37957a49f4 update/add support options in setup and about EGroupware page 2018-01-29 10:20:18 +01:00
nathangray
be93c24def Make sure popup notifications are fully in recipient's language
"Message from" and "Linked entries" were in sender's language
2018-01-25 15:40:25 -07:00
nathangray
670b74cf23 Fix wiki links did not load properly after login if your session was expired 2018-01-24 10:28:34 -07:00
Ralf Becker
034eddb37e * Mail: fix invalid domain name in headers stall whole mailbox
Horde_Idna::decode() and Horde_Mime_Headers::toArray() throws Horde_Idna_Exception for invalid domain names in email addresses like "test@-domain.com", which stall display of whole folder
2018-01-23 12:58:35 +01:00
Ralf Becker
3dadd5b14b fix call to protected method EGroupware\Api\Mail::clean_subject_for_filename() from context mail_integration 2018-01-23 09:31:54 +01:00
nathangray
e13bd2ed63 Mail - Reorganize and use same cleaning function when saving mail as infolog as for saving to VFS 2018-01-22 09:13:19 -07:00
Ralf Becker
79ee97a22c allow to sepecify last security release for multiple major versions 2018-01-21 10:27:40 +01:00
Hadi Nategh
5e94600677 *Mail: Fix sharing of attached files as download links in compose dialog exposes all folders as readonly shares 2018-01-17 16:32:21 +01:00
nathangray
f402561d7d Better tests for Customfields, fix a couple of permission bugs revealed
Found a problems when requesting 'all' custom fields, it would still use current user permissions
2018-01-12 10:03:34 -07:00
nathangray
3709d773d9 * Allow private custom fields in notifications, with filtering according to set permissions. Private custom fields are removed from notifications to non-users. 2018-01-10 10:43:43 -07:00