Commit Graph

349 Commits

Author SHA1 Message Date
nathan
96558b9da8 Fix missing translation in Select group & dropdown options 2023-02-09 14:47:43 -07:00
nathan
00a857b2d7 Projectmanager: Fix gantt column selection opens with wrong position
Now using a proper dialog, similar to nextmatch column selection
2023-02-08 11:48:56 -07:00
nathan
efa550f251 Et2Select: Add onTagClick property for actions on tag clicks
Fixes unable to detect clicking on individual tags inside readonly et2-select-email
2023-02-08 09:11:33 -07:00
ralf
ed09a0b079 add missing readonly et2-select-lang to fix language column in news-admin index 2023-02-08 08:24:59 +01:00
nathan
193dbfc339 Et2Select: Fix some search weirdness
- Search didn't start until 1 character more than expected
- Search didn't happen on enter because the et2-searchbox inside stopped the key event from bubbling
2023-02-07 16:24:06 -07:00
nathan
9cde6a7171 Fix some styling on select-email
- Make +N tag right aligned & look like text, not tag
- Fix popup to open below but covering field
- give popup border & dropshadow
2023-02-07 12:04:05 -07:00
nathan
2a3a8a7371 Et2Select: Fix tags can't be removed 2023-02-07 10:04:56 -07:00
Hadi Nategh
cb6f2ee808 Add missing column on email tag tooltip 2023-02-07 10:01:46 +01:00
nathan
1b7f9d3ebc Et2SelectEmail: Give dragged tags some z-index, so they go over the other controls 2023-02-06 15:07:30 -07:00
nathan
cd980c78df Limit mail to & cc addresses to 1 row, show all on hover.
Use:
multiple="true" rows="1" maxTagsVisible="1"
to trigger show all on hover
2023-02-06 14:48:55 -07:00
ralf
bd8198d230 missing et2-select-lang widget 2023-02-06 15:52:58 +01:00
Hadi Nategh
dda3b1f5d1 Remove excessive BR tag from email tag 2023-02-06 11:33:50 +01:00
nathan
1d8d4f9c72 Fix some readonly issues where widgets were not looking readonly
- Editable tags were still editable if the select was readonly
- LinkTo could still select an app (readonly not passed on)
- Hide the dropdown for multi-select when readonly
2023-02-03 14:09:07 -07:00
Hadi Nategh
138999f233 Add again full value as tooltip for email tags 2023-02-02 12:12:08 +01:00
nathan
ab56ad1171 Et2Select: Handle paste of CSV into selects with allowFreeEntries
Special handling for Et2SelectEmail to handle email addresses that may have a name or comma
2023-01-31 09:48:27 -07:00
nathan
e575c40ff3 Some missed cases where client-side lavatar was not used 2023-01-30 15:26:09 -07:00
nathan
f503743956 Use client-side Et2LAvatar instead of image for Et2SelectEmail options & tags
Should now be only avatar.php image when provided
2023-01-27 13:27:31 -07:00
nathan
5bab72b8be Use client-side Et2LAvatar for user accounts whenever possible, only using avatar.php when there's a real image.
TODO:
- Need to find a cheap way to determine if there's a real image in Api/src/Accounts.php & class.mail_compose.inc.php

- Still some work for me to do in Et2SelectEmail
2023-01-27 10:34:40 -07:00
nathan
9cebab3c2f Fix readonly selects could display 'undefined' with no value and no emptyLabel 2023-01-26 12:58:37 -07:00
nathan
62bc77a4d2 Make sure egw.lang() doesn't error trying to translate option label
This un-reverts 4e5f68f97c
2023-01-25 14:24:08 -07:00
nathan
4b8b454566 Make sure values are strings, otherwise they might not match comparison
Should fix tracker list "Created by" filter losing display when you select a search result
2023-01-25 13:43:35 -07:00
ralf
6ef78c9591 Revert "Fix missing translation on read-only select"
Causes:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'toLowerCase')
    at Object.lang (egw_lang.js:73:16)
    at Et2SelectAccountReadonly._readonlyRender (Et2SelectReadonly.ts:189:59)
    at Et2SelectAccountReadonly.render (Et2SelectReadonly.ts:168:16)
    at Et2SelectAccountReadonly.update (lit-element.js:6:304)
    at Et2SelectAccountReadonly.performUpdate (reactive-element.js:6:4849)
    at Et2SelectAccountReadonly.scheduleUpdate (reactive-element.js:6:4496)
    at Et2SelectAccountReadonly._$Ej (reactive-element.js:6:4404)

This reverts commit 4e5f68f97c.
2023-01-25 09:46:22 +01:00
nathan
4e5f68f97c Fix missing translation on read-only select 2023-01-24 14:44:28 -07:00
nathan
9bf0149645 Fix selectbox positioning issue
Tracker owner would open down instead of up with fontsize = 14.  Updating to shoelace 2.0.0-beta.81 fixes it.  Going farther introduces some other issues that I don't want to get into right now
2023-01-24 13:58:38 -07:00
nathan
2332c2a806 Et2Tag: Make edit textbox larger 2023-01-24 08:27:52 -07:00
nathan
7518278948 Add edit button to freeEntry selectbox tags 2023-01-23 17:34:37 -07:00
nathan
86917eff65 Fix file settings error "'0' is NOT allowed ('not found')!" for gid.
It did not have a '0' => 'root' option, which is what we were using for the value.
2023-01-19 09:21:03 -07:00
nathan
80fbd3cc26 Fix placeholder widget
IDs on et2-boxes caused unwanted namespace, Et2Listbox couldn't find its ID before fully initializing
2023-01-19 08:44:52 -07:00
nathan
4f7b54c6bb Fix some more select attribute / legacy options issues 2023-01-11 15:49:56 -07:00
nathan
a699117b1b Fix hiding server-side messages for selectboxes
Messages were not properly hidden & displayed, and setting handleFocus & handleBlur accidentally overwrote them in Shoelace widgets
2023-01-11 11:11:02 -07:00
nathan
1163f9e31d Hide server-side validation messages while widget has focus. If the value did not change, put messages back 2023-01-09 16:02:59 -07:00
nathan
7d94692dfd Fix some missing account names
- egw().accounts() were not cleaned
- accounts not in normal cache did not call requestUpdate() properly
2022-12-19 12:01:29 -07:00
nathan
ac97af35cb Lets try creating options directly when we get them, rather than going through update first
Timing was not getting menu items created soon enough, resulting in IDs instead of names in the options
2022-12-16 11:48:12 -07:00
nathan
a9fe524123 Et2Select: Fix value got wrecked by fix_bad_value() when there are option groups 2022-12-15 11:31:56 -07:00
nathan
e756962f86 Change egw.accounts() to always return a Promise 2022-12-15 10:22:19 -07:00
nathan
3b5f64a4c3 Implement option groups 2022-12-14 14:32:20 -07:00
nathan
5acc8c55c8 Et2SelectEmail: Fix fullEmail did not show full email 2022-12-12 14:07:08 -07:00
nathan
34172704dc Fix SelectAccount didn't always get values into options correctly 2022-12-12 13:10:53 -07:00
nathan
0f37d2f437 Fix sometimes missing accounts for SelectAccount widgets 2022-12-09 13:16:44 -07:00
nathan
6177ca0536 SearchMixin: Filter selected remote correctly for single selects too 2022-12-09 13:14:57 -07:00
nathan
8ed40c8c0e Et2SelectThumbnail: Fix current value(s) did not display 2022-12-09 09:03:43 -07:00
nathan
4b4d6fe184 Stop scrolling new tag into view, it causes calendar sidemenu to get stuck 2022-12-08 14:47:02 -07:00
nathan
ce64ddf9e0 Fix doubled tags if widget gets select_options after a remote option is selected 2022-12-08 14:28:05 -07:00
nathan
be5125509e SearchMixin: Fix selecting multiple remote values only showed the last 2022-12-08 10:24:49 -07:00
nathan
c26732a913 Some more fixes for historylog widget
- Fix options in proper format could be interpreted as sub-widgets
- Fix numeric values
2022-12-07 15:04:22 -07:00
nathan
fb40aedf89 SearchMixin: Use parent set select_otions, no need to duplicate 2022-12-06 11:59:51 -07:00
nathan
25f64d0064 Fix error on some bad options
Would sometimes stop historylog from loading
2022-12-06 10:05:47 -07:00
nathan
3971abc54b Fix some select options were not being cleaned
Integer values provided from server were not being converted to strings, breaking value handling & matching
2022-12-06 09:13:04 -07:00
nathan
fa2375b1a6 SearchMixin: Fix selected remote options got lost if adding a freeEntry 2022-12-05 13:56:31 -07:00
nathan
2b02d4e9ab Fix listbox sometimes lost value 2022-12-05 10:11:17 -07:00
nathan
7ba5730251 Change properties to camelCase 2022-12-05 09:42:55 -07:00
nathan
6eebabe472 SearchMixin: Fix tag edit
Double clicking just cleared the input, edit was immediately stopped due to search blur
2022-12-01 14:54:34 -07:00
nathan
404a29b985 SearchMixin: If user enters a valid free entry then changes focus without pressing Tab or Enter key, accept the free entry 2022-12-01 14:15:40 -07:00
nathan
6d41c9c30b Et2SelectAccount: Avoid error if option does not have an image 2022-11-21 09:16:38 -07:00
nathan
1d540aa74c Fix additional options to a static list were not properly added if they were in correct format with value & label 2022-11-21 09:14:27 -07:00
nathan
6a5d189489 Better fix for Et2SelectState not getting country set 2022-11-14 14:41:08 -07:00
nathan
47a48b386f Et2Select: Fix change event got fired too early
Don't need to block the event if we didn't actually change the value.  This fixes changing to common preferences
2022-11-09 15:34:28 -07:00
nathan
32bd2a1084 SearchMixin: Make sure dropdown doesn't cover bottom border 2022-11-09 09:30:53 -07:00
nathan
4dffd24feb Et2Select: Fix change event got fired too early
Second attempt.  If fix_bad_value() made a change, that was triggering change event before Et2App.et2_ready() had been called.  Now making sure that event does not get fired.
2022-11-08 11:04:03 -07:00
nathan
78333613fa Et2Select: Fix change event got fired too early
If fix_bad_value() made a change, that was triggering change event before Et2App.et2_ready() had been called
2022-11-07 09:57:00 -07:00
nathan
74f7f4dcb5 Et2SelectReadonly: Allow additional supplied options, but fix bug where they overwrote account options 2022-11-02 14:03:12 -06:00
nathan
48eb9c1968 Fix duplicate option warning from customfield select filter 2022-10-18 16:06:28 -06:00
nathan
bd62279f55 Et2Select: Cancel search timer on blur and menu close
If we don't, results might come back after we leave/close and re-open
2022-10-17 09:56:58 -06:00
nathan
0004aa5bb4 SearchMixin: Avoid errors if searchInputNode is not created 2022-10-14 15:12:08 -06:00
nathan
69ce014aa6 Et2Select: Vertically center multiple tags 2022-10-13 09:33:04 -06:00
nathan
08e899e91c Fix Et2SelectCategory had category border when multiple
Now only shows category border for single select, when there's a value
2022-10-13 08:41:42 -06:00
nathan
690e89157e Et2Listbox: Make rows set the height, not the max 2022-10-07 15:33:43 -06:00
nathan
8514792efc Fix changing select options did not properly clear previous options 2022-10-07 15:31:06 -06:00
ralf
c5b8261ec2 do NOT split RFC822 addresses containing comma in quoted name part eg. 'Becker, Ralf <rb@egroupware.org>' 2022-10-06 13:14:34 +02:00
nathan
3ce5aebe12 Collabora: Get insert placeholder dialog working again 2022-10-05 10:50:54 -06:00
nathan
f8e56edc20 Limit number of accounts (& other select/taglist search results) sent to client 2022-10-04 15:49:07 -06:00
nathan
7bb4332961 Et2SelectCategory: Fix loading with initial value did not get category color or icon in the displayed label 2022-10-04 09:17:31 -06:00
nathan
b5a2778168 Fix category did not display value on first load 2022-10-03 09:12:00 -06:00
nathan
12f8b2cb3e Et2SelectEmail: Add some documentation 2022-09-28 11:14:02 -06:00
nathan
ffd6c21ed4 Et2Select: Avoid errors if freeEntry has single quote 2022-09-27 13:55:32 -06:00
nathan
086d92e957 Et2Select: All selectboxes now stop scroll event from bubbling to prevent parent (sidemenu) from scrolling too 2022-09-23 10:54:02 -06:00
nathan
171c9c02cb Pressing escape while in search now closes dropdown 2022-09-23 10:40:16 -06:00
nathan
bea34ad403 Fix adding a freeEntry did not trigger change event 2022-09-22 15:18:34 -06:00
nathan
5a8f7c3c70 More fixing of missing search options / tags
Fixes new free entries don't show up after removing a free entry
2022-09-22 11:15:25 -06:00
nathan
8da8c14a00 Et2SelectEmail: Change multiple default to false to match other selects 2022-09-22 08:59:31 -06:00
nathan
2952df2799 Et2Select + SearchMixin: Fix some bugs with display and selecting entries
- Fix clicking on text while editing triggered re-display
- Avoid unneeded node re-creation when editing free entry, handle empty value as removal
multiple=true:
- Fix clearing search removed previously selected remote results
- Fix adding a free entry did not move search down, covering the new value
multiple=false:
- Fix search & edit inputs were shown at the same time
- Fix edit free entry always took over making it impossible to search
2022-09-21 17:13:29 -06:00
nathan
7dd0165cd2 Et2Select + search: Fix position adjustment did not work in all cases
Subsequent searches did not give space for searchbox
2022-09-20 10:07:36 -06:00
nathan
66368c6d3a Et2Select + search: Adjust dropdown position based on if it opens up or down 2022-09-20 09:43:25 -06:00
nathan
606e2688d4 Et2SelectEmail: Do not create image in tag, Et2EmailTag uses CSS for image
Fixes doubled image
2022-09-19 09:23:23 -06:00
nathan
1deeee207f Better way to show "no suggestions" indicator, works with local options now too 2022-09-16 11:17:06 -06:00
nathan
30c3000e87 Et2Select fixes
- Search with no results blocked any futher searches from displaying results
- Only show "no suggestions" after searching
2022-09-16 10:20:47 -06:00
nathan
9a036b1dfe Et2Select: Fix "required" styling did not show in a better way
Previous method (38e8df2) made widget entirely transparent
2022-09-15 15:26:06 -06:00
nathan
38e8df223d Et2Select: Fix "required" styling did not show 2022-09-15 12:36:31 -06:00
nathan
c8b6a5760b Et2Select: Re-add accidentally removed chunk that sets initial value when initial value is an array
Fixes mail preview didn't show to/from addresses
2022-09-15 08:49:36 -06:00
nathan
1b72eb4a00 Revert "Revert "Et2Search: Fix some UI bugs" as it no longer renders values and therefore easily destroys existing content"
This reverts commit 0287e06df2.
2022-09-15 08:30:50 -06:00
ralf
0287e06df2 Revert "Et2Search: Fix some UI bugs" as it no longer renders values and therefore easily destroys existing content
This reverts commit 56eb4d64ac.
2022-09-15 12:56:12 +02:00
nathan
56eb4d64ac Et2Search: Fix some UI bugs
- Fix missing loading spinner while searching
Clear button was in the way, now hiding clear button when displaying the spinner

- Fix searching for the same thing twice displays no results the second time
repeat() and map() directives were not putting the DOM nodes back in, worked around by using a temp div to render into.  There were some lifecycle mistakes as well leading to collisions & re-doing.
2022-09-14 15:47:36 -06:00
nathan
9096c17348 Et2Select: Tabbing out of search field now closes the dropdown 2022-09-13 09:06:59 -06:00
ralf
d8d8429622 an other fix for 4c00b812ee fixing error when trying to reply 2022-09-13 10:17:59 +02:00
ralf
c00c6f9e07 readonly et2-select-mail caused error with 4c00b812ee eg. in mail.display 2022-09-13 09:15:55 +02:00
nathan
4c00b812ee Fix edit inputbox covered new freeEntries 2022-09-12 12:48:21 -06:00
nathan
43cce1940d Fix selecting search result does not display label
Infolog contact filter still filtered, but did not show label for selected search result.
2022-09-12 10:19:38 -06:00
Hadi Nategh
1489944d49 Fix category border styling 2022-09-12 15:16:04 +02:00
ralf
26824323e5 got mailing lists working again in mail compose using includeLists=true attribute
using "$list_name <$list_id@lists.egroupware.org>" instead of just integer ids for the list, thought et2-select-mail is NOT displaying the mailing-list icon, after a mailing-list is selected
2022-09-12 14:51:13 +02:00
nathan
f85de279c6 Fix some property bugs
- Parse values that should have been objects but came as strings
- Decode SearchMixin.searchUrl
2022-09-08 11:17:34 -06:00