Ralf Becker
298a2041ab
* CalDAV/resources: fix wrong ACL/rights send to clients (PHP warning in log)
2018-04-12 13:05:14 +02:00
Ralf Becker
e6ccdba871
run fastcgi_finish_request also for non-compat install
2018-04-11 15:07:01 +02:00
Ralf Becker
8cd1707736
fix shutdown functions did not have $GLOBALS[egw] set, caused by session created by MServer
2018-04-11 15:07:01 +02:00
Ralf Becker
0bac07f1ba
fixing function and test
2018-04-11 14:06:54 +02:00
Ralf Becker
188865566b
limit filesystem depth for managed attachments to gard against infinit recursion
2018-04-11 11:26:26 +02:00
Ralf Becker
c795f13f81
remove 4-byte unicode when cleaning subjects
2018-04-11 11:24:53 +02:00
Ralf Becker
d647c197a7
fix smime key got immediatly deleted again
2018-04-10 15:22:42 +02:00
Ralf Becker
b968f65b4a
fixing not working links stream-wrapper
2018-04-10 08:56:20 +02:00
Ralf Becker
4c99e0bf99
fix Scrutinizer issue (seems to be some left over old code)
2018-04-09 17:36:35 +02:00
Ralf Becker
0d984589ff
* PHP 7.2: fix several PHP Fatal errors and warnings stalling installation and usage
2018-04-09 17:36:35 +02:00
Hadi Nategh
53a4130722
Fix move/copy actions in link_to widget vfsSelect try to create not unwanted new symlink
2018-04-04 17:55:14 +02:00
Hadi Nategh
7ac0e33fbb
Make sure mail_bo object is there before using it, fixes error "can not call undefined function reopen()"
2018-04-03 10:34:52 +02:00
Hadi Nategh
5c19bbfd2c
Implement new feature for vfs-select widget to accept extra buttons action. Additionally, add extra "copy" and "move" actions to link-to vfs dialog.
2018-03-28 11:13:26 +02:00
Hadi Nategh
a0ac4ed927
Fix merge replace placeholders causes huge performance issue. Additionally, fixes the extra $ sign shown up in replaced placeholders.
2018-03-23 16:48:02 +01:00
Ralf Becker
442da1e381
* Sharing/Collabora: fix not working cleanup of temp. files and shares
...
- 14.x installs had the job created with old class-name egw_sharing
- Wopi shares where never cleaned up, they are now after 3 month
2018-03-22 13:12:50 +01:00
Ralf Becker
762c60a61f
new method Api\Framework::getUrl() to get a full / externally usable Url
2018-03-21 12:40:59 +01:00
Ralf Becker
8c23fca35e
do NOT use hostname configured in setup, if it is the default localhost
...
stick with HTTP Host header in that case
2018-03-21 11:45:25 +01:00
nathangray
e7df918794
Re-init static streamwrapper, as some of them look at permissions or preferences
2018-03-20 15:22:50 +01:00
Hadi Nategh
796f485117
Remove not used csp method
2018-03-20 15:04:28 +01:00
Ralf Becker
d426394685
correctly propagate readonly for sharing and Collabora
2018-03-20 11:54:33 +01:00
Hadi Nategh
be4696b857
Get Collabora+Sharing into latest stable version
2018-03-19 16:05:43 +01:00
Ralf Becker
13c564e6a6
remove due to own table in 17.1 no longer needed migration of (private) custome-fields
2018-03-14 14:55:40 +01:00
stefanwerfling
1fe5478761
Update autoload.php
...
- add interface exist check for interface loading by vendor classes
2018-03-13 17:04:56 +01:00
Ralf Becker
0984cb7d8e
* AD/LDAP migration: change favorites and index states too
2018-03-12 21:23:49 +01:00
nathangray
183ee014c6
API - Avoid issue with incompatable types by forcing to array, even if no account found
2018-03-12 09:02:52 -06:00
Ralf Becker
c4c57acf3d
* EMail/Tracker/InfoLog: fix error converting mails by replacing 4-byte utf8 chars
...
MySQL and MariaDB before 10.1 need 4-byte utf8 chars replaced with our default utf8 charset
(MariaDB 10.1 does the replacement automatic, 10.0 cuts everything off behind and MySQL gives an error)
Changing charset to utf8mb4 requires schema update, shortening of some indexes and probably have negative impact on performace!
if (substr($this->Type, 0, 5) == 'mysql' && $this->ServerInfo['version'] < 10.1)
{
$value = preg_replace('/[\x{10000}-\x{10FFFF}]/u', "\xEF\xBF\xBD", $value);
}
2018-03-12 14:03:52 +01:00
Ralf Becker
9ce0feaf9b
* Api: use proxy configuration when downloading available tutorial videos
2018-03-12 11:19:10 +01:00
Hadi Nategh
569c7d2218
Fix tutorials.json url to use https
2018-03-12 11:08:38 +01:00
Ralf Becker
181747d006
Fix not working textbox validators containing backslashes
...
PHP xml parser reads backslashes literal from attributes,
while JavaScript ones need them escaped (eg. like PHP strings)
-> replace \\ with \ to get following XML working: validator="/^\\d+$"
2018-03-10 17:57:12 +01:00
nathangray
b475edc7a2
Silence warning about time in array format by passing it to constructor
2018-03-09 15:15:36 -07:00
Ralf Becker
09b6d37a04
* ActiveDirectory: additional allow accountExpires=0 for never expires
...
(beside attribute is not set or has value 9223372036854775807)
2018-03-09 19:57:09 +01:00
nathangray
45c7aa7c9c
* Api - Check if email address is known before offering 'Add as contact' button
2018-03-07 11:46:58 -07:00
Hadi Nategh
f97c18c108
* Mail: Fix "tel:" href links wrongly get denied by mail compose
2018-03-05 18:21:06 +01:00
Hadi Nategh
d7ce6af567
Fix mail with a bold digits gets removed from text part
2018-03-05 17:32:16 +01:00
Hadi Nategh
bba57a254b
Fix broken sharing caused by commit 89a8e6f448
2018-03-05 11:15:35 +01:00
Hadi Nategh
a987ddbe85
Make sure replace only and only VT char (Vertical Tab)
2018-03-02 12:14:17 +01:00
Ralf Becker
4ada67ee81
if we can not store failed login attempts in database, store it in cache
2018-02-28 18:02:53 +01:00
Ralf Becker
e4a5d599a2
* All apps: multiselect custom-field switches to single select after submit
2018-02-28 13:42:36 +01:00
Ralf Becker
ec9cc20c11
Switching consistent hashing (Libketama) off by default
...
as for just 2 Memcached servers it creates an extrem unbalanced
distribution favoring the 2. server and has no benefits,
as requests to the failed node can only go to the other one anyway.
2018-02-28 10:47:35 +01:00
nathangray
5807fd0f43
* InfoLog/PHP7.1: fix fatal error stalling merge-print of some InfoLog templates under PHP 7.1+
...
Make prefix argument optional
2018-02-28 10:15:51 +01:00
Ralf Becker
64aba9cbb9
* Admin: new config to generate no or lowercase email addresses for new users
2018-02-20 09:17:17 +01:00
nathangray
da586c3512
Use abstraction to determine mime type, see 9a398594ac
2018-02-15 10:20:02 -07:00
nathangray
f262fed4b2
Place check on session first to avoid errors if it's missing
2018-02-15 09:30:08 -07:00
nathangray
f4e2230191
* Etemplate - Don't trust browsers mime if we don't have to - fixes incorrect mime types and Resources rejecting pictures
2018-02-15 08:42:22 -07:00
nathangray
564a4cab5d
* Admin - fix group list filter & sort
...
- Remove created & modified columns since they're not stored for groups
- Fix email sort
- Fix search returned all results
2018-02-15 08:41:29 -07:00
Ralf Becker
c9cc1f2e63
fix PHP Warning if keys contain a backslash as in namespaced classes
2018-02-15 09:56:39 +01:00
nathangray
a1a43afe53
* Api - Fix sharing from mounted shares failed with 404
2018-02-14 10:30:23 -07:00
Ralf Becker
cf722f6d01
* Filemanager/Sharing: fix PHP 7.1 error causing auth request to popup
...
Session only stores app-names and $GLOBALS[egw_info][user][apps] gets restored from $GLOBALS[egw_info][apps] for the allowed app-names. Check if we need to restore from installed apps array was using is_array($GLOBALS[egw_info][user][apps][api]) instead or isset($GLOBALS[egw_info][user][apps][0]), as check if it is a real, non associative array
2018-02-14 09:47:32 +01:00
Hadi Nategh
9d5ddc84e2
* Filemanager: Add an user preference for being able to chose whether opening a merge print document should download it or open it with collabora editor
2018-02-08 14:24:05 +01:00
Hadi Nategh
0bbbad3a8c
Allow custom theme for mobile template
2018-02-08 10:31:23 +01:00
nathangray
e9d29852ad
* Api - Fix some spelling errors, reported by Stefan Unverricht
2018-02-07 13:31:50 -07:00
Ralf Becker
56f9c9478d
also fixing preg for email with optional domain part
2018-02-05 19:13:49 +01:00
nathangray
8231f44ce2
Attempt to prefer user's date format when parsing date from a string.
...
Should fix merging into spreadsheet problems with certain date formats (dd/mm/yyyy)
2018-02-05 10:11:59 -07:00
Ralf Becker
f203fa3eb2
fixing the fix, now "email.@domain.com" is invalied, but "x@domain.com" is valid
2018-02-05 16:07:46 +01:00
Ralf Becker
5668f9b04a
one letter name-part in email address failed validation, eg. "x@egroupware.org"
2018-02-05 15:35:41 +01:00
Hadi Nategh
189de3ddda
* Addressbook: Fix avatar photo gets removed when adding category to contact via contextmenu
2018-01-31 18:25:40 +01:00
Ralf Becker
a23be28d97
allow user & password again as in http://user:pass@example.com/ to fix tests
2018-01-30 17:03:38 +01:00
Ralf Becker
4d35e42eeb
allow private IP addresses (starting with 10.|169.254.|192.168.) too
2018-01-30 16:20:43 +01:00
nathangray
782deb84f1
Fix wiki links did not load properly after login if your session was expired
2018-01-29 08:43:39 -07:00
Ralf Becker
a17f2fc0b7
update/add support options in setup and about EGroupware page
2018-01-29 12:50:58 +01:00
Ralf Becker
30645713c6
* LDAP/ActiveDirectory: fix sorting accounts by anything other then account-name fails
2018-01-29 12:49:33 +01:00
Ralf Becker
297ff61523
* Mail: fix invalid domain name in headers stall whole mailbox
...
Horde_Idna::decode() and Horde_Mime_Headers::toArray() throws Horde_Idna_Exception for invalid domain names in email addresses like "test@-domain.com", which stall display of whole folder
2018-01-23 13:01:52 +01:00
Ralf Becker
a291fbeac6
fix call to protected method EGroupware\Api\Mail::clean_subject_for_filename() from context mail_integration
2018-01-23 09:29:25 +01:00
nathangray
e3ad2ebdf0
Mail - Reorganize and use same cleaning function when saving mail as infolog as for saving to VFS
2018-01-22 09:18:16 -07:00
Ralf Becker
b26c82bae6
allow to sepecify last security release for multiple major versions
2018-01-21 10:29:03 +01:00
Hadi Nategh
7e1b5602f1
* Mail: Fix a security issue when sharing of attached files as download links in compose dialog exposes all folders as readonly shares
2018-01-17 17:56:09 +01:00
nathangray
aae5094797
* Allow private custom fields in notifications, with filtering according to set permissions. Private custom fields are removed from notifications to non-users.
2018-01-15 12:52:33 -07:00
nathangray
001821175b
* API - Make sure private custom fields are not accidentally included in notification due to being cached
2018-01-15 12:52:15 -07:00
Neo Morina
e47ecfbe82
Made some changes at egw_actions
...
This is a usefull for opening "second level results" as a popup.
"Second level results" couldn't get opened as a popup at Project Manager app when i try to add a new Project as Template at the selected Project.
2018-01-11 10:27:28 -07:00
Ralf Becker
be8b18cf90
allow to specify a date-format in custom-fields using eg. format=Ymd, as it was possible in 11.1 in len field
2017-12-18 14:42:22 +01:00
Hadi Nategh
6c6518b445
* Mail/Admin: Fix upload picture into mail signature from editor image browser does not work.
2017-12-18 12:07:49 +01:00
Hadi Nategh
d5ac9b90a8
* Mail: Fix empty trash/empty junk actions causes error in some mail servers, e.g. Cyrus.
2017-12-15 15:25:16 +01:00
Hadi Nategh
aeec7a869f
Fix collabora can not open vfs symlinks from apps
2017-12-13 10:17:45 +01:00
nathangray
08f0073361
Add flag for select all to collabora action
2017-12-11 11:22:32 -07:00
Hadi Nategh
80576f7956
* Mail: fix vacation notice still sending out notification mail even if the original mail is a spam.
2017-12-08 13:54:54 +01:00
Ralf Becker
db6e6b376f
replace from PostgreSQL not understood && with standard AND
2017-12-07 17:28:54 +08:00
Ralf Becker
42ea57c124
* All apps/PostgreSQL: fix SQL error when deleting an entry without attachments
2017-12-07 17:21:26 +08:00
Ralf Becker
c3c385e1f4
* Filemanager/PostgreSQL: cant open file in Collabora because of SQL error
...
Syntax error: 7 ERROR: syntax error at or near "=“, PostgreSQL needs true/false not 1/0
2017-12-07 16:47:42 +08:00
nathangray
c1faf8329d
Fix historylog pagination, found by Filippos Karailanidis
2017-12-05 15:21:06 -07:00
nathangray
e2a6052058
* Api - Fix nested custom field merging
2017-12-01 11:59:28 -07:00
Hadi Nategh
2b72f759ff
* Addressbook: fix bug setting Hide User Account in preferences into Show all accounts breaks show accounts
2017-12-01 17:07:42 +01:00
Hadi Nategh
1effbd6b7f
Use filemanager_select for old etemplate apps
2017-12-01 11:07:35 +01:00
nathangray
5455b97664
* Addressbook - fix SQL error with accounts hidden + Organisation by location / department
...
- Fix accounts missing if no preference for hide accounts set
2017-11-30 10:10:34 +01:00
Ralf Becker
a049b86324
fix avatar/files update issues
2017-11-29 10:12:32 +01:00
nathangray
4a85f3c338
Fix missing fields in merge if info_contact is not a addressbook entry
2017-11-28 09:09:39 -07:00
Hadi Nategh
a7fcb77d1b
Fix error Call to a member function setDate() on boolean
2017-11-27 18:06:27 +01:00
nathangray
257edc3aa7
Addressbook - fix show/hide account preference bugs
...
- account filter was missing for show active
- preference changed to match current value
2017-11-22 08:42:37 -07:00
nathangray
cfb34b05bf
Addressbook - fix hide accounts preference did not work for duplicate & organisation views
...
- Added a new preference option to hide only deactivated accounts
2017-11-22 08:42:28 -07:00
nathangray
cd661ed3ba
Mail - stop additional mail in sent folder when merging multiple contacts into email
2017-11-21 08:43:40 -07:00
Hadi Nategh
8bf0763c1f
Fix list of favorites in VfsSelect contains previous selected contents as well
2017-11-20 17:50:21 +01:00
Hadi Nategh
6d51130cc6
Make favorites available as an individual button in VfsSelect dialog
2017-11-20 17:02:31 +01:00
Hadi Nategh
6d378b8e73
Fix attempting to open a document link in infolog pops collabora link even the user has no permission to the collabora app
2017-11-20 10:18:12 +01:00
nathangray
357f6ae65f
Mail - Also include HTML version of email in integration data (for apps that can handle it)
2017-11-15 08:50:33 -07:00
Ralf Becker
0e40bd7cb5
* CalDAV/CardDAV: fix encoding of control chars stalling iOS sync
...
eg. \xb is not allowed in XML and caused iOS sync to stall, as it's XML parser fails
use htmlspecialchars option ENT_XML1|ENT_DISALLOWED (PHP 5.4+) to ensure proper XML encoding
2017-11-10 15:50:28 +01:00
Ralf Becker
628e7596d3
allow to migrate accounts from ADS to SQL
2017-11-09 15:28:37 +01:00
Hadi Nategh
6b0a8a1b5d
Fix vfsSelect does not show any content for the first load
2017-11-09 10:26:49 +01:00
Ralf Becker
1b5e992f43
allow sql fragments in Api\Storage\Base::delete as in other places
2017-11-08 11:45:40 +01:00
Ralf Becker
8fdffab564
allow sql fragments in Api\Storage\Base::delete as in other places
2017-11-08 11:45:24 +01:00
Ralf Becker
464f1b3894
never invalidate session in sharing, as we cant regenerate it (and we dont need to)
2017-11-07 13:03:30 +01:00
Ralf Becker
1222ef1813
also log if _check_script_tag was able to disarm XSS automatic
2017-11-07 12:24:15 +01:00
Ralf Becker
5d1217b89b
deny sharing owner rights (chmod, chgrp, set eACL) and disable eACL tab
2017-11-06 15:19:19 +01:00
nathangray
dda47ca863
Disable extended ACL for readonly shares
2017-11-03 10:28:27 -06:00
Ralf Becker
4ebf79d0e1
* Sharing/Collabora: allow to use Collabora on writable shares (EPL only)
2017-11-03 12:43:09 +01:00
nathangray
ef7956f34b
Make sure lang gets passed on to registration
2017-11-02 11:13:29 -06:00
nathangray
069d49afba
Disable copy / paste for readonly shares
2017-11-02 09:43:08 -06:00
Ralf Becker
3689b3d645
* Filemanager/Sharing: deny rename, move, mkdir and rmdir on readonly share
2017-11-02 13:34:10 +01:00
Hadi Nategh
3465c40b50
Remove unsafe-eval CSP for CKEditor
2017-11-02 11:02:16 +01:00
Ralf Becker
0813403b5b
* All apps: get sharing working with files attached to application entries
2017-10-31 10:51:59 +01:00
Ralf Becker
b9594ea357
fix typo
2017-10-31 10:49:12 +01:00
Ralf Becker
b5574da397
remove system call used for PHP < 5.3.1
2017-10-31 09:55:23 +01:00
Ralf Becker
a4526c98cb
store CalDAV/CardDAV log in user spezific log directories
2017-10-30 15:00:42 +01:00
nathangray
616c11c1fb
Fix wrong table name
2017-10-27 17:48:42 +02:00
nathangray
0d14155472
Fix minimum fs_id was not returning proper value
2017-10-27 17:43:40 +02:00
nathangray
90ce0cc7b6
Add a function to get the lowest fs_id for a path
2017-10-27 17:43:40 +02:00
Ralf Becker
12dbfca137
check cookies for XSS attempts
2017-10-27 16:52:34 +02:00
nathangray
5750904809
Fix setlocale to be able to find locales on Ubuntu
2017-10-27 10:54:39 +02:00
Ralf Becker
5b573abef7
do not allow path traversal and htmlencode displayed path
2017-10-26 13:16:52 +02:00
nathangray
fdb47ab168
Merge calendar events into user account if there is one over user contact
2017-10-26 09:16:02 +02:00
Ralf Becker
77b42dd9a4
always send X-Content-Type-Options: nosniff
...
It does not harm and stops unpredictable results from browsers changing our content-types
(FF 50+ now also supports nosniff)
2017-10-25 17:35:30 +02:00
Hadi Nategh
fdb3202b6b
Add new config to the admin site configuration in order to be able to upload a custom header logo
2017-10-23 13:23:52 +02:00
nathangray
b8f8a014fa
Move all tests under api/src into api/tests
2017-10-23 10:14:14 +02:00
nathangray
24de1dff3b
Move PHPUnit tests from test to tests subdirectory
2017-10-23 09:51:28 +02:00
Ralf Becker
c88e6e0237
disabling E_DEPRECATED, as contrib apps wont work under PHP 7.1 with having eg. contructors with same name as the class
2017-10-21 12:03:10 +02:00
nathangray
d3c596a443
- Add a parameter to pass in the class of the notification to use so we can pass in a test one
...
- Explicitly tell notification what type of message (plain or html) we're giving it
2017-10-21 11:29:05 +02:00
Hadi Nategh
ff4396030a
Fix CKEditor Browse Server button to open vfsSelect
2017-10-20 18:55:22 +02:00
nathangray
accd6187e2
Get date widget duration test working again
2017-10-20 09:56:47 +02:00
nathangray
9e6ecce1d0
Move tests into app/tests subdirectory (not app/inc/test or app/test)
2017-10-18 18:30:54 +02:00
nathangray
237d81ce36
Move tests into app/tests subdirectory (not app/inc/test or app/test)
2017-10-18 15:43:35 +02:00
nathangray
865fd6405d
Move sanity check to a pre-condition check
2017-10-18 11:47:28 +02:00
Ralf Becker
1d7fb9fe90
improve check $GLOBALS[egw] is correctly initilized
2017-10-18 09:10:39 +02:00
nathangray
cd49f6568d
Replace the lost boolean cast
2017-10-17 16:48:35 +02:00
nathangray
88a3f3b1d4
Run test in UTC, so dates match our expectations
2017-10-17 15:40:05 +02:00
nathangray
6fad74c710
Fix test had no assertions
2017-10-17 13:29:17 +02:00
nathangray
8b1a8d38f5
Revert db10b21fa7
2017-10-17 12:48:46 +02:00
nathangray
db10b21fa7
Fix child actions under 'More...' did not inherit the inheritable attributes
2017-10-13 11:13:17 -06:00
nathangray
63a3940d68
Addressbook - adjust calendar event participants to match when merging contacts
2017-10-13 09:35:36 -06:00
Hadi Nategh
052bef84ce
W.I.P vfsSelect Widget:
...
- Fix upload feature not working
2017-10-13 13:22:45 +02:00
Hadi Nategh
5b76210218
W.I.P vfsSelect Widget:
...
- Fix mime types not being shown
- Fix name being displayed encoded in save2vfs mail
2017-10-12 17:45:46 +02:00
Hadi Nategh
2c721c95b2
W.I.P. VFS Select Widget:
...
- Add name and dialog_title as new attributes
- Fix SaveToVfs, SaveAttachmentToVfs, SaveAllToVfs in mail
- Fix button tile
2017-10-12 13:19:42 +02:00
Hadi Nategh
448cc8975f
W.I.P of VFS Select widget restructure
2017-10-11 18:27:42 +02:00
Hadi Nategh
de65d91dc7
Rmove fields for none private cutomfields when name refers to a single custom field
2017-10-06 16:27:37 +02:00
nathangray
0183635c02
Add permission check for collabora before setting actions to open in editor
2017-10-05 09:55:06 -06:00
Ralf Becker
6a3a944828
fix uncaught exception if Collabora is not configured or reachable
2017-10-05 11:00:38 +02:00
nathangray
1868b40359
Set up merge to open editable documents if collabora is there
2017-10-04 14:15:47 -06:00
nathangray
285eb8494b
Addressbook - Merging contacts now keeps all distribution lists, and it works now
2017-09-27 09:00:46 -06:00
Ralf Becker
1ae0f29f01
return "400 Bad Request" if propfind contains invalid elements or more then one
2017-09-26 19:13:05 +02:00
nathangray
2d57801c6a
* Addressbook - Merging contacts now keeps all distribution lists
2017-09-26 11:05:34 -06:00
Hadi Nategh
a4fdc052ab
Filemanager "New" actions:
...
- Add "New" actions into nm header as drop down list
- Re-arrange actions in contextmenu
- Let Etemplate modifies sel_options if extra changes are available
2017-09-26 18:43:18 +02:00
Hadi Nategh
6407379388
Accept localhost as a valid url
2017-09-26 11:37:37 +02:00
Ralf Becker
a6ec69169d
document and enhance function signaure for server-side callback of file and vfs-upload widget
...
also make it usable for vfs-upload widget with it's id containing entry's id
2017-09-21 11:33:40 +02:00