mirror of
https://github.com/EGroupware/egroupware.git
synced 2024-12-17 04:00:45 +01:00
483ad2cec4
code logic was wrong and it was using an API method that is also buggy => in file /egw/phpwgapi/inc/class.common.inc.php the method cmp_version_long(). 1) the code logic: it get versions for the current app and for the api from file (app/setup/setup.inc.php) and from DB. it loops over this 2 apps (app, and api), and set a $_current to true or false. this variable value is defined by the last app check in the loop (the API) => then if your API version is up to date, your application version is also. which was wrong for me. Well in the attached file i change the code logic.
90 lines
3.0 KiB
PHP
90 lines
3.0 KiB
PHP
<?php
|
|
/**************************************************************************\
|
|
* eGroupWare - Admin *
|
|
* http://www.egroupware.org *
|
|
* This application written by Miles Lott <milos@groupwhere.org> *
|
|
* 04/27/2005 Fixed by Olivier TITECA-BEAUPORT <oliviert@maphilo.com> *
|
|
* -------------------------------------------- *
|
|
* This program is free software; you can redistribute it and/or modify it *
|
|
* under the terms of the GNU General Public License as published by the *
|
|
* Free Software Foundation; either version 2 of the License, or (at your *
|
|
* option) any later version. *
|
|
\**************************************************************************/
|
|
|
|
/* $Id$ */
|
|
|
|
/* Check currentapp and API upgrade status */
|
|
|
|
if($GLOBALS['phpgw_info']['flags']['currentapp'] != 'home' &&
|
|
$GLOBALS['phpgw_info']['flags']['currentapp'] != 'welcome' &&
|
|
(isset($GLOBALS['phpgw_info']['server']['checkappversions']) &&
|
|
$GLOBALS['phpgw_info']['server']['checkappversions']))
|
|
{
|
|
if((isset($GLOBALS['phpgw_info']['user']['apps']['admin']) &&
|
|
$GLOBALS['phpgw_info']['user']['apps']['admin']) ||
|
|
$GLOBALS['phpgw_info']['server']['checkappversions'] == 'All')
|
|
{
|
|
$_returnhtml = array();
|
|
$app_name = $GLOBALS['phpgw_info']['flags']['currentapp'];
|
|
$GLOBALS['phpgw']->db->query("SELECT app_name,app_version FROM phpgw_applications WHERE app_name='$app_name' OR app_name='phpgwapi'",__LINE__,__FILE__);
|
|
while($GLOBALS['phpgw']->db->next_record())
|
|
{
|
|
$_db_version = $GLOBALS['phpgw']->db->f('app_version');
|
|
$app_name = $GLOBALS['phpgw']->db->f('app_name');
|
|
$_versionfile = $GLOBALS['phpgw']->common->get_app_dir($app_name) . '/setup/setup.inc.php';
|
|
if(file_exists($_versionfile))
|
|
{
|
|
include($_versionfile);
|
|
$_file_version = $setup_info[$app_name]['version'];
|
|
unset($setup_info);
|
|
|
|
if(amorethanb($_file_version, $_db_version))
|
|
{
|
|
if($app_name == 'phpgwapi' )
|
|
{
|
|
$_returnhtml[$app_name] = lang('The API requires an upgrade');
|
|
}
|
|
else
|
|
{
|
|
$_returnhtml[$app_name] = lang('This application requires an upgrade') . ": \n <br/>" . lang('Please run setup to become current') . '.' . "\n";
|
|
}
|
|
}
|
|
else
|
|
{
|
|
if($app_name == 'phpgwapi' )
|
|
{
|
|
$_returnhtml[$app_name] = lang('The API is current');
|
|
}
|
|
else
|
|
{
|
|
$_returnhtml[$app_name] = lang('This application is current') . "\n";
|
|
}
|
|
}
|
|
unset($_file_version);
|
|
}
|
|
else
|
|
{
|
|
// if setup.inc.php do not exist for the app, we assume that the app is current
|
|
if($app_name == 'phpgwapi' )
|
|
{
|
|
$_returnhtml[$app_name] = lang('The API is current');
|
|
}
|
|
else
|
|
{
|
|
$_returnhtml[$app_name] = lang('This application is current') . "\n";
|
|
}
|
|
}
|
|
unset($_db_version);
|
|
unset($_versionfile);
|
|
}
|
|
|
|
echo '<center>';
|
|
foreach ($_returnhtml as $_html)
|
|
{
|
|
echo '<br/>'.$_html;
|
|
}
|
|
echo '<center/>';
|
|
unset($_returnhtml);
|
|
unset($_html);
|
|
}
|
|
} |