extern/encfs
1
0
Fork 0
mirror of https://github.com/vgough/encfs.git synced 2024-11-22 16:03:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Remove "-o default_permissions" unless needed."

Browse Source 
Caused a regression: https://github.com/vgough/encfs/issues/112 , and
removing open_readonly_workaround caused another one. So let's just
keep it as it was.

This reverts commit 82ceb88998.
This commit is contained in:
Jakob Unterwurzacher 2016-06-25 15:12:04 +02:00
parent 4a691dc0bb
commit 87ee4b7d99
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
encfs/main.cpp
View File

@ -405,17 +405,14 @@ static bool processArgs(int argc, char *argv[],
PUSHARG("-o"); PUSHARG("-o");
PUSHARG("use_ino"); PUSHARG("use_ino");
// "default_permissions" comes with a performance cost. Only enable // "default_permissions" comes with a performance cost, and only makes
// it if makes sense. // sense if "allow_other"" is used.
for (int i = 0; i < out->fuseArgc; i++) { // But it works around the issues "open_readonly_workaround" causes,
if (out->fuseArgv[i] == NULL) { // so enable it unconditionally.
continue; // See https://github.com/vgough/encfs/issues/181 and
} else if (strcmp(out->fuseArgv[i], "allow_other") == 0) { // https://github.com/vgough/encfs/issues/112 for more info.
PUSHARG("-o"); PUSHARG("-o");
PUSHARG("default_permissions"); PUSHARG("default_permissions");
break;
}
}
#if defined(__APPLE__) #if defined(__APPLE__)
// With OSXFuse, the 'local' flag selects a local filesystem mount icon in // With OSXFuse, the 'local' flag selects a local filesystem mount icon in