mirror of
https://github.com/vgough/encfs.git
synced 2024-11-24 17:03:13 +01:00
a17f7366c2
* Fix up encfssh The original implementation of encfssh had several issues: - Could not safely handle directory names with spaces - Could not safely handle paths starting with a dash (`-`) - Option strings could not be passed with spaces - Could print incorrect help based on filenames in current directory - Used `test` syntax deprecated in current POSIX.2 standard - Had shell injection vulnerabilities based on both current working directory and mount-point directory names. - Failures of the canonicalize function could silently return the current directory rather than the target. In this version, shell injection is only permitted through the (explicitly defined) `FUSE_UMOUNT` mechanism. This version also adds support for the GNU-style "--help" argument.
94 lines
2.4 KiB
Bash
Executable File
94 lines
2.4 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
# This script mounts an encfs filesystem, starts a shell in the mounted
|
|
# directory, and then unmounts the filesystem when the shell exits.
|
|
# This is an equivalent of the cfssh utility for cfs.
|
|
# Contributed by David Rosenstrauch.
|
|
|
|
canonicalize() {
|
|
cd "$1" || return
|
|
pwd
|
|
}
|
|
|
|
|
|
case $1 in "" | -h | --help)
|
|
echo "Usage: encfssh encrypted_directory [unencrypted-directory [-p]]"
|
|
echo " -p mount the unencrypted directory as public"
|
|
exit 1
|
|
;;
|
|
esac
|
|
|
|
enc_dir=$1
|
|
unenc_dir_given=false
|
|
mount_public=false
|
|
if [ ! -z "$2" ]; then
|
|
unenc_dir_given=true
|
|
unenc_dir=$2
|
|
for arg in "$@" ; do
|
|
if [ "$arg" = "-p" ]; then
|
|
mount_public=true
|
|
fi
|
|
done
|
|
[ -d "$unenc_dir" ] || mkdir -- "$unenc_dir"
|
|
else
|
|
unenc_dir=$(mktemp -d .XXXXXXXX)
|
|
fi
|
|
|
|
if [ ! -d "$enc_dir" ]; then
|
|
mkdir -- "$enc_dir"
|
|
fi
|
|
|
|
enc_dir=$(canonicalize "$enc_dir")
|
|
unenc_dir=$(canonicalize "$unenc_dir")
|
|
|
|
options=
|
|
if [ "$unenc_dir_given" = "true" ]; then
|
|
if [ "$mount_public" = "true" ]; then
|
|
options="-- -o allow_other"
|
|
fi
|
|
fi
|
|
|
|
# Attach the directory and change into it
|
|
|
|
## options can only have one of two values (empty, or "-- -o allow_other"), so
|
|
## this unquoted expansion is safe; disabling relevant shellcheck warning.
|
|
## See code review feedback requesting this attached to
|
|
## https://github.com/vgough/encfs/pull/258/files/09b9fc5efb7c2694976baffe7dd21172fd182027
|
|
## ...and that warning's explanation at https://github.com/koalaman/shellcheck/wiki/SC2086
|
|
# shellcheck disable=SC2086
|
|
if encfs "$enc_dir" "$unenc_dir" $options; then :; else
|
|
echo "encfs failed"
|
|
rmdir -- "$unenc_dir"
|
|
exit 1
|
|
fi
|
|
if ! [ "$unenc_dir_given" = "true" ]; then
|
|
chmod 700 "$unenc_dir"
|
|
fi
|
|
echo "Directory is $unenc_dir" >&2
|
|
cd "$unenc_dir" || exit
|
|
|
|
# Fall back to umount if fusermount is not available (e.g., on OS X)
|
|
fuse_umount() {
|
|
if command -v fusermount >/dev/null 2>&1; then
|
|
fusermount -u "$@"
|
|
else
|
|
umount "$@" # MacOS case
|
|
fi
|
|
}
|
|
|
|
# Honor the SHELL environment variable to select a shell to run
|
|
"$SHELL"; retval=$?
|
|
|
|
# ensure that this shell isn't itself holding the mounted directory open
|
|
# ...but avoid terminating on failure, *or* causing a shellcheck warning for
|
|
# failing to check exit status from cd.
|
|
cd / ||:
|
|
|
|
# if unmount fails, skip rmdir, always use exit status of failure
|
|
fuse_umount "$unenc_dir" || exit
|
|
|
|
if ! [ "$unenc_dir_given" = true ]; then
|
|
rmdir -- "$unenc_dir"
|
|
fi
|
|
exit "$retval"
|