extern/gatus
1
0
Fork 0
mirror of https://github.com/TwiN/gatus.git synced 2025-04-16 07:28:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Increase test coverage and remove useless code

Browse Source
This commit is contained in:
TwinProduction 2021-07-18 00:05:22 -04:00 committed by Chris
parent 56fedcedd1
commit 1a597f92ba
2 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
storage/store/database/database.go
View File

@ -644,16 +644,10 @@ func (s *Store) getNumberOfEventsByServiceID(tx *sql.Tx, serviceID int64) (int64
return 0, err return 0, err
} }
var numberOfEvents int64 var numberOfEvents int64
var found bool
for rows.Next() { for rows.Next() {
_ = rows.Scan(&numberOfEvents) _ = rows.Scan(&numberOfEvents)
found = true
break
} }
_ = rows.Close() _ = rows.Close()
if !found {
return 0, errNoRowsReturned
}
return numberOfEvents, nil return numberOfEvents, nil
} }
@ -663,16 +657,10 @@ func (s *Store) getNumberOfResultsByServiceID(tx *sql.Tx, serviceID int64) (int6
return 0, err return 0, err
} }
var numberOfResults int64 var numberOfResults int64
var found bool
for rows.Next() { for rows.Next() {
_ = rows.Scan(&numberOfResults) _ = rows.Scan(&numberOfResults)
found = true
break
} }
_ = rows.Close() _ = rows.Close()
if !found {
return 0, errNoRowsReturned
}
return numberOfResults, nil return numberOfResults, nil
} }

3
storage/store/database/database_test.go
View File

@ -248,6 +248,9 @@ func TestStore_InvalidTransaction(t *testing.T) {
defer store.Close() defer store.Close()
tx, _ := store.db.Begin() tx, _ := store.db.Begin()
tx.Commit() tx.Commit()
if err := store.insertEvent(tx, 1, core.NewEventFromResult(&testSuccessfulResult)); err == nil {
t.Error("should've returned an error, because the transaction was already committed")
}
if err := store.insertResult(tx, 1, &testSuccessfulResult); err == nil { if err := store.insertResult(tx, 1, &testSuccessfulResult); err == nil {
t.Error("should've returned an error, because the transaction was already committed") t.Error("should've returned an error, because the transaction was already committed")
} }