extern/gatus
1
0
Fork 0
mirror of https://github.com/TwiN/gatus.git synced 2025-01-03 12:39:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

test(dns): Fix case with inconsistent results

Browse Source
This commit is contained in:
TwiN 2022-06-16 19:12:32 -04:00
parent 076f5c45e8
commit 43e8c57701
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
core/dns_test.go
View File

@ -39,11 +39,11 @@ func TestIntegrationQuery(t *testing.T) {
name: "test DNS with type CNAME", name: "test DNS with type CNAME",
inputDNS: DNS{ inputDNS: DNS{
QueryType: "CNAME", QueryType: "CNAME",
QueryName: "doc.google.com.", QueryName: "en.wikipedia.org.",
}, },
inputURL: "8.8.8.8", inputURL: "1.1.1.1",
expectedDNSCode: "NOERROR", expectedDNSCode: "NOERROR",
expectedBody: "writely.l.google.com.", expectedBody: "dyna.wikimedia.org.",
}, },
{ {
name: "test DNS with type MX", name: "test DNS with type MX",
@ -69,7 +69,7 @@ func TestIntegrationQuery(t *testing.T) {
name: "test DNS with fake type and retrieve error", name: "test DNS with fake type and retrieve error",
inputDNS: DNS{ inputDNS: DNS{
QueryType: "B", QueryType: "B",
QueryName: "google", QueryName: "example",
}, },
inputURL: "8.8.8.8", inputURL: "8.8.8.8",
isErrExpected: true, isErrExpected: true,
@ -77,7 +77,6 @@ func TestIntegrationQuery(t *testing.T) {
} }
for _, test := range tests { for _, test := range tests {
test := test
t.Run(test.name, func(t *testing.T) { t.Run(test.name, func(t *testing.T) {
dns := test.inputDNS dns := test.inputDNS
result := &Result{} result := &Result{}
@ -86,9 +85,8 @@ func TestIntegrationQuery(t *testing.T) {
t.Errorf("there should be errors") t.Errorf("there should be errors")
} }
if result.DNSRCode != test.expectedDNSCode { if result.DNSRCode != test.expectedDNSCode {
t.Errorf("DNSRCodePlaceholder '%s' should have been %s", result.DNSRCode, test.expectedDNSCode) t.Errorf("expected DNSRCode to be %s, got %s", test.expectedDNSCode, result.DNSRCode)
} }
if test.inputDNS.QueryType == "NS" { if test.inputDNS.QueryType == "NS" {
// Because there are often multiple nameservers backing a single domain, we'll only look at the suffix // Because there are often multiple nameservers backing a single domain, we'll only look at the suffix
if !pattern.Match(test.expectedBody, string(result.body)) { if !pattern.Match(test.expectedBody, string(result.body)) {