Minor fixes

This commit is contained in:
TwinProduction 2021-05-15 21:54:23 -04:00
parent a85c5d5486
commit 77de4c4742
3 changed files with 28 additions and 17 deletions

View File

@ -46,7 +46,8 @@ func TestAlertProvider_ToCustomAlertProviderWithResolvedAlert(t *testing.T) {
func TestAlertProvider_ToCustomAlertProviderWithTriggeredAlert(t *testing.T) { func TestAlertProvider_ToCustomAlertProviderWithTriggeredAlert(t *testing.T) {
provider := AlertProvider{Token: "123456:ABC-DEF1234ghIkl-zyx57W2v1u123ew11", ID: "0123456789"} provider := AlertProvider{Token: "123456:ABC-DEF1234ghIkl-zyx57W2v1u123ew11", ID: "0123456789"}
customAlertProvider := provider.ToCustomAlertProvider(&core.Service{}, &core.Alert{Description: "Healthcheck Successful"}, &core.Result{ConditionResults: []*core.ConditionResult{{Condition: "UNSUCCESSFUL_CONDITION", Success: false}}}, false) description := "Healthcheck Successful"
customAlertProvider := provider.ToCustomAlertProvider(&core.Service{}, &core.Alert{Description: &description}, &core.Result{ConditionResults: []*core.ConditionResult{{Condition: "UNSUCCESSFUL_CONDITION", Success: false}}}, false)
if customAlertProvider == nil { if customAlertProvider == nil {
t.Fatal("customAlertProvider shouldn't have been nil") t.Fatal("customAlertProvider shouldn't have been nil")
} }

View File

@ -31,7 +31,8 @@ func TestAlertProvider_ToCustomAlertProviderWithResolvedAlert(t *testing.T) {
From: "3", From: "3",
To: "4", To: "4",
} }
customAlertProvider := provider.ToCustomAlertProvider(&core.Service{Name: "service-name"}, &core.Alert{Description: "alert-description"}, &core.Result{}, true) description := "alert-description"
customAlertProvider := provider.ToCustomAlertProvider(&core.Service{Name: "service-name"}, &core.Alert{Description: &description}, &core.Result{}, true)
if customAlertProvider == nil { if customAlertProvider == nil {
t.Fatal("customAlertProvider shouldn't have been nil") t.Fatal("customAlertProvider shouldn't have been nil")
} }
@ -56,7 +57,8 @@ func TestAlertProvider_ToCustomAlertProviderWithTriggeredAlert(t *testing.T) {
From: "2", From: "2",
To: "1", To: "1",
} }
customAlertProvider := provider.ToCustomAlertProvider(&core.Service{Name: "service-name"}, &core.Alert{Description: "alert-description"}, &core.Result{}, false) description := "alert-description"
customAlertProvider := provider.ToCustomAlertProvider(&core.Service{Name: "service-name"}, &core.Alert{Description: &description}, &core.Result{}, false)
if customAlertProvider == nil { if customAlertProvider == nil {
t.Fatal("customAlertProvider shouldn't have been nil") t.Fatal("customAlertProvider shouldn't have been nil")
} }

View File

@ -25,15 +25,16 @@ func TestHandleAlerting(t *testing.T) {
}, },
} }
config.Set(cfg) config.Set(cfg)
enabled := true
service := &core.Service{ service := &core.Service{
URL: "http://example.com", URL: "http://example.com",
Alerts: []*core.Alert{ Alerts: []*core.Alert{
{ {
Type: core.CustomAlert, Type: core.CustomAlert,
Enabled: true, Enabled: &enabled,
FailureThreshold: 2, FailureThreshold: 2,
SuccessThreshold: 3, SuccessThreshold: 3,
SendOnResolved: true, SendOnResolved: &enabled,
Triggered: false, Triggered: false,
}, },
}, },
@ -78,15 +79,16 @@ func TestHandleAlertingWithBadAlertProvider(t *testing.T) {
Alerting: &alerting.Config{}, Alerting: &alerting.Config{},
} }
config.Set(cfg) config.Set(cfg)
enabled := true
service := &core.Service{ service := &core.Service{
URL: "http://example.com", URL: "http://example.com",
Alerts: []*core.Alert{ Alerts: []*core.Alert{
{ {
Type: core.CustomAlert, Type: core.CustomAlert,
Enabled: true, Enabled: &enabled,
FailureThreshold: 1, FailureThreshold: 1,
SuccessThreshold: 1, SuccessThreshold: 1,
SendOnResolved: true, SendOnResolved: &enabled,
Triggered: false, Triggered: false,
}, },
}, },
@ -113,15 +115,16 @@ func TestHandleAlertingWhenTriggeredAlertIsAlmostResolvedButServiceStartFailingA
}, },
} }
config.Set(cfg) config.Set(cfg)
enabled := true
service := &core.Service{ service := &core.Service{
URL: "http://example.com", URL: "http://example.com",
Alerts: []*core.Alert{ Alerts: []*core.Alert{
{ {
Type: core.CustomAlert, Type: core.CustomAlert,
Enabled: true, Enabled: &enabled,
FailureThreshold: 2, FailureThreshold: 2,
SuccessThreshold: 3, SuccessThreshold: 3,
SendOnResolved: true, SendOnResolved: &enabled,
Triggered: true, Triggered: true,
}, },
}, },
@ -147,15 +150,17 @@ func TestHandleAlertingWhenTriggeredAlertIsResolvedButSendOnResolvedIsFalse(t *t
}, },
} }
config.Set(cfg) config.Set(cfg)
enabled := true
disabled := false
service := &core.Service{ service := &core.Service{
URL: "http://example.com", URL: "http://example.com",
Alerts: []*core.Alert{ Alerts: []*core.Alert{
{ {
Type: core.CustomAlert, Type: core.CustomAlert,
Enabled: true, Enabled: &enabled,
FailureThreshold: 1, FailureThreshold: 1,
SuccessThreshold: 1, SuccessThreshold: 1,
SendOnResolved: false, SendOnResolved: &disabled,
Triggered: true, Triggered: true,
}, },
}, },
@ -179,15 +184,16 @@ func TestHandleAlertingWhenTriggeredAlertIsResolvedPagerDuty(t *testing.T) {
}, },
} }
config.Set(cfg) config.Set(cfg)
enabled := true
service := &core.Service{ service := &core.Service{
URL: "http://example.com", URL: "http://example.com",
Alerts: []*core.Alert{ Alerts: []*core.Alert{
{ {
Type: core.PagerDutyAlert, Type: core.PagerDutyAlert,
Enabled: true, Enabled: &enabled,
FailureThreshold: 1, FailureThreshold: 1,
SuccessThreshold: 1, SuccessThreshold: 1,
SendOnResolved: true, SendOnResolved: &enabled,
Triggered: false, Triggered: false,
}, },
}, },
@ -215,15 +221,16 @@ func TestHandleAlertingWithProviderThatReturnsAnError(t *testing.T) {
}, },
} }
config.Set(cfg) config.Set(cfg)
enabled := true
service := &core.Service{ service := &core.Service{
URL: "http://example.com", URL: "http://example.com",
Alerts: []*core.Alert{ Alerts: []*core.Alert{
{ {
Type: core.CustomAlert, Type: core.CustomAlert,
Enabled: true, Enabled: &enabled,
FailureThreshold: 2, FailureThreshold: 2,
SuccessThreshold: 2, SuccessThreshold: 2,
SendOnResolved: true, SendOnResolved: &enabled,
Triggered: false, Triggered: false,
}, },
}, },
@ -273,15 +280,16 @@ func TestHandleAlertingWithProviderThatOnlyReturnsErrorOnResolve(t *testing.T) {
}, },
} }
config.Set(cfg) config.Set(cfg)
enabled := true
service := &core.Service{ service := &core.Service{
URL: "http://example.com", URL: "http://example.com",
Alerts: []*core.Alert{ Alerts: []*core.Alert{
{ {
Type: core.CustomAlert, Type: core.CustomAlert,
Enabled: true, Enabled: &enabled,
FailureThreshold: 1, FailureThreshold: 1,
SuccessThreshold: 1, SuccessThreshold: 1,
SendOnResolved: true, SendOnResolved: &enabled,
Triggered: false, Triggered: false,
}, },
}, },