extern/gatus
1
0
Fork 0
mirror of https://github.com/TwiN/gatus.git synced 2025-02-22 05:01:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix issue with displayed condition when condition uses len()

Browse Source
This commit is contained in:
TwinProduction 2020-10-29 17:18:43 -04:00
parent d76caeeb35
commit babc7f9f07
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/condition.go
View File

@ -155,7 +155,11 @@ func sanitizeAndResolve(list []string, result *Result) []string {
if err.Error() != "unexpected end of JSON input" {
result.Errors = append(result.Errors, err.Error())
}
element = fmt.Sprintf("%s %s", element, InvalidConditionElementSuffix)
if wantLength {
element = fmt.Sprintf("len(%s) %s", element, InvalidConditionElementSuffix)
} else {
element = fmt.Sprintf("%s %s", element, InvalidConditionElementSuffix)
}
} else {
if wantLength {
element = fmt.Sprintf("%d", resolvedElementLength)

13
core/condition_test.go
View File

@ -126,6 +126,19 @@ func TestCondition_evaluateWithInvalidBodyJSONPathComplex(t *testing.T) {
}
}
func TestCondition_evaluateWithInvalidBodyJSONPathComplexWithLengthFunction(t *testing.T) {
expectedResolvedCondition := "len([BODY].data.name) (INVALID) == john"
condition := Condition("len([BODY].data.name) == john")
result := &Result{Body: []byte("{\"data\": {\"id\": 1}}")}
condition.evaluate(result)
if result.ConditionResults[0].Success {
t.Errorf("Condition '%s' should have been a failure, because the path was invalid", condition)
}
if result.ConditionResults[0].Condition != expectedResolvedCondition {
t.Errorf("Condition '%s' should have resolved to '%s', but resolved to '%s' instead", condition, expectedResolvedCondition, result.ConditionResults[0].Condition)
}
}
func TestCondition_evaluateWithBodyJSONPathDoublePlaceholders(t *testing.T) {
condition := Condition("[BODY].user.firstName != [BODY].user.lastName")
result := &Result{Body: []byte("{\"user\": {\"firstName\": \"john\", \"lastName\": \"doe\"}}")}