extern/gatus
1
0
Fork 0
mirror of https://github.com/TwiN/gatus.git synced 2024-11-24 17:04:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Postgres performance improvement

Browse Source
This commit is contained in:
TwinProduction 2021-09-11 17:49:31 -04:00
parent f3822a949d
commit cbfdc359d3
1 changed files with 20 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
storage/store/sql/sql.go
View File

@ -215,7 +215,6 @@ func (s *Store) Insert(service *core.Service, result *core.Result) error {
if err != nil { if err != nil {
return err return err
} }
//start := time.Now()
serviceID, err := s.getServiceID(tx, service) serviceID, err := s.getServiceID(tx, service)
if err != nil { if err != nil {
if err == common.ErrServiceNotFound { if err == common.ErrServiceNotFound {
@ -320,7 +319,6 @@ func (s *Store) Insert(service *core.Service, result *core.Result) error {
} }
} }
} }
//log.Printf("[sql][Insert] Successfully inserted result in duration=%dms", time.Since(start).Milliseconds())
if err = tx.Commit(); err != nil { if err = tx.Commit(); err != nil {
_ = tx.Rollback() _ = tx.Rollback()
} }
@ -558,16 +556,6 @@ func (s *Store) getResultsByServiceID(tx *sql.Tx, serviceID int64, page, pageSiz
ORDER BY service_result_id DESC -- Normally, we'd sort by timestamp, but sorting by service_result_id is faster ORDER BY service_result_id DESC -- Normally, we'd sort by timestamp, but sorting by service_result_id is faster
LIMIT $2 OFFSET $3 LIMIT $2 OFFSET $3
`, `,
//`
// SELECT * FROM (
// SELECT service_result_id, success, errors, connected, status, dns_rcode, certificate_expiration, hostname, ip, duration, timestamp
// FROM service_result
// WHERE service_id = $1
// ORDER BY service_result_id DESC -- Normally, we'd sort by timestamp, but sorting by service_result_id is faster
// LIMIT $2 OFFSET $3
// )
// ORDER BY service_result_id ASC -- Normally, we'd sort by timestamp, but sorting by service_result_id is faster
//`,
serviceID, serviceID,
pageSize, pageSize,
(page-1)*pageSize, (page-1)*pageSize,
@ -584,33 +572,34 @@ func (s *Store) getResultsByServiceID(tx *sql.Tx, serviceID int64, page, pageSiz
if len(joinedErrors) != 0 { if len(joinedErrors) != 0 {
result.Errors = strings.Split(joinedErrors, arraySeparator) result.Errors = strings.Split(joinedErrors, arraySeparator)
} }
//results = append(results, result)
// This is faster than using a subselect // This is faster than using a subselect
results = append([]*core.Result{result}, results...) results = append([]*core.Result{result}, results...)
idResultMap[id] = result idResultMap[id] = result
} }
_ = rows.Close() _ = rows.Close()
// Get the conditionResults // Get condition results
for serviceResultID, result := range idResultMap { args := make([]interface{}, 0, len(idResultMap))
rows, err = tx.Query( query := `SELECT service_result_id, condition, success
`
SELECT condition, success
FROM service_result_condition FROM service_result_condition
WHERE service_result_id = $1 WHERE service_result_id IN (`
`, index := 1
serviceResultID, for serviceResultID := range idResultMap {
) query += fmt.Sprintf("$%d,", index)
if err != nil { args = append(args, serviceResultID)
index++
}
query = query[:len(query)-1] + ")"
rows, err = tx.Query(query, args...)
if err != nil {
return nil, err
}
for rows.Next() {
conditionResult := &core.ConditionResult{}
var serviceResultID int64
if err = rows.Scan(&serviceResultID, &conditionResult.Condition, &conditionResult.Success); err != nil {
return return
} }
for rows.Next() { idResultMap[serviceResultID].ConditionResults = append(idResultMap[serviceResultID].ConditionResults, conditionResult)
conditionResult := &core.ConditionResult{}
if err = rows.Scan(&conditionResult.Condition, &conditionResult.Success); err != nil {
return
}
result.ConditionResults = append(result.ConditionResults, conditionResult)
}
_ = rows.Close()
} }
return return
} }