From a2b7f59dc9c28b3cc53ef4db4cc10c13adf74ef9 Mon Sep 17 00:00:00 2001 From: ssrtw Date: Thu, 13 Jun 2024 03:13:57 +0000 Subject: [PATCH] fix: correct title handling for RSS items without titles --- internal/feed/rss.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/internal/feed/rss.go b/internal/feed/rss.go index 2cd93c8..3ca8b51 100644 --- a/internal/feed/rss.go +++ b/internal/feed/rss.go @@ -93,7 +93,6 @@ func getItemsFromRSSFeedTask(request RSSFeedRequest) ([]RSSFeedItem, error) { rssItem := RSSFeedItem{ ChannelURL: feed.Link, - Title: item.Title, } if request.ItemLinkPrefix != "" { @@ -120,8 +119,14 @@ func getItemsFromRSSFeedTask(request RSSFeedRequest) ([]RSSFeedItem, error) { } } + if item.Title != "" { + rssItem.Title = item.Title + } else { + rssItem.Title = shortenFeedDescriptionLen(item.Description, 100) + } + if request.IsDetailed { - if !request.HideDescription && item.Description != "" { + if !request.HideDescription && item.Description != "" && item.Title != "" { rssItem.Description = shortenFeedDescriptionLen(item.Description, 200) } @@ -142,10 +147,6 @@ func getItemsFromRSSFeedTask(request RSSFeedRequest) ([]RSSFeedItem, error) { rssItem.Categories = categories } - } else { - if item.Title == "" { - rssItem.Title = shortenFeedDescriptionLen(item.Description, 100) - } } if request.Title != "" {