From a77d0ce5c056be3e248d24402fcba4981a0b26e0 Mon Sep 17 00:00:00 2001
From: Svilen Markov <7613769+svilenmarkov@users.noreply.github.com>
Date: Tue, 18 Mar 2025 13:11:19 +0000
Subject: [PATCH] Move behavior within the widget init

Otherwise we create a global getWidgetTitleURL
function that sounds a little too generic and vague
---
 internal/glance/widget-dns-stats.go | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/internal/glance/widget-dns-stats.go b/internal/glance/widget-dns-stats.go
index deda67c..7311b1b 100644
--- a/internal/glance/widget-dns-stats.go
+++ b/internal/glance/widget-dns-stats.go
@@ -60,19 +60,16 @@ func makeDNSWidgetTimeLabels(format string) [8]string {
 	return labels
 }
 
-func getWidgetTitleURL(widget *dnsStatsWidget) string {
+func (widget *dnsStatsWidget) initialize() error {
+	titleURL := strings.TrimRight(widget.URL, "/")
 	switch widget.Service {
 	case dnsServicePihole, dnsServicePiholeV6:
-		return fmt.Sprintf("%s/admin", strings.TrimRight(widget.URL, "/"))
-	default:
-		return widget.URL
+		titleURL = titleURL + "/admin"
 	}
-}
 
-func (widget *dnsStatsWidget) initialize() error {
 	widget.
 		withTitle("DNS Stats").
-		withTitleURL(getWidgetTitleURL(widget)).
+		withTitleURL(titleURL).
 		withCacheDuration(10 * time.Minute)
 
 	switch widget.Service {