From 2fd69ec58b801b276d475ef9e4af12deeacab5f6 Mon Sep 17 00:00:00 2001 From: Daenney Date: Thu, 30 May 2024 11:00:47 +0200 Subject: [PATCH] [chore] Make worker run messages debug output (#2944) On startup and shutdown of a worker, we log a message of the worker being started together with a textual representation of a memory address. Though this can be handy for developers to debug startup/shutdown sequencing issues of the workers, it's typically not very useful or informative for an admin. We can also output a lot of these (on my system I get 265 lines of these during startup). This changes the messages from Info to Debug, to not print them under normal circumstances. --- internal/transport/delivery/delivery.go | 4 ++-- internal/workers/worker_fn.go | 4 ++-- internal/workers/worker_msg.go | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/internal/transport/delivery/delivery.go b/internal/transport/delivery/delivery.go index 286f2abd2..5ae3e6cac 100644 --- a/internal/transport/delivery/delivery.go +++ b/internal/transport/delivery/delivery.go @@ -181,8 +181,8 @@ func (w *Worker) run(ctx context.Context) { if w.Client == nil || w.Queue == nil { panic("not yet initialized") } - log.Infof(ctx, "%p: starting worker", w) - defer log.Infof(ctx, "%p: stopped worker", w) + log.Debugf(ctx, "%p: starting worker", w) + defer log.Debugf(ctx, "%p: stopped worker", w) util.Must(func() { w.process(ctx) }) } diff --git a/internal/workers/worker_fn.go b/internal/workers/worker_fn.go index c41bee2b0..3f467e662 100644 --- a/internal/workers/worker_fn.go +++ b/internal/workers/worker_fn.go @@ -114,8 +114,8 @@ func (w *FnWorker) run(ctx context.Context) { if w.Queue == nil { panic("not yet initialized") } - log.Infof(ctx, "%p: starting worker", w) - defer log.Infof(ctx, "%p: stopped worker", w) + log.Debugf(ctx, "%p: starting worker", w) + defer log.Debugf(ctx, "%p: stopped worker", w) util.Must(func() { w.process(ctx) }) } diff --git a/internal/workers/worker_msg.go b/internal/workers/worker_msg.go index 1920c964e..0b43f5e07 100644 --- a/internal/workers/worker_msg.go +++ b/internal/workers/worker_msg.go @@ -127,8 +127,8 @@ func (w *MsgWorker[T]) run(ctx context.Context) { if w.Process == nil || w.Queue == nil { panic("not yet initialized") } - log.Infof(ctx, "%p: starting worker", w) - defer log.Infof(ctx, "%p: stopped worker", w) + log.Debugf(ctx, "%p: starting worker", w) + defer log.Debugf(ctx, "%p: stopped worker", w) util.Must(func() { w.process(ctx) }) }