mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2024-11-27 18:53:34 +01:00
33aee1b1e9
* reformat GetAccount() functionality, and add UpdateAccount() function.
* use fetched_at instead of last_webfingered_at
* catch local "not found" errors. small formatting / error string changes
* remove now unused error type
* return nil when wrapping nil error
* update expected error messages
* return correct url for foss satan webfinger
* add AP model for Some_User
* normalize local domain
* return notretrievable where appropriate
* expose NewErrNotRetrievable
* ensure webfinger for new accounts searched by uri
* update local account short circuit
* allow enrich to fail for already-known accounts
* remove unused LastWebfingeredAt
* expose test maps on mock http client
* update Update test
* reformat GetAccount() functionality, and add UpdateAccount() function.
* use fetched_at instead of last_webfingered_at
* catch local "not found" errors. small formatting / error string changes
* remove nil error checks (we shouldn't be passing nil errors to newError() initializers)
* remove mutex unlock on transport init fail (it hasn't yet been locked!)
* woops add back the error wrapping to use ErrNotRetrievable
* caches were never being started... 🙈
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
177 lines
5.8 KiB
Go
177 lines
5.8 KiB
Go
/*
|
|
GoToSocial
|
|
Copyright (C) 2021-2023 GoToSocial Authors admin@gotosocial.org
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU Affero General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU Affero General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Affero General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
package users_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/stretchr/testify/suite"
|
|
"github.com/superseriousbusiness/activity/streams"
|
|
"github.com/superseriousbusiness/activity/streams/vocab"
|
|
"github.com/superseriousbusiness/gotosocial/internal/api/activitypub/users"
|
|
apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
|
|
"github.com/superseriousbusiness/gotosocial/internal/oauth"
|
|
"github.com/superseriousbusiness/gotosocial/testrig"
|
|
)
|
|
|
|
type UserGetTestSuite struct {
|
|
UserStandardTestSuite
|
|
}
|
|
|
|
func (suite *UserGetTestSuite) TestGetUser() {
|
|
// the dereference we're gonna use
|
|
derefRequests := testrig.NewTestDereferenceRequests(suite.testAccounts)
|
|
signedRequest := derefRequests["foss_satan_dereference_zork"]
|
|
targetAccount := suite.testAccounts["local_account_1"]
|
|
|
|
// setup request
|
|
recorder := httptest.NewRecorder()
|
|
ctx, _ := testrig.CreateGinTestContext(recorder, nil)
|
|
ctx.Request = httptest.NewRequest(http.MethodGet, targetAccount.URI, nil) // the endpoint we're hitting
|
|
ctx.Request.Header.Set("accept", "application/activity+json")
|
|
ctx.Request.Header.Set("Signature", signedRequest.SignatureHeader)
|
|
ctx.Request.Header.Set("Date", signedRequest.DateHeader)
|
|
|
|
// we need to pass the context through signature check first to set appropriate values on it
|
|
suite.signatureCheck(ctx)
|
|
|
|
// normally the router would populate these params from the path values,
|
|
// but because we're calling the function directly, we need to set them manually.
|
|
ctx.Params = gin.Params{
|
|
gin.Param{
|
|
Key: users.UsernameKey,
|
|
Value: targetAccount.Username,
|
|
},
|
|
}
|
|
|
|
// trigger the function being tested
|
|
suite.userModule.UsersGETHandler(ctx)
|
|
|
|
// check response
|
|
suite.EqualValues(http.StatusOK, recorder.Code)
|
|
|
|
result := recorder.Result()
|
|
defer result.Body.Close()
|
|
b, err := ioutil.ReadAll(result.Body)
|
|
suite.NoError(err)
|
|
|
|
// should be a Person
|
|
m := make(map[string]interface{})
|
|
err = json.Unmarshal(b, &m)
|
|
suite.NoError(err)
|
|
|
|
t, err := streams.ToType(context.Background(), m)
|
|
suite.NoError(err)
|
|
|
|
person, ok := t.(vocab.ActivityStreamsPerson)
|
|
suite.True(ok)
|
|
|
|
// convert person to account
|
|
a, err := suite.tc.ASRepresentationToAccount(context.Background(), person, "")
|
|
suite.NoError(err)
|
|
suite.EqualValues(targetAccount.Username, a.Username)
|
|
}
|
|
|
|
// TestGetUserPublicKeyDeleted checks whether the public key of a deleted account can still be dereferenced.
|
|
// This is needed by remote instances for authenticating delete requests and stuff like that.
|
|
func (suite *UserGetTestSuite) TestGetUserPublicKeyDeleted() {
|
|
userModule := users.New(suite.processor)
|
|
targetAccount := suite.testAccounts["local_account_1"]
|
|
|
|
// first delete the account, as though zork had deleted himself
|
|
authed := &oauth.Auth{
|
|
Application: suite.testApplications["local_account_1"],
|
|
User: suite.testUsers["local_account_1"],
|
|
Account: suite.testAccounts["local_account_1"],
|
|
}
|
|
suite.processor.AccountDeleteLocal(context.Background(), authed, &apimodel.AccountDeleteRequest{
|
|
Password: "password",
|
|
DeleteOriginID: targetAccount.ID,
|
|
})
|
|
|
|
// wait for the account delete to be processed
|
|
if !testrig.WaitFor(func() bool {
|
|
a, _ := suite.db.GetAccountByID(context.Background(), targetAccount.ID)
|
|
return !a.SuspendedAt.IsZero()
|
|
}) {
|
|
suite.FailNow("delete of account timed out")
|
|
}
|
|
|
|
// the dereference we're gonna use
|
|
derefRequests := testrig.NewTestDereferenceRequests(suite.testAccounts)
|
|
signedRequest := derefRequests["foss_satan_dereference_zork_public_key"]
|
|
|
|
// setup request
|
|
recorder := httptest.NewRecorder()
|
|
ctx, _ := testrig.CreateGinTestContext(recorder, nil)
|
|
ctx.Request = httptest.NewRequest(http.MethodGet, targetAccount.PublicKeyURI, nil) // the endpoint we're hitting
|
|
ctx.Request.Header.Set("accept", "application/activity+json")
|
|
ctx.Request.Header.Set("Signature", signedRequest.SignatureHeader)
|
|
ctx.Request.Header.Set("Date", signedRequest.DateHeader)
|
|
|
|
// we need to pass the context through signature check first to set appropriate values on it
|
|
suite.signatureCheck(ctx)
|
|
|
|
// normally the router would populate these params from the path values,
|
|
// but because we're calling the function directly, we need to set them manually.
|
|
ctx.Params = gin.Params{
|
|
gin.Param{
|
|
Key: users.UsernameKey,
|
|
Value: targetAccount.Username,
|
|
},
|
|
}
|
|
|
|
// trigger the function being tested
|
|
userModule.UsersGETHandler(ctx)
|
|
|
|
// check response
|
|
suite.EqualValues(http.StatusOK, recorder.Code)
|
|
|
|
result := recorder.Result()
|
|
defer result.Body.Close()
|
|
b, err := ioutil.ReadAll(result.Body)
|
|
suite.NoError(err)
|
|
|
|
// should be a Person
|
|
m := make(map[string]interface{})
|
|
err = json.Unmarshal(b, &m)
|
|
suite.NoError(err)
|
|
|
|
t, err := streams.ToType(context.Background(), m)
|
|
suite.NoError(err)
|
|
|
|
person, ok := t.(vocab.ActivityStreamsPerson)
|
|
suite.True(ok)
|
|
|
|
// convert person to account
|
|
a, err := suite.tc.ASRepresentationToAccount(context.Background(), person, "")
|
|
suite.NoError(err)
|
|
suite.EqualValues(targetAccount.Username, a.Username)
|
|
}
|
|
|
|
func TestUserGetTestSuite(t *testing.T) {
|
|
suite.Run(t, new(UserGetTestSuite))
|
|
}
|