extern/heynote
1
0
Fork 0
mirror of https://github.com/heyman/heynote.git synced 2025-06-20 09:37:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't use conflicting name "select" for language change event

Browse Source 
#windows-build
This commit is contained in:
Jonatan Heyman 2023-01-16 21:52:45 +01:00
parent 9599fd7d92
commit c3918c32c5
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/App.vue
View File

@ -69,7 +69,7 @@
this.$refs.editor.focus() this.$refs.editor.focus()
}, },
onLanguageSelect(language) { onSelectLanguage(language) {
this.showLanguageSelector = false this.showLanguageSelector = false
this.$refs.editor.setLanguage(language) this.$refs.editor.setLanguage(language)
}, },
@ -102,7 +102,7 @@
<div class="overlay"> <div class="overlay">
<LanguageSelector <LanguageSelector
v-if="showLanguageSelector" v-if="showLanguageSelector"
@select="onLanguageSelect" @selectLanguage="onSelectLanguage"
@close="closeLanguageSelector" @close="closeLanguageSelector"
/> />
</div> </div>

8
src/components/LanguageSelector.vue
View File

@ -41,7 +41,7 @@
this.selected = Math.max(this.selected - 1, 0) this.selected = Math.max(this.selected - 1, 0)
event.preventDefault() event.preventDefault()
} else if (event.key === "Enter") { } else if (event.key === "Enter") {
this.$emit("select", this.filteredItems[this.selected].token) this.selectItem(this.filteredItems[this.selected].token)
event.preventDefault() event.preventDefault()
} else if (event.key === "Escape") { } else if (event.key === "Escape") {
this.$emit("close") this.$emit("close")
@ -49,6 +49,10 @@
} }
}, },
selectItem(token) {
this.$emit("selectLanguage", token)
},
onInput(event) { onInput(event) {
// reset selection // reset selection
this.selected = 0 this.selected = 0
@ -78,7 +82,7 @@
v-for="item, idx in filteredItems" v-for="item, idx in filteredItems"
:key="item.token" :key="item.token"
:class="idx === selected ? 'selected' : ''" :class="idx === selected ? 'selected' : ''"
@click="$emit('select', item.token)" @click="selectItem(item.token)"
> >
{{ item.name }} {{ item.name }}
</li> </li>