extern/hishtory
1
0
Fork 0
mirror of https://github.com/ddworken/hishtory.git synced 2024-11-23 00:34:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add comment to explain some confusing logic that we do have to keep

Browse Source
This commit is contained in:
David Dworken 2023-11-18 12:22:34 -08:00
parent 5bf734606f
commit 05088d4bed
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
client/cmd/saveHistoryEntry.go
View File

@ -567,6 +567,10 @@ func maybeSkipBashHistTimePrefix(cmdLine string) (string, error) {
}
func parseCrossPlatformTime(data string) time.Time {
// Note that this code is required to handle the case where timestamps are passed from `date %s%N`.
// As of f1a36d2, this is no longer the case. But, we want to ensure that when people upgrade from
// the old version (where they'll have an active shell session still using date) that we handle it
// properly. So we sadly have to keep this lax parsing code around indefinitely.
data = strings.TrimSuffix(data, "N") // Trim the N suffix that is present on MacOS where the date CLI doesn't support %N
startTime, err := strconv.ParseInt(data, 10, 64)
lib.CheckFatalError(err)