From 06424dfca869feb57d656f50cfc987b84a24b0df Mon Sep 17 00:00:00 2001 From: David Dworken Date: Sat, 19 Oct 2024 01:54:36 -0700 Subject: [PATCH] Add sanity checking to ensure we don't ever have a bug that uses flags as secret keys --- client/cmd/install.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/client/cmd/install.go b/client/cmd/install.go index 666aab0..52487e5 100644 --- a/client/cmd/install.go +++ b/client/cmd/install.go @@ -42,7 +42,10 @@ var installCmd = &cobra.Command{ if len(args) > 0 { secretKey = args[0] } - lib.CheckFatalError(install(secretKey, *offlineInstall, *skipConfigModification)) + if strings.HasPrefix(secretKey, "-") { + lib.CheckFatalError(fmt.Errorf("secret key %#v looks like a CLI flag, please use a secret key that does not start with a -", secretKey)) + } + // TODO: Add a check to crash if secretKey looks like a flag lib.CheckFatalError(install(secretKey, *offlineInstall, *skipConfigModification)) if os.Getenv("HISHTORY_SKIP_INIT_IMPORT") == "" { db, err := hctx.OpenLocalSqliteDb() lib.CheckFatalError(err)