extern/hishtory
1
0
Fork 0
mirror of https://github.com/ddworken/hishtory.git synced 2025-01-23 06:38:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add offline checking for deleting presaved entries so that hishtory works while offline

Browse Source
This commit is contained in:
David Dworken 2023-09-23 19:32:35 -07:00
parent 906277553c
commit 16f2751975
No known key found for this signature in database
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
client/cmd/saveHistoryEntry.go
View File

@ -163,7 +163,19 @@ func saveHistoryEntry(ctx context.Context) {
// Drop any entries from pre-saving since they're no longer needed
if config.BetaMode {
lib.CheckFatalError(deletePresavedEntries(ctx, entry))
err := deletePresavedEntries(ctx, entry)
if err != nil {
if lib.IsOfflineError(err) {
// Do Nothing: This means that if an entry is pre-saved, the user goes offline, and the
// command finishes running, then there will be a syncing inconsistency where remote devices
// will have the pre-saved entry and the main entry.
//
// TODO: Fix this by having the config store deletion requests to be resent once the device goes
// back online.
} else {
lib.CheckFatalError(err)
}
}
}
// Persist it locally