extern/hishtory
1
0
Fork 0
mirror of https://github.com/ddworken/hishtory.git synced 2025-08-23 12:41:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

Ensure that tests assert a lack of leaked connections

Browse Source
This commit is contained in:
David Dworken
2022-11-26 22:40:43 -08:00
parent f77eb38618
commit 22330f3ee1
3 changed files with 59 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
backend/server/server_test.go
View File

@@ -16,6 +16,7 @@ import (
"github.com/ddworken/hishtory/shared/testutils"
"github.com/go-test/deep"
"github.com/google/uuid"
"gorm.io/gorm"
)
func TestESubmitThenQuery(t *testing.T) {
@@ -113,6 +114,9 @@ func TestESubmitThenQuery(t *testing.T) {
if len(retrievedEntries) != 2 {
t.Fatalf("Expected to retrieve 2 entries, found %d", len(retrievedEntries))
}
// Assert that we aren't leaking connections
assertNoLeakedConnections(t, GLOBAL_DB)
}
func TestDumpRequestAndResponse(t *testing.T) {
@@ -279,6 +283,9 @@ func TestDumpRequestAndResponse(t *testing.T) {
t.Fatalf("DB data is different than input! \ndb =%#v\nentry1=%#v\nentry2=%#v", *dbEntry, entry1Dec, entry2Dec)
}
}
// Assert that we aren't leaking connections
assertNoLeakedConnections(t, GLOBAL_DB)
}
func TestUpdateReleaseVersion(t *testing.T) {
@@ -308,6 +315,9 @@ func TestUpdateReleaseVersion(t *testing.T) {
if !strings.HasPrefix(ReleaseVersion, "v0.") {
t.Fatalf("ReleaseVersion wasn't updated to contain a version: %#v", ReleaseVersion)
}
// Assert that we aren't leaking connections
assertNoLeakedConnections(t, GLOBAL_DB)
}
func TestDeletionRequests(t *testing.T) {
@@ -488,4 +498,18 @@ func TestDeletionRequests(t *testing.T) {
if diff := deep.Equal(*deletionRequest, expected); diff != nil {
t.Error(diff)
}
// Assert that we aren't leaking connections
assertNoLeakedConnections(t, GLOBAL_DB)
}
func assertNoLeakedConnections(t *testing.T, db *gorm.DB) {
sqlDB, err := db.DB()
if err != nil {
t.Fatal(err)
}
numConns := sqlDB.Stats().OpenConnections
if numConns > 1 {
t.Fatalf("expected DB to have not leak connections, actually have %d", numConns)
}
}