extern/hishtory
1
0
Fork 0
mirror of https://github.com/ddworken/hishtory.git synced 2025-06-26 15:02:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

Call Close() on sql.Rows to prevent connection leak

Browse Source
This commit is contained in:
David Dworken 2022-11-26 22:15:16 -08:00
parent 4e84f49de9
commit 2ba535b650
No known key found for this signature in database
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
backend/server/server.go
View File

@ -106,6 +106,7 @@ func usageStatsHandler(ctx context.Context, w http.ResponseWriter, r *http.Reque
if err != nil { if err != nil {
panic(err) panic(err)
} }
defer rows.Close()
tbl := table.New("Registration Date", "Num Devices", "Num Entries", "Num Queries", "Last Active", "Last Query", "Versions", "IPs") tbl := table.New("Registration Date", "Num Devices", "Num Entries", "Num Queries", "Last Active", "Last Query", "Versions", "IPs")
tbl.WithWriter(w) tbl.WithWriter(w)
for rows.Next() { for rows.Next() {
@ -145,7 +146,8 @@ func statsHandler(ctx context.Context, w http.ResponseWriter, r *http.Request) {
var weeklyQueryUsers int64 = 0 var weeklyQueryUsers int64 = 0
checkGormResult(GLOBAL_DB.WithContext(ctx).Model(&UsageData{}).Where("last_queried > ?", lastWeek).Count(&weeklyQueryUsers)) checkGormResult(GLOBAL_DB.WithContext(ctx).Model(&UsageData{}).Where("last_queried > ?", lastWeek).Count(&weeklyQueryUsers))
var lastRegistration string = "" var lastRegistration string = ""
err := GLOBAL_DB.WithContext(ctx).Raw("select to_char(max(registration_date), 'DD Month YYYY HH24:MI') from devices").Row().Scan(&lastRegistration) row := GLOBAL_DB.WithContext(ctx).Raw("select to_char(max(registration_date), 'DD Month YYYY HH24:MI') from devices").Row()
err := row.Scan(&lastRegistration)
if err != nil { if err != nil {
panic(err) panic(err)
} }
@ -396,6 +398,7 @@ func healthCheckHandler(ctx context.Context, w http.ResponseWriter, r *http.Requ
if err != nil { if err != nil {
panic(fmt.Sprintf("failed to count entries in DB: %v", err)) panic(fmt.Sprintf("failed to count entries in DB: %v", err))
} }
defer rows.Close()
if !rows.Next() { if !rows.Next() {
panic("Suspiciously few enc history entries!") panic("Suspiciously few enc history entries!")
} }