extern/hishtory
1
0
Fork 0
mirror of https://github.com/ddworken/hishtory.git synced 2025-08-09 15:15:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

Optimize TUI performance via sqlite tuning + caching (#290)

Browse Source 
* Optimize TUI performance via sqlite tuning + caching

* Disable TestTuiBench in GH actions since it is just meant for benchmarking

* Update golden

* Fix go errcheck finding

* Revert "Update golden"

This reverts commit 7c8865ce75.

* Clear the search cache after deletions

* Allowlist TestTuiBench-Query as an unused golden since it is not used on GH actions
This commit is contained in:
David Dworken
2025-02-03 14:59:16 -08:00
committed by GitHub
parent 380fb2afa7
commit 641e87c22a
8 changed files with 274 additions and 239 deletions
Download Patch File Download Diff File Expand all files Collapse all files

81
client/integration_test.go
View File

@ -21,6 +21,7 @@ import (
"github.com/ddworken/hishtory/client/data"
"github.com/ddworken/hishtory/client/hctx"
"github.com/ddworken/hishtory/client/lib"
"github.com/ddworken/hishtory/client/tui"
"github.com/ddworken/hishtory/shared"
"github.com/ddworken/hishtory/shared/ai"
"github.com/ddworken/hishtory/shared/testutils"
@ -3146,17 +3147,20 @@ func BenchmarkQuery(b *testing.B) {
numImported, err := lib.ImportHistory(ctx, false, true)
require.NoError(b, err)
require.GreaterOrEqual(b, numImported, numSyntheticEntries)
db := hctx.GetDb(ctx)
for i := range 1000 {
e := testutils.MakeFakeHistoryEntry(strings.Repeat(fmt.Sprintf("this is a long command %d", i), 100))
require.NoError(b, db.Create(e).Error)
}
// Benchmark it
for n := 0; n < b.N; n++ {
ctx := hctx.MakeContext()
// Benchmarked code:
b.StartTimer()
ctx := hctx.MakeContext()
err := lib.RetrieveAdditionalEntriesFromRemote(ctx, "tui")
require.NoError(b, err)
_, err = lib.Search(ctx, hctx.GetDb(ctx), "echo", 100)
require.NoError(b, err)
_, err := lib.Search(ctx, hctx.GetDb(ctx), "this is a long command 123", 100)
b.StopTimer()
require.NoError(b, err)
}
}
@ -3634,4 +3638,71 @@ func TestDefaultSearchColumnsAddDelete(t *testing.T) {
require.Equal(t, out, "command current_working_directory \n")
}
func TestTuiBench(t *testing.T) {
if testutils.IsGithubAction() {
t.Skip("Skipping benchmarking test in Github Actions")
}
// Setup
defer testutils.BackupAndRestore(t)()
createSyntheticImportEntries(t, 10000)
tester, _, _ := setupTestTui(t, Online)
ctx := hctx.MakeContext()
numImported, err := lib.ImportHistory(ctx, false, true)
require.NoError(t, err)
require.GreaterOrEqual(t, numImported, 10000)
db := hctx.GetDb(ctx)
for i := range 1000 {
e := testutils.MakeFakeHistoryEntry(strings.Repeat(fmt.Sprintf("this is a long command %d", i), 2))
require.NoError(t, db.Create(e).Error)
}
for range 30 {
out := captureTerminalOutputWithShellNameAndDimensions(t, tester, tester.ShellName(), 100, 20, []TmuxCommand{
{Keys: "hishtory SPACE tquery ENTER", ExtraDelay: 1},
{Keys: "t", NoSleep: true},
{Keys: "h", NoSleep: true},
{Keys: "i", NoSleep: true},
{Keys: "s", NoSleep: true},
{Keys: "SPACE", NoSleep: true},
{Keys: "i", NoSleep: true},
{Keys: "s", NoSleep: true},
{Keys: "SPACE", NoSleep: true},
{Keys: "1", NoSleep: true},
{Keys: "2", NoSleep: true},
{Keys: "3", NoSleep: true},
})
testutils.CompareGoldens(t, out, "TestTuiBench-Query")
}
}
func BenchmarkGetRows(b *testing.B) {
b.StopTimer()
// Setup with an install with a lot of entries
tester := zshTester{}
defer testutils.BackupAndRestore(b)()
testutils.ResetLocalState(b)
installHishtory(b, tester, "")
numSyntheticEntries := 100_000
createSyntheticImportEntries(b, numSyntheticEntries)
ctx := hctx.MakeContext()
numImported, err := lib.ImportHistory(ctx, false, true)
require.NoError(b, err)
require.GreaterOrEqual(b, numImported, numSyntheticEntries)
db := hctx.GetDb(ctx)
for i := range 1000 {
e := testutils.MakeFakeHistoryEntry(strings.Repeat(fmt.Sprintf("this is a long command %d", i), 100))
require.NoError(b, db.Create(e).Error)
}
config := hctx.GetConf(ctx)
// Benchmark it
for n := 0; n < b.N; n++ {
// Benchmarked code:
b.StartTimer()
_, _, err := tui.TestOnlyGetRows(ctx, config.DisplayedColumns, "bash", "", "this is a long command 123", 100)
b.StopTimer()
require.NoError(b, err)
}
}
// TODO: somehow test/confirm that hishtory works even if only bash/only zsh is installed