extern/hishtory
1
0
Fork 0
mirror of https://github.com/ddworken/hishtory.git synced 2025-08-09 23:17:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

Optimize TUI performance via sqlite tuning + caching (#290)

Browse Source 
* Optimize TUI performance via sqlite tuning + caching

* Disable TestTuiBench in GH actions since it is just meant for benchmarking

* Update golden

* Fix go errcheck finding

* Revert "Update golden"

This reverts commit 7c8865ce75.

* Clear the search cache after deletions

* Allowlist TestTuiBench-Query as an unused golden since it is not used on GH actions
This commit is contained in:
David Dworken
2025-02-03 14:59:16 -08:00
committed by GitHub
parent 380fb2afa7
commit 641e87c22a
8 changed files with 274 additions and 239 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
client/lib/lib.go
View File

@ -28,6 +28,10 @@ import (
"github.com/ddworken/hishtory/shared"
"github.com/araddon/dateparse"
"github.com/dgraph-io/ristretto"
"github.com/eko/gocache/lib/v4/cache"
"github.com/eko/gocache/lib/v4/store"
ristretto_store "github.com/eko/gocache/store/ristretto/v4"
"github.com/google/uuid"
"github.com/schollz/progressbar/v3"
"golang.org/x/exp/slices"
@ -769,7 +773,7 @@ func where(tx *gorm.DB, s string, args ...any) *gorm.DB {
func MakeWhereQueryFromSearch(ctx context.Context, db *gorm.DB, query string) (*gorm.DB, error) {
tokens := tokenize(query)
tx := db.Model(&data.HistoryEntry{}).Where("true")
tx := db.Model(&data.HistoryEntry{}).WithContext(ctx).Where("true")
for _, token := range tokens {
if strings.HasPrefix(token, "-") {
if token == "-" {
@ -807,6 +811,56 @@ func MakeWhereQueryFromSearch(ctx context.Context, db *gorm.DB, query string) (*
return tx, nil
}
type searchQuery struct {
query string
limit int
}
type searchResult struct {
results []*data.HistoryEntry
err error
}
var SEARCH_CACHE *cache.LoadableCache[*searchResult]
func ClearSearchCache(ctx context.Context) error {
if SEARCH_CACHE == nil {
return nil
}
return SEARCH_CACHE.Clear(ctx)
}
func SearchWithCache(ctx context.Context, db *gorm.DB, query string, limit int) ([]*data.HistoryEntry, error) {
if SEARCH_CACHE == nil {
loadFunction := func(ctx context.Context, key any) (*searchResult, []store.Option, error) {
sq := key.(searchQuery)
results, err := Search(ctx, db, sq.query, sq.limit)
return &searchResult{results, err}, []store.Option{store.WithCost(1), store.WithExpiration(time.Second * 3)}, nil
}
ristrettoCache, err := ristretto.NewCache(&ristretto.Config{
NumCounters: 1000,
MaxCost: 100,
BufferItems: 64,
})
if err != nil {
panic(err)
}
ristrettoStore := ristretto_store.NewRistretto(ristrettoCache)
cacheManager := cache.NewLoadable[*searchResult](
loadFunction,
cache.New[*searchResult](ristrettoStore),
)
SEARCH_CACHE = cacheManager
}
res, err := SEARCH_CACHE.Get(ctx, searchQuery{query, limit})
if err != nil {
return nil, fmt.Errorf("failed to get from cache: %w", err)
}
return res.results, res.err
}
func Search(ctx context.Context, db *gorm.DB, query string, limit int) ([]*data.HistoryEntry, error) {
return SearchWithOffset(ctx, db, query, limit, 0)
}