Revert the update change since that needs to be in a separate release

This commit is contained in:
David Dworken 2024-10-20 11:31:05 -07:00
parent 8bb87f2d7a
commit 8834eaca06
No known key found for this signature in database
2 changed files with 5 additions and 1 deletions

View File

@ -31,6 +31,9 @@ var (
offlineInstall *bool offlineInstall *bool
skipConfigModification *bool skipConfigModification *bool
skipUpdateConfigModification *bool skipUpdateConfigModification *bool
//lint:ignore U1000 Flag that is allowed to be specified, but not used
currentlyInstalledVersion *string
) )
var installCmd = &cobra.Command{ var installCmd = &cobra.Command{
@ -688,4 +691,5 @@ func init() {
offlineInstall = installCmd.Flags().Bool("offline", false, "Install hiSHtory in offline mode with all syncing capabilities disabled") offlineInstall = installCmd.Flags().Bool("offline", false, "Install hiSHtory in offline mode with all syncing capabilities disabled")
skipConfigModification = installCmd.Flags().Bool("skip-config-modification", false, "Skip modifying shell configs and instead instruct the user on how to modify their configs") skipConfigModification = installCmd.Flags().Bool("skip-config-modification", false, "Skip modifying shell configs and instead instruct the user on how to modify their configs")
skipUpdateConfigModification = installCmd.Flags().Bool("skip-update-config-modification", false, "Skip modifying shell configs for updates") skipUpdateConfigModification = installCmd.Flags().Bool("skip-update-config-modification", false, "Skip modifying shell configs for updates")
currentlyInstalledVersion = installCmd.Flags().String("currently-installed-version", "", "The currently installed version (used by the update command)")
} }

View File

@ -112,7 +112,7 @@ func update(ctx context.Context) error {
if err != nil { if err != nil {
return fmt.Errorf("failed to chmod +x the update (stdout=%#v, stderr=%#v): %w", stdout.String(), stderr.String(), err) return fmt.Errorf("failed to chmod +x the update (stdout=%#v, stderr=%#v): %w", stdout.String(), stderr.String(), err)
} }
cmd = exec.Command(getTmpClientPath(), "install", "--skip-update-config-modification") cmd = exec.Command(getTmpClientPath(), "install")
cmd.Stdout = os.Stdout cmd.Stdout = os.Stdout
stderr = bytes.Buffer{} stderr = bytes.Buffer{}
cmd.Stdin = os.Stdin cmd.Stdin = os.Stdin