extern/hishtory
1
0
Fork 0
mirror of https://github.com/ddworken/hishtory.git synced 2025-06-20 11:57:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Refactor deletion request creation to happen in a transaction to avoid 1-n DB queries

Browse Source
This commit is contained in:
David Dworken 2023-10-15 10:29:47 -07:00
parent 151dfb4009
commit 9f32ae5d2e
No known key found for this signature in database
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
backend/server/internal/database/db.go
View File

@ -243,22 +243,22 @@ func (db *DB) DeletionRequestCreate(ctx context.Context, request *shared.Deletio
fmt.Printf("db.DeletionRequestCreate: Found %d devices\n", len(devices)) fmt.Printf("db.DeletionRequestCreate: Found %d devices\n", len(devices))
// TODO: maybe this should be a transaction? return db.Transaction(func(tx *gorm.DB) error {
for _, device := range devices { for _, device := range devices {
request.DestinationDeviceId = device.DeviceId request.DestinationDeviceId = device.DeviceId
tx := db.WithContext(ctx).Create(&request) tx := db.WithContext(ctx).Create(&request)
if tx.Error != nil { if tx.Error != nil {
return fmt.Errorf("tx.Error: %w", tx.Error) return fmt.Errorf("create: tx.Error: %w", tx.Error)
}
} }
}
numDeleted, err := db.DeleteMessagesFromBackend(ctx, userID, request.Messages.Ids) numDeleted, err := db.DeleteMessagesFromBackend(ctx, userID, request.Messages.Ids)
if err != nil { if err != nil {
return fmt.Errorf("db.DeleteMessagesFromBackend: %w", err) return fmt.Errorf("db.DeleteMessagesFromBackend: %w", err)
} }
fmt.Printf("addDeletionRequestHandler: Deleted %d rows in the backend\n", numDeleted) fmt.Printf("addDeletionRequestHandler: Deleted %d rows in the backend\n", numDeleted)
return nil
return nil })
} }
func (db *DB) FeedbackCreate(ctx context.Context, feedback *shared.Feedback) error { func (db *DB) FeedbackCreate(ctx context.Context, feedback *shared.Feedback) error {