From a58c426ad339c4f60a4fbda80c27efe2491e4d34 Mon Sep 17 00:00:00 2001 From: David Dworken Date: Thu, 21 Dec 2023 17:43:26 -0800 Subject: [PATCH] Improve test to make the golden clearer about what is being tested --- client/client_test.go | 2 +- client/testdata/TestTui-InitialInvalidSearch | 4 ---- client/testutils.go | 2 +- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/client/client_test.go b/client/client_test.go index 03e5e40..6e48239 100644 --- a/client/client_test.go +++ b/client/client_test.go @@ -1858,7 +1858,7 @@ func testTui_search(t *testing.T, onlineStatus OnlineStatus) { {Keys: "hishtory SPACE tquery SPACE foo: ENTER", ExtraDelay: 1.5}, {Keys: "ls", ExtraDelay: 1.0}, }) - out = stripTuiCommandPrefix(t, out) + out = stripRequiredPrefix(t, out, "hishtory tquery foo:") testutils.CompareGoldens(t, out, "TestTui-InitialInvalidSearch") // Check the output when the search is invalid diff --git a/client/testdata/TestTui-InitialInvalidSearch b/client/testdata/TestTui-InitialInvalidSearch index b628fec..52bd27f 100644 --- a/client/testdata/TestTui-InitialInvalidSearch +++ b/client/testdata/TestTui-InitialInvalidSearch @@ -1,7 +1,3 @@ -foo: - - - Search Query: > ls ┌────────────────────────────────────────────────────────────────────────────────────────────────────────┐ diff --git a/client/testutils.go b/client/testutils.go index f4d4614..be30435 100644 --- a/client/testutils.go +++ b/client/testutils.go @@ -361,8 +361,8 @@ func stripShellPrefix(out string) string { func stripRequiredPrefix(t *testing.T, out, prefix string) string { require.Contains(t, out, prefix) return strings.TrimSpace(strings.Split(out, prefix)[1]) - } + func stripTuiCommandPrefix(t *testing.T, out string) string { return stripRequiredPrefix(t, out, "hishtory tquery") }