From cb95d4a396b7257c938904fb3dbab048ebc9b4be Mon Sep 17 00:00:00 2001 From: David Dworken Date: Sun, 24 Sep 2023 06:29:47 -0700 Subject: [PATCH] More test reliability improvements to fix all test failure root causes from 10 sample runs on Github Actions --- client/client_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/client/client_test.go b/client/client_test.go index e9b327a..340f891 100644 --- a/client/client_test.go +++ b/client/client_test.go @@ -1575,6 +1575,7 @@ func testTui_resize(t testing.TB) { out := captureTerminalOutputWithShellNameAndDimensions(t, tester, tester.ShellName(), 100, 20, []TmuxCommand{ {Keys: "hishtory SPACE tquery ENTER"}, }) + require.Contains(t, out, "hishtory tquery") out = strings.TrimSpace(strings.Split(out, "hishtory tquery")[1]) testutils.CompareGoldens(t, out, "TestTui-SmallTerminal") @@ -1678,7 +1679,7 @@ func testTui_delete(t testing.TB) { // And that it stays deleted out = captureTerminalOutputWithComplexCommands(t, tester, []TmuxCommand{ - {Keys: "hishtory SPACE tquery ENTER", ExtraDelay: 1.0}, + {Keys: "hishtory SPACE tquery ENTER", ExtraDelay: 1.5}, }) out = strings.TrimSpace(strings.Split(out, "hishtory tquery")[1]) testutils.CompareGoldens(t, out, "TestTui-DeleteAgainStill") @@ -1711,7 +1712,7 @@ func testTui_search(t testing.TB) { out = captureTerminalOutputWithComplexCommands(t, tester, []TmuxCommand{ {Keys: "hishtory SPACE tquery ENTER"}, // Extra delay to ensure that the search for 'ls' finishes before we select an entry - {Keys: "ls", ExtraDelay: 1.0}, + {Keys: "ls", ExtraDelay: 1.5}, {Keys: "ENTER"}, }) out = strings.Split(strings.TrimSpace(strings.Split(out, "hishtory tquery")[1]), "\n")[0]