From db19d8ebf10d76e3d7eb85f545ddeb700818708d Mon Sep 17 00:00:00 2001 From: David Dworken Date: Thu, 28 Dec 2023 19:52:39 -0800 Subject: [PATCH] Make unused goldens check in tests more lenient with goldens that are OS-specific --- client/posttest/main.go | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/client/posttest/main.go b/client/posttest/main.go index 3a16edb..b95db24 100644 --- a/client/posttest/main.go +++ b/client/posttest/main.go @@ -63,7 +63,16 @@ func checkGoldensUsed() { // And check for mismatches for _, f := range files { goldenName := path.Base(f.Name()) - if !slices.Contains(usedGoldens, goldenName) && !slices.Contains(UNUSED_GOLDENS, goldenName) { + if !slices.Contains(usedGoldens, goldenName) { + if slices.Contains(UNUSED_GOLDENS, goldenName) { + // It is allowlisted to not be used + continue + } + if (runtime.GOOS == "darwin" && strings.Contains(goldenName, "-linux")) || + (runtime.GOOS == "linux" && strings.Contains(goldenName, "-darwin")) { + // It is for another OS + continue + } err = fmt.Errorf("golden file %v was never used", goldenName) fmt.Println(err) log.Fatalf("%v", err)