Bump allowable size difference (+ fix linter errors)

This commit is contained in:
David Dworken 2022-05-27 22:41:52 -07:00
parent fb569b86fa
commit e7de3d9d42

View File

@ -629,7 +629,7 @@ func assertIdenticalBinaries(bin1Path, bin2Path string) error {
return fmt.Errorf("unsigned binaries have different lengths (len(%s)=%d, len(%s)=%d)", bin1Path, len(bin1), bin2Path, len(bin2)) return fmt.Errorf("unsigned binaries have different lengths (len(%s)=%d, len(%s)=%d)", bin1Path, len(bin1), bin2Path, len(bin2))
} }
differences := make([]string, 0) differences := make([]string, 0)
for i, _ := range bin1 { for i := range bin1 {
b1 := bin1[i] b1 := bin1[i]
b2 := bin2[i] b2 := bin2[i]
if b1 != b2 { if b1 != b2 {
@ -640,7 +640,7 @@ func assertIdenticalBinaries(bin1Path, bin2Path string) error {
for _, d := range differences { for _, d := range differences {
logger.Printf("comparing binaries: %#v\n", d) logger.Printf("comparing binaries: %#v\n", d)
} }
if len(differences) > 2 { if len(differences) > 5 {
return fmt.Errorf("found %d differences in the binary", len(differences)) return fmt.Errorf("found %d differences in the binary", len(differences))
} }
return nil return nil
@ -812,13 +812,6 @@ func ApiPost(path, contentType string, data []byte) ([]byte, error) {
return respBody, nil return respBody, nil
} }
type darwinCodeSignature struct {
Cd string `json:"cd"`
Cr string `json:"cr"`
Cr1 string `json:"cr1"`
Cs string `json:"cs"`
}
func IsOfflineError(err error) bool { func IsOfflineError(err error) bool {
return strings.Contains(err.Error(), "dial tcp: lookup api.hishtory.dev") || strings.Contains(err.Error(), "read: connection reset by peer") return strings.Contains(err.Error(), "dial tcp: lookup api.hishtory.dev") || strings.Contains(err.Error(), "read: connection reset by peer")
} }