Add || true so that it works on linux too

This commit is contained in:
David Dworken 2022-11-01 14:33:27 -07:00
parent 3485d4028b
commit e824665f2c
No known key found for this signature in database
2 changed files with 3 additions and 2 deletions

View File

@ -30,5 +30,5 @@ jobs:
export TZ='America/Los_Angeles' # Force the time zone so that test output is consistent
sudo chmod 0755 -R /usr/share/zsh/ || true # Work around a weird bug where zsh on ubuntu actiosn gives that diretory 0777 which makes zsh refuse to start
sudo hostname ghaction-runner-hostname || true # Set a consistent hostname so we can run tests that depend on it
sudo scutil --set HostName ghaction-runner-hostname
sudo scutil --set HostName ghaction-runner-hostname || true
make test

View File

@ -178,7 +178,8 @@ func buildCustomColumns(ctx *context.Context) (data.CustomColumns, error) {
}
err = cmd.Wait()
if err != nil {
return nil, fmt.Errorf("failed to execute custom command named %v (stdout=%#v, stderr=%#v)", cc.ColumnName, stdout.String(), stderr.String())
// Log a warning, but don't crash. This way commands can exit with a different status and still work.
hctx.GetLogger().Printf("failed to execute custom command named %v (stdout=%#v, stderr=%#v)", cc.ColumnName, stdout.String(), stderr.String())
}
ccv := data.CustomColumn{
Name: cc.ColumnName,